From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id A1011780091 for ; Fri, 8 Sep 2023 21:47:04 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=e63Taw14w6WfTKTaxrXUIvhAm1cT2V9qnhnmiDKRxog=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1694209623; v=1; b=tYuR5pw8tzD0bIlahHvbKcEU1X7t53sF2FZQsOZkDWzpZl98XSpY/pdgxGOu9nEvbiE7RC9/ 1QPfP9N0k7VYAM3CExoXmc+6uQmKduAbv9mUztIkbLKR2um0Pf57N4yQrc94iUUdERDREJhIur/ MtY2Lfb+SjDtaQHSFX9o0sqQ= X-Received: by 127.0.0.2 with SMTP id Z9DuYY7687511xmVmNeCa4L5; Fri, 08 Sep 2023 14:47:03 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web11.5651.1694209622864708708 for ; Fri, 08 Sep 2023 14:47:02 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10827"; a="375128327" X-IronPort-AV: E=Sophos;i="6.02,238,1688454000"; d="scan'208";a="375128327" X-Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Sep 2023 14:47:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10827"; a="989411170" X-IronPort-AV: E=Sophos;i="6.02,237,1688454000"; d="scan'208";a="989411170" X-Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga006.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 08 Sep 2023 14:47:02 -0700 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Fri, 8 Sep 2023 14:47:01 -0700 X-Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Fri, 8 Sep 2023 14:47:01 -0700 X-Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.45) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Fri, 8 Sep 2023 14:47:01 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oeW3k5FeaOl3mqk/wkZZJCVLS+b0DHVbucAQlI3DkrqdmSNH3Nw2zlBkQnlqFb1ONy1fXCDxWIr4N6W3sg9PVIzIpgfWXVVKvYNxL6lnyuZl59cOJuUef1EAwO836MDb71G4HwlHbJ6SQdv/fuLFZ9MvC3DBzNIkQNBOWdBokO30yqtaDKJx3k+Eq7l+WUEi7AKp0rqOKs2zLYiNf852bHYDriGfOPdkx0HzA7a1h2VdDeW+g/KBN1G79Lx4Zxtu1NF8+BU+pxaB7IWVG9acq9OQ2brXMIBW3wtmPOi96vBub8pjLNHk/bhgzfNXPx54IeTo8G8GXDjBPIkZ8WpGIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=x+cVWD6sfZuX+jCVfTJ9v97Sa6ydCq1npZeXt5xt1DU=; b=TeIgPrGoJe0Y+C3VMqRxCaXxHtYdSW5lmxljcTUAYmHAF5rkoE2GgeQglz/npiKz+lvqrn8w2MQHA4+IKu/LQ5b369WB8XRyX84M5JRe/xhH/HYmA3oPQUoRcSdtbwVAkcTTFXBwan6VHMLuB9pU4kX6O0Irq1+QRDPMyziN81oJLhrL1DA0W0ULQxFF5zo0k1woUHeRo5OTJblE3Ne/IodCFTx8l2UryC/zLk28ZRafW59hwrb04m+Znafs8uBHMwcNNeAxcR24nfVpwMikZzLj0W2i1oo+00ayYR9eCEz+Q5P+4sgJK/buCNj7YdiVcttpC71Dy8hW8h8pCSaiFQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com (2603:10b6:303:6d::19) by SJ0PR11MB5664.namprd11.prod.outlook.com (2603:10b6:a03:37f::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6768.30; Fri, 8 Sep 2023 21:46:59 +0000 X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::eaa6:1c0:c33f:2a11]) by CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::eaa6:1c0:c33f:2a11%2]) with mapi id 15.20.6768.029; Fri, 8 Sep 2023 21:46:58 +0000 From: "Michael D Kinney" To: Mike Maslenkin , "devel@edk2.groups.io" CC: "Bi, Dandan" , "Gao, Liming" , "Desimone, Nathaniel L" , "Wang, Jian J" , "Kinney, Michael D" Subject: Re: [edk2-devel] [PATCH 2/2] MdeModulePkg/Core/Dxe: Fix memory leak issue in FwVolBlock.c Thread-Topic: [PATCH 2/2] MdeModulePkg/Core/Dxe: Fix memory leak issue in FwVolBlock.c Thread-Index: AQHZ3Gjp6aD0TWxG4E2e6hFpWFqQ/LARgxtw Date: Fri, 8 Sep 2023 21:46:58 +0000 Message-ID: References: <20230901001032.52136-1-mike.maslenkin@gmail.com> <20230901001032.52136-3-mike.maslenkin@gmail.com> In-Reply-To: <20230901001032.52136-3-mike.maslenkin@gmail.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO1PR11MB4929:EE_|SJ0PR11MB5664:EE_ x-ms-office365-filtering-correlation-id: d5693a72-b65c-4374-1b64-08dbb0b520a9 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: Z1Jp8TK8MQaGmhDQHTurx5q6onCrJpgU4p5wbrf4oKq4BsLt6ISiscbyXNcfZureNgzhcUzRABVACppf4bKsFqeSkQRUPx52Lys5OFvJubPfWHM80eVOdKcnBGaxIOmQ+yjdFpi2DzpEYAO5Cxf0gnk1qh6s8l7uLsclbbpH0e6VedXeNzOpxpTkrkyCvj3+sMEop/huzwB2qaZ4mZuggJdF2L09dJRSiDqhNi4slcy9Lod0EjJxzTfQI1dew+uR4DPbW/WSNQRqhVofHrb9G0NcyZ3boa03B/xRkqdLJNegq7YIpMGORnQ0nyZaN4ipTPMIiYkJuQbDy2ZWqCDk+yncOMaYzFxd6J/9BHj1bmVLTcXTaChuxzRR3Qmv0Gu9iWDR48BHRePjG94i2ZUQjOAW0rAEHv0OUdWThoClekEUIyNyoTuf0nP7fJytv/1FaA8o2F2J7Q63aMCTvHpmLc029KT/MMbLzzxLRa8Zi7vAOEg/UzzcCHXELGOVXmY1uyndi+reZbr9tt9zciyCqrhEHRnkAVSP850bc8YR3XQK0Uj+O5S+mkZpwbnUSnUqbnqDftNKANwMM4cc2JoUiZNmM6d17uYkIHXjgxeffxTkl2bhR46LfTD/7nhu6AeG x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?YvxYw+Nvp4drNsoHR+eJQg9w3Yj5dj8bw6fys4iTM3Dk7jVf0RJdVcG8GQPb?= =?us-ascii?Q?bZNCWbk/C1pTNNeppdK78wPob4I3SsMnJi9S39zuwbkpY7/eFVelDrhcpA6Z?= =?us-ascii?Q?e4/1uoOwnbXaKw29v1HJBgx7SVmdN/J6qNGJQbJ9LgVKrSgUCUyfjeCqBD2N?= =?us-ascii?Q?EFlbgBBNyNpA0M3lv+b64bqkOm1EZNusq6/jmIJ/ok8SEMJf53x239cehtg6?= =?us-ascii?Q?5dzBWiao5s/BH4/hAYkFvp6FWyeJPdKBeDL8CPj+XIeQ+qYQn3sWe6EuipIK?= =?us-ascii?Q?uKFJSgrt8Gms9Wf/tWnfudu40Z9atoEqn3M26zeM5Q79Vuh1ujkJ7fogjob+?= =?us-ascii?Q?Y3DHLbmeR9K3tFbB4k9agxpyfrxzZphlSfUdddeT8JSslD82h50DSKkZK0Y/?= =?us-ascii?Q?Hk3cJ+vOMxU6tBfKYzGCPpPJbw12hNuSDsU5TFaPHuaRMZ+P+l8fFfS9p40l?= =?us-ascii?Q?/9te45mZe7Z8ksulKbyxIcWBaqB0M07RUH9da5sZ3QydyUr9rz4mPckngaFt?= =?us-ascii?Q?nrS/8RK9r3jlbWyMCluf3tBYUAWyv4dDxGeQ2BbW1pbcL+y2E9WXHbltODK1?= =?us-ascii?Q?MSDgSeGteEbyyIfqlEJXSylKXbrmZnNyjnhQNYJg61EoD/m4Q8LfU840iBJ/?= =?us-ascii?Q?Ld5MVD+FRGMpGTohAVXtA12zunXUQc0rueIb4QS3BPACdwa1iAzx9LqoKcDj?= =?us-ascii?Q?zXBNIt4NAEPbxkw44MYaQ6IsfvvyrVW/KWrGpbSXUNe7OGTAxfF7xazH2L/+?= =?us-ascii?Q?ABm3yMXapDas21uWoSTF2aH51Xpt290ptBPPqDXLJm0/JclQwHx1w90+qvv1?= =?us-ascii?Q?W0SULceFnWBsXduJ/xHab9RUqJ0eIG27t8Z2gQA9p+uCbMjXBgsrEBjXyYTq?= =?us-ascii?Q?RiXoYVzWk/F7UtHISjo9KIKrWPqEkKaSxe+7QNmG0lROxKipKh/8kYkB2rrC?= =?us-ascii?Q?dAchC4IzhsGGfxqFKhsVy7q39c+W/3yAEr/1NupzuJTgdL/zdiCKOvMpZqR8?= =?us-ascii?Q?aicZE7qJVOfVBy6jVy8wvwoG8bKS9lAWszVGwizYSEPP32JJ1IeMCYGCMfDc?= =?us-ascii?Q?3zj2SZij1NjSIp2LjlA0BuhSi31dN/4VqcZN6xSrw2fw4pO06DSteij7OD1y?= =?us-ascii?Q?jOkMZ3S1yukSA3+Y3y8WFXybJCSibU+y1SeTXO2hobiLihCYcAno+JQLWLUB?= =?us-ascii?Q?Yl9NO0yIWNKv4VncrnjgR72HADO8MlLYEzM+4FyYdy+X7vM985XOyJxRoq6F?= =?us-ascii?Q?nBugrroB5yUSVNn9oD59UBTIWrslcbCx/a5phvT2QLgAhQojp3LzXZs8MAiE?= =?us-ascii?Q?7V80IBJbGEz/guBbWBvdVwXMkfYP3Xl83bIYuM+uWqGCb1L/0xTCzNj7QpPZ?= =?us-ascii?Q?FXiRK2LDbugIhrp0fVGEW2E1qVLwUlgshwpqhewg2a7hYcz+PgV18XBCWCRL?= =?us-ascii?Q?xXNQmHrWtPXidDFddLxjMR0tNZNcQvA0kJqHzOJQf5JpcHAqwSYiQoETtWP6?= =?us-ascii?Q?f07bFY8UFgBdSPbX9tgtvdU6zDcfV2atGKI7cWZ/AoZXEA8xRNSlU/LoH+Lk?= =?us-ascii?Q?p94u6YCArkJ9e4V/tS694TtKSrAm7BYbWDjZwJBeUFWwXCmCWze4iZX1jhq1?= =?us-ascii?Q?yA=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4929.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d5693a72-b65c-4374-1b64-08dbb0b520a9 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Sep 2023 21:46:58.6477 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: M7neR8ynJfgPJ19jHBUXUxjLbVmWMRo1G60bRAM+NZmTb2kEMqfnnZrnfa2q2dYmiwj7gXR3PCau+UvKtL39p+LwQgG2Jy5qrUMlIii6GHQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5664 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,michael.d.kinney@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: XcD38mh86Mxecn4fO7jomEUWx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=tYuR5pw8; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io +Jian Cc: Jian J Wang Cc: Dandan Bi Cc: Liming Gao > -----Original Message----- > From: Mike Maslenkin > Sent: Thursday, August 31, 2023 5:11 PM > To: devel@edk2.groups.io > Cc: Bi, Dandan ; Gao, Liming > ; Kinney, Michael D ; > Desimone, Nathaniel L ; Mike Maslenkin > > Subject: [PATCH 2/2] MdeModulePkg/Core/Dxe: Fix memory leak issue in > FwVolBlock.c >=20 > FvbDev->LbaCache must be freed on error path before deallocating FvbDev. >=20 > Signed-off-by: Mike Maslenkin > --- > MdeModulePkg/Core/Dxe/FwVolBlock/FwVolBlock.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/MdeModulePkg/Core/Dxe/FwVolBlock/FwVolBlock.c > b/MdeModulePkg/Core/Dxe/FwVolBlock/FwVolBlock.c > index d81334ce24d1..9f5f40e5cd49 100644 > --- a/MdeModulePkg/Core/Dxe/FwVolBlock/FwVolBlock.c > +++ b/MdeModulePkg/Core/Dxe/FwVolBlock/FwVolBlock.c > @@ -551,6 +551,7 @@ ProduceFVBProtocolOnBuffer ( > // >=20 > FvbDev->DevicePath =3D (EFI_DEVICE_PATH_PROTOCOL *)AllocateCopyPool > (sizeof (FV_MEMMAP_DEVICE_PATH), &mFvMemmapDevicePathTemplate); >=20 > if (FvbDev->DevicePath =3D=3D NULL) { >=20 > + FreePool (FvbDev->LbaCache); >=20 > FreePool (FvbDev); >=20 > return EFI_OUT_OF_RESOURCES; >=20 > } >=20 > @@ -563,6 +564,7 @@ ProduceFVBProtocolOnBuffer ( > // >=20 > FvbDev->DevicePath =3D (EFI_DEVICE_PATH_PROTOCOL *)AllocateCopyPool > (sizeof (FV_PIWG_DEVICE_PATH), &mFvPIWGDevicePathTemplate); >=20 > if (FvbDev->DevicePath =3D=3D NULL) { >=20 > + FreePool (FvbDev->LbaCache); >=20 > FreePool (FvbDev); >=20 > return EFI_OUT_OF_RESOURCES; >=20 > } >=20 > -- > 2.32.0 (Apple Git-132) -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108465): https://edk2.groups.io/g/devel/message/108465 Mute This Topic: https://groups.io/mt/101085565/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-