Re: [edk2-devel] [edk2-platforms] [patch V3 24/35] Silicon/Hisilicon: Consume MdeLibs.dsc.inc for RegisterFilterLib

["Michael D Kinney" <michael.d.kinney@intel.com>]

Hi Dandan,

Here is another example of adding an include of a dsc.inc from another dsc.inc.
I do not think we should do this.

The NetworkPkg and UnitTestFranmeworkPkg have examples where it is ok
for one dsc.inc to include another dsc.inc, and that is if the included
dsc.inc is in the same package.

I would like to refine the suggestion to say that the dsc.inc from one
package should not include a dsc.inc from a different package. 

Best regards,

Mike

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Dandan Bi
> Sent: Friday, March 26, 2021 1:39 AM
> To: devel@edk2.groups.io
> Cc: Leif Lindholm <leif@nuviainc.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>; Wenyi Xie <xiewenyi2@huawei.com>
> Subject: [edk2-devel] [edk2-platforms] [patch V3 24/35] Silicon/Hisilicon: Consume MdeLibs.dsc.inc for RegisterFilterLib
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
> 
> MdeLibs.dsc.inc was added for some basic/default library
> instances provided by MdePkg and RegisterFilterLibNull Library
> was also added into it as the first version of MdeLibs.dsc.inc.
> 
> So update platform dsc to consume MdeLibs.dsc.inc for
> RegisterFilterLibNull which will be consumed by IoLib and BaseLib.
> 
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Wenyi Xie <xiewenyi2@huawei.com>
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
> V3:
> Update plaftom dsc to consume the MdeLibs.dsc.inc outside the common
> [LibraryClasses] section since we can specify different [LibraryClasses]
> section for libary instances in MdeLibs.dsc.inc.
> ---
>  Silicon/Hisilicon/Hisilicon.dsc.inc | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Silicon/Hisilicon/Hisilicon.dsc.inc b/Silicon/Hisilicon/Hisilicon.dsc.inc
> index 6bacd9cafd..a0db833bef 100644
> --- a/Silicon/Hisilicon/Hisilicon.dsc.inc
> +++ b/Silicon/Hisilicon/Hisilicon.dsc.inc
> @@ -5,10 +5,12 @@
>  #
>  #  SPDX-License-Identifier: BSD-2-Clause-Patent
>  #
>  #
> 
> +!include MdePkg/MdeLibs.dsc.inc
> +
>  [LibraryClasses.common]
>  !if $(TARGET) == RELEASE
>    DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf
>  !else
>    DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf
> --
> 2.18.0.windows.1
> 
> 
> 
> 
>