* [PATCH 1/1] Add a .editorconfig file to tell editors basic formatting details @ 2023-02-27 3:47 Rebecca Cran 2023-02-27 8:04 ` [edk2-devel] " Ard Biesheuvel 0 siblings, 1 reply; 14+ messages in thread From: Rebecca Cran @ 2023-02-27 3:47 UTC (permalink / raw) To: devel, Andrew Fish, Leif Lindholm, Michael D Kinney; +Cc: Rebecca Cran Add a .editorconfig file which editors can use for basic formatting details of files, such as tabs/spaces, line endings etc. Signed-off-by: Rebecca Cran <rebecca@bsdio.com> --- .editorconfig | 21 ++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/.editorconfig b/.editorconfig new file mode 100644 index 000000000000..f2651d7ad871 --- /dev/null +++ b/.editorconfig @@ -0,0 +1,21 @@ +# EditorConfig file: https://EditorConfig.org + +root = true + +[*] +charset = latin1 +end_of_line = crlf +insert_final_newline = true +trim_trailing_whitespace = true + +[*.py] +charset = utf-8 +indent_style = space +indent_size = 4 + +[Makefile,GNUmakefile] +indent_style = tab + +[*.{c,h,cpp,cc}] +indent_style = space +indent_size = 2 -- 2.37.1 (Apple Git-137.1) ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [edk2-devel] [PATCH 1/1] Add a .editorconfig file to tell editors basic formatting details 2023-02-27 3:47 [PATCH 1/1] Add a .editorconfig file to tell editors basic formatting details Rebecca Cran @ 2023-02-27 8:04 ` Ard Biesheuvel 2023-02-27 13:02 ` Rebecca Cran 0 siblings, 1 reply; 14+ messages in thread From: Ard Biesheuvel @ 2023-02-27 8:04 UTC (permalink / raw) To: devel, rebecca; +Cc: Andrew Fish, Leif Lindholm, Michael D Kinney On Mon, 27 Feb 2023 at 04:47, Rebecca Cran <rebecca@bsdio.com> wrote: > > Add a .editorconfig file which editors can use for basic formatting > details of files, such as tabs/spaces, line endings etc. > > Signed-off-by: Rebecca Cran <rebecca@bsdio.com> Thank you very much for this - this is very useful. Acked-by: Ard Biesheuvel <ardb@kernel.org> Could we add .dsc/.inf/.dec/etc files as well? > --- > .editorconfig | 21 ++++++++++++++++++++ > 1 file changed, 21 insertions(+) > > diff --git a/.editorconfig b/.editorconfig > new file mode 100644 > index 000000000000..f2651d7ad871 > --- /dev/null > +++ b/.editorconfig > @@ -0,0 +1,21 @@ > +# EditorConfig file: https://EditorConfig.org > + > +root = true > + > +[*] > +charset = latin1 > +end_of_line = crlf > +insert_final_newline = true > +trim_trailing_whitespace = true > + > +[*.py] > +charset = utf-8 > +indent_style = space > +indent_size = 4 > + > +[Makefile,GNUmakefile] > +indent_style = tab > + > +[*.{c,h,cpp,cc}] > +indent_style = space > +indent_size = 2 > -- > 2.37.1 (Apple Git-137.1) > > > > > > ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [edk2-devel] [PATCH 1/1] Add a .editorconfig file to tell editors basic formatting details 2023-02-27 8:04 ` [edk2-devel] " Ard Biesheuvel @ 2023-02-27 13:02 ` Rebecca Cran 2023-02-27 16:14 ` Michael D Kinney 0 siblings, 1 reply; 14+ messages in thread From: Rebecca Cran @ 2023-02-27 13:02 UTC (permalink / raw) To: Ard Biesheuvel, devel; +Cc: Andrew Fish, Leif Lindholm, Michael D Kinney On 2/27/23 1:04 AM, Ard Biesheuvel wrote: > On Mon, 27 Feb 2023 at 04:47, Rebecca Cran <rebecca@bsdio.com> wrote: >> Add a .editorconfig file which editors can use for basic formatting >> details of files, such as tabs/spaces, line endings etc. >> >> Signed-off-by: Rebecca Cran <rebecca@bsdio.com> > Thank you very much for this - this is very useful. > > Acked-by: Ard Biesheuvel <ardb@kernel.org> > > Could we add .dsc/.inf/.dec/etc files as well? I'll move the c/c++ indentation up to the [*] section so it applies to .dsc/.inf/etc too. -- Rebecca Cran ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [edk2-devel] [PATCH 1/1] Add a .editorconfig file to tell editors basic formatting details 2023-02-27 13:02 ` Rebecca Cran @ 2023-02-27 16:14 ` Michael D Kinney 2023-02-27 16:35 ` Rebecca Cran 0 siblings, 1 reply; 14+ messages in thread From: Michael D Kinney @ 2023-02-27 16:14 UTC (permalink / raw) To: devel@edk2.groups.io, rebecca@bsdio.com, Ard Biesheuvel Cc: Andrew Fish, Leif Lindholm, Kinney, Michael D There are a few file types that must be lf instead of crlf. Can those be added as well? Mike > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Rebecca Cran > Sent: Monday, February 27, 2023 5:03 AM > To: Ard Biesheuvel <ardb@kernel.org>; devel@edk2.groups.io > Cc: Andrew Fish <afish@apple.com>; Leif Lindholm <quic_llindhol@quicinc.com>; Kinney, Michael D <michael.d.kinney@intel.com> > Subject: Re: [edk2-devel] [PATCH 1/1] Add a .editorconfig file to tell editors basic formatting details > > On 2/27/23 1:04 AM, Ard Biesheuvel wrote: > > > On Mon, 27 Feb 2023 at 04:47, Rebecca Cran <rebecca@bsdio.com> wrote: > >> Add a .editorconfig file which editors can use for basic formatting > >> details of files, such as tabs/spaces, line endings etc. > >> > >> Signed-off-by: Rebecca Cran <rebecca@bsdio.com> > > Thank you very much for this - this is very useful. > > > > Acked-by: Ard Biesheuvel <ardb@kernel.org> > > > > Could we add .dsc/.inf/.dec/etc files as well? > > I'll move the c/c++ indentation up to the [*] section so it applies to > .dsc/.inf/etc too. > > > -- > Rebecca Cran > > > > > ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [edk2-devel] [PATCH 1/1] Add a .editorconfig file to tell editors basic formatting details 2023-02-27 16:14 ` Michael D Kinney @ 2023-02-27 16:35 ` Rebecca Cran 2023-02-27 18:18 ` Ard Biesheuvel 0 siblings, 1 reply; 14+ messages in thread From: Rebecca Cran @ 2023-02-27 16:35 UTC (permalink / raw) To: devel, michael.d.kinney, Ard Biesheuvel; +Cc: Andrew Fish, Leif Lindholm Is it just .sh files that need lf endings, or are there others? -- Rebecca Cran On 2/27/23 9:14 AM, Michael D Kinney wrote: > There are a few file types that must be lf instead of crlf. Can those be added as well? > > Mike > >> -----Original Message----- >> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Rebecca Cran >> Sent: Monday, February 27, 2023 5:03 AM >> To: Ard Biesheuvel <ardb@kernel.org>; devel@edk2.groups.io >> Cc: Andrew Fish <afish@apple.com>; Leif Lindholm <quic_llindhol@quicinc.com>; Kinney, Michael D <michael.d.kinney@intel.com> >> Subject: Re: [edk2-devel] [PATCH 1/1] Add a .editorconfig file to tell editors basic formatting details >> >> On 2/27/23 1:04 AM, Ard Biesheuvel wrote: >> >>> On Mon, 27 Feb 2023 at 04:47, Rebecca Cran <rebecca@bsdio.com> wrote: >>>> Add a .editorconfig file which editors can use for basic formatting >>>> details of files, such as tabs/spaces, line endings etc. >>>> >>>> Signed-off-by: Rebecca Cran <rebecca@bsdio.com> >>> Thank you very much for this - this is very useful. >>> >>> Acked-by: Ard Biesheuvel <ardb@kernel.org> >>> >>> Could we add .dsc/.inf/.dec/etc files as well? >> I'll move the c/c++ indentation up to the [*] section so it applies to >> .dsc/.inf/etc too. >> >> >> -- >> Rebecca Cran >> >> >> >> >> > > > > > ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [edk2-devel] [PATCH 1/1] Add a .editorconfig file to tell editors basic formatting details 2023-02-27 16:35 ` Rebecca Cran @ 2023-02-27 18:18 ` Ard Biesheuvel 2023-02-27 18:22 ` Michael D Kinney 0 siblings, 1 reply; 14+ messages in thread From: Ard Biesheuvel @ 2023-02-27 18:18 UTC (permalink / raw) To: devel, rebecca; +Cc: michael.d.kinney, Andrew Fish, Leif Lindholm On Mon, 27 Feb 2023 at 17:35, Rebecca Cran <rebecca@bsdio.com> wrote: > > Is it just .sh files that need lf endings, or are there others? > I think this only applies to .sh files. > > > On 2/27/23 9:14 AM, Michael D Kinney wrote: > > There are a few file types that must be lf instead of crlf. Can those be added as well? > > > > Mike > > > >> -----Original Message----- > >> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Rebecca Cran > >> Sent: Monday, February 27, 2023 5:03 AM > >> To: Ard Biesheuvel <ardb@kernel.org>; devel@edk2.groups.io > >> Cc: Andrew Fish <afish@apple.com>; Leif Lindholm <quic_llindhol@quicinc.com>; Kinney, Michael D <michael.d.kinney@intel.com> > >> Subject: Re: [edk2-devel] [PATCH 1/1] Add a .editorconfig file to tell editors basic formatting details > >> > >> On 2/27/23 1:04 AM, Ard Biesheuvel wrote: > >> > >>> On Mon, 27 Feb 2023 at 04:47, Rebecca Cran <rebecca@bsdio.com> wrote: > >>>> Add a .editorconfig file which editors can use for basic formatting > >>>> details of files, such as tabs/spaces, line endings etc. > >>>> > >>>> Signed-off-by: Rebecca Cran <rebecca@bsdio.com> > >>> Thank you very much for this - this is very useful. > >>> > >>> Acked-by: Ard Biesheuvel <ardb@kernel.org> > >>> > >>> Could we add .dsc/.inf/.dec/etc files as well? > >> I'll move the c/c++ indentation up to the [*] section so it applies to > >> .dsc/.inf/etc too. > >> > >> > >> -- > >> Rebecca Cran > >> > >> > >> > >> > >> > > > > > > > > > > > > > > > ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [edk2-devel] [PATCH 1/1] Add a .editorconfig file to tell editors basic formatting details 2023-02-27 18:18 ` Ard Biesheuvel @ 2023-02-27 18:22 ` Michael D Kinney 2023-02-27 18:23 ` Michael D Kinney 2023-02-28 6:43 ` Rebecca Cran 0 siblings, 2 replies; 14+ messages in thread From: Michael D Kinney @ 2023-02-27 18:22 UTC (permalink / raw) To: Ard Biesheuvel, devel@edk2.groups.io, rebecca@bsdio.com Cc: Andrew Fish, Leif Lindholm, Kinney, Michael D .gitmodules must be lf. Not sure about other git config files. Mike > -----Original Message----- > From: Ard Biesheuvel <ardb@kernel.org> > Sent: Monday, February 27, 2023 10:18 AM > To: devel@edk2.groups.io; rebecca@bsdio.com > Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Andrew Fish <afish@apple.com>; Leif Lindholm <quic_llindhol@quicinc.com> > Subject: Re: [edk2-devel] [PATCH 1/1] Add a .editorconfig file to tell editors basic formatting details > > On Mon, 27 Feb 2023 at 17:35, Rebecca Cran <rebecca@bsdio.com> wrote: > > > > Is it just .sh files that need lf endings, or are there others? > > > > I think this only applies to .sh files. > > > > > > > On 2/27/23 9:14 AM, Michael D Kinney wrote: > > > There are a few file types that must be lf instead of crlf. Can those be added as well? > > > > > > Mike > > > > > >> -----Original Message----- > > >> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Rebecca Cran > > >> Sent: Monday, February 27, 2023 5:03 AM > > >> To: Ard Biesheuvel <ardb@kernel.org>; devel@edk2.groups.io > > >> Cc: Andrew Fish <afish@apple.com>; Leif Lindholm <quic_llindhol@quicinc.com>; Kinney, Michael D > <michael.d.kinney@intel.com> > > >> Subject: Re: [edk2-devel] [PATCH 1/1] Add a .editorconfig file to tell editors basic formatting details > > >> > > >> On 2/27/23 1:04 AM, Ard Biesheuvel wrote: > > >> > > >>> On Mon, 27 Feb 2023 at 04:47, Rebecca Cran <rebecca@bsdio.com> wrote: > > >>>> Add a .editorconfig file which editors can use for basic formatting > > >>>> details of files, such as tabs/spaces, line endings etc. > > >>>> > > >>>> Signed-off-by: Rebecca Cran <rebecca@bsdio.com> > > >>> Thank you very much for this - this is very useful. > > >>> > > >>> Acked-by: Ard Biesheuvel <ardb@kernel.org> > > >>> > > >>> Could we add .dsc/.inf/.dec/etc files as well? > > >> I'll move the c/c++ indentation up to the [*] section so it applies to > > >> .dsc/.inf/etc too. > > >> > > >> > > >> -- > > >> Rebecca Cran > > >> > > >> > > >> > > >> > > >> > > > > > > > > > > > > > > > > > > > > > > > > > ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [edk2-devel] [PATCH 1/1] Add a .editorconfig file to tell editors basic formatting details 2023-02-27 18:22 ` Michael D Kinney @ 2023-02-27 18:23 ` Michael D Kinney 2023-02-28 18:20 ` Rebecca Cran 2023-02-28 6:43 ` Rebecca Cran 1 sibling, 1 reply; 14+ messages in thread From: Michael D Kinney @ 2023-02-27 18:23 UTC (permalink / raw) To: Ard Biesheuvel, devel@edk2.groups.io, rebecca@bsdio.com Cc: Andrew Fish, Leif Lindholm, Kinney, Michael D .gitmodules also must also use tabs. > -----Original Message----- > From: Kinney, Michael D <michael.d.kinney@intel.com> > Sent: Monday, February 27, 2023 10:22 AM > To: Ard Biesheuvel <ardb@kernel.org>; devel@edk2.groups.io; rebecca@bsdio.com > Cc: Andrew Fish <afish@apple.com>; Leif Lindholm <quic_llindhol@quicinc.com>; Kinney, Michael D <michael.d.kinney@intel.com> > Subject: RE: [edk2-devel] [PATCH 1/1] Add a .editorconfig file to tell editors basic formatting details > > .gitmodules must be lf. Not sure about other git config files. > > Mike > > > -----Original Message----- > > From: Ard Biesheuvel <ardb@kernel.org> > > Sent: Monday, February 27, 2023 10:18 AM > > To: devel@edk2.groups.io; rebecca@bsdio.com > > Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Andrew Fish <afish@apple.com>; Leif Lindholm <quic_llindhol@quicinc.com> > > Subject: Re: [edk2-devel] [PATCH 1/1] Add a .editorconfig file to tell editors basic formatting details > > > > On Mon, 27 Feb 2023 at 17:35, Rebecca Cran <rebecca@bsdio.com> wrote: > > > > > > Is it just .sh files that need lf endings, or are there others? > > > > > > > I think this only applies to .sh files. > > > > > > > > > > > On 2/27/23 9:14 AM, Michael D Kinney wrote: > > > > There are a few file types that must be lf instead of crlf. Can those be added as well? > > > > > > > > Mike > > > > > > > >> -----Original Message----- > > > >> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Rebecca Cran > > > >> Sent: Monday, February 27, 2023 5:03 AM > > > >> To: Ard Biesheuvel <ardb@kernel.org>; devel@edk2.groups.io > > > >> Cc: Andrew Fish <afish@apple.com>; Leif Lindholm <quic_llindhol@quicinc.com>; Kinney, Michael D > > <michael.d.kinney@intel.com> > > > >> Subject: Re: [edk2-devel] [PATCH 1/1] Add a .editorconfig file to tell editors basic formatting details > > > >> > > > >> On 2/27/23 1:04 AM, Ard Biesheuvel wrote: > > > >> > > > >>> On Mon, 27 Feb 2023 at 04:47, Rebecca Cran <rebecca@bsdio.com> wrote: > > > >>>> Add a .editorconfig file which editors can use for basic formatting > > > >>>> details of files, such as tabs/spaces, line endings etc. > > > >>>> > > > >>>> Signed-off-by: Rebecca Cran <rebecca@bsdio.com> > > > >>> Thank you very much for this - this is very useful. > > > >>> > > > >>> Acked-by: Ard Biesheuvel <ardb@kernel.org> > > > >>> > > > >>> Could we add .dsc/.inf/.dec/etc files as well? > > > >> I'll move the c/c++ indentation up to the [*] section so it applies to > > > >> .dsc/.inf/etc too. > > > >> > > > >> > > > >> -- > > > >> Rebecca Cran > > > >> > > > >> > > > >> > > > >> > > > >> > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [edk2-devel] [PATCH 1/1] Add a .editorconfig file to tell editors basic formatting details 2023-02-27 18:23 ` Michael D Kinney @ 2023-02-28 18:20 ` Rebecca Cran 2023-02-28 18:53 ` Ard Biesheuvel 2023-02-28 21:32 ` Michael D Kinney 0 siblings, 2 replies; 14+ messages in thread From: Rebecca Cran @ 2023-02-28 18:20 UTC (permalink / raw) To: Kinney, Michael D, Ard Biesheuvel, devel@edk2.groups.io Cc: Andrew Fish, Leif Lindholm Before I sent out an official v2 patch, does the following look good? diff --git a/.editorconfig b/.editorconfig new file mode 100644 index 000000000000..587d5bbaa884 --- /dev/null +++ b/.editorconfig @@ -0,0 +1,31 @@ +# EditorConfig file: https://EditorConfig.org + +root = true + +[*] +charset = latin1 +end_of_line = crlf +indent_style = space +indent_size = 2 +insert_final_newline = true +trim_trailing_whitespace = true + +[*.py] +charset = utf-8 +indent_style = space +indent_size = 4 + +[*.sh] +end_of_line = lf + +[.gitattributes] +end_of_line = lf + +[.mailmap] +charset = utf-8 + +[Maintainers.txt] +charset = utf-8 + +[Makefile,GNUmakefile] +indent_style = tab -- Rebecca Cran On 2/27/23 11:23 AM, Kinney, Michael D wrote: > .gitmodules also must also use tabs. > >> -----Original Message----- >> From: Kinney, Michael D <michael.d.kinney@intel.com> >> Sent: Monday, February 27, 2023 10:22 AM >> To: Ard Biesheuvel <ardb@kernel.org>; devel@edk2.groups.io; rebecca@bsdio.com >> Cc: Andrew Fish <afish@apple.com>; Leif Lindholm <quic_llindhol@quicinc.com>; Kinney, Michael D <michael.d.kinney@intel.com> >> Subject: RE: [edk2-devel] [PATCH 1/1] Add a .editorconfig file to tell editors basic formatting details >> >> .gitmodules must be lf. Not sure about other git config files. >> >> Mike >> >>> -----Original Message----- >>> From: Ard Biesheuvel <ardb@kernel.org> >>> Sent: Monday, February 27, 2023 10:18 AM >>> To: devel@edk2.groups.io; rebecca@bsdio.com >>> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Andrew Fish <afish@apple.com>; Leif Lindholm <quic_llindhol@quicinc.com> >>> Subject: Re: [edk2-devel] [PATCH 1/1] Add a .editorconfig file to tell editors basic formatting details >>> >>> On Mon, 27 Feb 2023 at 17:35, Rebecca Cran <rebecca@bsdio.com> wrote: >>>> Is it just .sh files that need lf endings, or are there others? >>>> >>> I think this only applies to .sh files. >>> >>>> >>>> On 2/27/23 9:14 AM, Michael D Kinney wrote: >>>>> There are a few file types that must be lf instead of crlf. Can those be added as well? >>>>> >>>>> Mike >>>>> >>>>>> -----Original Message----- >>>>>> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Rebecca Cran >>>>>> Sent: Monday, February 27, 2023 5:03 AM >>>>>> To: Ard Biesheuvel <ardb@kernel.org>; devel@edk2.groups.io >>>>>> Cc: Andrew Fish <afish@apple.com>; Leif Lindholm <quic_llindhol@quicinc.com>; Kinney, Michael D >>> <michael.d.kinney@intel.com> >>>>>> Subject: Re: [edk2-devel] [PATCH 1/1] Add a .editorconfig file to tell editors basic formatting details >>>>>> >>>>>> On 2/27/23 1:04 AM, Ard Biesheuvel wrote: >>>>>> >>>>>>> On Mon, 27 Feb 2023 at 04:47, Rebecca Cran <rebecca@bsdio.com> wrote: >>>>>>>> Add a .editorconfig file which editors can use for basic formatting >>>>>>>> details of files, such as tabs/spaces, line endings etc. >>>>>>>> >>>>>>>> Signed-off-by: Rebecca Cran <rebecca@bsdio.com> >>>>>>> Thank you very much for this - this is very useful. >>>>>>> >>>>>>> Acked-by: Ard Biesheuvel <ardb@kernel.org> >>>>>>> >>>>>>> Could we add .dsc/.inf/.dec/etc files as well? >>>>>> I'll move the c/c++ indentation up to the [*] section so it applies to >>>>>> .dsc/.inf/etc too. >>>>>> >>>>>> >>>>>> -- >>>>>> Rebecca Cran >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> >>>>> >>>>> >>>>> >>>>> >>>> >>>> >>>> >>>> ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [edk2-devel] [PATCH 1/1] Add a .editorconfig file to tell editors basic formatting details 2023-02-28 18:20 ` Rebecca Cran @ 2023-02-28 18:53 ` Ard Biesheuvel 2023-02-28 21:32 ` Michael D Kinney 1 sibling, 0 replies; 14+ messages in thread From: Ard Biesheuvel @ 2023-02-28 18:53 UTC (permalink / raw) To: Rebecca Cran Cc: Kinney, Michael D, devel@edk2.groups.io, Andrew Fish, Leif Lindholm On Tue, 28 Feb 2023 at 19:20, Rebecca Cran <rebecca@bsdio.com> wrote: > > Before I sent out an official v2 patch, does the following look good? > Looks fine to me, thanks. > > diff --git a/.editorconfig b/.editorconfig > new file mode 100644 > index 000000000000..587d5bbaa884 > --- /dev/null > +++ b/.editorconfig > @@ -0,0 +1,31 @@ > +# EditorConfig file: https://EditorConfig.org > + > +root = true > + > +[*] > +charset = latin1 > +end_of_line = crlf > +indent_style = space > +indent_size = 2 > +insert_final_newline = true > +trim_trailing_whitespace = true > + > +[*.py] > +charset = utf-8 > +indent_style = space > +indent_size = 4 > + > +[*.sh] > +end_of_line = lf > + > +[.gitattributes] > +end_of_line = lf > + > +[.mailmap] > +charset = utf-8 > + > +[Maintainers.txt] > +charset = utf-8 > + > +[Makefile,GNUmakefile] > +indent_style = tab > > > -- > Rebecca Cran > > > On 2/27/23 11:23 AM, Kinney, Michael D wrote: > > .gitmodules also must also use tabs. > > > >> -----Original Message----- > >> From: Kinney, Michael D <michael.d.kinney@intel.com> > >> Sent: Monday, February 27, 2023 10:22 AM > >> To: Ard Biesheuvel <ardb@kernel.org>; devel@edk2.groups.io; rebecca@bsdio.com > >> Cc: Andrew Fish <afish@apple.com>; Leif Lindholm <quic_llindhol@quicinc.com>; Kinney, Michael D <michael.d.kinney@intel.com> > >> Subject: RE: [edk2-devel] [PATCH 1/1] Add a .editorconfig file to tell editors basic formatting details > >> > >> .gitmodules must be lf. Not sure about other git config files. > >> > >> Mike > >> > >>> -----Original Message----- > >>> From: Ard Biesheuvel <ardb@kernel.org> > >>> Sent: Monday, February 27, 2023 10:18 AM > >>> To: devel@edk2.groups.io; rebecca@bsdio.com > >>> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Andrew Fish <afish@apple.com>; Leif Lindholm <quic_llindhol@quicinc.com> > >>> Subject: Re: [edk2-devel] [PATCH 1/1] Add a .editorconfig file to tell editors basic formatting details > >>> > >>> On Mon, 27 Feb 2023 at 17:35, Rebecca Cran <rebecca@bsdio.com> wrote: > >>>> Is it just .sh files that need lf endings, or are there others? > >>>> > >>> I think this only applies to .sh files. > >>> > >>>> > >>>> On 2/27/23 9:14 AM, Michael D Kinney wrote: > >>>>> There are a few file types that must be lf instead of crlf. Can those be added as well? > >>>>> > >>>>> Mike > >>>>> > >>>>>> -----Original Message----- > >>>>>> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Rebecca Cran > >>>>>> Sent: Monday, February 27, 2023 5:03 AM > >>>>>> To: Ard Biesheuvel <ardb@kernel.org>; devel@edk2.groups.io > >>>>>> Cc: Andrew Fish <afish@apple.com>; Leif Lindholm <quic_llindhol@quicinc.com>; Kinney, Michael D > >>> <michael.d.kinney@intel.com> > >>>>>> Subject: Re: [edk2-devel] [PATCH 1/1] Add a .editorconfig file to tell editors basic formatting details > >>>>>> > >>>>>> On 2/27/23 1:04 AM, Ard Biesheuvel wrote: > >>>>>> > >>>>>>> On Mon, 27 Feb 2023 at 04:47, Rebecca Cran <rebecca@bsdio.com> wrote: > >>>>>>>> Add a .editorconfig file which editors can use for basic formatting > >>>>>>>> details of files, such as tabs/spaces, line endings etc. > >>>>>>>> > >>>>>>>> Signed-off-by: Rebecca Cran <rebecca@bsdio.com> > >>>>>>> Thank you very much for this - this is very useful. > >>>>>>> > >>>>>>> Acked-by: Ard Biesheuvel <ardb@kernel.org> > >>>>>>> > >>>>>>> Could we add .dsc/.inf/.dec/etc files as well? > >>>>>> I'll move the c/c++ indentation up to the [*] section so it applies to > >>>>>> .dsc/.inf/etc too. > >>>>>> > >>>>>> > >>>>>> -- > >>>>>> Rebecca Cran > >>>>>> > >>>>>> > >>>>>> > >>>>>> > >>>>>> > >>>>> > >>>>> > >>>>> > >>>>> > >>>> > >>>> > >>>> > >>>> ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [edk2-devel] [PATCH 1/1] Add a .editorconfig file to tell editors basic formatting details 2023-02-28 18:20 ` Rebecca Cran 2023-02-28 18:53 ` Ard Biesheuvel @ 2023-02-28 21:32 ` Michael D Kinney 2023-03-01 3:22 ` Rebecca Cran 1 sibling, 1 reply; 14+ messages in thread From: Michael D Kinney @ 2023-02-28 21:32 UTC (permalink / raw) To: Rebecca Cran, Ard Biesheuvel, devel@edk2.groups.io Cc: Andrew Fish, Leif Lindholm, Kinney, Michael D What about .gitmodules? Mike > -----Original Message----- > From: Rebecca Cran <rebecca@bsdio.com> > Sent: Tuesday, February 28, 2023 10:21 AM > To: Kinney, Michael D <michael.d.kinney@intel.com>; Ard Biesheuvel <ardb@kernel.org>; devel@edk2.groups.io > Cc: Andrew Fish <afish@apple.com>; Leif Lindholm <quic_llindhol@quicinc.com> > Subject: Re: [edk2-devel] [PATCH 1/1] Add a .editorconfig file to tell editors basic formatting details > > Before I sent out an official v2 patch, does the following look good? > > > diff --git a/.editorconfig b/.editorconfig > new file mode 100644 > index 000000000000..587d5bbaa884 > --- /dev/null > +++ b/.editorconfig > @@ -0,0 +1,31 @@ > +# EditorConfig file: https://EditorConfig.org > + > +root = true > + > +[*] > +charset = latin1 > +end_of_line = crlf > +indent_style = space > +indent_size = 2 > +insert_final_newline = true > +trim_trailing_whitespace = true > + > +[*.py] > +charset = utf-8 > +indent_style = space > +indent_size = 4 > + > +[*.sh] > +end_of_line = lf > + > +[.gitattributes] > +end_of_line = lf > + > +[.mailmap] > +charset = utf-8 > + > +[Maintainers.txt] > +charset = utf-8 > + > +[Makefile,GNUmakefile] > +indent_style = tab > > > -- > Rebecca Cran > > > On 2/27/23 11:23 AM, Kinney, Michael D wrote: > > .gitmodules also must also use tabs. > > > >> -----Original Message----- > >> From: Kinney, Michael D <michael.d.kinney@intel.com> > >> Sent: Monday, February 27, 2023 10:22 AM > >> To: Ard Biesheuvel <ardb@kernel.org>; devel@edk2.groups.io; rebecca@bsdio.com > >> Cc: Andrew Fish <afish@apple.com>; Leif Lindholm <quic_llindhol@quicinc.com>; Kinney, Michael D <michael.d.kinney@intel.com> > >> Subject: RE: [edk2-devel] [PATCH 1/1] Add a .editorconfig file to tell editors basic formatting details > >> > >> .gitmodules must be lf. Not sure about other git config files. > >> > >> Mike > >> > >>> -----Original Message----- > >>> From: Ard Biesheuvel <ardb@kernel.org> > >>> Sent: Monday, February 27, 2023 10:18 AM > >>> To: devel@edk2.groups.io; rebecca@bsdio.com > >>> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Andrew Fish <afish@apple.com>; Leif Lindholm <quic_llindhol@quicinc.com> > >>> Subject: Re: [edk2-devel] [PATCH 1/1] Add a .editorconfig file to tell editors basic formatting details > >>> > >>> On Mon, 27 Feb 2023 at 17:35, Rebecca Cran <rebecca@bsdio.com> wrote: > >>>> Is it just .sh files that need lf endings, or are there others? > >>>> > >>> I think this only applies to .sh files. > >>> > >>>> > >>>> On 2/27/23 9:14 AM, Michael D Kinney wrote: > >>>>> There are a few file types that must be lf instead of crlf. Can those be added as well? > >>>>> > >>>>> Mike > >>>>> > >>>>>> -----Original Message----- > >>>>>> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Rebecca Cran > >>>>>> Sent: Monday, February 27, 2023 5:03 AM > >>>>>> To: Ard Biesheuvel <ardb@kernel.org>; devel@edk2.groups.io > >>>>>> Cc: Andrew Fish <afish@apple.com>; Leif Lindholm <quic_llindhol@quicinc.com>; Kinney, Michael D > >>> <michael.d.kinney@intel.com> > >>>>>> Subject: Re: [edk2-devel] [PATCH 1/1] Add a .editorconfig file to tell editors basic formatting details > >>>>>> > >>>>>> On 2/27/23 1:04 AM, Ard Biesheuvel wrote: > >>>>>> > >>>>>>> On Mon, 27 Feb 2023 at 04:47, Rebecca Cran <rebecca@bsdio.com> wrote: > >>>>>>>> Add a .editorconfig file which editors can use for basic formatting > >>>>>>>> details of files, such as tabs/spaces, line endings etc. > >>>>>>>> > >>>>>>>> Signed-off-by: Rebecca Cran <rebecca@bsdio.com> > >>>>>>> Thank you very much for this - this is very useful. > >>>>>>> > >>>>>>> Acked-by: Ard Biesheuvel <ardb@kernel.org> > >>>>>>> > >>>>>>> Could we add .dsc/.inf/.dec/etc files as well? > >>>>>> I'll move the c/c++ indentation up to the [*] section so it applies to > >>>>>> .dsc/.inf/etc too. > >>>>>> > >>>>>> > >>>>>> -- > >>>>>> Rebecca Cran > >>>>>> > >>>>>> > >>>>>> > >>>>>> > >>>>>> > >>>>> > >>>>> > >>>>> > >>>>> > >>>> > >>>> > >>>> > >>>> ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [edk2-devel] [PATCH 1/1] Add a .editorconfig file to tell editors basic formatting details 2023-02-28 21:32 ` Michael D Kinney @ 2023-03-01 3:22 ` Rebecca Cran 2023-03-01 3:27 ` Michael D Kinney 0 siblings, 1 reply; 14+ messages in thread From: Rebecca Cran @ 2023-03-01 3:22 UTC (permalink / raw) To: Kinney, Michael D, Ard Biesheuvel, devel@edk2.groups.io Cc: Andrew Fish, Leif Lindholm Mike, It looks like the line endings and tab/spaces of .gitmodules doesn't matter: do we still want to list a preference for it? "Given the following, I'm not sure line endings matter at all to git? $ file .gitmodules .gitmodules: ASCII text, with CRLF, LF line terminators $ file .gitignore .gitignore: ASCII text, with CRLF line terminators There's a CRLF in .gitmodules at the end of the brotli section. We could certainly specify that LF is _preferred_ for all .git files though?" On 2/28/23 2:32 PM, Kinney, Michael D wrote: > What about .gitmodules? > > Mike > >> -----Original Message----- >> From: Rebecca Cran <rebecca@bsdio.com> >> Sent: Tuesday, February 28, 2023 10:21 AM >> To: Kinney, Michael D <michael.d.kinney@intel.com>; Ard Biesheuvel <ardb@kernel.org>; devel@edk2.groups.io >> Cc: Andrew Fish <afish@apple.com>; Leif Lindholm <quic_llindhol@quicinc.com> >> Subject: Re: [edk2-devel] [PATCH 1/1] Add a .editorconfig file to tell editors basic formatting details >> >> Before I sent out an official v2 patch, does the following look good? >> >> >> diff --git a/.editorconfig b/.editorconfig >> new file mode 100644 >> index 000000000000..587d5bbaa884 >> --- /dev/null >> +++ b/.editorconfig >> @@ -0,0 +1,31 @@ >> +# EditorConfig file: https://EditorConfig.org >> + >> +root = true >> + >> +[*] >> +charset = latin1 >> +end_of_line = crlf >> +indent_style = space >> +indent_size = 2 >> +insert_final_newline = true >> +trim_trailing_whitespace = true >> + >> +[*.py] >> +charset = utf-8 >> +indent_style = space >> +indent_size = 4 >> + >> +[*.sh] >> +end_of_line = lf >> + >> +[.gitattributes] >> +end_of_line = lf >> + >> +[.mailmap] >> +charset = utf-8 >> + >> +[Maintainers.txt] >> +charset = utf-8 >> + >> +[Makefile,GNUmakefile] >> +indent_style = tab >> >> >> -- >> Rebecca Cran >> >> >> On 2/27/23 11:23 AM, Kinney, Michael D wrote: >>> .gitmodules also must also use tabs. >>> >>>> -----Original Message----- >>>> From: Kinney, Michael D <michael.d.kinney@intel.com> >>>> Sent: Monday, February 27, 2023 10:22 AM >>>> To: Ard Biesheuvel <ardb@kernel.org>; devel@edk2.groups.io; rebecca@bsdio.com >>>> Cc: Andrew Fish <afish@apple.com>; Leif Lindholm <quic_llindhol@quicinc.com>; Kinney, Michael D <michael.d.kinney@intel.com> >>>> Subject: RE: [edk2-devel] [PATCH 1/1] Add a .editorconfig file to tell editors basic formatting details >>>> >>>> .gitmodules must be lf. Not sure about other git config files. >>>> >>>> Mike >>>> >>>>> -----Original Message----- >>>>> From: Ard Biesheuvel <ardb@kernel.org> >>>>> Sent: Monday, February 27, 2023 10:18 AM >>>>> To: devel@edk2.groups.io; rebecca@bsdio.com >>>>> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Andrew Fish <afish@apple.com>; Leif Lindholm <quic_llindhol@quicinc.com> >>>>> Subject: Re: [edk2-devel] [PATCH 1/1] Add a .editorconfig file to tell editors basic formatting details >>>>> >>>>> On Mon, 27 Feb 2023 at 17:35, Rebecca Cran <rebecca@bsdio.com> wrote: >>>>>> Is it just .sh files that need lf endings, or are there others? >>>>>> >>>>> I think this only applies to .sh files. >>>>> >>>>>> On 2/27/23 9:14 AM, Michael D Kinney wrote: >>>>>>> There are a few file types that must be lf instead of crlf. Can those be added as well? >>>>>>> >>>>>>> Mike >>>>>>> >>>>>>>> -----Original Message----- >>>>>>>> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Rebecca Cran >>>>>>>> Sent: Monday, February 27, 2023 5:03 AM >>>>>>>> To: Ard Biesheuvel <ardb@kernel.org>; devel@edk2.groups.io >>>>>>>> Cc: Andrew Fish <afish@apple.com>; Leif Lindholm <quic_llindhol@quicinc.com>; Kinney, Michael D >>>>> <michael.d.kinney@intel.com> >>>>>>>> Subject: Re: [edk2-devel] [PATCH 1/1] Add a .editorconfig file to tell editors basic formatting details >>>>>>>> >>>>>>>> On 2/27/23 1:04 AM, Ard Biesheuvel wrote: >>>>>>>> >>>>>>>>> On Mon, 27 Feb 2023 at 04:47, Rebecca Cran <rebecca@bsdio.com> wrote: >>>>>>>>>> Add a .editorconfig file which editors can use for basic formatting >>>>>>>>>> details of files, such as tabs/spaces, line endings etc. >>>>>>>>>> >>>>>>>>>> Signed-off-by: Rebecca Cran <rebecca@bsdio.com> >>>>>>>>> Thank you very much for this - this is very useful. >>>>>>>>> >>>>>>>>> Acked-by: Ard Biesheuvel <ardb@kernel.org> >>>>>>>>> >>>>>>>>> Could we add .dsc/.inf/.dec/etc files as well? >>>>>>>> I'll move the c/c++ indentation up to the [*] section so it applies to >>>>>>>> .dsc/.inf/etc too. >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> Rebecca Cran >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>> >>>>>> >>>>>> ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [edk2-devel] [PATCH 1/1] Add a .editorconfig file to tell editors basic formatting details 2023-03-01 3:22 ` Rebecca Cran @ 2023-03-01 3:27 ` Michael D Kinney 0 siblings, 0 replies; 14+ messages in thread From: Michael D Kinney @ 2023-03-01 3:27 UTC (permalink / raw) To: Rebecca Cran, Ard Biesheuvel, devel@edk2.groups.io Cc: Andrew Fish, Leif Lindholm, Kinney, Michael D Thanks for looking into this more. Given what you found, no additional changes are required. I recall there are some other files that have specific requirements. We can add those when we run into them again. Mike > -----Original Message----- > From: Rebecca Cran <rebecca@bsdio.com> > Sent: Tuesday, February 28, 2023 7:23 PM > To: Kinney, Michael D <michael.d.kinney@intel.com>; Ard Biesheuvel <ardb@kernel.org>; devel@edk2.groups.io > Cc: Andrew Fish <afish@apple.com>; Leif Lindholm <quic_llindhol@quicinc.com> > Subject: Re: [edk2-devel] [PATCH 1/1] Add a .editorconfig file to tell editors basic formatting details > > Mike, > > > It looks like the line endings and tab/spaces of .gitmodules doesn't > matter: do we still want to list a preference for it? > > > "Given the following, I'm not sure line endings matter at all to git? > > > $ file .gitmodules > .gitmodules: ASCII text, with CRLF, LF line terminators > $ file .gitignore > .gitignore: ASCII text, with CRLF line terminators > > > There's a CRLF in .gitmodules at the end of the brotli section. > > We could certainly specify that LF is _preferred_ for all .git files > though?" > > > On 2/28/23 2:32 PM, Kinney, Michael D wrote: > > What about .gitmodules? > > > > Mike > > > >> -----Original Message----- > >> From: Rebecca Cran <rebecca@bsdio.com> > >> Sent: Tuesday, February 28, 2023 10:21 AM > >> To: Kinney, Michael D <michael.d.kinney@intel.com>; Ard Biesheuvel <ardb@kernel.org>; devel@edk2.groups.io > >> Cc: Andrew Fish <afish@apple.com>; Leif Lindholm <quic_llindhol@quicinc.com> > >> Subject: Re: [edk2-devel] [PATCH 1/1] Add a .editorconfig file to tell editors basic formatting details > >> > >> Before I sent out an official v2 patch, does the following look good? > >> > >> > >> diff --git a/.editorconfig b/.editorconfig > >> new file mode 100644 > >> index 000000000000..587d5bbaa884 > >> --- /dev/null > >> +++ b/.editorconfig > >> @@ -0,0 +1,31 @@ > >> +# EditorConfig file: https://EditorConfig.org > >> + > >> +root = true > >> + > >> +[*] > >> +charset = latin1 > >> +end_of_line = crlf > >> +indent_style = space > >> +indent_size = 2 > >> +insert_final_newline = true > >> +trim_trailing_whitespace = true > >> + > >> +[*.py] > >> +charset = utf-8 > >> +indent_style = space > >> +indent_size = 4 > >> + > >> +[*.sh] > >> +end_of_line = lf > >> + > >> +[.gitattributes] > >> +end_of_line = lf > >> + > >> +[.mailmap] > >> +charset = utf-8 > >> + > >> +[Maintainers.txt] > >> +charset = utf-8 > >> + > >> +[Makefile,GNUmakefile] > >> +indent_style = tab > >> > >> > >> -- > >> Rebecca Cran > >> > >> > >> On 2/27/23 11:23 AM, Kinney, Michael D wrote: > >>> .gitmodules also must also use tabs. > >>> > >>>> -----Original Message----- > >>>> From: Kinney, Michael D <michael.d.kinney@intel.com> > >>>> Sent: Monday, February 27, 2023 10:22 AM > >>>> To: Ard Biesheuvel <ardb@kernel.org>; devel@edk2.groups.io; rebecca@bsdio.com > >>>> Cc: Andrew Fish <afish@apple.com>; Leif Lindholm <quic_llindhol@quicinc.com>; Kinney, Michael D > <michael.d.kinney@intel.com> > >>>> Subject: RE: [edk2-devel] [PATCH 1/1] Add a .editorconfig file to tell editors basic formatting details > >>>> > >>>> .gitmodules must be lf. Not sure about other git config files. > >>>> > >>>> Mike > >>>> > >>>>> -----Original Message----- > >>>>> From: Ard Biesheuvel <ardb@kernel.org> > >>>>> Sent: Monday, February 27, 2023 10:18 AM > >>>>> To: devel@edk2.groups.io; rebecca@bsdio.com > >>>>> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Andrew Fish <afish@apple.com>; Leif Lindholm > <quic_llindhol@quicinc.com> > >>>>> Subject: Re: [edk2-devel] [PATCH 1/1] Add a .editorconfig file to tell editors basic formatting details > >>>>> > >>>>> On Mon, 27 Feb 2023 at 17:35, Rebecca Cran <rebecca@bsdio.com> wrote: > >>>>>> Is it just .sh files that need lf endings, or are there others? > >>>>>> > >>>>> I think this only applies to .sh files. > >>>>> > >>>>>> On 2/27/23 9:14 AM, Michael D Kinney wrote: > >>>>>>> There are a few file types that must be lf instead of crlf. Can those be added as well? > >>>>>>> > >>>>>>> Mike > >>>>>>> > >>>>>>>> -----Original Message----- > >>>>>>>> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Rebecca Cran > >>>>>>>> Sent: Monday, February 27, 2023 5:03 AM > >>>>>>>> To: Ard Biesheuvel <ardb@kernel.org>; devel@edk2.groups.io > >>>>>>>> Cc: Andrew Fish <afish@apple.com>; Leif Lindholm <quic_llindhol@quicinc.com>; Kinney, Michael D > >>>>> <michael.d.kinney@intel.com> > >>>>>>>> Subject: Re: [edk2-devel] [PATCH 1/1] Add a .editorconfig file to tell editors basic formatting details > >>>>>>>> > >>>>>>>> On 2/27/23 1:04 AM, Ard Biesheuvel wrote: > >>>>>>>> > >>>>>>>>> On Mon, 27 Feb 2023 at 04:47, Rebecca Cran <rebecca@bsdio.com> wrote: > >>>>>>>>>> Add a .editorconfig file which editors can use for basic formatting > >>>>>>>>>> details of files, such as tabs/spaces, line endings etc. > >>>>>>>>>> > >>>>>>>>>> Signed-off-by: Rebecca Cran <rebecca@bsdio.com> > >>>>>>>>> Thank you very much for this - this is very useful. > >>>>>>>>> > >>>>>>>>> Acked-by: Ard Biesheuvel <ardb@kernel.org> > >>>>>>>>> > >>>>>>>>> Could we add .dsc/.inf/.dec/etc files as well? > >>>>>>>> I'll move the c/c++ indentation up to the [*] section so it applies to > >>>>>>>> .dsc/.inf/etc too. > >>>>>>>> > >>>>>>>> > >>>>>>>> -- > >>>>>>>> Rebecca Cran > >>>>>>>> > >>>>>>>> > >>>>>>>> > >>>>>>>> > >>>>>>>> > >>>>>>> > >>>>>>> > >>>>>>> > >>>>>> > >>>>>> > >>>>>> ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [edk2-devel] [PATCH 1/1] Add a .editorconfig file to tell editors basic formatting details 2023-02-27 18:22 ` Michael D Kinney 2023-02-27 18:23 ` Michael D Kinney @ 2023-02-28 6:43 ` Rebecca Cran 1 sibling, 0 replies; 14+ messages in thread From: Rebecca Cran @ 2023-02-28 6:43 UTC (permalink / raw) To: Kinney, Michael D, Ard Biesheuvel, devel@edk2.groups.io Cc: Andrew Fish, Leif Lindholm Given the following, I'm not sure line endings matter at all to git? $ file .gitmodules .gitmodules: ASCII text, with CRLF, LF line terminators $ file .gitignore .gitignore: ASCII text, with CRLF line terminators There's a CRLF in .gitmodules at the end of the brotli section. We could certainly specify that LF is _preferred_ for all .git files though? -- Rebecca Cran On 2/27/23 11:22 AM, Kinney, Michael D wrote: > .gitmodules must be lf. Not sure about other git config files. > > Mike > >> -----Original Message----- >> From: Ard Biesheuvel <ardb@kernel.org> >> Sent: Monday, February 27, 2023 10:18 AM >> To: devel@edk2.groups.io; rebecca@bsdio.com >> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Andrew Fish <afish@apple.com>; Leif Lindholm <quic_llindhol@quicinc.com> >> Subject: Re: [edk2-devel] [PATCH 1/1] Add a .editorconfig file to tell editors basic formatting details >> >> On Mon, 27 Feb 2023 at 17:35, Rebecca Cran <rebecca@bsdio.com> wrote: >>> Is it just .sh files that need lf endings, or are there others? >>> >> I think this only applies to .sh files. >> >>> >>> On 2/27/23 9:14 AM, Michael D Kinney wrote: >>>> There are a few file types that must be lf instead of crlf. Can those be added as well? >>>> >>>> Mike >>>> >>>>> -----Original Message----- >>>>> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Rebecca Cran >>>>> Sent: Monday, February 27, 2023 5:03 AM >>>>> To: Ard Biesheuvel <ardb@kernel.org>; devel@edk2.groups.io >>>>> Cc: Andrew Fish <afish@apple.com>; Leif Lindholm <quic_llindhol@quicinc.com>; Kinney, Michael D >> <michael.d.kinney@intel.com> >>>>> Subject: Re: [edk2-devel] [PATCH 1/1] Add a .editorconfig file to tell editors basic formatting details >>>>> >>>>> On 2/27/23 1:04 AM, Ard Biesheuvel wrote: >>>>> >>>>>> On Mon, 27 Feb 2023 at 04:47, Rebecca Cran <rebecca@bsdio.com> wrote: >>>>>>> Add a .editorconfig file which editors can use for basic formatting >>>>>>> details of files, such as tabs/spaces, line endings etc. >>>>>>> >>>>>>> Signed-off-by: Rebecca Cran <rebecca@bsdio.com> >>>>>> Thank you very much for this - this is very useful. >>>>>> >>>>>> Acked-by: Ard Biesheuvel <ardb@kernel.org> >>>>>> >>>>>> Could we add .dsc/.inf/.dec/etc files as well? >>>>> I'll move the c/c++ indentation up to the [*] section so it applies to >>>>> .dsc/.inf/etc too. >>>>> >>>>> >>>>> -- >>>>> Rebecca Cran >>>>> >>>>> >>>>> >>>>> >>>>> >>>> >>>> >>>> >>>> >>> >>> >>> >>> ^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2023-03-01 3:27 UTC | newest] Thread overview: 14+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-02-27 3:47 [PATCH 1/1] Add a .editorconfig file to tell editors basic formatting details Rebecca Cran 2023-02-27 8:04 ` [edk2-devel] " Ard Biesheuvel 2023-02-27 13:02 ` Rebecca Cran 2023-02-27 16:14 ` Michael D Kinney 2023-02-27 16:35 ` Rebecca Cran 2023-02-27 18:18 ` Ard Biesheuvel 2023-02-27 18:22 ` Michael D Kinney 2023-02-27 18:23 ` Michael D Kinney 2023-02-28 18:20 ` Rebecca Cran 2023-02-28 18:53 ` Ard Biesheuvel 2023-02-28 21:32 ` Michael D Kinney 2023-03-01 3:22 ` Rebecca Cran 2023-03-01 3:27 ` Michael D Kinney 2023-02-28 6:43 ` Rebecca Cran
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox