* [edk2-devel] [PATCH 1/1] MdePkg: Update the comments of HiiConfigAccess ExtractConfig
[not found] <cover.1703126089.git.suqiangx.ren@intel.com>
@ 2023-12-21 2:40 ` SuqiangX Ren
2023-12-23 2:10 ` 回复: " gaoliming via groups.io
0 siblings, 1 reply; 8+ messages in thread
From: SuqiangX Ren @ 2023-12-21 2:40 UTC (permalink / raw)
To: devel; +Cc: Ren,Suqiang, Michael D Kinney, Liming Gao, Zhiguang Liu, Yi Li
From: "Ren,Suqiang" <suqiangx.ren@intel.com>
Add status code returned for HiiConfigAccess ExtractConfig to
align with UEFI spec 2.10.
REF: UEFI spec 2.10 Table 35.5.2
Signed-off-by: SuqiangX Ren <suqiangx.ren@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Zhiguang Liu <zhiguang.liu@intel.com>
Cc: Yi Li <yi1.li@intel.com>
---
MdePkg/Include/Protocol/HiiConfigAccess.h | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/MdePkg/Include/Protocol/HiiConfigAccess.h b/MdePkg/Include/Protocol/HiiConfigAccess.h
index 3baf91e07b2e..fbee7c52b021 100644
--- a/MdePkg/Include/Protocol/HiiConfigAccess.h
+++ b/MdePkg/Include/Protocol/HiiConfigAccess.h
@@ -102,9 +102,16 @@ typedef UINTN EFI_BROWSER_ACTION;
string.
@retval EFI_INVALID_PARAMETER Unknown name. Progress points
- to the & before the name in
+ to the "&" before the name in
question.
+ @retval EFI_INVALID_PARAMETER If Results or Progress is NULL.
+
+ @retval EFI_ACCESS_DENIED The action violated a system policy.
+
+ @retval EFI_DEVICE_ERROR Failed to extract the current configuration
+ for one or more named elements.
+
**/
typedef
EFI_STATUS
--
2.26.2.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112798): https://edk2.groups.io/g/devel/message/112798
Mute This Topic: https://groups.io/mt/103294018/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply related [flat|nested] 8+ messages in thread
* 回复: [edk2-devel] [PATCH 1/1] MdePkg: Update the comments of HiiConfigAccess ExtractConfig
2023-12-21 2:40 ` [edk2-devel] [PATCH 1/1] MdePkg: Update the comments of HiiConfigAccess ExtractConfig SuqiangX Ren
@ 2023-12-23 2:10 ` gaoliming via groups.io
2024-01-08 13:31 ` Ren, Suqiang
0 siblings, 1 reply; 8+ messages in thread
From: gaoliming via groups.io @ 2023-12-23 2:10 UTC (permalink / raw)
To: devel, suqiangx.ren
Cc: 'Michael D Kinney', 'Zhiguang Liu',
'Yi Li'
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 SuqiangX Ren
> 发送时间: 2023年12月21日 10:41
> 收件人: devel@edk2.groups.io
> 抄送: Ren,Suqiang <suqiangx.ren@intel.com>; Michael D Kinney
> <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> Zhiguang Liu <zhiguang.liu@intel.com>; Yi Li <yi1.li@intel.com>
> 主题: [edk2-devel] [PATCH 1/1] MdePkg: Update the comments of
> HiiConfigAccess ExtractConfig
>
> From: "Ren,Suqiang" <suqiangx.ren@intel.com>
>
> Add status code returned for HiiConfigAccess ExtractConfig to
> align with UEFI spec 2.10.
>
> REF: UEFI spec 2.10 Table 35.5.2
>
> Signed-off-by: SuqiangX Ren <suqiangx.ren@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Cc: Yi Li <yi1.li@intel.com>
> ---
> MdePkg/Include/Protocol/HiiConfigAccess.h | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/MdePkg/Include/Protocol/HiiConfigAccess.h
> b/MdePkg/Include/Protocol/HiiConfigAccess.h
> index 3baf91e07b2e..fbee7c52b021 100644
> --- a/MdePkg/Include/Protocol/HiiConfigAccess.h
> +++ b/MdePkg/Include/Protocol/HiiConfigAccess.h
> @@ -102,9 +102,16 @@ typedef UINTN EFI_BROWSER_ACTION;
> string.
>
> @retval EFI_INVALID_PARAMETER Unknown name. Progress points
> - to the & before the name in
> + to the "&" before the name in
> question.
>
> + @retval EFI_INVALID_PARAMETER If Results or Progress is NULL.
> +
> + @retval EFI_ACCESS_DENIED The action violated a system policy.
> +
> + @retval EFI_DEVICE_ERROR Failed to extract the current
> configuration
> + for one or more named elements.
> +
> **/
> typedef
> EFI_STATUS
> --
> 2.26.2.windows.1
>
>
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112856): https://edk2.groups.io/g/devel/message/112856
Mute This Topic: https://groups.io/mt/103329433/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [edk2-devel] [PATCH 1/1] MdePkg: Update the comments of HiiConfigAccess ExtractConfig
2023-12-23 2:10 ` 回复: " gaoliming via groups.io
@ 2024-01-08 13:31 ` Ren, Suqiang
2024-01-15 2:08 ` Ren, Suqiang
0 siblings, 1 reply; 8+ messages in thread
From: Ren, Suqiang @ 2024-01-08 13:31 UTC (permalink / raw)
To: Gao, Liming, devel@edk2.groups.io
Cc: Kinney, Michael D, Liu, Zhiguang, Li, Yi1
Hi Liming,
Could you please help to check and merge this patch?
https://github.com/tianocore/edk2/pull/5170
Thanks
Ren, Suqiang
-----Original Message-----
From: gaoliming <gaoliming@byosoft.com.cn>
Sent: Saturday, December 23, 2023 10:10 AM
To: devel@edk2.groups.io; Ren, SuqiangX <suqiangx.ren@intel.com>
Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Liu, Zhiguang <zhiguang.liu@intel.com>; Li, Yi1 <yi1.li@intel.com>
Subject: 回复: [edk2-devel] [PATCH 1/1] MdePkg: Update the comments of HiiConfigAccess ExtractConfig
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 SuqiangX Ren
> 发送时间: 2023年12月21日 10:41
> 收件人: devel@edk2.groups.io
> 抄送: Ren,Suqiang <suqiangx.ren@intel.com>; Michael D Kinney
> <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> Zhiguang Liu <zhiguang.liu@intel.com>; Yi Li <yi1.li@intel.com>
> 主题: [edk2-devel] [PATCH 1/1] MdePkg: Update the comments of
> HiiConfigAccess ExtractConfig
>
> From: "Ren,Suqiang" <suqiangx.ren@intel.com>
>
> Add status code returned for HiiConfigAccess ExtractConfig to align
> with UEFI spec 2.10.
>
> REF: UEFI spec 2.10 Table 35.5.2
>
> Signed-off-by: SuqiangX Ren <suqiangx.ren@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Cc: Yi Li <yi1.li@intel.com>
> ---
> MdePkg/Include/Protocol/HiiConfigAccess.h | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/MdePkg/Include/Protocol/HiiConfigAccess.h
> b/MdePkg/Include/Protocol/HiiConfigAccess.h
> index 3baf91e07b2e..fbee7c52b021 100644
> --- a/MdePkg/Include/Protocol/HiiConfigAccess.h
> +++ b/MdePkg/Include/Protocol/HiiConfigAccess.h
> @@ -102,9 +102,16 @@ typedef UINTN EFI_BROWSER_ACTION;
> string.
>
> @retval EFI_INVALID_PARAMETER Unknown name. Progress points
> - to the & before the name in
> + to the "&" before the name in
> question.
>
> + @retval EFI_INVALID_PARAMETER If Results or Progress is NULL.
> +
> + @retval EFI_ACCESS_DENIED The action violated a system policy.
> +
> + @retval EFI_DEVICE_ERROR Failed to extract the current
> configuration
> + for one or more named elements.
> +
> **/
> typedef
> EFI_STATUS
> --
> 2.26.2.windows.1
>
>
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113392): https://edk2.groups.io/g/devel/message/113392
Mute This Topic: https://groups.io/mt/103596624/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [edk2-devel] [PATCH 1/1] MdePkg: Update the comments of HiiConfigAccess ExtractConfig
2024-01-08 13:31 ` Ren, Suqiang
@ 2024-01-15 2:08 ` Ren, Suqiang
2024-01-16 0:35 ` 回复: " gaoliming via groups.io
2024-01-20 2:32 ` Michael D Kinney
0 siblings, 2 replies; 8+ messages in thread
From: Ren, Suqiang @ 2024-01-15 2:08 UTC (permalink / raw)
To: gaoliming, devel@edk2.groups.io; +Cc: Kinney, Michael D, Liu, Zhiguang, Li, Yi1
Hi Liming,
Could you help to merge below patches which all your reviewed-by? Thanks!
https://github.com/tianocore/edk2/pull/5170
https://github.com/tianocore/edk2/pull/5186
https://github.com/tianocore/edk2/pull/5190
Thanks
Ren, Suqiang
-----Original Message-----
From: Ren, SuqiangX
Sent: Monday, January 8, 2024 9:31 PM
To: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Liu, Zhiguang <Zhiguang.Liu@intel.com>; Li, Yi1 <yi1.li@intel.com>
Subject: RE: [edk2-devel] [PATCH 1/1] MdePkg: Update the comments of HiiConfigAccess ExtractConfig
Hi Liming,
Could you please help to check and merge this patch?
https://github.com/tianocore/edk2/pull/5170
Thanks
Ren, Suqiang
-----Original Message-----
From: gaoliming <gaoliming@byosoft.com.cn>
Sent: Saturday, December 23, 2023 10:10 AM
To: devel@edk2.groups.io; Ren, SuqiangX <suqiangx.ren@intel.com>
Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Liu, Zhiguang <zhiguang.liu@intel.com>; Li, Yi1 <yi1.li@intel.com>
Subject: 回复: [edk2-devel] [PATCH 1/1] MdePkg: Update the comments of HiiConfigAccess ExtractConfig
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 SuqiangX Ren
> 发送时间: 2023年12月21日 10:41
> 收件人: devel@edk2.groups.io
> 抄送: Ren,Suqiang <suqiangx.ren@intel.com>; Michael D Kinney
> <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> Zhiguang Liu <zhiguang.liu@intel.com>; Yi Li <yi1.li@intel.com>
> 主题: [edk2-devel] [PATCH 1/1] MdePkg: Update the comments of
> HiiConfigAccess ExtractConfig
>
> From: "Ren,Suqiang" <suqiangx.ren@intel.com>
>
> Add status code returned for HiiConfigAccess ExtractConfig to align
> with UEFI spec 2.10.
>
> REF: UEFI spec 2.10 Table 35.5.2
>
> Signed-off-by: SuqiangX Ren <suqiangx.ren@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Cc: Yi Li <yi1.li@intel.com>
> ---
> MdePkg/Include/Protocol/HiiConfigAccess.h | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/MdePkg/Include/Protocol/HiiConfigAccess.h
> b/MdePkg/Include/Protocol/HiiConfigAccess.h
> index 3baf91e07b2e..fbee7c52b021 100644
> --- a/MdePkg/Include/Protocol/HiiConfigAccess.h
> +++ b/MdePkg/Include/Protocol/HiiConfigAccess.h
> @@ -102,9 +102,16 @@ typedef UINTN EFI_BROWSER_ACTION;
> string.
>
> @retval EFI_INVALID_PARAMETER Unknown name. Progress points
> - to the & before the name in
> + to the "&" before the name in
> question.
>
> + @retval EFI_INVALID_PARAMETER If Results or Progress is NULL.
> +
> + @retval EFI_ACCESS_DENIED The action violated a system policy.
> +
> + @retval EFI_DEVICE_ERROR Failed to extract the current
> configuration
> + for one or more named elements.
> +
> **/
> typedef
> EFI_STATUS
> --
> 2.26.2.windows.1
>
>
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113786): https://edk2.groups.io/g/devel/message/113786
Mute This Topic: https://groups.io/mt/103596624/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 8+ messages in thread
* 回复: [edk2-devel] [PATCH 1/1] MdePkg: Update the comments of HiiConfigAccess ExtractConfig
2024-01-15 2:08 ` Ren, Suqiang
@ 2024-01-16 0:35 ` gaoliming via groups.io
2024-01-20 2:32 ` Michael D Kinney
1 sibling, 0 replies; 8+ messages in thread
From: gaoliming via groups.io @ 2024-01-16 0:35 UTC (permalink / raw)
To: devel, suqiangx.ren
Cc: 'Kinney, Michael D', 'Liu, Zhiguang',
'Li, Yi1'
Suqiang:
All three PRs have been merged.
Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Ren, Suqiang
> 发送时间: 2024年1月15日 10:09
> 收件人: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
> 抄送: Kinney, Michael D <michael.d.kinney@intel.com>; Liu, Zhiguang
> <zhiguang.liu@intel.com>; Li, Yi1 <yi1.li@intel.com>
> 主题: Re: [edk2-devel] [PATCH 1/1] MdePkg: Update the comments of
> HiiConfigAccess ExtractConfig
>
> Hi Liming,
>
> Could you help to merge below patches which all your reviewed-by?
> Thanks!
> https://github.com/tianocore/edk2/pull/5170
> https://github.com/tianocore/edk2/pull/5186
> https://github.com/tianocore/edk2/pull/5190
>
>
> Thanks
> Ren, Suqiang
>
> -----Original Message-----
> From: Ren, SuqiangX
> Sent: Monday, January 8, 2024 9:31 PM
> To: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Liu, Zhiguang
> <Zhiguang.Liu@intel.com>; Li, Yi1 <yi1.li@intel.com>
> Subject: RE: [edk2-devel] [PATCH 1/1] MdePkg: Update the comments of
> HiiConfigAccess ExtractConfig
>
> Hi Liming,
>
> Could you please help to check and merge this patch?
> https://github.com/tianocore/edk2/pull/5170
>
>
> Thanks
> Ren, Suqiang
>
> -----Original Message-----
> From: gaoliming <gaoliming@byosoft.com.cn>
> Sent: Saturday, December 23, 2023 10:10 AM
> To: devel@edk2.groups.io; Ren, SuqiangX <suqiangx.ren@intel.com>
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Liu, Zhiguang
> <zhiguang.liu@intel.com>; Li, Yi1 <yi1.li@intel.com>
> Subject: 回复: [edk2-devel] [PATCH 1/1] MdePkg: Update the comments of
> HiiConfigAccess ExtractConfig
>
> Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
>
> > -----邮件原件-----
> > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 SuqiangX
> Ren
> > 发送时间: 2023年12月21日 10:41
> > 收件人: devel@edk2.groups.io
> > 抄送: Ren,Suqiang <suqiangx.ren@intel.com>; Michael D Kinney
> > <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> > Zhiguang Liu <zhiguang.liu@intel.com>; Yi Li <yi1.li@intel.com>
> > 主题: [edk2-devel] [PATCH 1/1] MdePkg: Update the comments of
> > HiiConfigAccess ExtractConfig
> >
> > From: "Ren,Suqiang" <suqiangx.ren@intel.com>
> >
> > Add status code returned for HiiConfigAccess ExtractConfig to align
> > with UEFI spec 2.10.
> >
> > REF: UEFI spec 2.10 Table 35.5.2
> >
> > Signed-off-by: SuqiangX Ren <suqiangx.ren@intel.com>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> > Cc: Yi Li <yi1.li@intel.com>
> > ---
> > MdePkg/Include/Protocol/HiiConfigAccess.h | 9 ++++++++-
> > 1 file changed, 8 insertions(+), 1 deletion(-)
> >
> > diff --git a/MdePkg/Include/Protocol/HiiConfigAccess.h
> > b/MdePkg/Include/Protocol/HiiConfigAccess.h
> > index 3baf91e07b2e..fbee7c52b021 100644
> > --- a/MdePkg/Include/Protocol/HiiConfigAccess.h
> > +++ b/MdePkg/Include/Protocol/HiiConfigAccess.h
> > @@ -102,9 +102,16 @@ typedef UINTN EFI_BROWSER_ACTION;
> > string.
> >
> > @retval EFI_INVALID_PARAMETER Unknown name. Progress points
> > - to the & before the name in
> > + to the "&" before the name in
> > question.
> >
> > + @retval EFI_INVALID_PARAMETER If Results or Progress is NULL.
> > +
> > + @retval EFI_ACCESS_DENIED The action violated a system
> policy.
> > +
> > + @retval EFI_DEVICE_ERROR Failed to extract the current
> > configuration
> > + for one or more named
> elements.
> > +
> > **/
> > typedef
> > EFI_STATUS
> > --
> > 2.26.2.windows.1
> >
> >
> >
> >
> >
>
>
>
>
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113856): https://edk2.groups.io/g/devel/message/113856
Mute This Topic: https://groups.io/mt/103752871/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [edk2-devel] [PATCH 1/1] MdePkg: Update the comments of HiiConfigAccess ExtractConfig
2024-01-15 2:08 ` Ren, Suqiang
2024-01-16 0:35 ` 回复: " gaoliming via groups.io
@ 2024-01-20 2:32 ` Michael D Kinney
2024-01-22 1:54 ` Tan, Ming
1 sibling, 1 reply; 8+ messages in thread
From: Michael D Kinney @ 2024-01-20 2:32 UTC (permalink / raw)
To: Ren, SuqiangX, gaoliming, devel@edk2.groups.io
Cc: Liu, Zhiguang, Li, Yi1, Kinney, Michael D
Hi Suqiang,
For the Browser/HII related changes to the MdePkg can you also
prepare a patch to update the function headers in the implementation
of these APIs and make sure the implementation conforms to the
update header file changes?
Thanks,
Mike
> -----Original Message-----
> From: Ren, SuqiangX <suqiangx.ren@intel.com>
> Sent: Sunday, January 14, 2024 6:09 PM
> To: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Liu, Zhiguang
> <zhiguang.liu@intel.com>; Li, Yi1 <yi1.li@intel.com>
> Subject: RE: [edk2-devel] [PATCH 1/1] MdePkg: Update the comments of
> HiiConfigAccess ExtractConfig
>
> Hi Liming,
>
> Could you help to merge below patches which all your reviewed-by?
> Thanks!
> https://github.com/tianocore/edk2/pull/5170
> https://github.com/tianocore/edk2/pull/5186
> https://github.com/tianocore/edk2/pull/5190
>
>
> Thanks
> Ren, Suqiang
>
> -----Original Message-----
> From: Ren, SuqiangX
> Sent: Monday, January 8, 2024 9:31 PM
> To: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Liu, Zhiguang
> <Zhiguang.Liu@intel.com>; Li, Yi1 <yi1.li@intel.com>
> Subject: RE: [edk2-devel] [PATCH 1/1] MdePkg: Update the comments of
> HiiConfigAccess ExtractConfig
>
> Hi Liming,
>
> Could you please help to check and merge this patch?
> https://github.com/tianocore/edk2/pull/5170
>
>
> Thanks
> Ren, Suqiang
>
> -----Original Message-----
> From: gaoliming <gaoliming@byosoft.com.cn>
> Sent: Saturday, December 23, 2023 10:10 AM
> To: devel@edk2.groups.io; Ren, SuqiangX <suqiangx.ren@intel.com>
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Liu, Zhiguang
> <zhiguang.liu@intel.com>; Li, Yi1 <yi1.li@intel.com>
> Subject: 回复: [edk2-devel] [PATCH 1/1] MdePkg: Update the comments of
> HiiConfigAccess ExtractConfig
>
> Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
>
> > -----邮件原件-----
> > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 SuqiangX Ren
> > 发送时间: 2023年12月21日 10:41
> > 收件人: devel@edk2.groups.io
> > 抄送: Ren,Suqiang <suqiangx.ren@intel.com>; Michael D Kinney
> > <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> > Zhiguang Liu <zhiguang.liu@intel.com>; Yi Li <yi1.li@intel.com>
> > 主题: [edk2-devel] [PATCH 1/1] MdePkg: Update the comments of
> > HiiConfigAccess ExtractConfig
> >
> > From: "Ren,Suqiang" <suqiangx.ren@intel.com>
> >
> > Add status code returned for HiiConfigAccess ExtractConfig to align
> > with UEFI spec 2.10.
> >
> > REF: UEFI spec 2.10 Table 35.5.2
> >
> > Signed-off-by: SuqiangX Ren <suqiangx.ren@intel.com>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> > Cc: Yi Li <yi1.li@intel.com>
> > ---
> > MdePkg/Include/Protocol/HiiConfigAccess.h | 9 ++++++++-
> > 1 file changed, 8 insertions(+), 1 deletion(-)
> >
> > diff --git a/MdePkg/Include/Protocol/HiiConfigAccess.h
> > b/MdePkg/Include/Protocol/HiiConfigAccess.h
> > index 3baf91e07b2e..fbee7c52b021 100644
> > --- a/MdePkg/Include/Protocol/HiiConfigAccess.h
> > +++ b/MdePkg/Include/Protocol/HiiConfigAccess.h
> > @@ -102,9 +102,16 @@ typedef UINTN EFI_BROWSER_ACTION;
> > string.
> >
> > @retval EFI_INVALID_PARAMETER Unknown name. Progress points
> > - to the & before the name in
> > + to the "&" before the name in
> > question.
> >
> > + @retval EFI_INVALID_PARAMETER If Results or Progress is NULL.
> > +
> > + @retval EFI_ACCESS_DENIED The action violated a system
> policy.
> > +
> > + @retval EFI_DEVICE_ERROR Failed to extract the current
> > configuration
> > + for one or more named elements.
> > +
> > **/
> > typedef
> > EFI_STATUS
> > --
> > 2.26.2.windows.1
> >
> >
> >
> >
> >
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114109): https://edk2.groups.io/g/devel/message/114109
Mute This Topic: https://groups.io/mt/103596624/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [edk2-devel] [PATCH 1/1] MdePkg: Update the comments of HiiConfigAccess ExtractConfig
2024-01-20 2:32 ` Michael D Kinney
@ 2024-01-22 1:54 ` Tan, Ming
2024-01-23 1:35 ` Michael D Kinney
0 siblings, 1 reply; 8+ messages in thread
From: Tan, Ming @ 2024-01-22 1:54 UTC (permalink / raw)
To: devel@edk2.groups.io, Kinney, Michael D, Ren, SuqiangX, gaoliming
Cc: Liu, Zhiguang, Li, Yi1
Mike:
For the change of https://github.com/tianocore/edk2/pull/5170.
We checked all the files for function XxxExtractConfig, find there is not function will return EFI_DEVICE_ERROR in the function code directly.
One possible place is just call xxx ->BlockToConfig(), and the XxxExtractConfig will return the Status of call BlockToConfig().
For example in https://github.com/tianocore/edk2/blob/c251015292cc5f4ca003894e5922a40b08cd14b0/MdeModulePkg/Universal/DriverSampleDxe/DriverSample.c#L808
Status = HiiConfigRouting->BlockToConfig (
HiiConfigRouting,
ConfigRequest,
(UINT8 *)&PrivateData->Configuration,
BufferSize,
Results,
Progress
);
......
return Status;
So need we change the code, if such BlockToConfig return failed, then ignore the detail reason, but return EFI_DEVICE_ERROR in function XxxExtractConfig?
BR/Tan Ming.
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Michael D Kinney
Sent: Saturday, January 20, 2024 10:32 AM
To: Ren, SuqiangX <suqiangx.ren@intel.com>; gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
Cc: Liu, Zhiguang <zhiguang.liu@intel.com>; Li, Yi1 <yi1.li@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] [PATCH 1/1] MdePkg: Update the comments of HiiConfigAccess ExtractConfig
Hi Suqiang,
For the Browser/HII related changes to the MdePkg can you also prepare a patch to update the function headers in the implementation of these APIs and make sure the implementation conforms to the update header file changes?
Thanks,
Mike
> -----Original Message-----
> From: Ren, SuqiangX <suqiangx.ren@intel.com>
> Sent: Sunday, January 14, 2024 6:09 PM
> To: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Liu, Zhiguang
> <zhiguang.liu@intel.com>; Li, Yi1 <yi1.li@intel.com>
> Subject: RE: [edk2-devel] [PATCH 1/1] MdePkg: Update the comments of
> HiiConfigAccess ExtractConfig
>
> Hi Liming,
>
> Could you help to merge below patches which all your reviewed-by?
> Thanks!
> https://github.com/tianocore/edk2/pull/5170
> https://github.com/tianocore/edk2/pull/5186
> https://github.com/tianocore/edk2/pull/5190
>
>
> Thanks
> Ren, Suqiang
>
> -----Original Message-----
> From: Ren, SuqiangX
> Sent: Monday, January 8, 2024 9:31 PM
> To: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Liu, Zhiguang
> <Zhiguang.Liu@intel.com>; Li, Yi1 <yi1.li@intel.com>
> Subject: RE: [edk2-devel] [PATCH 1/1] MdePkg: Update the comments of
> HiiConfigAccess ExtractConfig
>
> Hi Liming,
>
> Could you please help to check and merge this patch?
> https://github.com/tianocore/edk2/pull/5170
>
>
> Thanks
> Ren, Suqiang
>
> -----Original Message-----
> From: gaoliming <gaoliming@byosoft.com.cn>
> Sent: Saturday, December 23, 2023 10:10 AM
> To: devel@edk2.groups.io; Ren, SuqiangX <suqiangx.ren@intel.com>
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Liu, Zhiguang
> <zhiguang.liu@intel.com>; Li, Yi1 <yi1.li@intel.com>
> Subject: 回复: [edk2-devel] [PATCH 1/1] MdePkg: Update the comments of
> HiiConfigAccess ExtractConfig
>
> Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
>
> > -----邮件原件-----
> > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 SuqiangX Ren
> > 发送时间: 2023年12月21日 10:41
> > 收件人: devel@edk2.groups.io
> > 抄送: Ren,Suqiang <suqiangx.ren@intel.com>; Michael D Kinney
> > <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> > Zhiguang Liu <zhiguang.liu@intel.com>; Yi Li <yi1.li@intel.com>
> > 主题: [edk2-devel] [PATCH 1/1] MdePkg: Update the comments of
> > HiiConfigAccess ExtractConfig
> >
> > From: "Ren,Suqiang" <suqiangx.ren@intel.com>
> >
> > Add status code returned for HiiConfigAccess ExtractConfig to align
> > with UEFI spec 2.10.
> >
> > REF: UEFI spec 2.10 Table 35.5.2
> >
> > Signed-off-by: SuqiangX Ren <suqiangx.ren@intel.com>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> > Cc: Yi Li <yi1.li@intel.com>
> > ---
> > MdePkg/Include/Protocol/HiiConfigAccess.h | 9 ++++++++-
> > 1 file changed, 8 insertions(+), 1 deletion(-)
> >
> > diff --git a/MdePkg/Include/Protocol/HiiConfigAccess.h
> > b/MdePkg/Include/Protocol/HiiConfigAccess.h
> > index 3baf91e07b2e..fbee7c52b021 100644
> > --- a/MdePkg/Include/Protocol/HiiConfigAccess.h
> > +++ b/MdePkg/Include/Protocol/HiiConfigAccess.h
> > @@ -102,9 +102,16 @@ typedef UINTN EFI_BROWSER_ACTION;
> > string.
> >
> > @retval EFI_INVALID_PARAMETER Unknown name. Progress points
> > - to the & before the name in
> > + to the "&" before the name in
> > question.
> >
> > + @retval EFI_INVALID_PARAMETER If Results or Progress is NULL.
> > +
> > + @retval EFI_ACCESS_DENIED The action violated a system
> policy.
> > +
> > + @retval EFI_DEVICE_ERROR Failed to extract the current
> > configuration
> > + for one or more named elements.
> > +
> > **/
> > typedef
> > EFI_STATUS
> > --
> > 2.26.2.windows.1
> >
> >
> >
> >
> >
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114128): https://edk2.groups.io/g/devel/message/114128
Mute This Topic: https://groups.io/mt/103596624/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [edk2-devel] [PATCH 1/1] MdePkg: Update the comments of HiiConfigAccess ExtractConfig
2024-01-22 1:54 ` Tan, Ming
@ 2024-01-23 1:35 ` Michael D Kinney
0 siblings, 0 replies; 8+ messages in thread
From: Michael D Kinney @ 2024-01-23 1:35 UTC (permalink / raw)
To: Tan, Ming, devel@edk2.groups.io, Ren, SuqiangX, gaoliming
Cc: Liu, Zhiguang, Li, Yi1, Kinney, Michael D
Hi Tan Ming,
In this case, the function header in the implementation needs to be
updated to match the MdePkg header file changes.
I agree that the device error would have to propagate from the HII
Config Routing Protocol that may use services such as UEFI Variable
Services or other device specific services to read/write config
data and that is where an EFI_DEVICE_ERROR can occur.
Mike
> -----Original Message-----
> From: Tan, Ming <ming.tan@intel.com>
> Sent: Sunday, January 21, 2024 5:54 PM
> To: devel@edk2.groups.io; Kinney, Michael D
> <michael.d.kinney@intel.com>; Ren, SuqiangX <suqiangx.ren@intel.com>;
> gaoliming <gaoliming@byosoft.com.cn>
> Cc: Liu, Zhiguang <zhiguang.liu@intel.com>; Li, Yi1 <yi1.li@intel.com>
> Subject: RE: [edk2-devel] [PATCH 1/1] MdePkg: Update the comments of
> HiiConfigAccess ExtractConfig
>
> Mike:
> For the change of https://github.com/tianocore/edk2/pull/5170.
> We checked all the files for function XxxExtractConfig, find there is
> not function will return EFI_DEVICE_ERROR in the function code directly.
> One possible place is just call xxx ->BlockToConfig(), and the
> XxxExtractConfig will return the Status of call BlockToConfig().
> For example in
> https://github.com/tianocore/edk2/blob/c251015292cc5f4ca003894e5922a40b0
> 8cd14b0/MdeModulePkg/Universal/DriverSampleDxe/DriverSample.c#L808
> Status = HiiConfigRouting->BlockToConfig (
> HiiConfigRouting,
> ConfigRequest,
> (UINT8 *)&PrivateData->Configuration,
> BufferSize,
> Results,
> Progress
> );
> ......
> return Status;
>
> So need we change the code, if such BlockToConfig return failed, then
> ignore the detail reason, but return EFI_DEVICE_ERROR in function
> XxxExtractConfig?
>
> BR/Tan Ming.
>
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Michael D
> Kinney
> Sent: Saturday, January 20, 2024 10:32 AM
> To: Ren, SuqiangX <suqiangx.ren@intel.com>; gaoliming
> <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
> Cc: Liu, Zhiguang <zhiguang.liu@intel.com>; Li, Yi1 <yi1.li@intel.com>;
> Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: Re: [edk2-devel] [PATCH 1/1] MdePkg: Update the comments of
> HiiConfigAccess ExtractConfig
>
> Hi Suqiang,
>
> For the Browser/HII related changes to the MdePkg can you also prepare a
> patch to update the function headers in the implementation of these APIs
> and make sure the implementation conforms to the update header file
> changes?
>
> Thanks,
>
> Mike
>
> > -----Original Message-----
> > From: Ren, SuqiangX <suqiangx.ren@intel.com>
> > Sent: Sunday, January 14, 2024 6:09 PM
> > To: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
> > Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Liu, Zhiguang
> > <zhiguang.liu@intel.com>; Li, Yi1 <yi1.li@intel.com>
> > Subject: RE: [edk2-devel] [PATCH 1/1] MdePkg: Update the comments of
> > HiiConfigAccess ExtractConfig
> >
> > Hi Liming,
> >
> > Could you help to merge below patches which all your reviewed-by?
> > Thanks!
> > https://github.com/tianocore/edk2/pull/5170
> > https://github.com/tianocore/edk2/pull/5186
> > https://github.com/tianocore/edk2/pull/5190
> >
> >
> > Thanks
> > Ren, Suqiang
> >
> > -----Original Message-----
> > From: Ren, SuqiangX
> > Sent: Monday, January 8, 2024 9:31 PM
> > To: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
> > Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Liu, Zhiguang
> > <Zhiguang.Liu@intel.com>; Li, Yi1 <yi1.li@intel.com>
> > Subject: RE: [edk2-devel] [PATCH 1/1] MdePkg: Update the comments of
> > HiiConfigAccess ExtractConfig
> >
> > Hi Liming,
> >
> > Could you please help to check and merge this patch?
> > https://github.com/tianocore/edk2/pull/5170
> >
> >
> > Thanks
> > Ren, Suqiang
> >
> > -----Original Message-----
> > From: gaoliming <gaoliming@byosoft.com.cn>
> > Sent: Saturday, December 23, 2023 10:10 AM
> > To: devel@edk2.groups.io; Ren, SuqiangX <suqiangx.ren@intel.com>
> > Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Liu, Zhiguang
> > <zhiguang.liu@intel.com>; Li, Yi1 <yi1.li@intel.com>
> > Subject: 回复: [edk2-devel] [PATCH 1/1] MdePkg: Update the comments of
> > HiiConfigAccess ExtractConfig
> >
> > Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
> >
> > > -----邮件原件-----
> > > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 SuqiangX Ren
> > > 发送时间: 2023年12月21日 10:41
> > > 收件人: devel@edk2.groups.io
> > > 抄送: Ren,Suqiang <suqiangx.ren@intel.com>; Michael D Kinney
> > > <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> > > Zhiguang Liu <zhiguang.liu@intel.com>; Yi Li <yi1.li@intel.com>
> > > 主题: [edk2-devel] [PATCH 1/1] MdePkg: Update the comments of
> > > HiiConfigAccess ExtractConfig
> > >
> > > From: "Ren,Suqiang" <suqiangx.ren@intel.com>
> > >
> > > Add status code returned for HiiConfigAccess ExtractConfig to align
> > > with UEFI spec 2.10.
> > >
> > > REF: UEFI spec 2.10 Table 35.5.2
> > >
> > > Signed-off-by: SuqiangX Ren <suqiangx.ren@intel.com>
> > > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > > Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> > > Cc: Yi Li <yi1.li@intel.com>
> > > ---
> > > MdePkg/Include/Protocol/HiiConfigAccess.h | 9 ++++++++-
> > > 1 file changed, 8 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/MdePkg/Include/Protocol/HiiConfigAccess.h
> > > b/MdePkg/Include/Protocol/HiiConfigAccess.h
> > > index 3baf91e07b2e..fbee7c52b021 100644
> > > --- a/MdePkg/Include/Protocol/HiiConfigAccess.h
> > > +++ b/MdePkg/Include/Protocol/HiiConfigAccess.h
> > > @@ -102,9 +102,16 @@ typedef UINTN EFI_BROWSER_ACTION;
> > > string.
> > >
> > > @retval EFI_INVALID_PARAMETER Unknown name. Progress points
> > > - to the & before the name in
> > > + to the "&" before the name in
> > > question.
> > >
> > > + @retval EFI_INVALID_PARAMETER If Results or Progress is NULL.
> > > +
> > > + @retval EFI_ACCESS_DENIED The action violated a system
> > policy.
> > > +
> > > + @retval EFI_DEVICE_ERROR Failed to extract the current
> > > configuration
> > > + for one or more named elements.
> > > +
> > > **/
> > > typedef
> > > EFI_STATUS
> > > --
> > > 2.26.2.windows.1
> > >
> > >
> > >
> > >
> > >
> >
> >
>
>
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114161): https://edk2.groups.io/g/devel/message/114161
Mute This Topic: https://groups.io/mt/103596624/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2024-01-23 1:35 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <cover.1703126089.git.suqiangx.ren@intel.com>
2023-12-21 2:40 ` [edk2-devel] [PATCH 1/1] MdePkg: Update the comments of HiiConfigAccess ExtractConfig SuqiangX Ren
2023-12-23 2:10 ` 回复: " gaoliming via groups.io
2024-01-08 13:31 ` Ren, Suqiang
2024-01-15 2:08 ` Ren, Suqiang
2024-01-16 0:35 ` 回复: " gaoliming via groups.io
2024-01-20 2:32 ` Michael D Kinney
2024-01-22 1:54 ` Tan, Ming
2024-01-23 1:35 ` Michael D Kinney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox