From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 7A8B6740035 for ; Tue, 23 Jan 2024 17:27:37 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=l38voIYoJ+glH4L16p7bRmROYuM3v1W9azyfR99BUZI=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1706030856; v=1; b=PKbsS8EAaWL7ghf18RP82jsjob59Xt4GrYrH5TQHcAnefySf5HYWV5RUx1A7/EHKxyjKJ0ty 8b93A4iEsmjnV0pj7qfU0bPKq86Xn62e0PiYW9T/yfvPvsQKxGE75v7R8ZFxAMEaCzyN1Raw4yy m/o/k7o/CB+nnxt21g4dhwfo= X-Received: by 127.0.0.2 with SMTP id ZEyRYY7687511xzVIpuOAbez; Tue, 23 Jan 2024 09:27:36 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) by mx.groups.io with SMTP id smtpd.web11.19214.1706030855277598945 for ; Tue, 23 Jan 2024 09:27:35 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10962"; a="487783" X-IronPort-AV: E=Sophos;i="6.05,214,1701158400"; d="scan'208";a="487783" X-Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jan 2024 09:26:36 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10962"; a="1117324883" X-IronPort-AV: E=Sophos;i="6.05,214,1701158400"; d="scan'208";a="1117324883" X-Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga005.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 23 Jan 2024 09:26:29 -0800 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 23 Jan 2024 09:26:28 -0800 X-Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Tue, 23 Jan 2024 09:26:28 -0800 X-Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.101) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Tue, 23 Jan 2024 09:26:27 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=INaZRJbq1f0RjfwsfYWVJFu7SKq4rWWwfcbwNCg5yFHTdWjYCPSgiF7AxUIjDAT+z8CJydyl4a78rBK3+Ir/I40HpDM4xj01raSKGGrtbo70KgucVE2BUsfBnqaAiRz030Tr/hic6hlAdJvSEvG/EMVvLMA7zSUClfnrvvfxuM68zcql5bvr90Nqyx4zrwvd9gyeMOBO3ZvmIiaR4BoCOWduksKhwQiNFZ2VZFPvAOCHW5Encpjzc+ucMHva0wqNMWIzg1Hu1gvcv2+wm6toKRt3vgz0tGi9C3q2bW8OSAIJ9fRnWDIt0D/CQaBnS8nbOAX1Ae8NQr+b4GHdGRNy8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yavPmRhnAo/mHnCXvRGQdWTidE3zjBO2mJocp5BbCSI=; b=a2Sn/Vm0OqWlFNucBMKMaXpOjzGdMS4BhBEg/jjWXo8DzscsPeAbAyc69ylfahGZwtyeiqkLM+qLWumMkyekwg9EEo+2lfDVjGX9GCwR1+ThIXo0de5dEIb+1AsAdSiOGUFTz88dtYEobGFtx6C+l0leTvhigzhiUaKR5roGcRtoBtsfMGK72WYknHnnnuryju9FpsUL1pGSKGItytcKn4YGmFezKr+4ZMhFfBLjOb2K2KV2GEwOViZJ0OKQHiIcwky1oKlfmRELecCnVI5y4OqZhNfRWhdehTdk/MG8uFrQz1l0g5wIYVUk/bCdvv8+5DO8oOoXqK6irzbWQcYfRw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com (2603:10b6:303:6d::19) by CY5PR11MB6536.namprd11.prod.outlook.com (2603:10b6:930:40::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7202.36; Tue, 23 Jan 2024 17:26:25 +0000 X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::7e42:1633:d0a6:9c00]) by CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::7e42:1633:d0a6:9c00%6]) with mapi id 15.20.7202.035; Tue, 23 Jan 2024 17:26:25 +0000 From: "Michael D Kinney" To: "devel@edk2.groups.io" , "Huang, Qing" CC: "Kinney, Michael D" Subject: Re: [edk2-devel] [PATCH v1] MdePkg/BaseCpuLibNull: Add stub function of StandardSignatureIsAuthenticAMD() in CpuLibNull instance Thread-Topic: [edk2-devel] [PATCH v1] MdePkg/BaseCpuLibNull: Add stub function of StandardSignatureIsAuthenticAMD() in CpuLibNull instance Thread-Index: AQHaTfCThqSanrTJc0yRxPI6KPMB8rDnpabA Date: Tue, 23 Jan 2024 17:26:25 +0000 Message-ID: References: <20240123113649.712-1-qing.huang@intel.com> In-Reply-To: <20240123113649.712-1-qing.huang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO1PR11MB4929:EE_|CY5PR11MB6536:EE_ x-ms-office365-filtering-correlation-id: 745a5315-aa75-4534-ab61-08dc1c386d08 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: ecWL/Vi7WnNiOe7VJ2v2VQ1O0IOretIY7Fti83qlYcufLhxUvwHrQXTPhkkzAcMDetWCRdZy6WPDfed7KNskWdl2CmCLVOP2xw9lPidH5cIAJKYwzk2eWaq4zrLp3EJrkod921XsSbnzr3NbBPM8jlDv4Jd6/SvmflLKjCvmKG7nWYrujwe5/Bf8MCFFeRwIeaV3qkgw0w5q79H1k2GCpGClPsdgQyHV5mhGTcjQQ4c0roL00ci9H9LKfibtyLSNUEA6bK0jbwwMkluOPk30AQi/9IprEw0kogE0FWA9gbvjAFM+gc+itSTr+lxJxXlZ5llLifMhkvS9spEDLywOQJeBMVfkA4YnCm+X1taBxWAWdZ1cpN5jeca3ipie3jqVMsdutX4qhz32AH1IisEZsSYFyIJrVPPmA+twBT39g9DRaB+BpWVCJbUTIP18AWX7DxhpFZcnidHHwKnZ/QXqPYe6TMbWXRbLoV0X/b9dZFi4vJVR9SZCuypAwTjPTrb3LptRzGA4mVoWAAhOKhgTmp/8fmlMMLjSPtwB+e2p3WfqCHOXYvyB38+dRPLskZKcC3HEPDQ7Ji4T8Bp6tYmL18kG4LxG5Hvb8S5ILmhwvjDnxXptrPXSXzVBFYCIZHzHi6qq3xPzOGC5FiEGXncFjg== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?S6X6Ymxn8sLjEzRtt9/OWCtTLVT4OZuCtWzJ7IgzBKssHjDFPZK9CKM+YbSi?= =?us-ascii?Q?PQFb7WFH8eZbD/Kqm/F00fsLpP6Yw6WJlf12cy9E5E6A0TXDvV4rVb4wW6Nd?= =?us-ascii?Q?b3jaC0Uv1q1+haweamkGUwH1FzBMzK8TROoS5hzmEO+2AKeWeVb3ix1ec9IW?= =?us-ascii?Q?FGUw/9EkfaWDuslbcBhk3Z9suqHFmNRRVrDMQosXHIhikPuhXBTSa9ciwC2R?= =?us-ascii?Q?1fUSRMU3bIJXrmgNCFtFYBqwBXRbAWvkKzd/kuohq61CdYzbULqhLanyK8Qr?= =?us-ascii?Q?xy2yDXjqe8MujuBI+pkx/PEE5TBYK/qHC7pCZTLTQeUHb+jV4uS+pLQLzncP?= =?us-ascii?Q?Y8UAs+BaMplzV4Cj+tuJyrd9i62ML00lj3Zr3z+FEpKS9dVF8iXdCMJWMFDc?= =?us-ascii?Q?igk+5+/gKiDW5fU9kZ/0WTRUWDUfKjE1lm11ZU/7PHns5baBdnkTWOeKTxoM?= =?us-ascii?Q?/kFxbg2hnpsieSyjnZ4ocYWbfV1lCS0FP8OcOfDb2exmFJH72s7YM3N+g+sp?= =?us-ascii?Q?7gp/ZF4SPeqDSsNF+OkiVT8qmxU3okAwVZi/VDU0txksfAdvq0I2uvppIsYx?= =?us-ascii?Q?+QHwr+swhuCLCVhc1RASMt8rsBBGMdI8P92yJWoLa4FVMAwLAMFNmCngHSZQ?= =?us-ascii?Q?McW0CC7f2fY/LBBoib1SKfVnheAXFy5D3wTZb1NMPw1+rs5FlpLJFD4+d6sw?= =?us-ascii?Q?/EPa3FkTdKgr3XM5Nm5g6XEa0oxCIjtsI9C4wIbtxGRGhL5TFS7gvgWzDD8c?= =?us-ascii?Q?klf0McKnXHu8xMXOOCRU0dyogNph77ATnnMbODhghjNRYVwnZnPlDxn14NiI?= =?us-ascii?Q?WEp6c5cJ3TzWd/TBnusoKPI2iiHz/NaDpc+mu9hjEoAlYzeqyJ2MAZdPU9pS?= =?us-ascii?Q?jgxPSZ1qKURdUet+h2HMxzXBUD4oVkMyJ34f54nVuwIPOB0bAO4PmDfYrv+o?= =?us-ascii?Q?KZaO1jaxVDjZdjWGPDTEAqJKkQ1pbW0oL1R566gCQCsZgEQ3Sd1Wq75KOfTU?= =?us-ascii?Q?iljRlPoJNXh68wiEeK94+HGWNtt4Oe9x+ttU3q+zfQrT7GagNIrEk/gQ18SK?= =?us-ascii?Q?IIVzADD+Sl6okDTPIMpJsyBLbqeZpRBhSgx5kGY7N8GdBPu2XfaY4gZ+nv0p?= =?us-ascii?Q?a/JVf4mhR5Xq4h9LouGtmzC653unQMpiuMGXcbP9bwBMs47DDaOzv3AckMhY?= =?us-ascii?Q?72Ak8hBNq+XcppE9LmCVg4HcXUQ3/JzbCKGrGVuMErx7TdwSrPJICR5Ghc+B?= =?us-ascii?Q?V0ZAy7WnRDbe5kOTIGRcZ/VWW8UQxn6QhbHm7YqTxD167k63R5ZG6tJWp0rz?= =?us-ascii?Q?Zw5ShVLRCKl0V1BB3hYwFJeHbyTiWEcOUeMG/GW5Fw/rwMCZaOoa/5YcfQWf?= =?us-ascii?Q?BGlU1l5sKyG5LEbeEh1+AOv90mkHdCMoyls88XtR/+MgbEV9Uhk8WxLyddvE?= =?us-ascii?Q?jgJIOlQIxJ34WrwGcHRqNWEhEDaPGnAeEogPatO9T6Viu5ez95mwEnzxR5LU?= =?us-ascii?Q?mlZYR71l6F9t93V4du4ApHd19zZuFAN0ym/iDfQMsawBemZxswJmxo7zhbyh?= =?us-ascii?Q?34Ek3jN8ehy2I1do7/fXP5GGhC3JjwO20FJXErWlb1S3vtKNFGEYidqq2Ym9?= =?us-ascii?Q?Cw=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4929.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 745a5315-aa75-4534-ab61-08dc1c386d08 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jan 2024 17:26:25.2678 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: FoILmhg4gpFXowmxCGj7eyPjBS0kF4o02ih0oyImxMoBokgFNQlQ6xDi3FSwqMwwHT4Tqww5aOLCRN54Nz6OuDSkhREJntO/8lEvFbZJ8pc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6536 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,michael.d.kinney@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: CdPHvYbOmrNrFqK4p4xo7Z9Vx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=PKbsS8EA; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Hi Qing, Thank you for this update to add the missing API to BaseCpuLibNull. There are a few very minor comments below. I will make those updates in the PR for merge. With those changes: Reviewed-by: Michael D Kinney Mike > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Huang, > Qing > Sent: Tuesday, January 23, 2024 3:37 AM > To: devel@edk2.groups.io > Cc: Huang, Qing > Subject: [edk2-devel] [PATCH v1] MdePkg/BaseCpuLibNull: Add stub > function of StandardSignatureIsAuthenticAMD() in CpuLibNull instance Subject line too long >=20 > CpuLib.h exposes StandardSignatureIsAuthenticAMD() API and we require > stub function in its BaseCpuLibNull library > instance to avoid potential link issue. >=20 Missing Cc for MdePkg maintainers. > Signed-off-by: Qing Huang > --- > MdePkg/Library/BaseCpuLibNull/BaseCpuLibNull.c | 17 ++++++++++++++++- > 1 file changed, 16 insertions(+), 1 deletion(-) >=20 > diff --git a/MdePkg/Library/BaseCpuLibNull/BaseCpuLibNull.c > b/MdePkg/Library/BaseCpuLibNull/BaseCpuLibNull.c > index 3ba7a35096..ba7981551d 100644 > --- a/MdePkg/Library/BaseCpuLibNull/BaseCpuLibNull.c > +++ b/MdePkg/Library/BaseCpuLibNull/BaseCpuLibNull.c > @@ -1,7 +1,7 @@ > /** @file > Null instance of CPU Library. >=20 > - Copyright (c) 2020, Intel Corporation. All rights reserved.
> + Copyright (c) 2020 - 2024, Intel Corporation. All rights > reserved.
Updating end year not required for Intel copyright statements. > SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > **/ > @@ -35,3 +35,18 @@ CpuFlushTlb ( > ) > { > } > + > +/** > + Determine if the standard CPU signature is "AuthenticAMD". > + > + @retval TRUE The CPU signature matches. > + @retval FALSE The CPU signature does not match. > +**/ > +BOOLEAN > +EFIAPI > +StandardSignatureIsAuthenticAMD ( > + VOID > + ) > +{ > + return FALSE; > +} > -- > 2.42.0.windows.2 >=20 >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114226): https://edk2.groups.io/g/devel/message/114226 Mute This Topic: https://groups.io/mt/103907626/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-