Re: [edk2-devel] [PATCH v3 2/8] FatPkg/FatPei: Remove extraneous debug message argument

["Michael D Kinney" <michael.d.kinney@intel.com>]

Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>

Mike

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Michael Kubacki
> Sent: Thursday, September 8, 2022 9:28 AM
> To: Ni, Ray <ray.ni@intel.com>; devel@edk2.groups.io
> Subject: Re: [edk2-devel] [PATCH v3 2/8] FatPkg/FatPei: Remove extraneous debug message argument
> 
> Still need this review.
> 
> Patch has been on list for over a month and changes one line of code.
> 
> On 9/6/2022 11:05 PM, Michael Kubacki wrote:
> > Hello Ray,
> >
> > Can you please review this patch?
> >
> > FatPkg is the only package missing a review on the series.
> >
> > Thanks,
> > Michael
> >
> > On 9/2/2022 6:22 PM, Michael Kubacki wrote:
> >> From: Michael Kubacki <michael.kubacki@microsoft.com>
> >>
> >> This debug macro should take one argument based on the number of
> >> print specifiers defined. However, two arguments are given.
> >>
> >> It looks like the code may have been refactored such that the
> >> second argument was moved to a new print and this argument was
> >> not removed. In any case, it should not be there now.
> >>
> >> Cc: Ray Ni <ray.ni@intel.com>
> >> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> >> ---
> >>   FatPkg/FatPei/Gpt.c | 2 +-
> >>   1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/FatPkg/FatPei/Gpt.c b/FatPkg/FatPei/Gpt.c
> >> index 0a1a25ceeff1..9e17ce88086f 100644
> >> --- a/FatPkg/FatPei/Gpt.c
> >> +++ b/FatPkg/FatPei/Gpt.c
> >> @@ -361,7 +361,7 @@ PartitionCheckGptEntryArray (
> >>       PrivateData->BlockDeviceCount++;
> >> -    DEBUG ((DEBUG_INFO, "Find GPT Partition [0x%lx",
> >> PartitionEntryBuffer[Index].StartingLBA, BlockDevPtr->LastBlock));
> >> +    DEBUG ((DEBUG_INFO, "Find GPT Partition [0x%lx",
> >> PartitionEntryBuffer[Index].StartingLBA));
> >>       DEBUG ((DEBUG_INFO, ", 0x%lx]\n", BlockDevPtr->LastBlock));
> >>       DEBUG ((DEBUG_INFO, "         BlockSize %x\n",
> >> BlockDevPtr->BlockSize));
> >>     }
> >
> >
> >
> >
> 
> 
> 
>