* Re: [edk2-devel] [PATCH 1/1] BaseTools/tools_def: drop -mgeneral-regs-only for AArch64 CLANGDWARF [not found] <17942B788A4667A6.3650@groups.io> @ 2023-11-07 13:11 ` Yeping Song 2023-11-07 13:12 ` Leif Lindholm 0 siblings, 1 reply; 5+ messages in thread From: Yeping Song @ 2023-11-07 13:11 UTC (permalink / raw) To: devel@edk2.groups.io, Yeping Song (QUIC), Liming Gao, Leif Lindholm (QUIC) Cc: Rebecca Cran, Liming Gao, Bob Feng, Yuwei Chen, Ard Biesheuvel, Leif Lindholm (QUIC), Sami Mujawar, Kinney, Michael D Hi all, I would like for this to be include in stable tag. Please help to review and merge this patch into stable release. Thanks Yepings -----Original Message----- From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Yeping Song Sent: Saturday, November 4, 2023 12:38 AM To: devel@edk2.groups.io Cc: Yeping Song (QUIC) <quic_yepings@quicinc.com>; Rebecca Cran <rebecca@bsdio.com>; Liming Gao <gaoliming@byosoft.com.cn>; Bob Feng <bob.c.feng@intel.com>; Yuwei Chen <yuwei.chen@intel.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>; Leif Lindholm (QUIC) <quic_llindhol@quicinc.com>; Sami Mujawar <sami.mujawar@arm.com> Subject: [edk2-devel] [PATCH 1/1] BaseTools/tools_def: drop -mgeneral-regs-only for AArch64 CLANGDWARF WARNING: This email originated from outside of Qualcomm. Please be wary of any links or attachments, and do not enable macros. Commit 0df6c8c157af9 ("BaseTools/tools_def AARCH64: avoid SIMD registers in XIP code") adds -mgeneral-regs-only to GCC_AARCH64_CC_XIPFLAGS, in order to avoid a bug present in certain versions of GCC. This was never a problem for clang. That's given the history of what the problem is. Then we can describe how we fix it: Change *_CLANGDWARF_AARCH64_CC_XIPFLAGS to set the required -mstrict-align option instead of importing the whole GCC variable. Signed-off-by: Yeping Song <quic_yepings@quicinc.com> Cc: Rebecca Cran <rebecca@bsdio.com> Cc: Liming Gao <gaoliming@byosoft.com.cn> Cc: Bob Feng <bob.c.feng@intel.com> Cc: Yuwei Chen <yuwei.chen@intel.com> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org> Cc: Leif Lindholm <quic_llindhol@quicinc.com> Cc: Sami Mujawar <sami.mujawar@arm.com> --- BaseTools/Conf/tools_def.template | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template index 5bd5283655ea..c34ecfd557c5 100755 --- a/BaseTools/Conf/tools_def.template +++ b/BaseTools/Conf/tools_def.template @@ -2015,7 +2015,7 @@ DEFINE CLANGDWARF_AARCH64_DLINK_FLAGS = DEF(CLANGDWARF_AARCH64_TARGET) DEF(GCC_ *_CLANGDWARF_AARCH64_RC_FLAGS = DEF(GCC_AARCH64_RC_FLAGS) DEF(GCC_AARCH64_RC_BTI_FLAGS) *_CLANGDWARF_AARCH64_VFRPP_FLAGS = DEF(GCC_VFRPP_FLAGS) DEF(CLANGDWARF_AARCH64_TARGET) $(PLATFORM_FLAGS) *_CLANGDWARF_AARCH64_ASLPP_FLAGS = DEF(GCC_ASLPP_FLAGS) DEF(CLANGDWARF_AARCH64_TARGET) -*_CLANGDWARF_AARCH64_CC_XIPFLAGS = DEF(GCC_AARCH64_CC_XIPFLAGS) +*_CLANGDWARF_AARCH64_CC_XIPFLAGS = -mstrict-align DEBUG_CLANGDWARF_AARCH64_CC_FLAGS = DEF(CLANGDWARF_AARCH64_CC_FLAGS) $(PLATFORM_FLAGS) -flto -O1 DEBUG_CLANGDWARF_AARCH64_DLINK_FLAGS = DEF(CLANGDWARF_AARCH64_DLINK_FLAGS) -flto -Wl,-O1 -fuse-ld=lld -L$(WORKSPACE)/ArmPkg/Library/GccLto -llto-aarch64 -Wl,-plugin-opt=-pass-through=-llto-aarch64 -Wl,--no-pie,--no-relax -- 2.25.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110851): https://edk2.groups.io/g/devel/message/110851 Mute This Topic: https://groups.io/mt/102368361/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [edk2-devel] [PATCH 1/1] BaseTools/tools_def: drop -mgeneral-regs-only for AArch64 CLANGDWARF 2023-11-07 13:11 ` [edk2-devel] [PATCH 1/1] BaseTools/tools_def: drop -mgeneral-regs-only for AArch64 CLANGDWARF Yeping Song @ 2023-11-07 13:12 ` Leif Lindholm 2023-11-09 13:42 ` 回复: " gaoliming via groups.io 0 siblings, 1 reply; 5+ messages in thread From: Leif Lindholm @ 2023-11-07 13:12 UTC (permalink / raw) To: Yeping Song (QUIC), devel@edk2.groups.io, Liming Gao Cc: Rebecca Cran, Bob Feng, Yuwei Chen, Ard Biesheuvel, Sami Mujawar, Kinney, Michael D Liming, You reviewed this patch before the stable tag. Am I OK to stage a github PR for this change? Reviewed-by: Leif Lindholm <quic_llindhol@quicinc.com> Regards, Leif On 2023-11-07 13:11, Yeping Song (QUIC) wrote: > Hi all, > I would like for this to be include in stable tag. Please help to review and merge this patch into stable release. > Thanks > Yepings > > > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Yeping Song > Sent: Saturday, November 4, 2023 12:38 AM > To: devel@edk2.groups.io > Cc: Yeping Song (QUIC) <quic_yepings@quicinc.com>; Rebecca Cran <rebecca@bsdio.com>; Liming Gao <gaoliming@byosoft.com.cn>; Bob Feng <bob.c.feng@intel.com>; Yuwei Chen <yuwei.chen@intel.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>; Leif Lindholm (QUIC) <quic_llindhol@quicinc.com>; Sami Mujawar <sami.mujawar@arm.com> > Subject: [edk2-devel] [PATCH 1/1] BaseTools/tools_def: drop -mgeneral-regs-only for AArch64 CLANGDWARF > > WARNING: This email originated from outside of Qualcomm. Please be wary of any links or attachments, and do not enable macros. > > Commit 0df6c8c157af9 ("BaseTools/tools_def AARCH64: > avoid SIMD registers in XIP code") > adds -mgeneral-regs-only to GCC_AARCH64_CC_XIPFLAGS, in order to avoid a bug present in certain versions of GCC. > This was never a problem for clang. > That's given the history of what the problem is. > Then we can describe how we fix it: > Change *_CLANGDWARF_AARCH64_CC_XIPFLAGS to set the required -mstrict-align option instead of importing the whole GCC variable. > > Signed-off-by: Yeping Song <quic_yepings@quicinc.com> > Cc: Rebecca Cran <rebecca@bsdio.com> > Cc: Liming Gao <gaoliming@byosoft.com.cn> > Cc: Bob Feng <bob.c.feng@intel.com> > Cc: Yuwei Chen <yuwei.chen@intel.com> > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org> > Cc: Leif Lindholm <quic_llindhol@quicinc.com> > Cc: Sami Mujawar <sami.mujawar@arm.com> > --- > BaseTools/Conf/tools_def.template | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template > index 5bd5283655ea..c34ecfd557c5 100755 > --- a/BaseTools/Conf/tools_def.template > +++ b/BaseTools/Conf/tools_def.template > @@ -2015,7 +2015,7 @@ DEFINE CLANGDWARF_AARCH64_DLINK_FLAGS = DEF(CLANGDWARF_AARCH64_TARGET) DEF(GCC_ > *_CLANGDWARF_AARCH64_RC_FLAGS = DEF(GCC_AARCH64_RC_FLAGS) DEF(GCC_AARCH64_RC_BTI_FLAGS) > *_CLANGDWARF_AARCH64_VFRPP_FLAGS = DEF(GCC_VFRPP_FLAGS) DEF(CLANGDWARF_AARCH64_TARGET) $(PLATFORM_FLAGS) > *_CLANGDWARF_AARCH64_ASLPP_FLAGS = DEF(GCC_ASLPP_FLAGS) DEF(CLANGDWARF_AARCH64_TARGET) > -*_CLANGDWARF_AARCH64_CC_XIPFLAGS = DEF(GCC_AARCH64_CC_XIPFLAGS) > +*_CLANGDWARF_AARCH64_CC_XIPFLAGS = -mstrict-align > > DEBUG_CLANGDWARF_AARCH64_CC_FLAGS = DEF(CLANGDWARF_AARCH64_CC_FLAGS) $(PLATFORM_FLAGS) -flto -O1 > DEBUG_CLANGDWARF_AARCH64_DLINK_FLAGS = DEF(CLANGDWARF_AARCH64_DLINK_FLAGS) -flto -Wl,-O1 -fuse-ld=lld -L$(WORKSPACE)/ArmPkg/Library/GccLto -llto-aarch64 -Wl,-plugin-opt=-pass-through=-llto-aarch64 -Wl,--no-pie,--no-relax > -- > 2.25.1 > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110852): https://edk2.groups.io/g/devel/message/110852 Mute This Topic: https://groups.io/mt/102368361/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply [flat|nested] 5+ messages in thread
* 回复: [edk2-devel] [PATCH 1/1] BaseTools/tools_def: drop -mgeneral-regs-only for AArch64 CLANGDWARF 2023-11-07 13:12 ` Leif Lindholm @ 2023-11-09 13:42 ` gaoliming via groups.io 2023-11-09 14:39 ` Leif Lindholm 0 siblings, 1 reply; 5+ messages in thread From: gaoliming via groups.io @ 2023-11-09 13:42 UTC (permalink / raw) To: devel, quic_llindhol, 'Yeping Song (QUIC)' Cc: 'Rebecca Cran', 'Bob Feng', 'Yuwei Chen', 'Ard Biesheuvel', 'Sami Mujawar', 'Kinney, Michael D' Leif: Sure. This patch can be merged for this stable tag. Thanks Liming > -----邮件原件----- > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Leif Lindholm > 发送时间: 2023年11月7日 21:13 > 收件人: Yeping Song (QUIC) <quic_yepings@quicinc.com>; > devel@edk2.groups.io; Liming Gao <gaoliming@byosoft.com.cn> > 抄送: Rebecca Cran <rebecca@bsdio.com>; Bob Feng > <bob.c.feng@intel.com>; Yuwei Chen <yuwei.chen@intel.com>; Ard > Biesheuvel <ardb+tianocore@kernel.org>; Sami Mujawar > <sami.mujawar@arm.com>; Kinney, Michael D <michael.d.kinney@intel.com> > 主题: Re: [edk2-devel] [PATCH 1/1] BaseTools/tools_def: drop > -mgeneral-regs-only for AArch64 CLANGDWARF > > Liming, > > You reviewed this patch before the stable tag. Am I OK to stage a github > PR for this change? > > Reviewed-by: Leif Lindholm <quic_llindhol@quicinc.com> > > Regards, > > Leif > > On 2023-11-07 13:11, Yeping Song (QUIC) wrote: > > Hi all, > > I would like for this to be include in stable tag. Please help to review and > merge this patch into stable release. > > Thanks > > Yepings > > > > > > -----Original Message----- > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Yeping > Song > > Sent: Saturday, November 4, 2023 12:38 AM > > To: devel@edk2.groups.io > > Cc: Yeping Song (QUIC) <quic_yepings@quicinc.com>; Rebecca Cran > <rebecca@bsdio.com>; Liming Gao <gaoliming@byosoft.com.cn>; Bob Feng > <bob.c.feng@intel.com>; Yuwei Chen <yuwei.chen@intel.com>; Ard > Biesheuvel <ardb+tianocore@kernel.org>; Leif Lindholm (QUIC) > <quic_llindhol@quicinc.com>; Sami Mujawar <sami.mujawar@arm.com> > > Subject: [edk2-devel] [PATCH 1/1] BaseTools/tools_def: drop > -mgeneral-regs-only for AArch64 CLANGDWARF > > > > WARNING: This email originated from outside of Qualcomm. Please be wary > of any links or attachments, and do not enable macros. > > > > Commit 0df6c8c157af9 ("BaseTools/tools_def AARCH64: > > avoid SIMD registers in XIP code") > > adds -mgeneral-regs-only to GCC_AARCH64_CC_XIPFLAGS, in order to avoid > a bug present in certain versions of GCC. > > This was never a problem for clang. > > That's given the history of what the problem is. > > Then we can describe how we fix it: > > Change *_CLANGDWARF_AARCH64_CC_XIPFLAGS to set the required > -mstrict-align option instead of importing the whole GCC variable. > > > > Signed-off-by: Yeping Song <quic_yepings@quicinc.com> > > Cc: Rebecca Cran <rebecca@bsdio.com> > > Cc: Liming Gao <gaoliming@byosoft.com.cn> > > Cc: Bob Feng <bob.c.feng@intel.com> > > Cc: Yuwei Chen <yuwei.chen@intel.com> > > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org> > > Cc: Leif Lindholm <quic_llindhol@quicinc.com> > > Cc: Sami Mujawar <sami.mujawar@arm.com> > > --- > > BaseTools/Conf/tools_def.template | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/BaseTools/Conf/tools_def.template > b/BaseTools/Conf/tools_def.template > > index 5bd5283655ea..c34ecfd557c5 100755 > > --- a/BaseTools/Conf/tools_def.template > > +++ b/BaseTools/Conf/tools_def.template > > @@ -2015,7 +2015,7 @@ DEFINE CLANGDWARF_AARCH64_DLINK_FLAGS > = DEF(CLANGDWARF_AARCH64_TARGET) DEF(GCC_ > > *_CLANGDWARF_AARCH64_RC_FLAGS = > DEF(GCC_AARCH64_RC_FLAGS) DEF(GCC_AARCH64_RC_BTI_FLAGS) > > *_CLANGDWARF_AARCH64_VFRPP_FLAGS = > DEF(GCC_VFRPP_FLAGS) DEF(CLANGDWARF_AARCH64_TARGET) > $(PLATFORM_FLAGS) > > *_CLANGDWARF_AARCH64_ASLPP_FLAGS = > DEF(GCC_ASLPP_FLAGS) DEF(CLANGDWARF_AARCH64_TARGET) > > -*_CLANGDWARF_AARCH64_CC_XIPFLAGS = > DEF(GCC_AARCH64_CC_XIPFLAGS) > > +*_CLANGDWARF_AARCH64_CC_XIPFLAGS = -mstrict-align > > > > DEBUG_CLANGDWARF_AARCH64_CC_FLAGS = > DEF(CLANGDWARF_AARCH64_CC_FLAGS) $(PLATFORM_FLAGS) -flto -O1 > > DEBUG_CLANGDWARF_AARCH64_DLINK_FLAGS = > DEF(CLANGDWARF_AARCH64_DLINK_FLAGS) -flto -Wl,-O1 -fuse-ld=lld > -L$(WORKSPACE)/ArmPkg/Library/GccLto -llto-aarch64 > -Wl,-plugin-opt=-pass-through=-llto-aarch64 -Wl,--no-pie,--no-relax > > -- > > 2.25.1 > > > > > > > > > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110978): https://edk2.groups.io/g/devel/message/110978 Mute This Topic: https://groups.io/mt/102485456/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: 回复: [edk2-devel] [PATCH 1/1] BaseTools/tools_def: drop -mgeneral-regs-only for AArch64 CLANGDWARF 2023-11-09 13:42 ` 回复: " gaoliming via groups.io @ 2023-11-09 14:39 ` Leif Lindholm 2023-11-09 19:17 ` Michael D Kinney 0 siblings, 1 reply; 5+ messages in thread From: Leif Lindholm @ 2023-11-09 14:39 UTC (permalink / raw) To: devel, gaoliming Cc: 'Yeping Song (QUIC)', 'Rebecca Cran', 'Bob Feng', 'Yuwei Chen', 'Ard Biesheuvel', 'Sami Mujawar', 'Kinney, Michael D' Thanks! https://github.com/tianocore/edk2/pull/5023 raised. / Leif On Thu, Nov 09, 2023 at 21:42:38 +0800, gaoliming via groups.io wrote: > Leif: > Sure. This patch can be merged for this stable tag. > > Thanks > Liming > > -----邮件原件----- > > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Leif Lindholm > > 发送时间: 2023年11月7日 21:13 > > 收件人: Yeping Song (QUIC) <quic_yepings@quicinc.com>; > > devel@edk2.groups.io; Liming Gao <gaoliming@byosoft.com.cn> > > 抄送: Rebecca Cran <rebecca@bsdio.com>; Bob Feng > > <bob.c.feng@intel.com>; Yuwei Chen <yuwei.chen@intel.com>; Ard > > Biesheuvel <ardb+tianocore@kernel.org>; Sami Mujawar > > <sami.mujawar@arm.com>; Kinney, Michael D <michael.d.kinney@intel.com> > > 主题: Re: [edk2-devel] [PATCH 1/1] BaseTools/tools_def: drop > > -mgeneral-regs-only for AArch64 CLANGDWARF > > > > Liming, > > > > You reviewed this patch before the stable tag. Am I OK to stage a github > > PR for this change? > > > > Reviewed-by: Leif Lindholm <quic_llindhol@quicinc.com> > > > > Regards, > > > > Leif > > > > On 2023-11-07 13:11, Yeping Song (QUIC) wrote: > > > Hi all, > > > I would like for this to be include in stable tag. Please help to review and > > merge this patch into stable release. > > > Thanks > > > Yepings > > > > > > > > > -----Original Message----- > > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Yeping > > Song > > > Sent: Saturday, November 4, 2023 12:38 AM > > > To: devel@edk2.groups.io > > > Cc: Yeping Song (QUIC) <quic_yepings@quicinc.com>; Rebecca Cran > > <rebecca@bsdio.com>; Liming Gao <gaoliming@byosoft.com.cn>; Bob Feng > > <bob.c.feng@intel.com>; Yuwei Chen <yuwei.chen@intel.com>; Ard > > Biesheuvel <ardb+tianocore@kernel.org>; Leif Lindholm (QUIC) > > <quic_llindhol@quicinc.com>; Sami Mujawar <sami.mujawar@arm.com> > > > Subject: [edk2-devel] [PATCH 1/1] BaseTools/tools_def: drop > > -mgeneral-regs-only for AArch64 CLANGDWARF > > > > > > WARNING: This email originated from outside of Qualcomm. Please be wary > > of any links or attachments, and do not enable macros. > > > > > > Commit 0df6c8c157af9 ("BaseTools/tools_def AARCH64: > > > avoid SIMD registers in XIP code") > > > adds -mgeneral-regs-only to GCC_AARCH64_CC_XIPFLAGS, in order to avoid > > a bug present in certain versions of GCC. > > > This was never a problem for clang. > > > That's given the history of what the problem is. > > > Then we can describe how we fix it: > > > Change *_CLANGDWARF_AARCH64_CC_XIPFLAGS to set the required > > -mstrict-align option instead of importing the whole GCC variable. > > > > > > Signed-off-by: Yeping Song <quic_yepings@quicinc.com> > > > Cc: Rebecca Cran <rebecca@bsdio.com> > > > Cc: Liming Gao <gaoliming@byosoft.com.cn> > > > Cc: Bob Feng <bob.c.feng@intel.com> > > > Cc: Yuwei Chen <yuwei.chen@intel.com> > > > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org> > > > Cc: Leif Lindholm <quic_llindhol@quicinc.com> > > > Cc: Sami Mujawar <sami.mujawar@arm.com> > > > --- > > > BaseTools/Conf/tools_def.template | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/BaseTools/Conf/tools_def.template > > b/BaseTools/Conf/tools_def.template > > > index 5bd5283655ea..c34ecfd557c5 100755 > > > --- a/BaseTools/Conf/tools_def.template > > > +++ b/BaseTools/Conf/tools_def.template > > > @@ -2015,7 +2015,7 @@ DEFINE CLANGDWARF_AARCH64_DLINK_FLAGS > > = DEF(CLANGDWARF_AARCH64_TARGET) DEF(GCC_ > > > *_CLANGDWARF_AARCH64_RC_FLAGS = > > DEF(GCC_AARCH64_RC_FLAGS) DEF(GCC_AARCH64_RC_BTI_FLAGS) > > > *_CLANGDWARF_AARCH64_VFRPP_FLAGS = > > DEF(GCC_VFRPP_FLAGS) DEF(CLANGDWARF_AARCH64_TARGET) > > $(PLATFORM_FLAGS) > > > *_CLANGDWARF_AARCH64_ASLPP_FLAGS = > > DEF(GCC_ASLPP_FLAGS) DEF(CLANGDWARF_AARCH64_TARGET) > > > -*_CLANGDWARF_AARCH64_CC_XIPFLAGS = > > DEF(GCC_AARCH64_CC_XIPFLAGS) > > > +*_CLANGDWARF_AARCH64_CC_XIPFLAGS = -mstrict-align > > > > > > DEBUG_CLANGDWARF_AARCH64_CC_FLAGS = > > DEF(CLANGDWARF_AARCH64_CC_FLAGS) $(PLATFORM_FLAGS) -flto -O1 > > > DEBUG_CLANGDWARF_AARCH64_DLINK_FLAGS = > > DEF(CLANGDWARF_AARCH64_DLINK_FLAGS) -flto -Wl,-O1 -fuse-ld=lld > > -L$(WORKSPACE)/ArmPkg/Library/GccLto -llto-aarch64 > > -Wl,-plugin-opt=-pass-through=-llto-aarch64 -Wl,--no-pie,--no-relax > > > -- > > > 2.25.1 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110987): https://edk2.groups.io/g/devel/message/110987 Mute This Topic: https://groups.io/mt/102485456/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: 回复: [edk2-devel] [PATCH 1/1] BaseTools/tools_def: drop -mgeneral-regs-only for AArch64 CLANGDWARF 2023-11-09 14:39 ` Leif Lindholm @ 2023-11-09 19:17 ` Michael D Kinney 0 siblings, 0 replies; 5+ messages in thread From: Michael D Kinney @ 2023-11-09 19:17 UTC (permalink / raw) To: Leif Lindholm, devel@edk2.groups.io, Gao, Liming Cc: 'Yeping Song (QUIC)', 'Rebecca Cran', Feng, Bob C, Chen, Christine, 'Ard Biesheuvel', 'Sami Mujawar', Kinney, Michael D Merged: https://github.com/tianocore/edk2/pull/5023 https://github.com/tianocore/edk2/commit/e077ccff6d0f2e8c3fc44b3e2ab71aff66927c3b Mike > -----Original Message----- > From: Leif Lindholm <quic_llindhol@quicinc.com> > Sent: Thursday, November 9, 2023 6:39 AM > To: devel@edk2.groups.io; Gao, Liming <gaoliming@byosoft.com.cn> > Cc: 'Yeping Song (QUIC)' <quic_yepings@quicinc.com>; 'Rebecca Cran' > <rebecca@bsdio.com>; Feng, Bob C <bob.c.feng@intel.com>; Chen, > Christine <yuwei.chen@intel.com>; 'Ard Biesheuvel' > <ardb+tianocore@kernel.org>; 'Sami Mujawar' <sami.mujawar@arm.com>; > Kinney, Michael D <michael.d.kinney@intel.com> > Subject: Re: 回复: [edk2-devel] [PATCH 1/1] BaseTools/tools_def: drop - > mgeneral-regs-only for AArch64 CLANGDWARF > > Thanks! > > https://github.com/tianocore/edk2/pull/5023 raised. > > / > Leif > > On Thu, Nov 09, 2023 at 21:42:38 +0800, gaoliming via groups.io wrote: > > Leif: > > Sure. This patch can be merged for this stable tag. > > > > Thanks > > Liming > > > -----邮件原件----- > > > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Leif > Lindholm > > > 发送时间: 2023年11月7日 21:13 > > > 收件人: Yeping Song (QUIC) <quic_yepings@quicinc.com>; > > > devel@edk2.groups.io; Liming Gao <gaoliming@byosoft.com.cn> > > > 抄送: Rebecca Cran <rebecca@bsdio.com>; Bob Feng > > > <bob.c.feng@intel.com>; Yuwei Chen <yuwei.chen@intel.com>; Ard > > > Biesheuvel <ardb+tianocore@kernel.org>; Sami Mujawar > > > <sami.mujawar@arm.com>; Kinney, Michael D > <michael.d.kinney@intel.com> > > > 主题: Re: [edk2-devel] [PATCH 1/1] BaseTools/tools_def: drop > > > -mgeneral-regs-only for AArch64 CLANGDWARF > > > > > > Liming, > > > > > > You reviewed this patch before the stable tag. Am I OK to stage a > github > > > PR for this change? > > > > > > Reviewed-by: Leif Lindholm <quic_llindhol@quicinc.com> > > > > > > Regards, > > > > > > Leif > > > > > > On 2023-11-07 13:11, Yeping Song (QUIC) wrote: > > > > Hi all, > > > > I would like for this to be include in stable tag. Please help > to review and > > > merge this patch into stable release. > > > > Thanks > > > > Yepings > > > > > > > > > > > > -----Original Message----- > > > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of > Yeping > > > Song > > > > Sent: Saturday, November 4, 2023 12:38 AM > > > > To: devel@edk2.groups.io > > > > Cc: Yeping Song (QUIC) <quic_yepings@quicinc.com>; Rebecca Cran > > > <rebecca@bsdio.com>; Liming Gao <gaoliming@byosoft.com.cn>; Bob > Feng > > > <bob.c.feng@intel.com>; Yuwei Chen <yuwei.chen@intel.com>; Ard > > > Biesheuvel <ardb+tianocore@kernel.org>; Leif Lindholm (QUIC) > > > <quic_llindhol@quicinc.com>; Sami Mujawar <sami.mujawar@arm.com> > > > > Subject: [edk2-devel] [PATCH 1/1] BaseTools/tools_def: drop > > > -mgeneral-regs-only for AArch64 CLANGDWARF > > > > > > > > WARNING: This email originated from outside of Qualcomm. Please > be wary > > > of any links or attachments, and do not enable macros. > > > > > > > > Commit 0df6c8c157af9 ("BaseTools/tools_def AARCH64: > > > > avoid SIMD registers in XIP code") > > > > adds -mgeneral-regs-only to GCC_AARCH64_CC_XIPFLAGS, in order to > avoid > > > a bug present in certain versions of GCC. > > > > This was never a problem for clang. > > > > That's given the history of what the problem is. > > > > Then we can describe how we fix it: > > > > Change *_CLANGDWARF_AARCH64_CC_XIPFLAGS to set the required > > > -mstrict-align option instead of importing the whole GCC variable. > > > > > > > > Signed-off-by: Yeping Song <quic_yepings@quicinc.com> > > > > Cc: Rebecca Cran <rebecca@bsdio.com> > > > > Cc: Liming Gao <gaoliming@byosoft.com.cn> > > > > Cc: Bob Feng <bob.c.feng@intel.com> > > > > Cc: Yuwei Chen <yuwei.chen@intel.com> > > > > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org> > > > > Cc: Leif Lindholm <quic_llindhol@quicinc.com> > > > > Cc: Sami Mujawar <sami.mujawar@arm.com> > > > > --- > > > > BaseTools/Conf/tools_def.template | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/BaseTools/Conf/tools_def.template > > > b/BaseTools/Conf/tools_def.template > > > > index 5bd5283655ea..c34ecfd557c5 100755 > > > > --- a/BaseTools/Conf/tools_def.template > > > > +++ b/BaseTools/Conf/tools_def.template > > > > @@ -2015,7 +2015,7 @@ DEFINE CLANGDWARF_AARCH64_DLINK_FLAGS > > > = DEF(CLANGDWARF_AARCH64_TARGET) DEF(GCC_ > > > > *_CLANGDWARF_AARCH64_RC_FLAGS = > > > DEF(GCC_AARCH64_RC_FLAGS) DEF(GCC_AARCH64_RC_BTI_FLAGS) > > > > *_CLANGDWARF_AARCH64_VFRPP_FLAGS = > > > DEF(GCC_VFRPP_FLAGS) DEF(CLANGDWARF_AARCH64_TARGET) > > > $(PLATFORM_FLAGS) > > > > *_CLANGDWARF_AARCH64_ASLPP_FLAGS = > > > DEF(GCC_ASLPP_FLAGS) DEF(CLANGDWARF_AARCH64_TARGET) > > > > -*_CLANGDWARF_AARCH64_CC_XIPFLAGS = > > > DEF(GCC_AARCH64_CC_XIPFLAGS) > > > > +*_CLANGDWARF_AARCH64_CC_XIPFLAGS = -mstrict-align > > > > > > > > DEBUG_CLANGDWARF_AARCH64_CC_FLAGS = > > > DEF(CLANGDWARF_AARCH64_CC_FLAGS) $(PLATFORM_FLAGS) -flto -O1 > > > > DEBUG_CLANGDWARF_AARCH64_DLINK_FLAGS = > > > DEF(CLANGDWARF_AARCH64_DLINK_FLAGS) -flto -Wl,-O1 -fuse-ld=lld > > > -L$(WORKSPACE)/ArmPkg/Library/GccLto -llto-aarch64 > > > -Wl,-plugin-opt=-pass-through=-llto-aarch64 -Wl,--no-pie,--no- > relax > > > > -- > > > > 2.25.1 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110996): https://edk2.groups.io/g/devel/message/110996 Mute This Topic: https://groups.io/mt/102485456/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-11-09 19:18 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <17942B788A4667A6.3650@groups.io>
2023-11-07 13:11 ` [edk2-devel] [PATCH 1/1] BaseTools/tools_def: drop -mgeneral-regs-only for AArch64 CLANGDWARF Yeping Song
2023-11-07 13:12 ` Leif Lindholm
2023-11-09 13:42 ` 回复: " gaoliming via groups.io
2023-11-09 14:39 ` Leif Lindholm
2023-11-09 19:17 ` Michael D Kinney
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox