From: "Michael D Kinney" <michael.d.kinney@intel.com>
To: "Bi, Dandan" <dandan.bi@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>,
"Kinney, Michael D" <michael.d.kinney@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>,
Bret Barkelew <Bret.Barkelew@microsoft.com>
Subject: Re: [patch V3 27/29] UnitTestFrameworkPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib
Date: Fri, 26 Mar 2021 16:35:22 +0000 [thread overview]
Message-ID: <CO1PR11MB49293DFDD043D400B7BD2AE2D2619@CO1PR11MB4929.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210326072346.4212-28-dandan.bi@intel.com>
Dandan,
I am not sure if one dsc.inc file should include another dsc.inc file.
If a package/platform DSC file has a dependency on other packages to build,
then that DSC file can include the dsc.inc files from those dependent packages.
This limits the dsc.inc include depth is 1. Nesting includes of dsc.inc files
increases complexity.
Thanks,
Mike
> -----Original Message-----
> From: Bi, Dandan <dandan.bi@intel.com>
> Sent: Friday, March 26, 2021 12:24 AM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew
> <Bret.Barkelew@microsoft.com>
> Subject: [patch V3 27/29] UnitTestFrameworkPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
>
> MdeLibs.dsc.inc was added for some basic/default library
> instances provided by MdePkg and RegisterFilterLibNull Library
> was also added into it as the first version of MdeLibs.dsc.inc.
>
> So update platform dsc to consume MdeLibs.dsc.inc for
> RegisterFilterLibNull which will be consumed by IoLib and BaseLib.
>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
> UnitTestFrameworkPkg/UnitTestFrameworkPkgTarget.dsc.inc | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/UnitTestFrameworkPkg/UnitTestFrameworkPkgTarget.dsc.inc
> b/UnitTestFrameworkPkg/UnitTestFrameworkPkgTarget.dsc.inc
> index 8adf690098..68ad37e989 100644
> --- a/UnitTestFrameworkPkg/UnitTestFrameworkPkgTarget.dsc.inc
> +++ b/UnitTestFrameworkPkg/UnitTestFrameworkPkgTarget.dsc.inc
> @@ -1,13 +1,15 @@
> ## @file
> # UnitTestFrameworkPkg DSC include file for target based test DSC
> #
> -# Copyright (c) 2019 - 2020, Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) 2019 - 2021, Intel Corporation. All rights reserved.<BR>
> # SPDX-License-Identifier: BSD-2-Clause-Patent
> #
> ##
>
> +!include MdePkg/MdeLibs.dsc.inc
> +
> [LibraryClasses]
> #
> # Entry point
> #
> PeimEntryPoint|MdePkg/Library/PeimEntryPoint/PeimEntryPoint.inf
> --
> 2.18.0.windows.1
next prev parent reply other threads:[~2021-03-26 16:35 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-26 7:23 [patch V3 00/29] Add a new library class RegisterFilterLib in edk2 to filter/trace port IO/MMIO/MSR access Dandan Bi
2021-03-26 7:23 ` [patch V3 01/29] MdePkg: Add RegisterFilterLib class and NULL instance Dandan Bi
2021-03-26 7:23 ` [patch V3 02/29] MdePkg: Add MdeLibs.dsc.inc file to MdePkg Dandan Bi
2021-03-26 7:23 ` [patch V3 03/29] ArmPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib Dandan Bi
2021-03-26 7:23 ` [patch V3 04/29] ArmPlatformPkg: " Dandan Bi
2021-03-26 7:23 ` [patch V3 05/29] ArmVirtPkg: " Dandan Bi
2021-03-26 7:23 ` [patch V3 06/29] CryptoPkg: " Dandan Bi
2021-03-26 7:23 ` [patch V3 07/29] DynamicTablesPkg: " Dandan Bi
2021-03-26 7:23 ` [patch V3 08/29] EmbeddedPkg: " Dandan Bi
2021-03-26 7:23 ` [patch V3 09/29] EmulatorPkg: " Dandan Bi
2021-03-26 7:23 ` [patch V3 10/29] FatPkg: " Dandan Bi
2021-03-26 7:23 ` [patch V3 11/29] FmpDevicePkg: " Dandan Bi
2021-03-26 7:23 ` [patch V3 12/29] IntelFsp2Pkg: " Dandan Bi
2021-03-26 7:23 ` [patch V3 13/29] IntelFsp2WrapperPkg: " Dandan Bi
2021-03-26 8:11 ` Chiu, Chasel
2021-03-26 7:23 ` [patch V3 14/29] MdeModulePkg: " Dandan Bi
2021-03-26 7:23 ` [patch V3 15/29] MdePkg: " Dandan Bi
2021-03-26 7:23 ` [patch V3 16/29] NetworkPkg: " Dandan Bi
2021-03-26 7:23 ` [patch V3 17/29] OvmfPkg: " Dandan Bi
2021-03-26 7:23 ` [patch V3 18/29] PcAtChipsetPkg: " Dandan Bi
2021-03-26 7:23 ` [patch V3 19/29] RedfishPkg: " Dandan Bi
2021-03-26 7:23 ` [patch V3 20/29] SecurityPkg: " Dandan Bi
2021-03-26 7:23 ` [patch V3 21/29] ShellPkg: " Dandan Bi
2021-03-26 7:23 ` [patch V3 22/29] SignedCapsulePkg: " Dandan Bi
2021-03-26 7:23 ` [patch V3 23/29] SourceLevelDebugPkg: " Dandan Bi
2021-03-26 7:23 ` [patch V3 24/29] StandaloneMmPkg: " Dandan Bi
2021-03-26 7:23 ` [patch V3 25/29] UefiCpuPkg: " Dandan Bi
2021-03-26 7:23 ` [patch V3 26/29] UefiPayloadPkg: " Dandan Bi
2021-03-26 14:39 ` Guo Dong
2021-03-26 7:23 ` [patch V3 27/29] UnitTestFrameworkPkg: " Dandan Bi
2021-03-26 16:35 ` Michael D Kinney [this message]
2021-03-26 7:23 ` [patch V3 28/29] MdePkg/IoLib: Filter/trace port IO/MMIO access Dandan Bi
2021-03-26 7:23 ` [patch V3 29/29] MdePkg/Baseib: Filter/trace MSR access for IA32/X64 Dandan Bi
2021-03-26 7:57 ` [patch V3 00/29] Add a new library class RegisterFilterLib in edk2 to filter/trace port IO/MMIO/MSR access Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO1PR11MB49293DFDD043D400B7BD2AE2D2619@CO1PR11MB4929.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox