Re: [PATCH v2 01/13] OvmfPkg: Replace static struct initialization with ZeroMem call

["Michael D Kinney" <michael.d.kinney@intel.com>]

Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>


> -----Original Message-----
> From: Yao, Jiewen <jiewen.yao@intel.com>
> Sent: Tuesday, March 28, 2023 3:40 PM
> To: Rebecca Cran <rebecca@bsdio.com>; devel@edk2.groups.io; Oliver Smith-Denny <osd@smith-denny.com>; Jiang, Guomin
> <guomin.jiang@intel.com>; Lu, Xiaoyu1 <xiaoyu1.lu@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; Ard Biesheuvel
> <ardb+tianocore@kernel.org>; Justen, Jordan L <jordan.l.justen@intel.com>; Gerd Hoffmann <kraxel@redhat.com>; Feng, Bob C
> <bob.c.feng@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Andrew Fish <afish@apple.com>; Leif Lindholm
> <quic_llindhol@quicinc.com>; Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: RE: [PATCH v2 01/13] OvmfPkg: Replace static struct initialization with ZeroMem call
> 
> Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>
> 
> > -----Original Message-----
> > From: Rebecca Cran <rebecca@bsdio.com>
> > Sent: Wednesday, March 29, 2023 1:31 AM
> > To: devel@edk2.groups.io; Oliver Smith-Denny <osd@smith-denny.com>;
> > Jiang, Guomin <guomin.jiang@intel.com>; Lu, Xiaoyu1
> > <xiaoyu1.lu@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; Yao, Jiewen
> > <jiewen.yao@intel.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>;
> > Justen, Jordan L <jordan.l.justen@intel.com>; Gerd Hoffmann
> > <kraxel@redhat.com>; Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming
> > <gaoliming@byosoft.com.cn>; Andrew Fish <afish@apple.com>; Leif
> > Lindholm <quic_llindhol@quicinc.com>; Kinney, Michael D
> > <michael.d.kinney@intel.com>
> > Cc: Rebecca Cran <rebecca@bsdio.com>
> > Subject: [PATCH v2 01/13] OvmfPkg: Replace static struct initialization with
> > ZeroMem call
> >
> > Replace the static struct initialization with a call to ZeroMem to avoid
> > generating a call to memset in certain build configurations.
> >
> > Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
> > Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
> > Reviewed-by: Oliver Smith-Denny <osd@smith-denny.com>
> > ---
> >  OvmfPkg/Library/PlatformInitLib/MemDetect.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/OvmfPkg/Library/PlatformInitLib/MemDetect.c
> > b/OvmfPkg/Library/PlatformInitLib/MemDetect.c
> > index 38cece9173e8..0bcdfb83721f 100644
> > --- a/OvmfPkg/Library/PlatformInitLib/MemDetect.c
> > +++ b/OvmfPkg/Library/PlatformInitLib/MemDetect.c
> > @@ -608,10 +608,12 @@ PlatformAddressWidthFromCpuid (
> >  {
> >    UINT32   RegEax, RegEbx, RegEcx, RegEdx, Max;
> >    UINT8    PhysBits;
> > -  CHAR8    Signature[13] = { 0 };
> > +  CHAR8    Signature[13];
> >    BOOLEAN  Valid         = FALSE;
> >    BOOLEAN  Page1GSupport = FALSE;
> >
> > +  ZeroMem (Signature, sizeof (Signature));
> > +
> >    AsmCpuid (0x80000000, &RegEax, &RegEbx, &RegEcx, &RegEdx);
> >    *(UINT32 *)(Signature + 0) = RegEbx;
> >    *(UINT32 *)(Signature + 4) = RegEdx;
> > --
> > 2.34.1