From: "Michael D Kinney" <michael.d.kinney@intel.com>
To: "Jayaprakash, N" <n.jayaprakash@intel.com>,
Rebecca Cran <rebecca@bsdio.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc: remove gitmodules file added through accidental commit
Date: Tue, 30 Jul 2024 17:23:14 +0000 [thread overview]
Message-ID: <CO1PR11MB4929425704B39D320D07EEDDD2B02@CO1PR11MB4929.namprd11.prod.outlook.com> (raw)
In-Reply-To: <PH7PR11MB5943B743F1DDCD067DD7120EEEB02@PH7PR11MB5943.namprd11.prod.outlook.com>
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
> -----Original Message-----
> From: Jayaprakash, N <n.jayaprakash@intel.com>
> Sent: Tuesday, July 30, 2024 10:03 AM
> To: Rebecca Cran <rebecca@bsdio.com>; devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: RE: [edk2-libc Patch 1/1] edk2-libc: remove gitmodules file added
> through accidental commit
>
> Thanks Rebecca for your quick response.
>
> Regards,
> JP
>
> -----Original Message-----
> From: Rebecca Cran <rebecca@bsdio.com>
> Sent: Tuesday, July 30, 2024 10:03 PM
> To: Jayaprakash, N <n.jayaprakash@intel.com>; devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: Re: [edk2-libc Patch 1/1] edk2-libc: remove gitmodules file added
> through accidental commit
>
> Reviewed-by: Rebecca Cran <rebecca@bsdio.com>
>
>
> On 7/30/24 10:17 AM, Jayaprakash N wrote:
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4822
> >
> > Due to an accidental commit went into edk2-libc while experimenting
> > with some inner-source repos lead to the addition of gitmodules file
> > and a submodule. This commit is undoing this change by removing the
> > gitmodules file and the submodule.
> >
> > Cc: Rebecca Cran <rebecca@bsdio.com>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Jayaprakash N <n.jayaprakash@intel.com>
> > Signed-off-by: Jayaprakash N <n.jayaprakash@intel.com>
> > ---
> > .gitmodules | 3 ---
> > AppPkg/CommonCode/SetupFiles | 1 -
> > 2 files changed, 4 deletions(-)
> > delete mode 100644 .gitmodules
> > delete mode 160000 AppPkg/CommonCode/SetupFiles
> >
> > diff --git a/.gitmodules b/.gitmodules deleted file mode 100644 index
> > 04db1ef..0000000
> > --- a/.gitmodules
> > +++ /dev/null
> > @@ -1,3 +0,0 @@
> > -[submodule "AppPkg/CommonCode/SetupFiles"]
> > - path = AppPkg/CommonCode/SetupFiles
> > - url = https://github.com/intel-
> innersource/applications.validation.advancedsystemtools.products.setup-
> files.git
> > diff --git a/AppPkg/CommonCode/SetupFiles
> > b/AppPkg/CommonCode/SetupFiles deleted file mode 160000 index
> > 8fa0030..0000000
> > --- a/AppPkg/CommonCode/SetupFiles
> > +++ /dev/null
> > @@ -1 +0,0 @@
> > -Subproject commit 8fa00308a6e22df94094c47dc4d650b0466e78ea
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120131): https://edk2.groups.io/g/devel/message/120131
Mute This Topic: https://groups.io/mt/107630356/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
prev parent reply other threads:[~2024-07-30 17:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-30 16:17 [edk2-devel] [edk2-libc Patch 0/1] remove gitmodules added through accidental commit Jayaprakash, N
2024-07-30 16:17 ` [edk2-devel] [edk2-libc Patch 1/1] edk2-libc: remove gitmodules file " Jayaprakash, N
2024-07-30 16:32 ` Rebecca Cran
2024-07-30 17:03 ` Jayaprakash, N
2024-07-30 17:23 ` Michael D Kinney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO1PR11MB4929425704B39D320D07EEDDD2B02@CO1PR11MB4929.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox