From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 826A5740038 for ; Fri, 8 Sep 2023 21:40:19 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=/o5SXf+OWnoLdQfzK+rTL2EAHdmwEM1MPLpZU/J7NQ0=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1694209218; v=1; b=RDegL605nzSUW+JXkMYPLjUoiIQtaTwESUcsEIqz6SjDUq6VfCdEKqxFVyehxPdRrSu5YjBt ImZbgZapDeWc7w6++5sR2tQQiQEZhgXa0EluEGFgQPJ6GuJjW6x+IMx9pwQL4xy6gw/Sii8RYI7 usES8vdpsdCpTS7Mjtthk9pE= X-Received: by 127.0.0.2 with SMTP id ajxBYY7687511xx2o7duyywE; Fri, 08 Sep 2023 14:40:18 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web10.5319.1694209217288147110 for ; Fri, 08 Sep 2023 14:40:17 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10827"; a="357217925" X-IronPort-AV: E=Sophos;i="6.02,237,1688454000"; d="scan'208";a="357217925" X-Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Sep 2023 14:40:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10827"; a="745746953" X-IronPort-AV: E=Sophos;i="6.02,237,1688454000"; d="scan'208";a="745746953" X-Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga007.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 08 Sep 2023 14:40:06 -0700 X-Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Fri, 8 Sep 2023 14:40:06 -0700 X-Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Fri, 8 Sep 2023 14:40:06 -0700 X-Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.173) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Fri, 8 Sep 2023 14:40:05 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Yqb3LDR2zfotHfx/IHAtUX1Z/BcQ74wZS46zXgmH/VJ1NrNg38mj8CLV/AJZuKmx8T66TypPs3TpPU963amOQVT+RW02R7qkcG5/83xLXs3hFMeXLOjWXOoX57hDvuZUF6DrOuOzO1mwOogriYsanZ/qV0TEIXFqATfnbxyTDMxzkDSpY5VGJJclILosnAGRI9O+c2XU0MlUFCVDdlxJauTpJqLSg+pEOrvSjBIxjFE5R9SI/Lq4NGsnH6apZeS8gzi8x+hnNlZxlP6VBIiY4axTH5JbUndKXPew46YUs00IxRKHraq5PRZ7x7J/MOu7ipjyZhI4VdAq/k42G01KNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=C3ANq+GgH2xIlLkyJ6rtUBFgGek3FnIdL0CkPshE5Dc=; b=jJUNGFcyrI5oORScncaUeY5x8/oixBXWJCmSM2reXx8LPl/7A0MBAuoKEKc4reTF5RC59UYBfuQR+nQoV7mHPpGN5VQ33ic+8nIVZuAMS5CIgFLqnhLGYo39IslDBED4eFFZnVDwCbujlFV2XIEnS8WqFmXYR1f9lnru5GRfwWk4IRLYvQshSej7jRa5SUo1zDNswrmyglSYSIIgBDaabKZoOkXob8iEVg2jkJxrIdfOEdiHSbO9M008+ch7YCvejT/cAiPa90lm2eQnNGP+otz9odJ9a3FKCY13bNbusP7tN5Dslwg3KO3b6yQact2VVmpqMOyTfMVJuU4aGYwRhw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com (2603:10b6:303:6d::19) by PH7PR11MB6356.namprd11.prod.outlook.com (2603:10b6:510:1fc::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6768.30; Fri, 8 Sep 2023 21:40:02 +0000 X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::eaa6:1c0:c33f:2a11]) by CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::eaa6:1c0:c33f:2a11%2]) with mapi id 15.20.6768.029; Fri, 8 Sep 2023 21:40:02 +0000 From: "Michael D Kinney" To: Mike Maslenkin , "devel@edk2.groups.io" CC: "Bi, Dandan" , "Gao, Liming" , "Desimone, Nathaniel L" , "Kinney, Michael D" Subject: Re: [edk2-devel] [PATCH 0/2] MdeModulePkg/Core/Dxe: Fix memory leak issues Thread-Topic: [PATCH 0/2] MdeModulePkg/Core/Dxe: Fix memory leak issues Thread-Index: AQHZ3GjtAwof6RoSLE+W5I7N5nKpKbARgKrA Date: Fri, 8 Sep 2023 21:40:02 +0000 Message-ID: References: <20230901001032.52136-1-mike.maslenkin@gmail.com> In-Reply-To: <20230901001032.52136-1-mike.maslenkin@gmail.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO1PR11MB4929:EE_|PH7PR11MB6356:EE_ x-ms-office365-filtering-correlation-id: f5306b8a-2d3f-410f-469b-08dbb0b428bb x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: H4nokou4P0dMgPMWJdKco5oBlz3MMXHD1ZiSGXZid+6F+C1nRHUkIINBJOPuPR+TtxAklxcJzBb6i8rR6X1tIruDR8isFL/mFahFbrFddaE2SPanzURcyjB3gmqMuGGievkDrojLgSUpWvguD05K6GArZpBYCh0rzCqDwDgEmA8xRzXmFXZbDi/P/ryxLDnA4N/r14pZgGO2wIIoYCQXVWeqPNJqlY80jRhHze9nB3XY4gWMb4KhQc2hcI7GFMcLGWUyMFwnC9qIFV/NBF5BelcjjHJnskV4YD9fimbqJEgNHHSf5Mid63WdNf88Whv5mG+KTD+/JT62qUtfsxOnpb+Xe+9TgFg0Ii3ZN4g9TNw0trmWZVFwXBhfMlWPrWqgaap+H1W4j7ZcT5X1PErmPHUmHfec7TXrOruY3/Vfr4/CiWHwIfOH4Uq/jDHJTPpDxV4lqQzMVz+eBU/1IVyK/XVAYLShw+DbPV3DZopStrIyhFV5xbFCL+tB92nkcdcpgKMuzJKiMo7pF6SOljdBO4PpmPXBOLTo6hI2wPiwzqOBuyTq5A2gr1WzYWs+W+rKaQPQocXe3q/Bd7mizZikYstraiVBDlMVrw95bFkAmUmw07sscPAAoGCYlOyRvOIR x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?B828M8rGfAvWggKJI+43tbJ0zEMbasNPURbjP5RsD1B+nTqIvyISAai7jDBd?= =?us-ascii?Q?fEc+zMnOT7qc2zMkcNF8umRkI+afN21dAO7XydoojWTELSTEBcct/Dv1hJKo?= =?us-ascii?Q?kgxgVOBnGiWnAxIu4WtNmUfha72wKeVaEKZpnm9WldVniOLrxtsTj/2/hE82?= =?us-ascii?Q?jnwXRa/NBl+KtHRBnjnW5KLSAO/fMUnRKAhkKMnH6WEOv2iRO6Cwyhaay9Nw?= =?us-ascii?Q?JGw0p98E8gKtwPKdVvpZgOqZx1ktaCn74RWZcf81cqCMd5r0cM3XPuYbDFPv?= =?us-ascii?Q?qXXC6T/BEY3IEmnmGmjK2GoWr44L9E6GwXy65LviV8WnMLHhECsS11wj2bNF?= =?us-ascii?Q?cCRFF5BLqU9h20yi9ePVQ13czWJJtPJTWNwiwv8AGdbSTHbihUMtBpRb6z+l?= =?us-ascii?Q?M2MPBKUuhS7i5Wy0y62Weh86t162VRSd6PmTWuk3TGKDUjbIHGwH/6aOjqGL?= =?us-ascii?Q?zykncladS1+s2Uz2WOR6FD50Lysvn7P27SJi+GEnnBlcLTblNasP9m8hUPGv?= =?us-ascii?Q?qjo0MZo37oeeNbO6YeJ1JCV8JD74udMEU6x67EqamCakUVA8NV+eg9V2Vtn8?= =?us-ascii?Q?/SV6OFiLad0S9T3+ckF2I7rkl4/klkCc+VMIwKRdP/UHIelvSGRtfCZzwZdl?= =?us-ascii?Q?R9KeGq03fQBzGmUgqrEP3skgI5HoCWWeHvYee3rfHZ4M+kWBCC6rnA06DxSC?= =?us-ascii?Q?tBykROzJgw4d7Db83y2czCtibZkPwsswaSYjaA6b2ThNNUr5T5pud0Hv1fQk?= =?us-ascii?Q?74hLBZ700hzgf216fHT6JTAi0uw3a9FeY4iVSRwbL+BjoEK6yB30TBDLoVxR?= =?us-ascii?Q?WezkC+x29dEzCgCJbNRqD4Hg5Vbxk09IjDiytcc9iLRdICHm+Fbzet/zY3Bn?= =?us-ascii?Q?RB4sjWPfDKzAHzxAi6IhddxuMhwmVwp8YqhM+Io5yPtDJcLprV9ZBHPkKuXg?= =?us-ascii?Q?BOinEbGAqMp/jjl558ZhJtlhOshyPQzta20JiPIrqKbTT5UAK24pHvzVb4+F?= =?us-ascii?Q?QaYdLGq00UEWIO+49aiwt26qjReYB0BTLhOiH0zbYAsbgj1nXOjDeF2roDwi?= =?us-ascii?Q?RdJQiSbUwbUTyMOh2pUpXEkY3idHc06f5Twr0TgQfvPaHV6T6d2wIzVe92SD?= =?us-ascii?Q?O88pwqA8MMuIKl//yOHSlSiSE5WrRu1K2Cnl2ZG3npxtPUwPlFRqqF2ISMyc?= =?us-ascii?Q?5yGsLBV64cmGO9/kkJKDb8EFCQfgeUndF6Ws2+g3MPVSTZ6NogBPhnp+rLGj?= =?us-ascii?Q?aa9hUy5T/FuFhe5VpIfxBergsc3otVSFcSBy3kEIh4GG7fdGoBaVz8MisL+5?= =?us-ascii?Q?f9tAvN05R987xc8XRIsO2R/KWBxPHYv/SjnLgfV9jDMODqc6dCKuT3/gXkCo?= =?us-ascii?Q?5PoUUEfM5uJTrZq6DP94JsYXJWyss+VktvBwt6dY0UMSUOfk5vft9u+f/SdQ?= =?us-ascii?Q?9ZL8dRxxvTIgmGIFLIhCB09nAuPWZ1MRbsnV6dhm5l55zqJofx0WyY7GE87x?= =?us-ascii?Q?w/BTQhv/aawGcQeLn0ip2AStkKSr8NiuiLfcPzCtiVQ0itOLJyCmSV6sJD3d?= =?us-ascii?Q?xDWGJXbs+fKiQR8/iCeCpk4Lrsvf6Bdh96XhTFXKdKlLZnwzYGO9xATT5sPv?= =?us-ascii?Q?8w=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4929.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f5306b8a-2d3f-410f-469b-08dbb0b428bb X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Sep 2023 21:40:02.6457 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 11p9wm7HkkTL55K308tMLCKZpGU3R9sVPKER763DneD1TADYr+Zy1w4BXnxc1UodlyU3fXLR0yyVRcum80gyqZtdudpoZnH4Fqf6BWEK9oM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6356 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,michael.d.kinney@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: p8nCiyHn6Sa6oTKDc2bvwoGix7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=RDegL605; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Series Reviewed-by: Michael D Kinney > -----Original Message----- > From: Mike Maslenkin > Sent: Thursday, August 31, 2023 5:11 PM > To: devel@edk2.groups.io > Cc: Bi, Dandan ; Gao, Liming > ; Kinney, Michael D ; > Desimone, Nathaniel L ; Mike Maslenkin > > Subject: [PATCH 0/2] MdeModulePkg/Core/Dxe: Fix memory leak issues >=20 > Please, find trivial memory leak fixes on error path. >=20 > The only question: is it required to use FreePool() or CoreFreePool() > from DXE core code? Patch 2/2 is made in accordance with existing code. >=20 > Cc: Dandan Bi > Cc: Liming Gao > Cc: Michael D Kinney > Cc: Nate DeSimone > Signed-off-by: Mike Maslenkin >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108463): https://edk2.groups.io/g/devel/message/108463 Mute This Topic: https://groups.io/mt/101085561/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-