public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Michael D Kinney" <michael.d.kinney@intel.com>
To: "Guo, Gua" <gua.guo@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>,
	"Hsu, VictorX" <victorx.hsu@intel.com>
Cc: "Chiu, Chasel" <chasel.chiu@intel.com>,
	"Prakashan,
	Krishnadas Veliyathuparambil"
	<krishnadas.veliyathuparambil.prakashan@intel.com>,
	"K N, Karthik" <karthik.k.n@intel.com>,
	"Chan, Laura" <laura.chan@intel.com>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] [PATCH 0/4] Trace Hub debug library support
Date: Mon, 8 May 2023 00:45:06 +0000	[thread overview]
Message-ID: <CO1PR11MB49294505D2AE387DF4E31627D2719@CO1PR11MB4929.namprd11.prod.outlook.com> (raw)
In-Reply-To: <BL1PR11MB547853820F559745F2437B31EF609@BL1PR11MB5478.namprd11.prod.outlook.com>

Gua,

I see this PR says it passes CI but there are merge conflicts.

Can you please update the series to address the conflicts.

Thanks,

Mike

> -----Original Message-----
> From: Guo, Gua <gua.guo@intel.com>
> Sent: Thursday, April 20, 2023 7:33 PM
> To: devel@edk2.groups.io; Hsu, VictorX <victorx.hsu@intel.com>
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Prakashan, Krishnadas Veliyathuparambil
> <krishnadas.veliyathuparambil.prakashan@intel.com>; K N, Karthik
> <karthik.k.n@intel.com>; Chan, Laura <laura.chan@intel.com>
> Subject: RE: [edk2-devel] [PATCH 0/4] Trace Hub debug library support
> 
> + Related folk
> 
> I want to let the PR for related stakeholder review it.
> 
> And have any open ?
> https://github.com/tianocore/edk2/pull/3901
> 
> 
> Thanks,
> Gua
> 
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> victorx.hsu@intel.com
> Sent: Tuesday, April 18, 2023 7:05 PM
> To: devel@edk2.groups.io
> Cc: Hsu, VictorX <victorx.hsu@intel.com>
> Subject: [edk2-devel] [PATCH 0/4] Trace Hub debug library support
> 
> From: VictorX Hsu <victorx.hsu@intel.com>
> 
> -	TraceHub UniversalPayload Spec:
> https://github.com/UniversalScalableFirmware/documentation/pull/52
> (Industry Standard)
> -	MipiSysTLib Wrapper: https://github.com/MIPI-Alliance/public-mipi-
> sys-t.git (Industry Standard)
> -	TraceHubDebugLib: Intel(R) Trace Hub (TH) — The Linux Kernel
> documentation (Industry Standard)
>     Developers Guide: https://cdrdv2-public.intel.com/671536/intel-trace-hub-
> developers-manual-2-1-2.pdf (Public Document)
> 
> VictorX Hsu (4):
>   MdePkg: Add MipiSysTLib library
>   MdeModulePkg: Add TraceHubDebugSysTLib library
>   MdePkg: Add NULL library of TraceHubDebugSysTLib
>   Maintainers.txt: Update reviewers and maintainers for Trace Hub dbg
>     lib.
> 
>  .gitmodules                                   |   5 +-
>  .pytool/CISettings.py                         |   2 +
>  Maintainers.txt                               |  18 +
>  .../Include/Guid/TraceHubDebugInfoHob.h       |  25 +
>  .../BaseTraceHubDebugSysTLib.c                | 251 ++++++
>  .../BaseTraceHubDebugSysTLib.inf              |  44 +
>  .../DxeSmmTraceHubDebugSysTLib.c              | 247 ++++++
>  .../DxeSmmTraceHubDebugSysTLib.inf            |  50 ++
>  .../InternalTraceHubApi.c                     |  82 ++
>  .../InternalTraceHubApi.h                     |  46 +
>  .../InternalTraceHubApiCommon.c               | 208 +++++
>  .../InternalTraceHubApiCommon.h               | 119 +++
>  .../PeiTraceHubDebugSysTLib.c                 | 290 +++++++
>  .../PeiTraceHubDebugSysTLib.inf               |  50 ++
>  .../Library/TraceHubDebugSysTLib/Readme.md    |  30 +
>  MdeModulePkg/MdeModulePkg.dec                 |  21 +
>  MdeModulePkg/MdeModulePkg.dsc                 |   3 +
>  MdeModulePkg/MdeModulePkg.uni                 |  18 +
>  MdePkg/Include/Library/MipiSysTLib.h          |  66 ++
>  MdePkg/Include/Library/TraceHubDebugSysTLib.h |  81 ++
>  MdePkg/Library/MipiSysTLib/GenMipiSystH.py    | 132 +++
>  MdePkg/Library/MipiSysTLib/MipiSysTLib.c      | 123 +++
>  MdePkg/Library/MipiSysTLib/MipiSysTLib.inf    |  55 ++
>  MdePkg/Library/MipiSysTLib/Platform.c         | 164 ++++
>  MdePkg/Library/MipiSysTLib/Platform.h         | 138 +++
>  MdePkg/Library/MipiSysTLib/Readme.md          |  25 +
>  MdePkg/Library/MipiSysTLib/mipi_syst.h        | 789 ++++++++++++++++++
>  MdePkg/Library/MipiSysTLib/mipisyst           |   1 +
>  .../TraceHubDebugSysTLibNull.c                |  76 ++
>  .../TraceHubDebugSysTLibNull.inf              |  29 +
>  MdePkg/MdePkg.ci.yaml                         |  15 +-
>  MdePkg/MdePkg.dec                             |   9 +
>  MdePkg/MdePkg.dsc                             |   2 +
>  ReadMe.rst                                    |   1 +
>  34 files changed, 3212 insertions(+), 3 deletions(-)  create mode 100644
> MdeModulePkg/Include/Guid/TraceHubDebugInfoHob.h
>  create mode 100644
> MdeModulePkg/Library/TraceHubDebugSysTLib/BaseTraceHubDebugSysTLib.c
>  create mode 100644
> MdeModulePkg/Library/TraceHubDebugSysTLib/BaseTraceHubDebugSysTLib.i
> nf
>  create mode 100644
> MdeModulePkg/Library/TraceHubDebugSysTLib/DxeSmmTraceHubDebugSysTL
> ib.c
>  create mode 100644
> MdeModulePkg/Library/TraceHubDebugSysTLib/DxeSmmTraceHubDebugSysTL
> ib.inf
>  create mode 100644
> MdeModulePkg/Library/TraceHubDebugSysTLib/InternalTraceHubApi.c
>  create mode 100644
> MdeModulePkg/Library/TraceHubDebugSysTLib/InternalTraceHubApi.h
>  create mode 100644
> MdeModulePkg/Library/TraceHubDebugSysTLib/InternalTraceHubApiCommon
> .c
>  create mode 100644
> MdeModulePkg/Library/TraceHubDebugSysTLib/InternalTraceHubApiCommon
> .h
>  create mode 100644
> MdeModulePkg/Library/TraceHubDebugSysTLib/PeiTraceHubDebugSysTLib.c
>  create mode 100644
> MdeModulePkg/Library/TraceHubDebugSysTLib/PeiTraceHubDebugSysTLib.inf
>  create mode 100644
> MdeModulePkg/Library/TraceHubDebugSysTLib/Readme.md
>  create mode 100644 MdePkg/Include/Library/MipiSysTLib.h
>  create mode 100644 MdePkg/Include/Library/TraceHubDebugSysTLib.h
>  create mode 100644 MdePkg/Library/MipiSysTLib/GenMipiSystH.py
>  create mode 100644 MdePkg/Library/MipiSysTLib/MipiSysTLib.c
>  create mode 100644 MdePkg/Library/MipiSysTLib/MipiSysTLib.inf
>  create mode 100644 MdePkg/Library/MipiSysTLib/Platform.c
>  create mode 100644 MdePkg/Library/MipiSysTLib/Platform.h
>  create mode 100644 MdePkg/Library/MipiSysTLib/Readme.md
>  create mode 100644 MdePkg/Library/MipiSysTLib/mipi_syst.h
>  create mode 160000 MdePkg/Library/MipiSysTLib/mipisyst
>  create mode 100644
> MdePkg/Library/TraceHubDebugSysTLibNull/TraceHubDebugSysTLibNull.c
>  create mode 100644
> MdePkg/Library/TraceHubDebugSysTLibNull/TraceHubDebugSysTLibNull.inf
> 
> --
> 2.40.0.windows.1
> 
> 
> 
> 
> 


  reply	other threads:[~2023-05-08  0:45 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-18 11:04 [PATCH 0/4] Trace Hub debug library support victorx.hsu
2023-04-18 11:04 ` [PATCH 1/4] MdePkg: Add MipiSysTLib library victorx.hsu
2023-04-18 11:04 ` [PATCH 2/4] MdeModulePkg: Add TraceHubDebugSysTLib library victorx.hsu
2023-04-18 11:05 ` [PATCH 3/4] MdePkg: Add NULL library of TraceHubDebugSysTLib victorx.hsu
2023-04-18 11:05 ` [PATCH 4/4] Maintainers.txt: Update reviewers and maintainers for Trace Hub dbg lib victorx.hsu
2023-04-21  2:33 ` [edk2-devel] [PATCH 0/4] Trace Hub debug library support Guo, Gua
2023-05-08  0:45   ` Michael D Kinney [this message]
2023-05-08  5:18     ` Hsu, VictorX
2023-05-08  5:21       ` Michael D Kinney
     [not found] ` <1757D27BA79AB0E1.26256@groups.io>
2023-04-24  1:37   ` Guo, Gua
     [not found]   ` <1758BB2DE6DD05C7.10313@groups.io>
2023-05-03 20:48     ` Guo, Gua
2023-05-03 23:54       ` Prakashan, Krishnadas Veliyathuparambil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CO1PR11MB49294505D2AE387DF4E31627D2719@CO1PR11MB4929.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox