Re: [edk2-devel] [PATCH] UefiCpuPkg/MicrocodeMeasurementDxe: Fix exception

["Michael D Kinney" <michael.d.kinney@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3404 bytes --]

Merged

PR: https://github.com/tianocore/edk2/pull/4129

Commit: https://github.com/tianocore/edk2/commit/fd1820b7ea09e53e404d6f56bb8bc4b51a5dd83e

Mike

From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Darbin Reyes
Sent: Thursday, March 9, 2023 8:31 PM
To: devel@edk2.groups.io; Reyes, Darbin <darbin.reyes@intel.com>; Dong, Eric <eric.dong@intel.com>; Ni, Ray <ray.ni@intel.com>; Kumar, Rahul R <rahul.r.kumar@intel.com>; kraxel@redhat.com
Cc: Narey, Jacob <jacob.narey@intel.com>
Subject: Re: [edk2-devel] [PATCH] UefiCpuPkg/MicrocodeMeasurementDxe: Fix exception

+ @UefiCpuPkg Maintainers

Requesting an estimated ETA on integration of this 1 character patch.

I understand the patch queue is huge, just looking to provide a realistic expectation to those who are blocked by this and waiting for me to provide an update.

Warm Regards,
Darbin
________________________________
From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> on behalf of Darbin Reyes <darbin.reyes@intel.com<mailto:darbin.reyes@intel.com>>
Sent: Tuesday, March 7, 2023 3:04 PM
To: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>>
Cc: Reyes, Darbin <darbin.reyes@intel.com<mailto:darbin.reyes@intel.com>>; Narey, Jacob <jacob.narey@intel.com<mailto:jacob.narey@intel.com>>
Subject: [edk2-devel] [PATCH] UefiCpuPkg/MicrocodeMeasurementDxe: Fix exception

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4360

An incorrect format specifier is being used in a DEBUG print,
specifically, a variable of type EFI_STATUS was being printed with
the %a format specifier (pointer to an ASCII string), thus the value of
the Status variable was being treated as the address of a string,
leading to a CPU exception, when encountered this bug manifests itself
as a hang near "Ready to Boot Event", with the last DEBUG print being
"INFO: Got MicrocodePatchHob with microcode patches starting address"
followed by a CPU Exception dump.

Signed-off-by: Darbin Reyes <darbin.reyes@intel.com<mailto:darbin.reyes@intel.com>>
Reviewed-by: Jacob Narey <jacob.narey@intel.com<mailto:jacob.narey@intel.com>>
---
 UefiCpuPkg/MicrocodeMeasurementDxe/MicrocodeMeasurementDxe.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/UefiCpuPkg/MicrocodeMeasurementDxe/MicrocodeMeasurementDxe.c b/UefiCpuPkg/MicrocodeMeasurementDxe/MicrocodeMeasurementDxe.c
index 762ca159ff..5fd3b3365c 100644
--- a/UefiCpuPkg/MicrocodeMeasurementDxe/MicrocodeMeasurementDxe.c
+++ b/UefiCpuPkg/MicrocodeMeasurementDxe/MicrocodeMeasurementDxe.c
@@ -238,7 +238,7 @@ MeasureMicrocodePatches (
        TotalMicrocodeSize)

       );

   } else {

-    DEBUG ((DEBUG_ERROR, "ERROR: TpmMeasureAndLogData failed with status %a!\n", Status));

+    DEBUG ((DEBUG_ERROR, "ERROR: TpmMeasureAndLogData failed with status %r!\n", Status));

   }



   FreePool (Offsets);

--
2.38.1.windows.1



-=-=-=-=-=-=
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#100818): https://edk2.groups.io/g/devel/message/100818
Mute This Topic: https://groups.io/mt/97461560/7511391
Group Owner: devel+owner@edk2.groups.io<mailto:devel+owner@edk2.groups.io>
Unsubscribe: https://edk2.groups.io/g/devel/unsub [darbin.reyes@intel.com]
-=-=-=-=-=-=



[-- Attachment #2: Type: text/html, Size: 45749 bytes --]