From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 26160740035 for ; Tue, 23 Jan 2024 23:15:28 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=ZgJCVBGTcmkVfl+fvLCca26WB0xX7f2lpbawWvRGZvI=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1706051727; v=1; b=V+1S5QZFfqfStd7O4sQukbXeJim3+YeqhPITL8GklTkLFPYjccef8C0nuBFXCIlNFo543/57 WoFF9ATgiDasRptzM5oTudF6zcNqiRjMxL48ZzUoo4gC/E+1Yyl2NNbKsEgaWUGUI5sawqexRaI mHL8JkWC1mQO+euI9+UcQopg= X-Received: by 127.0.0.2 with SMTP id xaLVYY7687511xHcpMftQ8og; Tue, 23 Jan 2024 15:15:27 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) by mx.groups.io with SMTP id smtpd.web10.9331.1706051721514303842 for ; Tue, 23 Jan 2024 15:15:21 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10962"; a="9047076" X-IronPort-AV: E=Sophos;i="6.05,215,1701158400"; d="scan'208";a="9047076" X-Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jan 2024 15:15:21 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10962"; a="876499225" X-IronPort-AV: E=Sophos;i="6.05,215,1701158400"; d="scan'208";a="876499225" X-Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by FMSMGA003.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 23 Jan 2024 15:15:20 -0800 X-Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 23 Jan 2024 15:15:19 -0800 X-Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 23 Jan 2024 15:15:19 -0800 X-Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Tue, 23 Jan 2024 15:15:19 -0800 X-Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.101) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Tue, 23 Jan 2024 15:15:19 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dbTE7pnpAdD4zHmjdUgjz11cWp6gH4hDjnWjFZxB425xbCvn3NJeKSw53UyPRzlPjda7JBuQivbQws6ZebHiXyZVTa6VaUBupw7fhcXjsmskchIQSYPVdrF1i4SCCPFwYX61pyRQ9YFetoVz3q+CRDfKQtWxw3uLJ1Sm0Yz6SyVO27tDFA10JHbNMaSH+0Vq1ABrfxAR9tJWMQ/dFG+Mz2OV0+0qf3Q0QirBOgyIxdsiYDKOqSgTUyaWmd2iUcqbX2+HnZ2ntjlOtJqpLT4S5pi7RS1DAcY7p2XlgO4QeBK1WqW0HurBZookDtVPaCCj2aU9svsCufBGGilfG9hC5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vde0tt5Zfpby+vg0NDc8N5+AA+NW3xn+N9hA31ilM48=; b=mxl8SiHnhQqP2tYKJUOfY/JSGlMrpN/j+MM6C3R6CUoN6moa0GwKA3L08cvRwM/B12xpmXYCuncolJajBCyubhn299OH7HMTfnRIPiRZ2m8FiJuSQp2u/qmEPpe2KWPtPO2WV8a6uL1X8pYemR5XYUayDYQF7y6RGsGPpNh/LbMG8lMXwdu3SgEWbVAzc9lsbwby1SWog7T14vkCIHKv+PBRpVdpyIkmcl28tCHH+7vmgeTajRkTyq8rtDV+2uPtE4bEs0Uk27rgje+UWs9oLZZ1PPyfliEY0Av/L52OCh+KXVE57ApKnTwJ0LVuDzzt1JKPQTH7CVmtKqnwueuOtw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com (2603:10b6:303:6d::19) by SA0PR11MB4623.namprd11.prod.outlook.com (2603:10b6:806:95::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7202.37; Tue, 23 Jan 2024 23:15:15 +0000 X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::7e42:1633:d0a6:9c00]) by CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::7e42:1633:d0a6:9c00%6]) with mapi id 15.20.7202.035; Tue, 23 Jan 2024 23:15:15 +0000 From: "Michael D Kinney" To: "Tan, Ming" , "devel@edk2.groups.io" CC: "Shang, Qingyu" , "Gao, Liming" , "Liu, Zhiguang" , "Kinney, Michael D" Subject: Re: [edk2-devel] [PATCH] MdePkg: Update ReceiveData and SendData function description Thread-Topic: [PATCH] MdePkg: Update ReceiveData and SendData function description Thread-Index: AQHaRF+K1MKccmKhDEu1qN/9ayONmrDoGqeg Date: Tue, 23 Jan 2024 23:15:14 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO1PR11MB4929:EE_|SA0PR11MB4623:EE_ x-ms-office365-filtering-correlation-id: 700e6655-9981-419b-ebf2-08dc1c692808 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: VEhUkjcXLSqn/+Obfj8P3+aFK5gLh+oJ34P5dHYm5WwCHjyxOHKGa+9MrdxbYA9C540alv/Cyht0hfUG/eSGetICd5AAXle2me2YWU33NEo2aWO1NrP8vrrotSqxjR+rzgHrRauVTvQl29fD0DsJmz2Glww6xT/1xc8gpvoQey7O9rInzm/YTwR7q9BHD05L2yfCmqLroBIC00kiY8XMWqgqOCF0VI53ndRynhYPuVtVSYQUljnDmA4pGVtOkFj28aT4cUNuBF6SOdxTf6Z49LRsYWIg9r4KBJ3+CZ/skYlTv79J4LOkdYwvcSzHSVMkh4zd9AqnlcqaQmuD0AerlL6iEzQkjm7B4EdTs0l1hjm/xBzdwEBLXrTr0b9ys5J+DG+lkqd7FbSC+PzBJIa2baD96tSWhYMbAKZHs8MPGzCdWVfsB01XS4v51c09oxfe8Tp6CRYn4J0G6zmvONuxRy5MSEar/Bz7qDtXLXoowguq7abExvZFMIO2CYfLpjSkvwmY0DmUriMtBawvvAunb4qoWEclreZQVUXDzyWWUg9NT58m8TUlJ0uOP2825yKoKhqoC+DRZz7OvQrdlREhLvJIWVtSxy1x4RyEz638F4ftvqdtxC96vZ2Dlf2zCJQP x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?LKsmRSpR+qxJ5yQX7s3K+f4oXs/TXIlBulXhKEp+6kIvJVc9fsnImCwPRR1P?= =?us-ascii?Q?GY1TqmxdPFzKPYirlDKr24e4Qu/rRDKfMrGAoD9hwU7tABaU3xvIS2SUbfte?= =?us-ascii?Q?m0p6uf93tC/v/kl3HnSgz2+cIafdqugtYLizuz5q73UsEfxr5qd70BmnBDIm?= =?us-ascii?Q?KyrItdZ0IhdV+zCyN9fVt8am5bau4l9o17BBSTHk4mx4EsxffqvUvWc+Mq5p?= =?us-ascii?Q?bAlUFuJdvDVS9xKc7tSVrFR1VSJ0hLfpDefEIuPSmiejQVWUzRoa7PHVZnuy?= =?us-ascii?Q?+WvME9MDgoz6sdCGkYNbJqxrtJqLa+rhZfIi/r8/3KGlYzEvT7d6VBEOjbyj?= =?us-ascii?Q?I9rAnm70PwqdchcMkGfzFVcamB1G3JUutu1CBMcVsEA0UTvkzXY/CuRH4UfO?= =?us-ascii?Q?1VFuv+Dm8/3b/+Sf43NPjEBln8+X13GxIQ5xc8PhPBeuSzaLHtFJoM2Lb2Ti?= =?us-ascii?Q?RzPFIlgKh4th7CKr0Ejb3CzYCt/0M+SecQPVJIgiHuzxHFa1GLFrTQHfinqC?= =?us-ascii?Q?wZqB8GJidh+kQaFYqgXf6gfwXD8LQxzGK2Sgb8qnGmqr6QaT3nzlzIMMOw1i?= =?us-ascii?Q?aOpVa0cT/KiUHb8bD+ag2tHzatc+NjZSA7gp930p5qXRocM2cZpKr8ZaJXIz?= =?us-ascii?Q?o3w5IKuMpbBuqw4xnWqU3MbYX+Fp28YXldUFYik9ircEK1P/WcF/bPABHlGk?= =?us-ascii?Q?r8nrURI/1jsTp6K7O9+oYYt0Bs04j6Aorjp3/4wpcNs86QRFd6eq2G7YJhG5?= =?us-ascii?Q?aBviLYXRaw6sMJarr8WW+9SIP98Qw8qIPgbjQ8/fAFAO8vENiQtVJrY6X0tT?= =?us-ascii?Q?75oByiRT+aiP0fKHB/DVV27lk+rIahs4ngXq/A5uEWhO1N2YkiFUbgYri9qk?= =?us-ascii?Q?AmAwhusPdH+H+mMrATR1RwwAC/hj4qbF4X1Y2bPymx0m0A8/wqOEY82xHBJS?= =?us-ascii?Q?sW7OP2sQKoSQ1f7Iaj1gjwAbIbQ1J2IJkG2Uym3fZzIRYGeJMjqZh8BvfJz1?= =?us-ascii?Q?W9b/Did1Iep8HOvvcKzwHLBqYbXimfj14s73PWdFIKee0bb1ynYsBaEhqnTA?= =?us-ascii?Q?J60YL4s68rk6LgrhMCbi49jEY32MW41ME4flHMZbLNPeyb6mm5wjgsJ5tRaa?= =?us-ascii?Q?Mdd8YBrh1To5g1kk4akFsyITBDEmik7EY2yK/OUdVoAPl37Z3SO7SY8TXS8I?= =?us-ascii?Q?n4lsRptkpRYE/id8wIjLXt9Uf4iktuQmqkZykg5LrBx0rmFYIR11ryp5tsfA?= =?us-ascii?Q?MlA/EezoVZbbsMbDb04hNWxLY5lIWLTpmnv9Bh5Ha++sgAZoACrTEuSCT5FU?= =?us-ascii?Q?rgsPWkEbDW1usyv972e6CKKUFZXUPMXWrPqobGlmqzGNjcBj4ae6ZS7G7CnT?= =?us-ascii?Q?OonTh4fr7kuuiwijMAudwrQsOl8tZZbXx+NjYIGqX3I7uyEmRlmtc/bLEWYy?= =?us-ascii?Q?vD5KJtf7CzMQNnd3CzNLFDf0K+YMN9OxkFDbG7oXMsxzUb5YXkwu89JltLMW?= =?us-ascii?Q?VGZlM54NFj32idSCEaqvFKZxQogHrcqdLLSemP5WCo3u9zAifO5qUz+dSQKH?= =?us-ascii?Q?Av6SnGVTLMYkHMaLfPsav7GFQXii5+ah0EgAPRfJderkBdcXxefdwLRNKYPN?= =?us-ascii?Q?uQ=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4929.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 700e6655-9981-419b-ebf2-08dc1c692808 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jan 2024 23:15:14.8439 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: M4gGQCkqA1DkF18vAevPJxuExL58R9ACHiBHSbRxsSv/5CppGvW3TNtSWtvIvKs84CXusyZe/imuT437wuIkYUUSi1Grr1dGFsWW9d89HHQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4623 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,michael.d.kinney@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: PhBYRznueEPjU4PkUlLqyYj3x7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=V+1S5QZF; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Hi Ming, Please update the function headers for the following drivers that=20 provide implementations of the Storage Security Command Protocol. MdeModulePkg\Bus\Ata\AtaBusDxe\AtaBus.c: 1485 @param This Indicates a pointer to the c= alling context. 1486: @param MediaId ID of the medium to receive = data from. 1487 @param Timeout The timeout, in 100ns units,= to use for the execution 1602 @param This Indicates a pointer to the c= alling context. 1603: @param MediaId ID of the medium to receive = data from. 1604 @param Timeout The timeout, in 100ns units,= to use for the execution MdeModulePkg\Bus\Ata\AtaBusDxe\AtaBus.h: 929 @param This Indicates a pointer to the c= alling context. 930: @param MediaId ID of the medium to receive = data from. 931 @param Timeout The timeout, in 100ns units,= to use for the execution 1009 @param This Indicates a pointer to the c= alling context. 1010: @param MediaId ID of the medium to receive = data from. 1011 @param Timeout The timeout, in 100ns units,= to use for the execution MdeModulePkg\Bus\Pci\NvmExpressDxe\NvmExpressBlockIo.c: 1701 @param This Indicates a pointer to the c= alling context. 1702: @param MediaId ID of the medium to receive = data from. 1703 @param Timeout The timeout, in 100ns units,= to use for the execution 1814 @param This Indicates a pointer to the c= alling context. 1815: @param MediaId ID of the medium to receive = data from. 1816 @param Timeout The timeout, in 100ns units,= to use for the execution MdeModulePkg\Bus\Pci\NvmExpressDxe\NvmExpressBlockIo.h: 291 @param This Indicates a pointer to the ca= lling context. 292: @param MediaId ID of the medium to receive d= ata from. 293 @param Timeout The timeout, in 100ns units, = to use for the execution 371 @param This Indicates a pointer to the ca= lling context. 372: @param MediaId ID of the medium to receive d= ata from. 373 @param Timeout The timeout, in 100ns units, = to use for the execution MdeModulePkg\Bus\Scsi\ScsiDiskDxe\ScsiDisk.c: 1899 @param This Indicates a pointer to the c= alling context. 1900: @param MediaId ID of the medium to receive = data from. 1901 @param Timeout The timeout, in 100ns units,= to use for the execution 2121 @param This Indicates a pointer to the c= alling context. 2122: @param MediaId ID of the medium to receive = data from. 2123 @param Timeout The timeout, in 100ns units,= to use for the execution MdeModulePkg\Bus\Scsi\ScsiDiskDxe\ScsiDisk.h: 679 @param This Indicates a pointer to the ca= lling context. 680: @param MediaId ID of the medium to receive d= ata from. 681 @param Timeout The timeout, in 100ns units, = to use for the execution 753 @param This Indicates a pointer to the ca= lling context. 754: @param MediaId ID of the medium to receive d= ata from. 755 @param Timeout The timeout, in 100ns units, = to use for the execution MdeModulePkg\Bus\Sd\EmmcDxe\EmmcBlockIo.c: 1269 @param[in] This Indicates a pointer to t= he calling context. 1270: @param[in] MediaId ID of the medium to rece= ive data from. 1271 @param[in] Timeout The timeout, in 100ns un= its, to use for the execution 1456 @param This Indicates a pointer to the c= alling context. 1457: @param MediaId ID of the medium to receive = data from. 1458 @param Timeout The timeout, in 100ns units,= to use for the execution 1557 @param This Indicates a pointer to the c= alling context. 1558: @param MediaId ID of the medium to receive = data from. 1559 @param Timeout The timeout, in 100ns units,= to use for the execution MdeModulePkg\Bus\Sd\EmmcDxe\EmmcBlockIo.h: 252 @param[in] This Indicates a pointer to th= e calling context. 253: @param[in] MediaId ID of the medium to recei= ve data from. 254 @param[in] Timeout The timeout, in 100ns uni= ts, to use for the execution 339 @param This Indicates a pointer to the ca= lling context. 340: @param MediaId ID of the medium to receive d= ata from. 341 @param Timeout The timeout, in 100ns units, = to use for the execution 419 @param This Indicates a pointer to the ca= lling context. 420: @param MediaId ID of the medium to receive d= ata from. 421 @param Timeout The timeout, in 100ns units, = to use for the execution SecurityPkg\Tcg\Opal\OpalPassword\OpalPasswordPei.c: 51 @param This Indicates a pointer to the ca= lling context. 52: @param MediaId ID of the medium to receive d= ata from. 53 @param Timeout The timeout, in 100ns units, = to use for the execution 150 @param This Indicates a pointer to the ca= lling context. 151: @param MediaId ID of the medium to receive d= ata from. 152 @param Timeout The timeout, in 100ns units, = to use for the execution Thanks, Mike > -----Original Message----- > From: Tan, Ming > Sent: Wednesday, January 10, 2024 11:26 PM > To: devel@edk2.groups.io > Cc: Shang, Qingyu ; Kinney, Michael D > ; Gao, Liming ; > Liu, Zhiguang > Subject: [PATCH] MdePkg: Update ReceiveData and SendData function > description >=20 > From: Qingyu Shang >=20 > Refer to Uefi spec 2.10 section 13.14, update the parameter 'MediaId' > description for EFI_STORAGE_SECURITY_COMMAND_PROTOCOL function > ReceiveData > and SendData. >=20 > Signed-off-by: Qingyu Shang > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Zhiguang Liu > --- > MdePkg/Include/Protocol/StorageSecurityCommand.h | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) >=20 > diff --git a/MdePkg/Include/Protocol/StorageSecurityCommand.h > b/MdePkg/Include/Protocol/StorageSecurityCommand.h > index 810af59b85..206ae79aff 100644 > --- a/MdePkg/Include/Protocol/StorageSecurityCommand.h > +++ b/MdePkg/Include/Protocol/StorageSecurityCommand.h > @@ -59,7 +59,9 @@ typedef struct _EFI_STORAGE_SECURITY_COMMAND_PROTOCOL > EFI_STORAGE_SECURITY_COMMA > function shall return EFI_DEVICE_ERROR. >=20 >=20 >=20 > @param This Indicates a pointer to the > calling context. >=20 > - @param MediaId ID of the medium to receive data > from. >=20 > + @param MediaId ID of the medium to receive data > from. If there is no >=20 > + block IO protocol supported by > the physical device, the >=20 > + value of MediaId is undefined. >=20 > @param Timeout The timeout, in 100ns units, to > use for the execution >=20 > of the security protocol > command. A Timeout value of 0 >=20 > means that this function will > wait indefinitely for the >=20 > @@ -138,7 +140,9 @@ EFI_STATUS > shall return EFI_DEVICE_ERROR. >=20 >=20 >=20 > @param This Indicates a pointer to the > calling context. >=20 > - @param MediaId ID of the medium to receive data > from. >=20 > + @param MediaId ID of the medium to receive data > from. If there is no >=20 > + block IO protocol supported by > the physical device, the >=20 > + value of MediaId is undefined. >=20 > @param Timeout The timeout, in 100ns units, to > use for the execution >=20 > of the security protocol > command. A Timeout value of 0 >=20 > means that this function will > wait indefinitely for the >=20 > -- > 2.39.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114239): https://edk2.groups.io/g/devel/message/114239 Mute This Topic: https://groups.io/mt/103658104/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-