[edk2-platforms][PATCH v1 00/10] Add variableFlashInfoLib

[edk2-platforms][PATCH v1 00/10] Add variableFlashInfoLib

[Michael Kubacki]

From: Michael Kubacki <michael.kubacki@microsoft.com>

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479

Adds an instance for the library class VariableFlashInfoLib that
was recently introduced in MdeModulePkg. This change is made to
allow the new variable driver to build that has a dependency on
this library class and does not require any further platform
changes.

Note that this series is for an upcoming change in MdeModulePkg
and requires that change to be present locally for testing.

https://edk2.groups.io/g/devel/message/88787

Cc: Abner Chang <abner.chang@hpe.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Daniel Schaefer <daniel.schaefer@hpe.com>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Gilbert Chen <gilbert.chen@hpe.com>
Cc: Graeme Gregory <graeme@nuviainc.com>
Cc: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Cc: Jeremy Linton <jeremy.linton@arm.com>
Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Masami Hiramatsu <masami.hiramatsu@linaro.org>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Radoslaw Biernacki <rad@semihalf.com>
Cc: Sami Mujawar <sami.mujawar@arm.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>

Michael Kubacki (10):
  OverdriveBoard: Add VariableFlashInfoLib
  BeagleBoardPkg: Add VariableFlashInfoLib
  MinPlatformPkg: Add VariableFlashInfoLib
  CelloBoard: Add VariableFlashInfoLib
  SbsaQemu: Add VariableFlashInfoLib
  RaspberryPi: Add VariableFlashInfoLib
  U5SeriesPkg: Add VariableFlashInfoLib
  Socionext: Add VariableFlashInfoLib
  Softiron: Add VariableFlashInfoLib
  PlatformStandaloneMmPkg: Add VariableFlashInfoLib

 Platform/AMD/OverdriveBoard/OverdriveBoard.dsc                             | 1 +
 Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc                     | 1 +
 Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc                | 1 +
 Platform/LeMaker/CelloBoard/CelloBoard.dsc                                 | 1 +
 Platform/Qemu/SbsaQemu/SbsaQemu.dsc                                        | 1 +
 Platform/RaspberryPi/RPi3/RPi3.dsc                                         | 1 +
 Platform/RaspberryPi/RPi4/RPi4.dsc                                         | 1 +
 Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc                 | 1 +
 Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc       | 1 +
 Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc               | 1 +
 Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc                | 1 +
 Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc | 1 +
 12 files changed, 12 insertions(+)

-- 
2.28.0.windows.1

[edk2-platforms][PATCH v1 01/10] OverdriveBoard: Add VariableFlashInfoLib

[Michael Kubacki]

From: Michael Kubacki <michael.kubacki@microsoft.com>

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479

Adds an instance for the library class VariableFlashInfoLib that
was recently introduced in MdeModulePkg. This change is made to
allow the new variable driver to build that has a dependency on
this library class and does not require any further platform
changes.

Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
---
 Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
index fceb8b64dfde..236e8f1db3dd 100644
--- a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
+++ b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
@@ -125,6 +125,7 @@ [LibraryClasses.common]
   OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf
   RngLib|MdePkg/Library/DxeRngLib/DxeRngLib.inf
   TlsLib|CryptoPkg/Library/TlsLib/TlsLib.inf
+  VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf
   VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
   VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf
 
-- 
2.28.0.windows.1

[edk2-platforms][PATCH v1 02/10] BeagleBoardPkg: Add VariableFlashInfoLib

[Michael Kubacki]

From: Michael Kubacki <michael.kubacki@microsoft.com>

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479

Adds an instance for the library class VariableFlashInfoLib that
was recently introduced in MdeModulePkg. This change is made to
allow the new variable driver to build that has a dependency on
this library class and does not require any further platform
changes.

Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
---
 Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc b/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc
index 7df306045d12..2de49fc0932c 100644
--- a/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc
+++ b/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc
@@ -137,6 +137,7 @@ [LibraryClasses.common]
   AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf
   TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf
   VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf
+  VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf
   VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
 
   UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.inf
-- 
2.28.0.windows.1

[edk2-platforms][PATCH v1 03/10] MinPlatformPkg: Add VariableFlashInfoLib

[Michael Kubacki]

From: Michael Kubacki <michael.kubacki@microsoft.com>

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479

Adds an instance for the library class VariableFlashInfoLib that
was recently introduced in MdeModulePkg. This change is made to
allow the new variable driver to build that has a dependency on
this library class and does not require any further platform
changes.

Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Eric Dong <eric.dong@intel.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
---
 Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
index c3d05fc913a7..58a18fae6ec8 100644
--- a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
+++ b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
@@ -169,5 +169,6 @@ [LibraryClasses.common]
   MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.inf
 
   SmbusLib|MdePkg/Library/BaseSmbusLibNull/BaseSmbusLibNull.inf
+  VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf
   VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf
   VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
-- 
2.28.0.windows.1

[edk2-platforms][PATCH v1 04/10] CelloBoard: Add VariableFlashInfoLib

[Michael Kubacki]

From: Michael Kubacki <michael.kubacki@microsoft.com>

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479

Adds an instance for the library class VariableFlashInfoLib that
was recently introduced in MdeModulePkg. This change is made to
allow the new variable driver to build that has a dependency on
this library class and does not require any further platform
changes.

Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
---
 Platform/LeMaker/CelloBoard/CelloBoard.dsc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Platform/LeMaker/CelloBoard/CelloBoard.dsc b/Platform/LeMaker/CelloBoard/CelloBoard.dsc
index 11d989cf3463..6be8062e60f6 100644
--- a/Platform/LeMaker/CelloBoard/CelloBoard.dsc
+++ b/Platform/LeMaker/CelloBoard/CelloBoard.dsc
@@ -119,6 +119,7 @@ [LibraryClasses.common]
   RealTimeClockLib|Silicon/AMD/Styx/Library/RealTimeClockLib/RealTimeClockLib.inf
   TimeBaseLib|EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.inf
 
+  VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf
   VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf
   CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf
   UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
-- 
2.28.0.windows.1

[edk2-platforms][PATCH v1 05/10] SbsaQemu: Add VariableFlashInfoLib

[Michael Kubacki]

From: Michael Kubacki <michael.kubacki@microsoft.com>

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479

Adds an instance for the library class VariableFlashInfoLib that
was recently introduced in MdeModulePkg. This change is made to
allow the new variable driver to build that has a dependency on
this library class and does not require any further platform
changes.

Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: Graeme Gregory <graeme@nuviainc.com>
Cc: Radoslaw Biernacki <rad@semihalf.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
---
 Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Platform/Qemu/SbsaQemu/SbsaQemu.dsc b/Platform/Qemu/SbsaQemu/SbsaQemu.dsc
index 1d1a25196e22..97014e2fb630 100644
--- a/Platform/Qemu/SbsaQemu/SbsaQemu.dsc
+++ b/Platform/Qemu/SbsaQemu/SbsaQemu.dsc
@@ -163,6 +163,7 @@ [LibraryClasses.common]
   PlatformSecureLib|OvmfPkg/Library/PlatformSecureLib/PlatformSecureLib.inf
 
   VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf
+  VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf
   VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf
   VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
 
-- 
2.28.0.windows.1

[edk2-platforms][PATCH v1 06/10] RaspberryPi: Add VariableFlashInfoLib

[Michael Kubacki]

From: Michael Kubacki <michael.kubacki@microsoft.com>

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479

Adds an instance for the library class VariableFlashInfoLib that
was recently introduced in MdeModulePkg. This change is made to
allow the new variable driver to build that has a dependency on
this library class and does not require any further platform
changes.

Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: Jeremy Linton <jeremy.linton@arm.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
---
 Platform/RaspberryPi/RPi3/RPi3.dsc | 1 +
 Platform/RaspberryPi/RPi4/RPi4.dsc | 1 +
 2 files changed, 2 insertions(+)

diff --git a/Platform/RaspberryPi/RPi3/RPi3.dsc b/Platform/RaspberryPi/RPi3/RPi3.dsc
index 6dc48dc23302..0eed03c097f8 100644
--- a/Platform/RaspberryPi/RPi3/RPi3.dsc
+++ b/Platform/RaspberryPi/RPi3/RPi3.dsc
@@ -174,6 +174,7 @@ [LibraryClasses.common]
   AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf
 !endif
   VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf
+  VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf
   VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf
   VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
   GpioLib|Silicon/Broadcom/Bcm283x/Library/GpioLib/GpioLib.inf
diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc b/Platform/RaspberryPi/RPi4/RPi4.dsc
index a9c0c36bb12b..eabddd7382cf 100644
--- a/Platform/RaspberryPi/RPi4/RPi4.dsc
+++ b/Platform/RaspberryPi/RPi4/RPi4.dsc
@@ -174,6 +174,7 @@ [LibraryClasses.common]
   AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf
 !endif
   VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf
+  VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf
   VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf
   VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
   GpioLib|Silicon/Broadcom/Bcm283x/Library/GpioLib/GpioLib.inf
-- 
2.28.0.windows.1

[edk2-platforms][PATCH v1 07/10] U5SeriesPkg: Add VariableFlashInfoLib

[Michael Kubacki]

From: Michael Kubacki <michael.kubacki@microsoft.com>

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479

Adds an instance for the library class VariableFlashInfoLib that
was recently introduced in MdeModulePkg. This change is made to
allow the new variable driver to build that has a dependency on
this library class and does not require any further platform
changes.

Cc: Abner Chang <abner.chang@hpe.com>
Cc: Gilbert Chen <gilbert.chen@hpe.com>
Cc: Daniel Schaefer <daniel.schaefer@hpe.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
---
 Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc           | 1 +
 Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc | 1 +
 2 files changed, 2 insertions(+)

diff --git a/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc b/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc
index 318851332a7f..7b36b2c885e0 100644
--- a/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc
+++ b/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc
@@ -100,6 +100,7 @@ [LibraryClasses]
   ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf
   UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
   FdtLib|EmbeddedPkg/Library/FdtLib/FdtLib.inf
+  VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf
   VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
 
 # RISC-V Platform Library
diff --git a/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc b/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc
index 98a6a69ca3ec..26895a75ec2f 100644
--- a/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc
+++ b/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc
@@ -100,6 +100,7 @@ [LibraryClasses]
   ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf
   UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
   FdtLib|EmbeddedPkg/Library/FdtLib/FdtLib.inf
+  VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf
   VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
 
 # RISC-V Platform Library
-- 
2.28.0.windows.1

[edk2-platforms][PATCH v1 08/10] Socionext: Add VariableFlashInfoLib

[Michael Kubacki]

From: Michael Kubacki <michael.kubacki@microsoft.com>

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479

Adds an instance for the library class VariableFlashInfoLib that
was recently introduced in MdeModulePkg. This change is made to
allow the new variable driver to build that has a dependency on
this library class and does not require any further platform
changes.

Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: Masami Hiramatsu <masami.hiramatsu@linaro.org>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
---
 Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc b/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc
index 690cdef9d91c..a052de49c958 100644
--- a/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc
+++ b/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc
@@ -128,6 +128,7 @@ [LibraryClasses.common]
 
   NorFlashInfoLib|EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.inf
 
+  VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf
   VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
 
 [LibraryClasses.common.SEC]
-- 
2.28.0.windows.1

[edk2-platforms][PATCH v1 09/10] Softiron: Add VariableFlashInfoLib

[Michael Kubacki]

From: Michael Kubacki <michael.kubacki@microsoft.com>

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479

Adds an instance for the library class VariableFlashInfoLib that
was recently introduced in MdeModulePkg. This change is made to
allow the new variable driver to build that has a dependency on
this library class and does not require any further platform
changes.

Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
---
 Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
index 25fafca51852..37ce04f6a9e3 100644
--- a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
+++ b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
@@ -121,6 +121,7 @@ [LibraryClasses.common]
   RealTimeClockLib|Silicon/AMD/Styx/Library/RealTimeClockLib/RealTimeClockLib.inf
   TimeBaseLib|EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.inf
 
+  VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf
   VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
   VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf
   CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf
-- 
2.28.0.windows.1

[edk2-platforms][PATCH v1 10/10] PlatformStandaloneMmPkg: Add VariableFlashInfoLib

[Michael Kubacki]

From: Michael Kubacki <michael.kubacki@microsoft.com>

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479

Adds an instance for the library class VariableFlashInfoLib that
was recently introduced in MdeModulePkg. This change is made to
allow the new variable driver to build that has a dependency on
this library class and does not require any further platform
changes.

Cc: Sami Mujawar <sami.mujawar@arm.com>
Cc: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
---
 Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc b/Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc
index 33364deb1ef0..653029c52fdb 100644
--- a/Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc
+++ b/Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc
@@ -34,6 +34,7 @@ [LibraryClasses]
   ArmLib|ArmPkg/Library/ArmLib/ArmBaseLib.inf
   BaseLib|MdePkg/Library/BaseLib/BaseLib.inf
   SafeIntLib|MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.inf
+  VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf
   VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
   BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf
   DebugPrintErrorLevelLib|MdePkg/Library/BaseDebugPrintErrorLevelLib/BaseDebugPrintErrorLevelLib.inf
-- 
2.28.0.windows.1

Re: [edk2-devel] [edk2-platforms][PATCH v1 07/10] U5SeriesPkg: Add VariableFlashInfoLib

[Abner Chang]

Reviewed-by: Abner Chang <abner.chang@hpe.com>

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Michael
> Kubacki
> Sent: Thursday, April 21, 2022 4:44 AM
> To: devel@edk2.groups.io
> Cc: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>;
> Gilbert Chen <gilbert.chen@hpe.com>; Schaefer, Daniel (ROM Janitor)
> <daniel.schaefer@hpe.com>
> Subject: [edk2-devel] [edk2-platforms][PATCH v1 07/10] U5SeriesPkg: Add
> VariableFlashInfoLib
> 
> From: Michael Kubacki <michael.kubacki@microsoft.com>
> 
> REF:INVALID URI REMOVED.
> cgi?id=3479__;!!NpxR!3PhEOFQSnwjCzmgG3JnYXRlZBh_ix2221KBb7AJK4fIG_
> PlogbyEkSE_3IJvCdQ$
> 
> Adds an instance for the library class VariableFlashInfoLib that
> was recently introduced in MdeModulePkg. This change is made to
> allow the new variable driver to build that has a dependency on
> this library class and does not require any further platform
> changes.
> 
> Cc: Abner Chang <abner.chang@hpe.com>
> Cc: Gilbert Chen <gilbert.chen@hpe.com>
> Cc: Daniel Schaefer <daniel.schaefer@hpe.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> ---
>  Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc           | 1 +
> 
> Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc
> | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc
> b/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc
> index 318851332a7f..7b36b2c885e0 100644
> --- a/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc
> +++ b/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc
> @@ -100,6 +100,7 @@ [LibraryClasses]
>    ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf
> 
> UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBoo
> tManagerLib.inf
>    FdtLib|EmbeddedPkg/Library/FdtLib/FdtLib.inf
> +
> VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/Base
> VariableFlashInfoLib.inf
> 
> VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/Va
> riablePolicyHelperLib.inf
> 
>  # RISC-V Platform Library
> diff --git
> a/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.d
> sc
> b/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.
> dsc
> index 98a6a69ca3ec..26895a75ec2f 100644
> ---
> a/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.d
> sc
> +++
> b/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.
> dsc
> @@ -100,6 +100,7 @@ [LibraryClasses]
>    ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf
> 
> UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBoo
> tManagerLib.inf
>    FdtLib|EmbeddedPkg/Library/FdtLib/FdtLib.inf
> +
> VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/Base
> VariableFlashInfoLib.inf
> 
> VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/Va
> riablePolicyHelperLib.inf
> 
>  # RISC-V Platform Library
> --
> 2.28.0.windows.1
> 
> 
> 
> 
> 

Re: [edk2-devel] [edk2-platforms][PATCH v1 00/10] Add variableFlashInfoLib

[Michael Kubacki]

Reminder to all to review this series for your package. It is a simple 
change needed to keep your package building.

So far, only Abner Chang <abner.chang@hpe.com> has responded for 
U5SeriesPkg.

On 4/20/2022 4:44 PM, Michael Kubacki wrote:
> From: Michael Kubacki <michael.kubacki@microsoft.com>
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
> 
> Adds an instance for the library class VariableFlashInfoLib that
> was recently introduced in MdeModulePkg. This change is made to
> allow the new variable driver to build that has a dependency on
> this library class and does not require any further platform
> changes.
> 
> Note that this series is for an upcoming change in MdeModulePkg
> and requires that change to be present locally for testing.
> 
> https://edk2.groups.io/g/devel/message/88787
> 
> Cc: Abner Chang <abner.chang@hpe.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Daniel Schaefer <daniel.schaefer@hpe.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Gilbert Chen <gilbert.chen@hpe.com>
> Cc: Graeme Gregory <graeme@nuviainc.com>
> Cc: Ilias Apalodimas <ilias.apalodimas@linaro.org>
> Cc: Jeremy Linton <jeremy.linton@arm.com>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Masami Hiramatsu <masami.hiramatsu@linaro.org>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Radoslaw Biernacki <rad@semihalf.com>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> 
> Michael Kubacki (10):
>    OverdriveBoard: Add VariableFlashInfoLib
>    BeagleBoardPkg: Add VariableFlashInfoLib
>    MinPlatformPkg: Add VariableFlashInfoLib
>    CelloBoard: Add VariableFlashInfoLib
>    SbsaQemu: Add VariableFlashInfoLib
>    RaspberryPi: Add VariableFlashInfoLib
>    U5SeriesPkg: Add VariableFlashInfoLib
>    Socionext: Add VariableFlashInfoLib
>    Softiron: Add VariableFlashInfoLib
>    PlatformStandaloneMmPkg: Add VariableFlashInfoLib
> 
>   Platform/AMD/OverdriveBoard/OverdriveBoard.dsc                             | 1 +
>   Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc                     | 1 +
>   Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc                | 1 +
>   Platform/LeMaker/CelloBoard/CelloBoard.dsc                                 | 1 +
>   Platform/Qemu/SbsaQemu/SbsaQemu.dsc                                        | 1 +
>   Platform/RaspberryPi/RPi3/RPi3.dsc                                         | 1 +
>   Platform/RaspberryPi/RPi4/RPi4.dsc                                         | 1 +
>   Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc                 | 1 +
>   Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc       | 1 +
>   Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc               | 1 +
>   Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc                | 1 +
>   Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc | 1 +
>   12 files changed, 12 insertions(+)
> 

Re: [edk2-platforms][PATCH v1 06/10] RaspberryPi: Add VariableFlashInfoLib

[Jeremy Linton]

Hi,

On 4/20/22 15:44, mikuback@linux.microsoft.com wrote:
> From: Michael Kubacki <michael.kubacki@microsoft.com>
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
> 
> Adds an instance for the library class VariableFlashInfoLib that
> was recently introduced in MdeModulePkg. This change is made to
> allow the new variable driver to build that has a dependency on
> this library class and does not require any further platform
> changes.
> 
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Jeremy Linton <jeremy.linton@arm.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> ---
>   Platform/RaspberryPi/RPi3/RPi3.dsc | 1 +
>   Platform/RaspberryPi/RPi4/RPi4.dsc | 1 +
>   2 files changed, 2 insertions(+)
> 
> diff --git a/Platform/RaspberryPi/RPi3/RPi3.dsc b/Platform/RaspberryPi/RPi3/RPi3.dsc
> index 6dc48dc23302..0eed03c097f8 100644
> --- a/Platform/RaspberryPi/RPi3/RPi3.dsc
> +++ b/Platform/RaspberryPi/RPi3/RPi3.dsc
> @@ -174,6 +174,7 @@ [LibraryClasses.common]
>     AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf
>   !endif
>     VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf
> +  VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf
>     VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf
>     VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
>     GpioLib|Silicon/Broadcom/Bcm283x/Library/GpioLib/GpioLib.inf
> diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc b/Platform/RaspberryPi/RPi4/RPi4.dsc
> index a9c0c36bb12b..eabddd7382cf 100644
> --- a/Platform/RaspberryPi/RPi4/RPi4.dsc
> +++ b/Platform/RaspberryPi/RPi4/RPi4.dsc
> @@ -174,6 +174,7 @@ [LibraryClasses.common]
>     AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf
>   !endif
>     VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf
> +  VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf
>     VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf
>     VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
>     GpioLib|Silicon/Broadcom/Bcm283x/Library/GpioLib/GpioLib.inf

I applied both this and the other required set, built and booted them, 
and the variable store appears to continue behaving as before (both 
with/without my SPI flash patches).

And this looks fairly trivial, I'm not sure why its not just picked up 
as part of one of the other variable store related .inf's but <shrug>

So for this patch:

Tested-by: Jeremy Linton <jeremy.linton@arm.com>
Reviewed-by: Jeremy Linton <jeremy.linton@arm.com>

Re: [edk2-platforms][PATCH v1 06/10] RaspberryPi: Add VariableFlashInfoLib

[Michael Kubacki]

Thanks for testing it.

On 4/22/2022 10:41 AM, Jeremy Linton wrote:
> Hi,
> 
> On 4/20/22 15:44, mikuback@linux.microsoft.com wrote:
>> From: Michael Kubacki <michael.kubacki@microsoft.com>
>>
>> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
>>
>> Adds an instance for the library class VariableFlashInfoLib that
>> was recently introduced in MdeModulePkg. This change is made to
>> allow the new variable driver to build that has a dependency on
>> this library class and does not require any further platform
>> changes.
>>
>> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
>> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
>> Cc: Jeremy Linton <jeremy.linton@arm.com>
>> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
>> ---
>>   Platform/RaspberryPi/RPi3/RPi3.dsc | 1 +
>>   Platform/RaspberryPi/RPi4/RPi4.dsc | 1 +
>>   2 files changed, 2 insertions(+)
>>
>> diff --git a/Platform/RaspberryPi/RPi3/RPi3.dsc 
>> b/Platform/RaspberryPi/RPi3/RPi3.dsc
>> index 6dc48dc23302..0eed03c097f8 100644
>> --- a/Platform/RaspberryPi/RPi3/RPi3.dsc
>> +++ b/Platform/RaspberryPi/RPi3/RPi3.dsc
>> @@ -174,6 +174,7 @@ [LibraryClasses.common]
>>     
>> AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf 
>>
>>   !endif
>>     VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf
>> +  
>> VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf 
>>
>>     
>> VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf 
>>
>>     
>> VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf 
>>
>>     GpioLib|Silicon/Broadcom/Bcm283x/Library/GpioLib/GpioLib.inf
>> diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc 
>> b/Platform/RaspberryPi/RPi4/RPi4.dsc
>> index a9c0c36bb12b..eabddd7382cf 100644
>> --- a/Platform/RaspberryPi/RPi4/RPi4.dsc
>> +++ b/Platform/RaspberryPi/RPi4/RPi4.dsc
>> @@ -174,6 +174,7 @@ [LibraryClasses.common]
>>     
>> AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf 
>>
>>   !endif
>>     VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf
>> +  
>> VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf 
>>
>>     
>> VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf 
>>
>>     
>> VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf 
>>
>>     GpioLib|Silicon/Broadcom/Bcm283x/Library/GpioLib/GpioLib.inf
> 
> I applied both this and the other required set, built and booted them, 
> and the variable store appears to continue behaving as before (both 
> with/without my SPI flash patches).
> 
> And this looks fairly trivial, I'm not sure why its not just picked up 
> as part of one of the other variable store related .inf's but <shrug>
> 
> So for this patch:
> 
> Tested-by: Jeremy Linton <jeremy.linton@arm.com>
> Reviewed-by: Jeremy Linton <jeremy.linton@arm.com>

Re: [edk2-devel] [edk2-platforms][PATCH v1 00/10] Add variableFlashInfoLib

[Michael D Kinney]

Hi Michael,

1) This patch series is dependent on the edk2 repo patch series that adds the 
   VariableFlashInfoLib.  This patch series cannot be committed until the 
   edk2 changes are committed because it will break all the edk2-platforms
   if this one is committed first.

2) The related edk2 changes are a breaking change for all downstream platforms
   that also need to add VariableFlashInfoLib to their DSC files.

   Should breaking changes like this also require a separate email that
   is sent to devel@edk2.groups.io, announce@edk2.groups.io, and discuss@edk2.groups.io
   to increase the visibility of breaking changes?


Series Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>


Best regards,

Mike

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Michael Kubacki
> Sent: Wednesday, April 20, 2022 1:44 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner <abner.chang@hpe.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>; Chiu, Chasel <chasel.chiu@intel.com>;
> Schaefer, Daniel <daniel.schaefer@hpe.com>; Dong, Eric <eric.dong@intel.com>; Gilbert Chen <gilbert.chen@hpe.com>; Graeme Gregory
> <graeme@nuviainc.com>; Ilias Apalodimas <ilias.apalodimas@linaro.org>; Jeremy Linton <jeremy.linton@arm.com>; Leif Lindholm
> <quic_llindhol@quicinc.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Masami Hiramatsu <masami.hiramatsu@linaro.org>; Desimone,
> Nathaniel L <nathaniel.l.desimone@intel.com>; Radoslaw Biernacki <rad@semihalf.com>; Sami Mujawar <sami.mujawar@arm.com>
> Subject: [edk2-devel] [edk2-platforms][PATCH v1 00/10] Add variableFlashInfoLib
> 
> From: Michael Kubacki <michael.kubacki@microsoft.com>
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
> 
> Adds an instance for the library class VariableFlashInfoLib that
> was recently introduced in MdeModulePkg. This change is made to
> allow the new variable driver to build that has a dependency on
> this library class and does not require any further platform
> changes.
> 
> Note that this series is for an upcoming change in MdeModulePkg
> and requires that change to be present locally for testing.
> 
> https://edk2.groups.io/g/devel/message/88787
> 
> Cc: Abner Chang <abner.chang@hpe.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Daniel Schaefer <daniel.schaefer@hpe.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Gilbert Chen <gilbert.chen@hpe.com>
> Cc: Graeme Gregory <graeme@nuviainc.com>
> Cc: Ilias Apalodimas <ilias.apalodimas@linaro.org>
> Cc: Jeremy Linton <jeremy.linton@arm.com>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Masami Hiramatsu <masami.hiramatsu@linaro.org>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Radoslaw Biernacki <rad@semihalf.com>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> 
> Michael Kubacki (10):
>   OverdriveBoard: Add VariableFlashInfoLib
>   BeagleBoardPkg: Add VariableFlashInfoLib
>   MinPlatformPkg: Add VariableFlashInfoLib
>   CelloBoard: Add VariableFlashInfoLib
>   SbsaQemu: Add VariableFlashInfoLib
>   RaspberryPi: Add VariableFlashInfoLib
>   U5SeriesPkg: Add VariableFlashInfoLib
>   Socionext: Add VariableFlashInfoLib
>   Softiron: Add VariableFlashInfoLib
>   PlatformStandaloneMmPkg: Add VariableFlashInfoLib
> 
>  Platform/AMD/OverdriveBoard/OverdriveBoard.dsc                             | 1 +
>  Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc                     | 1 +
>  Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc                | 1 +
>  Platform/LeMaker/CelloBoard/CelloBoard.dsc                                 | 1 +
>  Platform/Qemu/SbsaQemu/SbsaQemu.dsc                                        | 1 +
>  Platform/RaspberryPi/RPi3/RPi3.dsc                                         | 1 +
>  Platform/RaspberryPi/RPi4/RPi4.dsc                                         | 1 +
>  Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc                 | 1 +
>  Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc       | 1 +
>  Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc               | 1 +
>  Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc                | 1 +
>  Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc | 1 +
>  12 files changed, 12 insertions(+)
> 
> --
> 2.28.0.windows.1
> 
> 
> 
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#89148): https://edk2.groups.io/g/devel/message/89148
> Mute This Topic: https://groups.io/mt/90592905/1643496
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub [michael.d.kinney@intel.com]
> -=-=-=-=-=-=
> 

Re: [edk2-platforms][PATCH v1 10/10] PlatformStandaloneMmPkg: Add VariableFlashInfoLib

[Sami Mujawar]

Hi Michael,

Thank you for this patch.

These changes look good to me.

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar

On 20/04/2022 09:44 pm, mikuback@linux.microsoft.com wrote:
> From: Michael Kubacki <michael.kubacki@microsoft.com>
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
>
> Adds an instance for the library class VariableFlashInfoLib that
> was recently introduced in MdeModulePkg. This change is made to
> allow the new variable driver to build that has a dependency on
> this library class and does not require any further platform
> changes.
>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Cc: Ilias Apalodimas <ilias.apalodimas@linaro.org>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> ---
>   Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc b/Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc
> index 33364deb1ef0..653029c52fdb 100644
> --- a/Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc
> +++ b/Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc
> @@ -34,6 +34,7 @@ [LibraryClasses]
>     ArmLib|ArmPkg/Library/ArmLib/ArmBaseLib.inf
>     BaseLib|MdePkg/Library/BaseLib/BaseLib.inf
>     SafeIntLib|MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.inf
> +  VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf
>     VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
>     BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf
>     DebugPrintErrorLevelLib|MdePkg/Library/BaseDebugPrintErrorLevelLib/BaseDebugPrintErrorLevelLib.inf

Re: [edk2-platforms][PATCH v1 00/10] Add variableFlashInfoLib

[Sami Mujawar]

Hi Michael,

There are other platforms in edk2-platforms that would possibly require 
similar changes.

e.g. Platform\ARM\VExpressPkg\ArmVExpress-FVP-AArch64.dsc, 
Platform\ARM\JunoPkg\ArmJuno.dsc, etc.

Do you plan to submit patches to update these platforms as well?

Regards,

Sami Mujawar

On 20/04/2022 09:44 pm, mikuback@linux.microsoft.com wrote:
> From: Michael Kubacki <michael.kubacki@microsoft.com>
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
>
> Adds an instance for the library class VariableFlashInfoLib that
> was recently introduced in MdeModulePkg. This change is made to
> allow the new variable driver to build that has a dependency on
> this library class and does not require any further platform
> changes.
>
> Note that this series is for an upcoming change in MdeModulePkg
> and requires that change to be present locally for testing.
>
> https://edk2.groups.io/g/devel/message/88787
>
> Cc: Abner Chang <abner.chang@hpe.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Daniel Schaefer <daniel.schaefer@hpe.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Gilbert Chen <gilbert.chen@hpe.com>
> Cc: Graeme Gregory <graeme@nuviainc.com>
> Cc: Ilias Apalodimas <ilias.apalodimas@linaro.org>
> Cc: Jeremy Linton <jeremy.linton@arm.com>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Masami Hiramatsu <masami.hiramatsu@linaro.org>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Radoslaw Biernacki <rad@semihalf.com>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
>
> Michael Kubacki (10):
>    OverdriveBoard: Add VariableFlashInfoLib
>    BeagleBoardPkg: Add VariableFlashInfoLib
>    MinPlatformPkg: Add VariableFlashInfoLib
>    CelloBoard: Add VariableFlashInfoLib
>    SbsaQemu: Add VariableFlashInfoLib
>    RaspberryPi: Add VariableFlashInfoLib
>    U5SeriesPkg: Add VariableFlashInfoLib
>    Socionext: Add VariableFlashInfoLib
>    Softiron: Add VariableFlashInfoLib
>    PlatformStandaloneMmPkg: Add VariableFlashInfoLib
>
>   Platform/AMD/OverdriveBoard/OverdriveBoard.dsc                             | 1 +
>   Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc                     | 1 +
>   Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc                | 1 +
>   Platform/LeMaker/CelloBoard/CelloBoard.dsc                                 | 1 +
>   Platform/Qemu/SbsaQemu/SbsaQemu.dsc                                        | 1 +
>   Platform/RaspberryPi/RPi3/RPi3.dsc                                         | 1 +
>   Platform/RaspberryPi/RPi4/RPi4.dsc                                         | 1 +
>   Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc                 | 1 +
>   Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc       | 1 +
>   Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc               | 1 +
>   Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc                | 1 +
>   Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc | 1 +
>   12 files changed, 12 insertions(+)
>

Re: [edk2-platforms][PATCH v1 00/10] Add variableFlashInfoLib

[Michael Kubacki]

Thanks for pointing those out. It looks like ArmVExpress.dsc.inc can 
include it for both of those platforms. I'll add that in a V2.

Regards,
Michael

On 4/25/2022 12:06 PM, Sami Mujawar wrote:
> Hi Michael,
> 
> There are other platforms in edk2-platforms that would possibly require 
> similar changes.
> 
> e.g. Platform\ARM\VExpressPkg\ArmVExpress-FVP-AArch64.dsc, 
> Platform\ARM\JunoPkg\ArmJuno.dsc, etc.
> 
> Do you plan to submit patches to update these platforms as well?
> 
> Regards,
> 
> Sami Mujawar
> 
> On 20/04/2022 09:44 pm, mikuback@linux.microsoft.com wrote:
>> From: Michael Kubacki <michael.kubacki@microsoft.com>
>>
>> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
>>
>> Adds an instance for the library class VariableFlashInfoLib that
>> was recently introduced in MdeModulePkg. This change is made to
>> allow the new variable driver to build that has a dependency on
>> this library class and does not require any further platform
>> changes.
>>
>> Note that this series is for an upcoming change in MdeModulePkg
>> and requires that change to be present locally for testing.
>>
>> https://edk2.groups.io/g/devel/message/88787
>>
>> Cc: Abner Chang <abner.chang@hpe.com>
>> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
>> Cc: Chasel Chiu <chasel.chiu@intel.com>
>> Cc: Daniel Schaefer <daniel.schaefer@hpe.com>
>> Cc: Eric Dong <eric.dong@intel.com>
>> Cc: Gilbert Chen <gilbert.chen@hpe.com>
>> Cc: Graeme Gregory <graeme@nuviainc.com>
>> Cc: Ilias Apalodimas <ilias.apalodimas@linaro.org>
>> Cc: Jeremy Linton <jeremy.linton@arm.com>
>> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
>> Cc: Liming Gao <gaoliming@byosoft.com.cn>
>> Cc: Masami Hiramatsu <masami.hiramatsu@linaro.org>
>> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
>> Cc: Radoslaw Biernacki <rad@semihalf.com>
>> Cc: Sami Mujawar <sami.mujawar@arm.com>
>> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
>>
>> Michael Kubacki (10):
>>    OverdriveBoard: Add VariableFlashInfoLib
>>    BeagleBoardPkg: Add VariableFlashInfoLib
>>    MinPlatformPkg: Add VariableFlashInfoLib
>>    CelloBoard: Add VariableFlashInfoLib
>>    SbsaQemu: Add VariableFlashInfoLib
>>    RaspberryPi: Add VariableFlashInfoLib
>>    U5SeriesPkg: Add VariableFlashInfoLib
>>    Socionext: Add VariableFlashInfoLib
>>    Softiron: Add VariableFlashInfoLib
>>    PlatformStandaloneMmPkg: Add VariableFlashInfoLib
>>
>>   
>> Platform/AMD/OverdriveBoard/OverdriveBoard.dsc                             
>> | 1 +
>>   
>> Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc                     
>> | 1 +
>>   
>> Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc                
>> | 1 +
>>   
>> Platform/LeMaker/CelloBoard/CelloBoard.dsc                                 
>> | 1 +
>>   
>> Platform/Qemu/SbsaQemu/SbsaQemu.dsc                                        
>> | 1 +
>>   
>> Platform/RaspberryPi/RPi3/RPi3.dsc                                         
>> | 1 +
>>   
>> Platform/RaspberryPi/RPi4/RPi4.dsc                                         
>> | 1 +
>>   
>> Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc                 
>> | 1 +
>>   
>> Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc       
>> | 1 +
>>   
>> Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc               
>> | 1 +
>>   
>> Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc                
>> | 1 +
>>   
>> Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc 
>> | 1 +
>>   12 files changed, 12 insertions(+)
>>

Re: [edk2-platforms][PATCH v1 10/10] PlatformStandaloneMmPkg: Add VariableFlashInfoLib

[Ilias Apalodimas]

Thanks for the patches

On Mon, 25 Apr 2022 at 19:06, Sami Mujawar <sami.mujawar@arm.com> wrote:
>
> Hi Michael,
>
> Thank you for this patch.
>
> These changes look good to me.
>
> Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
>
> Regards,
>
> Sami Mujawar
>
> On 20/04/2022 09:44 pm, mikuback@linux.microsoft.com wrote:
> > From: Michael Kubacki <michael.kubacki@microsoft.com>
> >
> > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
> >
> > Adds an instance for the library class VariableFlashInfoLib that
> > was recently introduced in MdeModulePkg. This change is made to
> > allow the new variable driver to build that has a dependency on
> > this library class and does not require any further platform
> > changes.
> >
> > Cc: Sami Mujawar <sami.mujawar@arm.com>
> > Cc: Ilias Apalodimas <ilias.apalodimas@linaro.org>
> > Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> > ---
> >   Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc b/Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc
> > index 33364deb1ef0..653029c52fdb 100644
> > --- a/Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc
> > +++ b/Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc
> > @@ -34,6 +34,7 @@ [LibraryClasses]
> >     ArmLib|ArmPkg/Library/ArmLib/ArmBaseLib.inf
> >     BaseLib|MdePkg/Library/BaseLib/BaseLib.inf
> >     SafeIntLib|MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.inf
> > +  VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf
> >     VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
> >     BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf
> >     DebugPrintErrorLevelLib|MdePkg/Library/BaseDebugPrintErrorLevelLib/BaseDebugPrintErrorLevelLib.inf

Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>