From: "Michael D Kinney" <michael.d.kinney@intel.com>
To: "Jayaprakash, N" <n.jayaprakash@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Rebecca Cran <rebecca@bsdio.com>,
"Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] [edk2-libc Patch 1/1] ek2-libc: writeio function in edk2module.c not working as expected
Date: Sun, 10 Dec 2023 03:12:39 +0000 [thread overview]
Message-ID: <CO1PR11MB492952B0F6252D933F92E9AFD288A@CO1PR11MB4929.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20231209174307.1497-2-n.jayaprakash@intel.com>
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
> -----Original Message-----
> From: Jayaprakash, N <n.jayaprakash@intel.com>
> Sent: Saturday, December 9, 2023 9:43 AM
> To: devel@edk2.groups.io
> Cc: Jayaprakash, N <n.jayaprakash@intel.com>; Rebecca Cran
> <rebecca@bsdio.com>; Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: [edk2-libc Patch 1/1] ek2-libc: writeio function in
> edk2module.c not working as expected
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4619
>
> This commit fixes the issue reported in the BZ4619.
> The order of passing the parameters to IoWrite* functions
> called within writeio function in edk2module.c has been corrected
> Also verified the changes by writing reset command to 0xCF9 port
> using writeio function in edk2module.c
>
> Cc: Rebecca Cran <rebecca@bsdio.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Jayaprakash N <n.jayaprakash@intel.com>
> Signed-off-by: Jayaprakash N <n.jayaprakash@intel.com>
> ---
> .../Python/Python-3.6.8/PyMod-3.6.8/Modules/edk2module.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/AppPkg/Applications/Python/Python-3.6.8/PyMod-
> 3.6.8/Modules/edk2module.c b/AppPkg/Applications/Python/Python-
> 3.6.8/PyMod-3.6.8/Modules/edk2module.c
> index 8786df8..d6af8da 100644
> --- a/AppPkg/Applications/Python/Python-3.6.8/PyMod-
> 3.6.8/Modules/edk2module.c
> +++ b/AppPkg/Applications/Python/Python-3.6.8/PyMod-
> 3.6.8/Modules/edk2module.c
> @@ -3985,9 +3985,9 @@ edk2_writeio(PyObject *self, PyObject *args)
>
> Py_BEGIN_ALLOW_THREADS
> addrs = (short)(addr & 0xffff);
> - if (1 == sz) IoWrite8((unsigned char)(value & 0xFF), addrs);
> - else if (2 == sz) IoWrite16((unsigned short)(value & 0xFFFF), addrs);
> - else if (4 == sz) IoWrite32(value, addrs);
> + if (1 == sz) IoWrite8(addrs, (unsigned char)(value & 0xFF));
> + else if (2 == sz) IoWrite16(addrs, (unsigned short)(value & 0xFFFF));
> + else if (4 == sz) IoWrite32(addrs, value);
> Py_END_ALLOW_THREADS
>
> Py_INCREF(Py_None);
> --
> 2.40.0.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112256): https://edk2.groups.io/g/devel/message/112256
Mute This Topic: https://groups.io/mt/103077058/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
prev parent reply other threads:[~2023-12-10 3:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-09 17:43 [edk2-devel] [edk2-libc Patch 0/1] writeio() edk2module not working as expected Jayaprakash, N
2023-12-09 17:43 ` [edk2-devel] [edk2-libc Patch 1/1] ek2-libc: writeio function in edk2module.c " Jayaprakash, N
2023-12-10 3:12 ` Michael D Kinney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO1PR11MB492952B0F6252D933F92E9AFD288A@CO1PR11MB4929.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox