From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 745A9940F32 for ; Sun, 10 Dec 2023 03:12:47 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=nsQ2tCwmOAKV0X4+VQ/6DLatTKGXcxnOTXxyn4lcH5k=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1702177966; v=1; b=h3LPyVNKJZIZcfaB4A2BEm+ezj3ts07IbI++d50aHa9oTYyXPImlg73SOuo8k6Z9nThVXvt+ kWXIOyP9MXpQz+IMdUMDp2ABbMexZ8ihJpT3uNzP83+AOQpFtS3mItaRBAzYoFKtXJvc+wx26cr TE0wbEAABQPPbGG+YWy/a4x8= X-Received: by 127.0.0.2 with SMTP id spVcYY7687511x2obFZcr3YW; Sat, 09 Dec 2023 19:12:46 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web10.41134.1702177964788661667 for ; Sat, 09 Dec 2023 19:12:45 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10919"; a="461007776" X-IronPort-AV: E=Sophos;i="6.04,264,1695711600"; d="scan'208";a="461007776" X-Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Dec 2023 19:12:43 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10919"; a="843046489" X-IronPort-AV: E=Sophos;i="6.04,264,1695711600"; d="scan'208";a="843046489" X-Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga004.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 09 Dec 2023 19:12:43 -0800 X-Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Sat, 9 Dec 2023 19:12:43 -0800 X-Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Sat, 9 Dec 2023 19:12:43 -0800 X-Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Sat, 9 Dec 2023 19:12:43 -0800 X-Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.41) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Sat, 9 Dec 2023 19:12:42 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nVvM3RjcEn1/DzDzXRVH213dKUNE+oq0957gSw5MGgIcWecso5nB4ODLppqBpGJ+xNpy3zB700Y2t1sUtI+CEAALuE8S8JZ28anFcPr+4v4T1Gc6kl132FmmdOVGkPLqGdgHryd7ntQW24wuR23fwEzIg/r8+Yvrqe15GV5iwYj0OX5S4ZUEXLXr+NgDVzhLfKappaiVwqt5yMelIGDu8JHECQzeKEKCd+iyORzFPp9wYcAt1wnzBo2tHFax5VmChi+sOgFkUC2+dHEfKNQ5rHrMttFub293GrgHwRwosVPBVBmcbB2Tlc1D6kCcZfBdLQ0QUHgwfrQ5fkJYaBnFew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rwgHucbyk5Zhv+cUZ6iAieKjekJASgUhJdKNE9DwO8k=; b=crm2I0EPFB8iXTsCdWllKrCENQA8mYOVenOYbMMWhxYV6WKF5QnDlQE96UOmiER2eLIaRcO6upi1O1p7ysEagRsSkSBSO6kP8allYRedLj7kLW/g1TYX9nH6IMnsFYj0piIGD+kI7RN2SEc6PO3sHaqtBMvCh6dA9Pu7jinLlp9vMtZryxMHfF73Y/wWvUeLbPEb8iF+3hq+1DjMZaX/o10cXJmy4c+I1PFVnUAz5cZ95vyEVnY35jhwzvcCCglYDT+b85lONxBMj3KFddEfHCzICNDI1R0g8JRs8HwcYqmwShjCGAGdWQBfxNreocxh+r9FNbbYLp6cC1+xuLIo/g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com (2603:10b6:303:6d::19) by PH8PR11MB6780.namprd11.prod.outlook.com (2603:10b6:510:1cb::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.30; Sun, 10 Dec 2023 03:12:40 +0000 X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::4382:5b03:f13:88ff]) by CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::4382:5b03:f13:88ff%4]) with mapi id 15.20.7068.030; Sun, 10 Dec 2023 03:12:39 +0000 From: "Michael D Kinney" To: "Jayaprakash, N" , "devel@edk2.groups.io" CC: Rebecca Cran , "Kinney, Michael D" Subject: Re: [edk2-devel] [edk2-libc Patch 1/1] ek2-libc: writeio function in edk2module.c not working as expected Thread-Topic: [edk2-libc Patch 1/1] ek2-libc: writeio function in edk2module.c not working as expected Thread-Index: AQHaKsc65Q4Z7mh1HkGveeuEL/dYprCh19EA Date: Sun, 10 Dec 2023 03:12:39 +0000 Message-ID: References: <20231209174307.1497-1-n.jayaprakash@intel.com> <20231209174307.1497-2-n.jayaprakash@intel.com> In-Reply-To: <20231209174307.1497-2-n.jayaprakash@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO1PR11MB4929:EE_|PH8PR11MB6780:EE_ x-ms-office365-filtering-correlation-id: df876cb7-d366-4a44-b722-08dbf92dddd9 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: dMtsHSqHS37/mMpYyGUlaBe7Mw4a2vkUKzQPw1PqMIwJ08EC150BEdbdpkm5CNafWlVvmNAMRQjtWL6Ng79bdoDmHP5z1rAAdQMPAlrhdNzYFFAF8skgNoyWqm6OluiPMRVmIV07VymNz8aWzvN6FQwzI1RPO3q2CXr8LnQ1BCJx7p47+XoY+7lovc5qM6IbpU5FGh3B/agpWV+BTVf54aMbq2u0fK+IzaiKHg5QB6wMlp8YdvXUCa5nvTE0VJO6UcX7Qh/fMaPbzxEepmx+OfUDyAe+zIEl/GyJh6hj6z7yfoQ3nS0MLdjUZEX/C5N5LRiaxep8VA2ydQQnP25jmcW0MvVkK/+uXi3m7qsL9EBqf/vZhSMbeW8cYaA3U6X4r8OGyvYZCI9wBDLTwh1buSdi/7Cy/S8pKNrL8xbEOVbneslcBhFge2IXdX5yLJkmCTBLIoaN7sSNf9wBpsiMiZy8hbrV6zeW2tUNoNw2Uz3mdl6ApjVSS67y9JDGhGG6WOHeHqo6daABqDBEhRHKZeMiDeJggVJ4fko9o4QfhfDreGiEG7LaIi/s/6dOwbWt/uvUAO0TJh9447eFLUrimMD5VIW6xJpAJELY16dfgrc= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?+RMcFb9DWfeZc8ECIVDgIOjKF8JToRwYMYxKtxdO77luG0LnXJGoLX0QX1W8?= =?us-ascii?Q?W5DXE9uaYDk3tgE/UDgyKnvC4/oNy9nPuzkYWgrzf0JRkmnRXgxmI2sxgHLy?= =?us-ascii?Q?Uhj0TDelnu6aj0QedttAU2hw4yYIKtsDmjpO35Fi89mXaINaN94kTOifUE7X?= =?us-ascii?Q?eLZKZHOzNayVVAVZZXwnlg8fzJkcutWTE4tKqMKBydmXtEaA1d7KJ5wcKs62?= =?us-ascii?Q?yeuZzeGdihbCapfP10TKiGHRDn8cWjPbc/k3DFc6Ri2nGac/r4jQhHNysjSm?= =?us-ascii?Q?yQ4/YXpHuVB1w9TmaKLi2ZOQZE/ezeK1Zs9euEQQhqNQNeKQ288FCxlZEn7f?= =?us-ascii?Q?acNGJaSGRRAlwGsRvvg/dZnVwjGpIHyT2FxjaYMAPAouX/IEN05UvdbpyW7B?= =?us-ascii?Q?+w5MPSGn92IGyRz4q6zBD3CBKjhqnqc0cVdHDQyER3XyILptXWlbyqzRyNis?= =?us-ascii?Q?KzZN9QkYo2IzFlGFY5n4OA6bUc6MTiLqGAhOMheJAxCEV2FI7N4RfGNy3LTi?= =?us-ascii?Q?JYcQ4pWrtjD+3IOMItR8q7MD2/Cvf2zI4MweDsj0aHynatJkWdwKzFSh+uuS?= =?us-ascii?Q?dtgK7OUMdka+lGGgETDQznHONgHDzr78uNX+f/lHkGhPxQ2YfvNCzAMmIKlq?= =?us-ascii?Q?dBGiJU+Q/2VGCoyWK74Io7sQ7fArp3N8iUs/EzrxsTIhIcEy3pGaqMPs5Pr0?= =?us-ascii?Q?aGn2zLjNlnzocpHVIpNZSXlztxFNl56JPhXqVVeBNQsABuw2wjHPVqYx8rgf?= =?us-ascii?Q?dJfHT2bsEpSBsbs5FY+5HchT6grzyjiiwxklpB9gsb4eCdLTdJ9xe4Yq8as1?= =?us-ascii?Q?yHH2GGdAMRj1buXCVa8J1w0YCZBjM1cpfPXTM8GLKmbOgzpH53L4LprOz5xV?= =?us-ascii?Q?rgoETfn3iSPhG6+gUhQfMMrUdEwqoiCTIw7Qb2TxrIyMAcBsUXixYwj3jT5R?= =?us-ascii?Q?QxIsTt8TGtUNxWo438/uca5DygqdILv7Uelqq2y5FSN9XwlIw6Gm/eGIRpnO?= =?us-ascii?Q?gpDrahHBAMM+Y8+C/CYeKa9T3lryzIpRPK2+EeJsANuRb8ClHAzi6R5jItNO?= =?us-ascii?Q?6CQJS7uC3f+iKjUUD0cneg8iz5hCKgMXWq+5kNp4SvHxDErjCsuOD+BmT3j2?= =?us-ascii?Q?+PrPDt6Ve3nvRh4SGC0z+k5bPqJ5FB/dniBpn7lXD+5GKf5KZSZO6plNEHOq?= =?us-ascii?Q?3fRuv0zJjk6vTUq3EtDH5kFUbiANJHJIgd0PRfcWjGDnWzVtwfjD4T0PDpvF?= =?us-ascii?Q?DMRlZ8URqpbjywI4TG7uoS9pk4WoP95Ar8P+Jm3E8JdzjeSuMnNmL4dlKGWo?= =?us-ascii?Q?ZI0TPNZEpC2qFtHqH2OA96/u0b9gLPeUQAAYlPI8dA8hc7LSPAcn0XfHG6KD?= =?us-ascii?Q?3EPHbi8arofiUS3cugGTbDTBHKS8fERLZ67Z04MyjvpEHPLWXR1dlI+p7FYS?= =?us-ascii?Q?Fkv0RPj2o6wQte5tX2XNCoqXQB0xVH0+GnID17BlX9OQkny6bbGP2ng1VEq8?= =?us-ascii?Q?KI3tLlqCWMv/4oB3E+Xlbjlsfv2WxBP2gI7AGjpJNFfD0mlgchCsUh0HGE/i?= =?us-ascii?Q?3yBQ70eKRgky40W5s0FKWak9vjKp7zZ2bayBfmqa?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4929.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: df876cb7-d366-4a44-b722-08dbf92dddd9 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Dec 2023 03:12:39.3630 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: EO4XXagSndrRS8f5lStukN9j64VFBacaMlhAQpFuvuhGJwGyJTXYs6625+CyndeAq0Dfx4xKVh8OG9HBA8+0wvHc9FzveonJTX69RZ6BD4g= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB6780 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,michael.d.kinney@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 1UYNzK96eggMyvtrpfj0bvdZx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=h3LPyVNK; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Reviewed-by: Michael D Kinney > -----Original Message----- > From: Jayaprakash, N > Sent: Saturday, December 9, 2023 9:43 AM > To: devel@edk2.groups.io > Cc: Jayaprakash, N ; Rebecca Cran > ; Kinney, Michael D > Subject: [edk2-libc Patch 1/1] ek2-libc: writeio function in > edk2module.c not working as expected >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4619 >=20 > This commit fixes the issue reported in the BZ4619. > The order of passing the parameters to IoWrite* functions > called within writeio function in edk2module.c has been corrected > Also verified the changes by writing reset command to 0xCF9 port > using writeio function in edk2module.c >=20 > Cc: Rebecca Cran > Cc: Michael D Kinney > Cc: Jayaprakash N > Signed-off-by: Jayaprakash N > --- > .../Python/Python-3.6.8/PyMod-3.6.8/Modules/edk2module.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/AppPkg/Applications/Python/Python-3.6.8/PyMod- > 3.6.8/Modules/edk2module.c b/AppPkg/Applications/Python/Python- > 3.6.8/PyMod-3.6.8/Modules/edk2module.c > index 8786df8..d6af8da 100644 > --- a/AppPkg/Applications/Python/Python-3.6.8/PyMod- > 3.6.8/Modules/edk2module.c > +++ b/AppPkg/Applications/Python/Python-3.6.8/PyMod- > 3.6.8/Modules/edk2module.c > @@ -3985,9 +3985,9 @@ edk2_writeio(PyObject *self, PyObject *args) >=20 > Py_BEGIN_ALLOW_THREADS > addrs =3D (short)(addr & 0xffff); > - if (1 =3D=3D sz) IoWrite8((unsigned char)(value & 0xFF), addrs); > - else if (2 =3D=3D sz) IoWrite16((unsigned short)(value & 0xFFFF), addr= s); > - else if (4 =3D=3D sz) IoWrite32(value, addrs); > + if (1 =3D=3D sz) IoWrite8(addrs, (unsigned char)(value & 0xFF)); > + else if (2 =3D=3D sz) IoWrite16(addrs, (unsigned short)(value & 0xFFFF= )); > + else if (4 =3D=3D sz) IoWrite32(addrs, value); > Py_END_ALLOW_THREADS >=20 > Py_INCREF(Py_None); > -- > 2.40.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112256): https://edk2.groups.io/g/devel/message/112256 Mute This Topic: https://groups.io/mt/103077058/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-