Mergify is no longer auto closing personal Github PRs

Mergify is no longer auto closing personal Github PRs

[Rebecca Cran]

I noticed that Mergify is no longer auto closing personal builds: for 
example https://github.com/tianocore/edk2/pull/2026 is still open.

Compare that to https://github.com/tianocore/edk2/pull/1708 where 
mergify commented "All checks passed. Auto close personal build."


-- 

Rebecca Cran

Re: Mergify is no longer auto closing personal Github PRs

[Michael D Kinney]

Hi Rebecca,

Yes.  This is the new behavior after changes were added in July 9, 2021.

    https://github.com/tianocore/edk2/commit/b491eace373ea3fa435a0136db3c38e0360e6f11#diff-a3528dea46dcf4932a9c3dfdd1a9e320daeed9256f3906d4174915470add4189

    .mergify: Simplify Mergify rules using GitHub status checks

    * Enable Mergify queue feature to support auto rebase when
      'push' label is set and gauarntee that all EDK II CI checks
      are run before merging in changes with linear history.
    * Use status checks configured in GitHub branch protections
    * Allow non EDK II Maintainers to create a PR
      Requires an EDK II Maintainer to accept the change and
      request merge by adding 'push' label.  Only EDK II Maintainers
      have ability to set/clear labels.
    * Do not automatically close PRs for personal builds.

    Cc: Liming Gao <gaoliming@byosoft.com.cn>
    Cc: Sean Brogan <sean.brogan@microsoft.com>
    Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
    Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
    Acked-by: Bret Barkelew <bret.barkelew@microsoft.com>
    Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

Developers that submit personal builds are responsible for closing 
them if they are no longer required.  This allows the same PR to be
used if the developer wants to fix issues on the same branch.

We will likely have to do periodic review to close PRs that are left
open for an extended period of time.

Mike

> -----Original Message-----
> From: Rebecca Cran <rebecca@bsdio.com>
> Sent: Tuesday, October 5, 2021 8:24 AM
> To: devel@edk2.groups.io; Leif Lindholm <leif@nuviainc.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Andrew Fish
> <afish@apple.com>
> Subject: Mergify is no longer auto closing personal Github PRs
> 
> I noticed that Mergify is no longer auto closing personal builds: for
> example https://github.com/tianocore/edk2/pull/2026 is still open.
> 
> Compare that to https://github.com/tianocore/edk2/pull/1708 where
> mergify commented "All checks passed. Auto close personal build."
> 
> 
> --
> 
> Rebecca Cran
>