Re: [edk2-devel] [PATCH V4] MdeModulePkg/Pci: Display more information of PCIe devices

["Michael D Kinney" <michael.d.kinney@intel.com>]

Acked-by: Michael D Kinney <michael.d.kinney@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ni, Ray
> Sent: Monday, February 13, 2023 6:18 PM
> To: devel@edk2.groups.io; abner.chang@amd.com
> Cc: Wu, Hao A <hao.a.wu@intel.com>; Garrett Kirkendall <garrett.kirkendall@amd.com>
> Subject: Re: [edk2-devel] [PATCH V4] MdeModulePkg/Pci: Display more information of PCIe devices
> 
> Reviewed-by: Ray Ni <ray.ni@intel.com>
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Chang,
> > Abner via groups.io
> > Sent: Thursday, January 12, 2023 1:14 PM
> > To: devel@edk2.groups.io
> > Cc: Wu, Hao A <hao.a.wu@intel.com>; Ni, Ray <ray.ni@intel.com>; Garrett
> > Kirkendall <garrett.kirkendall@amd.com>; Abner Chang
> > <abner.chang@amd.com>
> > Subject: [edk2-devel] [PATCH V4] MdeModulePkg/Pci: Display more
> > information of PCIe devices
> >
> > From: Abner Chang <abner.chang@amd.com>
> >
> > In V4: Update the copyright to 2023.
> > In V3: Add AMD copyright.
> > In V2: Remove the signed-off-by: Abner Chang
> >
> > Display PCIe Vendor ID and Device ID in DEBUG message.
> >
> > Signed-off-by: Jiangang He <jiangang.he@amd.com>
> > Cc: Hao A Wu <hao.a.wu@intel.com>
> > Cc: Ray Ni <ray.ni@intel.com>
> > Cc: Garrett Kirkendall <garrett.kirkendall@amd.com>
> > Cc: Abner Chang <abner.chang@amd.com>
> > ---
> >  MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c | 7 +++++--
> >  1 file changed, 5 insertions(+), 2 deletions(-)
> >
> > diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> > b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> > index 8eca8596958..6594b8eae83 100644
> > --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> > +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> > @@ -3,6 +3,7 @@
> >
> >  Copyright (c) 2006 - 2021, Intel Corporation. All rights reserved.<BR>
> >  (C) Copyright 2015 Hewlett Packard Enterprise Development LP<BR>
> > +Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.<BR>
> >  SPDX-License-Identifier: BSD-2-Clause-Patent
> >
> >  **/
> > @@ -227,13 +228,15 @@ PciSearchDevice (
> >
> >    DEBUG ((
> >      DEBUG_INFO,
> > -    "PciBus: Discovered %s @ [%02x|%02x|%02x]\n",
> > +    "PciBus: Discovered %s @ [%02x|%02x|%02x]  [VID = 0x%x, DID =
> > 0x%0x]\n",
> >      IS_PCI_BRIDGE (Pci) ?     L"PPB" :
> >      IS_CARDBUS_BRIDGE (Pci) ? L"P2C" :
> >      L"PCI",
> >      Bus,
> >      Device,
> > -    Func
> > +    Func,
> > +    Pci->Hdr.VendorId,
> > +    Pci->Hdr.DeviceId
> >      ));
> >
> >    if (!IS_PCI_BRIDGE (Pci)) {
> > --
> > 2.37.1.windows.1
> >
> >
> >
> >
> >
> 
> 
> 
> 
>