From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 39CA3AC1B49 for ; Thu, 18 Jan 2024 20:04:35 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=AggGR4wZtK72P9oFJhu2/R2mQmy57lupph+6PtoNbxw=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1705608274; v=1; b=jYQQHe6oUajirIQM/cqWCtnahtF8Tivp1FqFff9wv25LM5iYWaZYhZ6nNYA75KA5xeqdSNbJ Xtha0RJnJsXkJerH2wmMrWNgyoECTirYhfOlH1O7ThgAT0UFufFZVxe6OuKhhI5Id6fW6E9KaPn IklffEo9iVbMf0KRN65Xrznc= X-Received: by 127.0.0.2 with SMTP id jtkoYY7687511xMC2R18VKtA; Thu, 18 Jan 2024 12:04:34 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web11.3332.1705608273177611141 for ; Thu, 18 Jan 2024 12:04:33 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10956"; a="464837141" X-IronPort-AV: E=Sophos;i="6.05,203,1701158400"; d="scan'208";a="464837141" X-Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jan 2024 12:04:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10956"; a="818869898" X-IronPort-AV: E=Sophos;i="6.05,203,1701158400"; d="scan'208";a="818869898" X-Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga001.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 18 Jan 2024 12:04:32 -0800 X-Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 18 Jan 2024 12:03:14 -0800 X-Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 18 Jan 2024 12:03:14 -0800 X-Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.168) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 18 Jan 2024 12:02:36 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cUKb2jZlPFmC7TmtrBqTg/FDMRsKOxNtF2GCAlib+fZ3DesUHuxuKESdjHKkLaJHe4TwuDX1CdEZKX+zvZrsvntiwbdn4pr3deQTpUlg58K1huxV/yJyqSbZvU+y8GXZMPxU3Sz9hagUAOsba610/hkbQHbe3EGzE6gOHhCYyrIH8DPAnxhMSkkzSXKFnavoRq4u45FuV8enZCEp7Hpsoc12Pm0uAB9jB1Vt1qUgDEqUlu6cKV6pddRlzuZNaDBIfSlJCI5K8k4AqfmXxSMHWznNLt3IdHLuo/vFH0J+BmhCrrKMA2hMEmDoixTpnFK3AosnV5QmVuunSMv1qziWbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=227ZefGlbAYtY3HVVpCGtBX5/eVS659Vc4wIvvTLFyA=; b=DTTzETv833eJhrF5CSMus6fOPWi111BIiL2kHnsyVjbjB/xLk2jXpErhX1pQlmAwr5BCG0RT0r4PFsV/nR5p1OBwrKPlxn9W/AIMttvINiLVGavXeFNuwDikjYNBQLcUEMtO1ZAtXnqBPAAfI1+Ax35wtxljZtTbNkLNkEsMa4gpqcS2SLrW/9bBElvdvWKaEI3rWB3kjo3TBA6t5t0SZNfdyRMsfPdAnH5xOITxrDepZrdChR71s0+K3xXV01vjoywV9a5nlIMBdPeUVQXjyaZzE8AJis6fvdXk13F9MofNsyb2RVFGJqXfhfTfkpk6CUOXRwjPsCPT7qkHw4vTaw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com (2603:10b6:303:6d::19) by CYYPR11MB8330.namprd11.prod.outlook.com (2603:10b6:930:b8::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7202.23; Thu, 18 Jan 2024 20:02:34 +0000 X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::4382:5b03:f13:88ff]) by CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::4382:5b03:f13:88ff%4]) with mapi id 15.20.7202.024; Thu, 18 Jan 2024 20:02:34 +0000 From: "Michael D Kinney" To: "Pethaiyan, Madhan" , "devel@edk2.groups.io" CC: "Gao, Liming" , "Xu, Wei6" , "Tan, Ming" , "S, Ashraf Ali" , "Kinney, Michael D" Subject: Re: [edk2-devel] [PATCH V2] FmpDevicePkg: GetImageInfo Add missing condition Thread-Topic: [PATCH V2] FmpDevicePkg: GetImageInfo Add missing condition Thread-Index: AQHaQf3ri8yJvnyzKkqDxn26CDrvubDfVK8AgAC5xiA= Date: Thu, 18 Jan 2024 20:02:33 +0000 Message-ID: References: <2d53b710572890495a268f208027c8de1e9b7fea.1704696138.git.madhan.pethaiyan@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO1PR11MB4929:EE_|CYYPR11MB8330:EE_ x-ms-office365-filtering-correlation-id: bcdc665c-69f2-45c7-7935-08dc18606924 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: YNZPbrM6t1EACbB30TIJHXjTyl5aRZgf5MdKFsELXQsQ0cqHEppd4o1/dtH4PXxydyvcV2if38RxFW88560HwclbGtrlG56UFQdUwu0dTRi3Ls3kSb6fb++UIiAyDuOBwk6iG79KEkEkPNGRuYDbkK+vrX1eF9nKvRZiZuP82SemTE2DOD3bZ+ReteJn0gUUJb92hIG/MRf4/cXcW6pK47N9w6PRYrWEJb5nubSXpgViujctksAzDD4kT6OcjvMsE0A7wZ91yK7h18HjnhPOggVhw1Y7BthLPmJSHqpMpwPmvL3IxuZ4uQmsZQDfMGK/mPLZGcoZTWEcyoI6nhd11MIb7eFc7KVuZm/FsgGfbDk8aoMmgqL8P7505bHgyq/CrXC+4NsWki0Iqv3RsSb7fdk72PAg7ESNGoKKpSGy03FE00DkzPuZ5zo/DfMMZs67yJuXRMNKAptAlmc+0xCEqDg46FPLijciNn1joAHMgEzC7uBjHD+AD4sr66SFQqW9zv/KYUo3uPDNvaQvS4DvBWKEvvjgkxKYfEYEBzLYclqJYudf0rikxVRoIj6ODY47Aa/TQ2FYvI5ineYQv/KpJs7/liGvjRX9cUYJ452VJbDOms22+4XfynQnktWAC6Ar x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?COjI2jY5xyc15OHYjPy3gRWneuXtiFA4g+dgWRyis6fkBbLA2E2GpKklfmG6?= =?us-ascii?Q?8cBdQEJYaEbZT6YnwufypKXS/+M7sOpJMvyr+mG5SumK2tTU77mbM8U7pvOm?= =?us-ascii?Q?Sc550FGH7MTT8w2YJrozMs7XeSt/AE7hhCRorduqT2gin0LmbInneDq4EfoX?= =?us-ascii?Q?oOrpLD5dEovGPftmUZ/NfwpEz78ywaPJGWx1lPlVC/2+nCUWLvYFnF/MZMbE?= =?us-ascii?Q?cmVLJsL+sr7730gJXf+KRSOxQQfaCwFIA126HBoTPp+pK/EN58zcZfvm8l8B?= =?us-ascii?Q?YepPl2ICcHlZPbfMQUKHDDzxFgL/ImzEVH50+Br59FHuqpgKQkQf9SxyMeRi?= =?us-ascii?Q?zYx1Hhn6zW0AMS+OMsnIQvF2QY+KBjaHiQpoTQQf49xt6oFhq574eFoq0dI4?= =?us-ascii?Q?Lu8X88Gdznx1j0r0xNmM4sn/2RXltQDh2XTqR9r9OjPjf2NrldyUTYRNew1S?= =?us-ascii?Q?G6EKTrmh8x6zqZV3zjKe03/8HbOav+UDwfXGA+f+TF4wfzYXm8FA6Lfh4lvo?= =?us-ascii?Q?tCtdKtirwzaWHzR3BG3nTTvBksn5CniFX4ipKqzREfHmHOmpLYTuqeO0r2gR?= =?us-ascii?Q?PhyYbBdk/w/ZDjGLUHMroeFe4bL6JKs/NslnBiKnG6IUEYcaRUh8YhjmYWf7?= =?us-ascii?Q?Pydv8Irit8ctIs+VbdIUsnO7a8Ut9VU/bqRG+uFZUU/o/pfMdxV3SmLzGhEf?= =?us-ascii?Q?yS3A7uQe803CylHd7Tdg+vNSDsTsF/3xUWNdnnyGz6zTNIXT1d/RoNnE/ELy?= =?us-ascii?Q?8q3r1uMxE+gDjZdVvsQYQNATjKknEKdB+VZTQQBqc2bGlWRXmScfFfmX4VHt?= =?us-ascii?Q?RiSn5bmcIFSWbriSb0WIuNOA05yfZfNftJvCvLpfzfI1ZGEja5s+DddIVXRN?= =?us-ascii?Q?rNUWP/uUzO3RqbWeonjjnLUSH945bNd5jF2cVyq9R2nd7bER1bqYnk+2BorD?= =?us-ascii?Q?ToGwA77+VtlFDRCYlcLE3vLCnWorGoI/8zYXQyVhC8Y4KaWCtoIvX+WQrfAH?= =?us-ascii?Q?4q2upJG1a1Nu+ChVTQoe69EdE4tmtJwDh9JsfSFAh7n0u1Wet9UOMvhU731P?= =?us-ascii?Q?0TRIhkblBqnzaE/cvlkxxtLNhYtpeSnAJJtn0pjVZeIn62D8LklAARdhKjH6?= =?us-ascii?Q?LGTnL8+T9xNCAzLF3GjHydtKkQ9JGz30EVJZpXfxVQtBlCr5mMngMs7gQLI1?= =?us-ascii?Q?BWvapsOFkC9pkO6JF3rTru40jLiy5wF8uIAOWuIyHXW4ytI3qH5jisWY1M8E?= =?us-ascii?Q?nlXz2JdDlITdf5Udh+QgfQuOUNyTUnyMkn8cTROC3OFv/abqSdptW3nxy7ya?= =?us-ascii?Q?meeN7yk0bybMCe7P58J+MTPmtIsukauJaTxcguD3p7aj8b+ZpNvjSRMYxNjz?= =?us-ascii?Q?ff1iimGjP2YHwpCRFrrPKZIPQzgwAaq3lhlXQq9wPdhifd282R3nj9rRUbqb?= =?us-ascii?Q?S/nnSagfwi2FICx5qZl57gqCUy5rW6d5nMX7LA99TaGUCuYB+kYLX+32ICM7?= =?us-ascii?Q?COrd9CbiImhxKfP91SkjbPL80/VxTksfIYL9y4U9BCh7wMmyRcCK+ZDVjiSx?= =?us-ascii?Q?GlRlacjwvoG+v+w0B8aXZvjHY/W4EKhb+L2+qjHhtUagbKiw2/WmzrsTl93c?= =?us-ascii?Q?dQ=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4929.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bcdc665c-69f2-45c7-7935-08dc18606924 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jan 2024 20:02:33.9177 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ATMlYYMx2G5VZK1pCdHblmnaxMFSGuQ+PlVwLevM01RfrzQXw7jzeRjM6VeZjh+H+7loOl9FMh5ynGN+qo2w3q8au5J4DWdI0ogVYHdYFIY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYYPR11MB8330 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,michael.d.kinney@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 9PFHqxwtMmIZvs2pQXsY1JGUx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=jYQQHe6o; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Reviewed-by: Michael D Kinney > -----Original Message----- > From: Pethaiyan, Madhan > Sent: Thursday, January 18, 2024 12:57 AM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Kinney, Michael D > ; Xu, Wei6 ; Tan, Ming > ; S, Ashraf Ali > Subject: RE: [PATCH V2] FmpDevicePkg: GetImageInfo Add missing condition >=20 > Hi All, >=20 > I had corrected the description, added the UEFI spec version and section > details . Please check and approve it >=20 > Thanks, > P. Madhan >=20 > -----Original Message----- > From: Pethaiyan, Madhan > Sent: Monday, January 8, 2024 12:13 PM > To: devel@edk2.groups.io > Cc: Pethaiyan, Madhan ; Gao, Liming > ; Kinney, Michael D > ; Xu, Wei6 > Subject: [PATCH V2] FmpDevicePkg: GetImageInfo Add missing condition >=20 > From: "Pethaiyan, Madhan" >=20 > UEFI Spec 2.10 , 23.1 Firmware Management Protocol , Added missing > condition check under GetImageInfo function, if the PackageVersionName > is NULL return EFI_INVALID_PARAMETER >=20 > Signed-off-by: Pethaiyan Madhan > Cc: Liming Gao > Cc: Michael D Kinney > Cc: Wei6 Xu > --- > FmpDevicePkg/FmpDxe/FmpDxe.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/FmpDevicePkg/FmpDxe/FmpDxe.c b/FmpDevicePkg/FmpDxe/FmpDxe.c > index 1e7ec4a09e..e87094f84c 100644 > --- a/FmpDevicePkg/FmpDxe/FmpDxe.c > +++ b/FmpDevicePkg/FmpDxe/FmpDxe.c > @@ -495,7 +495,7 @@ GetTheImageInfo ( > // Confirm that buffer isn't null > // > if ( (ImageInfo =3D=3D NULL) || (DescriptorVersion =3D=3D NULL) || > (DescriptorCount =3D=3D NULL) || (DescriptorSize =3D=3D NULL) > - || (PackageVersion =3D=3D NULL)) > + || (PackageVersion =3D=3D NULL) || (PackageVersionName =3D=3D NULL)= ) > { > DEBUG ((DEBUG_ERROR, "FmpDxe(%s): GetImageInfo() - Pointer > Parameter is NULL.\n", mImageIdName)); > Status =3D EFI_INVALID_PARAMETER; > -- > 2.38.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114009): https://edk2.groups.io/g/devel/message/114009 Mute This Topic: https://groups.io/mt/103620853/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-