Re: [PATCH v3 0/4] UncrustifyCheck Ignore Support

["Michael D Kinney" <michael.d.kinney@intel.com>]

Series Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>



> -----Original Message-----
> From: mikuback@linux.microsoft.com <mikuback@linux.microsoft.com>
> Sent: Friday, April 1, 2022 2:58 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Sean Brogan
> <sean.brogan@microsoft.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>; Yao,
> Jiewen <jiewen.yao@intel.com>; Justen, Jordan L <jordan.l.justen@intel.com>; Gerd Hoffmann <kraxel@redhat.com>; Rebecca
> Cran <rebecca@bsdio.com>; Peter Grehan <grehan@freebsd.org>; Laszlo Ersek <lersek@redhat.com>
> Subject: [PATCH v3 0/4] UncrustifyCheck Ignore Support
> 
> From: Michael Kubacki <michael.kubacki@microsoft.com>
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3880
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3875
> 
> This patch series:
> 1. Updates ignore handling in UncrustifyCheck including adding
> a new CI plugin configuration option to ignore files in a package.
> 2. Reverts Uncrustify changes as requested for files in OvmfPkg.
> 3. Uses the new ignore file option to ignore the files that had
> Uncrustify formatting reverted in OvmfPkg.
> 
> V3 Changes:
> 1. [2/4] Replace "nofile.txt" placeholder value passed to
>    parse_gitignore_lines() with a more generic file description
>    and a comment to provide additional context.
> V2 Changes:
> 1. [1/4] Normalize file paths returned from
>    UncrustifyCheck._get_git_ignored_paths()
> 
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Rebecca Cran <rebecca@bsdio.com>
> Cc: Peter Grehan <grehan@freebsd.org>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> 
> Michael Kubacki (4):
>   .pytool/Plugin/UncrustifyCheck: Update func to return absolute paths
>   .pytool/Plugin/UncrustifyCheck: Add ignore file support
>   OvmfPkg: Revert Uncrustify formatting in VbeShim.h files
>   OvmfPkg: Do not check VbeShim.h formatting with Uncrustify
> 
>  .pytool/Plugin/UncrustifyCheck/Readme.md          |    7 +
>  .pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py |   40 +-
>  OvmfPkg/Bhyve/BhyveRfbDxe/VbeShim.h               | 1811 ++++++++++----------
>  OvmfPkg/OvmfPkg.ci.yaml                           |    5 +
>  OvmfPkg/QemuVideoDxe/VbeShim.h                    | 1389 ++++++++-------
>  5 files changed, 1650 insertions(+), 1602 deletions(-)
> 
> --
> 2.28.0.windows.1