From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web10.113287.1683564862129120232 for ; Mon, 08 May 2023 09:54:22 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=MwIvThns; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: michael.d.kinney@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1683564862; x=1715100862; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=jteay7UthWH1RXMqdI/b8iyPbgsPsN3Zcxc1tjhFyUw=; b=MwIvThnsBWjgS4mGL7k0elhhr7B/s7X1UzbwXJHMYOB5y27G0NKmLTll dPQEZj2pMP3yW6V1KzI1QYl0gqm9G9JHc7Xm/hsvT7GlrEg7r8w1Scd+Z BN0KDPRf4btyV1WIvgBC967/nobCcmeDGyYrN6q/kFxospT06rbfYFFdK etayDdtcbCHxcNmM/639elx2mDuLovaWeRWSqSyDqnUUR9QWuEHXttzp6 OYu67a84fcjMqC/MdL1/WWGjiZpBpoE0sk4NQTOE58SMVrVnmc4j6mV8g 4v0I84pu3cCoFrrGEAGp7rEvihjiLOuw8oA2TEJoL/rcZ4x8f+8vF18I0 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10704"; a="347168021" X-IronPort-AV: E=Sophos;i="5.99,259,1677571200"; d="scan'208";a="347168021" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 May 2023 09:54:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10704"; a="698591278" X-IronPort-AV: E=Sophos;i="5.99,259,1677571200"; d="scan'208";a="698591278" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga002.jf.intel.com with ESMTP; 08 May 2023 09:54:20 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Mon, 8 May 2023 09:54:20 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Mon, 8 May 2023 09:54:20 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.105) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Mon, 8 May 2023 09:54:20 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mgSA+UnwtCexUMF9RRfLc+LwZka7QSkMrzZGyDwuYG3I3ldIWnp6qgH3DEHGZOvc0UiXh05+pqt3jacktxzhpTcg3brWap0EHnlpr7/pTJKEwelwP7tpyaGGxhwWZOSo0+yon2SzwlO8JLn+71IXQzqFi92/QBpvGelBtrBJKBD73goIOOslaKaMPMAjvKnGylYSjdOvrsHHOyL5+p4uAk6ZVhtDd2NeyFqSWyGi+/iyBI8SVPvl2B6GfInHCWhdm9qnoZvmjwAsFtmrwtS8uDTSjBLG7lwdY+yEVikiDcB+UQ0sFnISMdHolnj4hUGkoOEIY4LEFMlbZo9vlm+d4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iF6o9NknJplL2nvH5EOdJAYoyhYeYyxHqEFTCm7VYjE=; b=YMqq8JEBIiqtqnkDB3TiD79IFTfj3aXqlSUM3FCPBSwAm/tKhA6odqk0J9UXg4w+7QLQtq9wbDsqtoX6dsDiOkFHecpgY43PG0HPoElNKaA6Rz+SEG5VIyKCMGSqj99ccrc2m/nEF8qZsegZkEkfZWwA4O4K+FbT3ItQzdKQzj7jNvQQnyXirK34xDE7K2/+79qi5L0zgB/I9OVyurhC3MmhgCkLRWa3assKJZ+IsYQoNQpYmSNx1IHxK0JIE60dJBhSslHHAZPWTHHuXzoV6UoxQzPfyyTd8EbrpqIWogunUxJmOUOxWXmcfcuGJHciodYqbKdE+FNF4/aUSiGfiQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CO1PR11MB4929.namprd11.prod.outlook.com (2603:10b6:303:6d::19) by SA2PR11MB5148.namprd11.prod.outlook.com (2603:10b6:806:11e::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.32; Mon, 8 May 2023 16:54:18 +0000 Received: from CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::9b1e:23e9:53e:291]) by CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::9b1e:23e9:53e:291%7]) with mapi id 15.20.6363.032; Mon, 8 May 2023 16:54:18 +0000 From: "Michael D Kinney" To: "Guo, Gua" , "devel@edk2.groups.io" CC: Sean Brogan , Michael Kubacki , "Kinney, Michael D" Subject: Re: [PATCH v1] BaseTools/Plugin: Too many execute file will be failure Thread-Topic: [PATCH v1] BaseTools/Plugin: Too many execute file will be failure Thread-Index: AQHZgZrJmNNQ6SNud06zbbDQdBvBY69Ql8qw Date: Mon, 8 May 2023 16:54:18 +0000 Message-ID: References: <20230508104929.604-1-gua.guo@intel.com> In-Reply-To: <20230508104929.604-1-gua.guo@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO1PR11MB4929:EE_|SA2PR11MB5148:EE_ x-ms-office365-filtering-correlation-id: d463689a-d1f3-4c06-9e4f-08db4fe4dd3e x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: y4KgS4N3O7yV24/57d0/2fz63LPLR8f3kBojI8ME1uZ1qtfWjcbrOT+jI9JMjzR9rauEZuo0FxXuG5cui2NOHvCNlzQV5u3NWUjqZSnvRdXKY3cRsBRIxTx6f45q2ESN3f2jizR9we27pQfvJQYr7eCaCJwuXPT6hSxnhVWSsRtk/ySiH6PDGb8ZqCZyv8uzae1X94+C3/lC/n9X/1M9kCF6rD58buxXmQ6wf0pNYtWX7UXj/abXzNKcUN24SaXngoZmVLNKaI61EZsNSMZUu4CHDK1hIT7kKLLvE1t4UPrAiaaUhPwVOXOosWBUZbeasNFXHeLQILt975K42lBKedys67bWzhncT6UdTbcmifjAydgALKa/NXjQbgQLwsuiRNRnLIw74dOGOkfVGCn31LQ1pPhHPwYTX/cbVlBjuiPu+hBEE0FVGp20v3RDTDHs6jPUTW+VfQZfRcParqUU85Hg3Qb+l/C3r9QKYI2vCdMUcdq7AYpTkuqOUq9MU/Wf1pmMd3eRm6ichgCj18fvEaVXwgVB2zR/+lTxhD6FCskSnR8e4RwbB1Hm+z+nkqayHBVULyxehbW/Yij1rurrD7VTJvGzyKbHfpjqXOMYV0ZJqQpP+1zm3V/jGkjhin16 x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4929.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(376002)(346002)(136003)(39860400002)(366004)(451199021)(33656002)(38100700002)(52536014)(2906002)(38070700005)(55016003)(86362001)(8676002)(5660300002)(316002)(76116006)(64756008)(66476007)(82960400001)(66446008)(122000001)(66946007)(66556008)(8936002)(41300700001)(4326008)(83380400001)(186003)(26005)(9686003)(53546011)(107886003)(6506007)(7696005)(478600001)(54906003)(71200400001)(110136005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ZgZ0ci09GtpeENKbcUb4S7QfIFQrv7/dQGLmlFblhIhKQ4NLW+zBQerrLb3P?= =?us-ascii?Q?Hfm4aR1NaNuMn9po9jM2ICoeUCOnM5b5AgdFDAjzPXpPUVDNKwgXvbPuubVC?= =?us-ascii?Q?uhBnu5c/QrwJjuq0vmuM8tLB6nIzKrlpG+5U+wF0Cy91u4Yczc7IDiY6ffvT?= =?us-ascii?Q?tKlgU/YinlAcPMdtyA+BxJVkJ+J6O6y5k8tekvYIcixewBbwGQsemQijjlB2?= =?us-ascii?Q?qXiBg8RP6XDbI0N0shNwAxadhcgFmeyVZOqfQinfGaxVTcWTEQLVsvyqlpcB?= =?us-ascii?Q?vZ3yh+tIUQ+Yr5a7uWmSvYMzIiltY4hkhKIL2NCEUg/d5N/XRe3q6s5685Cr?= =?us-ascii?Q?+KHgS5+xpJ3ruVWknV1mZz/99NfjU27dM20c/Dv74z711zxnLikObaWWH7J2?= =?us-ascii?Q?4r63CedMNM4ae4QyaL4t0digYVJiAvDrI5BrTFIi+rEbTNh/gJjwv7JyNerL?= =?us-ascii?Q?0fBuIcXJ6yntPlK+cMe5Wg8yLQiDPM/amA2WcP+nw/btVF23HftJY3N/q7iZ?= =?us-ascii?Q?u4s8sgXNnC+JlX3/NtMZZ3lQoojboJid7CEsIUAZSjpf/k4DaZRvLuIn3Gr8?= =?us-ascii?Q?4YLrTXT3IcqbH+RCn+NepzUjOHQ0mXz0ed9RBw4qQPPoNdvUxNF3DyniG1en?= =?us-ascii?Q?uYylOAp5A7/R6s35s7QQkre6QhUJG0SLZ6yr0A0aCeTpPYxWX3tck+N1zwcm?= =?us-ascii?Q?og/3op6SagNbk7fLFKVtY4fb6nTgIPAnS7bXehSJMiD1BOtpi29ZQXesYs+F?= =?us-ascii?Q?n53C7RefEJW0JO8StvwcdPiyOiPtVCWJLLPsKB5Ji5PKpromMMJqGR/HI6sB?= =?us-ascii?Q?f+PzuPya0rwkaM4oBwBpLc4lZgp5GWw3VE73kk5Hd7OGiq6nKigmrn1tMnsv?= =?us-ascii?Q?bB78ZasMtPsnP7zszh+EG0Nx7ro7j2wgQY/MCLrM4r5zflMTph7WwoDdIW4Y?= =?us-ascii?Q?8OpPxpqsWMVvtLsAQ8Jpw2UfIMPgY5YXLlZ8o7ikvwdG4B57/wN0GRxnTPdc?= =?us-ascii?Q?URsx1HUWpxa4O0qGHf3aYmOcTYt74A6TjVyMWt+DWscOeUuhG655k5BNtQbN?= =?us-ascii?Q?uFi4R7cg2faLTSz/Sva1AbRm6yWCtmvJBdIcqXGDI5UWabLj8LTqncX7AaOH?= =?us-ascii?Q?woKvVjnXbRSo9e7RakkX2EkkvKrW97Oeb4ziW5liUt9NT1in35+mfaMDR++c?= =?us-ascii?Q?XYV31N/q9on2P6palHu0em3YSD6eciaNzUrzywq6y1ckdnB0wk2O8bnuPLzB?= =?us-ascii?Q?4jWKf8kpy3qV21qPsrAnZ/NSB+BErgAp8KK3rLQpgfCvnNNvTrjQpknA64m8?= =?us-ascii?Q?Q9yZuSP7BaSXGdrkQ+3rko8/E39h6+II544Lm3dNodyZgxtoc5zdqo/uYOnN?= =?us-ascii?Q?CIxwI4f0TRPZO8FFpxfqWzRwGMnqb0gQCa5JFsCMTj5UhSSVFWoHKOXEhpe5?= =?us-ascii?Q?IoysVq42SCUOOsnmjbQgxpQIyNd9ckR4THZWQaNzxQ9OeZR2X55N3B74UwJb?= =?us-ascii?Q?CMnspf0eX0Kd8yZjfcufPelAxFx2xAGm7zb1OdyyJGmdbyOjGM+Ooi+k1duN?= =?us-ascii?Q?9XkY7YXpGIgugotLTkGBZF4AEzic6nMCHaOZ3wPTEleT5W7SC7WU0PDBwt3Q?= =?us-ascii?Q?xw=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4929.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d463689a-d1f3-4c06-9e4f-08db4fe4dd3e X-MS-Exchange-CrossTenant-originalarrivaltime: 08 May 2023 16:54:18.5714 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: eRZCGYnnOmENlSFJOCvjS85+HCbxfaQTw+YLm4xVfpmG/vhVlRE8mwHJmx3TI+h4EONwcBX+u9h9cvHx/71nYWE3NqnN6BxiZDzrbQpJkl0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5148 Return-Path: michael.d.kinney@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Gua, Can you add summary of change made to the commit message? I think it is changes passing many coverage files in single command line to= breaking it up into many command lines with one coverage file per command = line. Right? Mike > -----Original Message----- > From: Guo, Gua > Sent: Monday, May 8, 2023 3:49 AM > To: devel@edk2.groups.io > Cc: Guo, Gua ; Kinney, Michael D > ; Sean Brogan ; > Michael Kubacki > Subject: [PATCH v1] BaseTools/Plugin: Too many execute file will be failu= re >=20 > From: Gua Guo >=20 > Windows command prompt have 8191 character limitation, > enhance it to make command too long can be resloved. >=20 > Change-Id: I7f1d8d46274f1c0104572d47253d499900effe76 > Cc: Michael D Kinney > Cc: Sean Brogan > Cc: Michael Kubacki > Signed-off-by: Gua Guo > --- > .../HostBasedUnitTestRunner.py | 31 ++++++++++++++++--- > 1 file changed, 27 insertions(+), 4 deletions(-) >=20 > diff --git > a/BaseTools/Plugin/HostBasedUnitTestRunner/HostBasedUnitTestRunner.py > b/BaseTools/Plugin/HostBasedUnitTestRunner/HostBasedUnitTestRunner.py > index d993de9412..05bb6da50a 100644 > --- > a/BaseTools/Plugin/HostBasedUnitTestRunner/HostBasedUnitTestRunner.py > +++ > b/BaseTools/Plugin/HostBasedUnitTestRunner/HostBasedUnitTestRunner.py > @@ -209,13 +209,25 @@ class HostBasedUnitTestRunner(IUefiBuildPlugin): > coverageFile =3D "" >=20 > for testFile in testList: >=20 > ret =3D RunCmd("OpenCppCoverage", f"--source {workspace} -- > export_type binary:{testFile}.cov -- {testFile}") >=20 > - coverageFile +=3D " --input_coverage=3D" + testFile + ".cov" >=20 > + if ret !=3D 0: >=20 > + logging.error("UnitTest Coverage: Failed to collect cove= rage data.") >=20 > + return 1 >=20 > + >=20 > + coverageFile =3D f" --input_coverage=3D{testFile}.cov" >=20 > + if (os.path.isfile(f"{os.path.join(buildOutputBase, 'coverag= e.cov')}")): >=20 > + coverageFile +=3D f" --input_coverage=3D{os.path.join(bu= ildOutputBase, > 'coverage.cov')}" >=20 > + ret =3D RunCmd("OpenCppCoverage", f"--export_type > binary:{os.path.join(buildOutputBase, 'coverage.cov')} -- > working_dir=3D{workspace}Build {coverageFile}") >=20 > if ret !=3D 0: >=20 > logging.error("UnitTest Coverage: Failed to collect cove= rage data.") >=20 > return 1 >=20 >=20 >=20 > # Generate and XML file if requested.by each package >=20 > - ret =3D RunCmd("OpenCppCoverage", f"--export_type > cobertura:{os.path.join(buildOutputBase, 'coverage.xml')} -- > working_dir=3D{workspace}Build {coverageFile}") >=20 > + ret =3D RunCmd( >=20 > + "OpenCppCoverage", >=20 > + f"--export_type cobertura:{os.path.join(buildOutputBase, > 'coverage.xml')} " + >=20 > + f"--working_dir=3D{workspace}Build " + >=20 > + f"--input_coverage=3D{os.path.join(buildOutputBase, 'coverag= e.cov')}" >=20 > + ) >=20 > if ret !=3D 0: >=20 > logging.error("UnitTest Coverage: Failed to generate cobertu= ra format > xml in single package.") >=20 > return 1 >=20 > @@ -224,9 +236,20 @@ class HostBasedUnitTestRunner(IUefiBuildPlugin): > testCoverageList =3D glob.glob(os.path.join(workspace, "Build", > "**","*Test*.exe.cov"), recursive=3DTrue) >=20 > coverageFile =3D "" >=20 > for testCoverage in testCoverageList: >=20 > - coverageFile +=3D " --input_coverage=3D" + testCoverage >=20 > + coverageFile =3D f" --input_coverage=3D{testCoverage}" >=20 > + if (os.path.isfile(f"{workspace}Build/coverage.cov")): >=20 > + coverageFile +=3D f" -- > input_coverage=3D{workspace}Build/coverage.cov" >=20 > + ret =3D RunCmd("OpenCppCoverage", f"--export_type > binary:{workspace}Build/coverage.cov --working_dir=3D{workspace}Build > {coverageFile}") >=20 > + if ret !=3D 0: >=20 > + logging.error("UnitTest Coverage: Failed to collect cove= rage data.") >=20 > + return 1 >=20 >=20 >=20 > - ret =3D RunCmd("OpenCppCoverage", f"--export_type > cobertura:{workspace}Build/coverage.xml --working_dir=3D{workspace}Build > {coverageFile}") >=20 > + ret =3D RunCmd( >=20 > + "OpenCppCoverage", >=20 > + f"--export_type cobertura:{workspace}Build/coverage.xml " + >=20 > + f"--working_dir=3D{workspace}Build " + >=20 > + f"--input_coverage=3D{workspace}Build/coverage.cov" >=20 > + ) >=20 > if ret !=3D 0: >=20 > logging.error("UnitTest Coverage: Failed to generate cobertu= ra format > xml.") >=20 > return 1 >=20 > -- > 2.39.2.windows.1