From: "Michael D Kinney" <michael.d.kinney@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Vang, Judah" <judah.vang@intel.com>,
"Kinney, Michael D" <michael.d.kinney@intel.com>
Cc: "Yao, Jiewen" <jiewen.yao@intel.com>,
"Wang, Jian J" <jian.j.wang@intel.com>,
Xiaoyu Lu <xiaoyux.lu@intel.com>,
"Jiang, Guomin" <guomin.jiang@intel.com>,
"Mistry, Nishant C" <nishant.c.mistry@intel.com>,
"Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] [PATCH v2 1/1] CryptoPkg: Need to enable crypto functions
Date: Wed, 21 Dec 2022 03:20:01 +0000 [thread overview]
Message-ID: <CO1PR11MB49295A99C0A90E6F8F12605BD2EB9@CO1PR11MB4929.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20221221030418.1137-2-judah.vang@intel.com>
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
Mike
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Judah Vang
> Sent: Tuesday, December 20, 2022 7:04 PM
> To: devel@edk2.groups.io
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; Xiaoyu Lu <xiaoyux.lu@intel.com>; Jiang,
> Guomin <guomin.jiang@intel.com>; Mistry, Nishant C <nishant.c.mistry@intel.com>
> Subject: [edk2-devel] [PATCH v2 1/1] CryptoPkg: Need to enable crypto functions
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3992
>
> V2: Update Readme and CryptoPkg.dsc to reflect changes and be in sync.
>
> V1: Enable CryptAes for PEI phase. Enable CryptHkdf for SMM phase.
> Update Readme.md
>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Xiaoyu Lu <xiaoyux.lu@intel.com>
> Cc: Guomin Jiang <guomin.jiang@intel.com>
> Cc: Nishant C Mistry <nishant.c.mistry@intel.com>
> Signed-off-by: Jian J Wang <jian.j.wang@intel.com>
> Signed-off-by: Nishant C Mistry <nishant.c.mistry@intel.com>
> Signed-off-by: Judah Vang <judah.vang@intel.com>
> ---
> CryptoPkg/CryptoPkg.dsc | 8 +++++++-
> CryptoPkg/Readme.md | 12 ++++++------
> 2 files changed, 13 insertions(+), 7 deletions(-)
>
> diff --git a/CryptoPkg/CryptoPkg.dsc b/CryptoPkg/CryptoPkg.dsc
> index 3b245979c34c..4676193e8953 100644
> --- a/CryptoPkg/CryptoPkg.dsc
> +++ b/CryptoPkg/CryptoPkg.dsc
> @@ -2,7 +2,7 @@
> # Cryptographic Library Package for UEFI Security Implementation.
> # PEIM, DXE Driver, and SMM Driver with all crypto services enabled.
> #
> -# Copyright (c) 2009 - 2021, Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) 2009 - 2022, Intel Corporation. All rights reserved.<BR>
> # Copyright (c) 2020, Hewlett Packard Enterprise Development LP. All rights reserved.<BR>
> # Copyright (c) 2022, Loongson Technology Corporation Limited. All rights reserved.<BR>
> # SPDX-License-Identifier: BSD-2-Clause-Patent
> @@ -239,6 +239,11 @@ [PcdsFixedAtBuild]
> gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Rsa.Services.Free | TRUE
> gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Rsa.Services.SetKey | TRUE
> gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Pkcs.Services.Pkcs5HashPassword | TRUE
> + gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Aes.Services.GetContextSize | TRUE
> + gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Aes.Services.Init | TRUE
> + gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Aes.Services.CbcEncrypt | TRUE
> + gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Aes.Services.CbcDecrypt | TRUE
> + gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Hkdf.Family |
> PCD_CRYPTO_SERVICE_ENABLE_FAMILY
> !endif
>
> #
> @@ -278,6 +283,7 @@ [PcdsFixedAtBuild]
> gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Aes.Services.CbcDecrypt | TRUE
> gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.AeadAesGcm.Services.Encrypt | TRUE
> gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.AeadAesGcm.Services.Decrypt | TRUE
> + gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Hkdf.Family |
> PCD_CRYPTO_SERVICE_ENABLE_FAMILY
> !endif
>
> ###################################################################################################
> diff --git a/CryptoPkg/Readme.md b/CryptoPkg/Readme.md
> index cb072db72397..284a16f299fd 100644
> --- a/CryptoPkg/Readme.md
> +++ b/CryptoPkg/Readme.md
> @@ -207,15 +207,15 @@ also configured.
> | Sha512 | N | N | C | C | C | C |
> C |
> | X509 | N | N | | | C | C |
> C |
> | Tdes | Y | Y | | | | |
> |
> -| Aes.GetContextSize | N | N | | | C | C |
> C |
> -| Aes.Init | N | N | | | C | C |
> C |
> +| Aes.GetContextSize | N | N | | C | C | C |
> C |
> +| Aes.Init | N | N | | C | C | C |
> C |
> | Aes.EcbEncrypt | Y | Y | | | | |
> |
> | Aes.EcbDecrypt | Y | Y | | | | |
> |
> -| Aes.CbcEncrypt | N | N | | | C | C |
> C |
> -| Aes.CbcDecrypt | N | N | | | C | C |
> C |
> +| Aes.CbcEncrypt | N | N | | C | C | C |
> C |
> +| Aes.CbcDecrypt | N | N | | C | C | C |
> C |
> | Arc4 | Y | Y | | | | |
> |
> | Sm3 | N | N | | C | C | C |
> C |
> -| Hkdf | N | N | | C | C | |
> C |
> +| Hkdf | N | N | | C | C | C |
> C |
> | Tls | N | N | | | C-Tls | |
> |
> | TlsSet | N | N | | | C-Tls | |
> |
> | TlsGet | N | N | | | C-Tls | |
> |
> @@ -460,7 +460,7 @@ and CryptoSmm modules.
> gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Rsa.Services.Free | TRUE
> gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Rsa.Services.SetKey | TRUE
> gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Pkcs.Services.Pkcs5HashPassword | TRUE
> - gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Hkdf.Services.Sha256ExtractAndExpand | TRUE
> + gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Hkdf.Family |
> PCD_CRYPTO_SERVICE_ENABLE_FAMILY
> ```
>
> #### Common DXE and SMM PcdCryptoServiceFamilyEnable Settings
> --
> 2.35.1.windows.2
>
>
>
>
>
next prev parent reply other threads:[~2022-12-21 3:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-21 3:04 [PATCH v2 0/1] Enable AES and HKDF Judah Vang
2022-12-21 3:04 ` [PATCH v2 1/1] CryptoPkg: Need to enable crypto functions Judah Vang
2022-12-21 3:20 ` Michael D Kinney [this message]
2022-12-21 13:06 ` [edk2-devel] " Yao, Jiewen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO1PR11MB49295A99C0A90E6F8F12605BD2EB9@CO1PR11MB4929.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox