public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* Error building OVMF on x86 macOS with Xcode 12.5
@ 2021-05-02  4:04 Rebecca Cran
  2021-05-02 18:04 ` [edk2-devel] " Michael D Kinney
  0 siblings, 1 reply; 7+ messages in thread
From: Rebecca Cran @ 2021-05-02  4:04 UTC (permalink / raw)
  To: devel, Andrew Fish, Laszlo Ersek

I'm trying to build OVMF on an x86 Mac running Big Sur and Xcode 12.5.

If I run "./OvmfPkg/build.sh -a X64 -t XCODE5 -b RELEASE" it seems to
get quite far, but then tries to run ld with "-z common-page-size",
causing the error:


"ld" -arch x86_64 -u __ModuleEntryPoint -e __ModuleEntryPoint -preload
-segalign 0x20 -pie -all_load -dead_strip -seg1addr 0x240 -map
/Users/bcran/src/edk2/Build/OvmfX64/RELEASE_XCODE5/X64/MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/MonotonicCounterRuntimeDxe/DEBUG/MonotonicCounterRuntimeDxe.map
-z common-page-size=0x1000 -seg1addr 0x1000 -segalign 0x1000 -o
/Users/bcran/src/edk2/Build/OvmfX64/RELEASE_XCODE5/X64/MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/MonotonicCounterRuntimeDxe/DEBUG/MonotonicCounterRuntimeDxe.dll 
-filelist
/Users/bcran/src/edk2/Build/OvmfX64/RELEASE_XCODE5/X64/MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/MonotonicCounterRuntimeDxe/OUTPUT/static_library_files.lst
Building ... /Users/bcran/src/edk2/UefiCpuPkg/CpuMpPei/CpuMpPei.inf [X64]
make: Nothing to be done for `tbuild'.
ld: unknown option: -z


-- 

Rebecca Cran



^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [edk2-devel] Error building OVMF on x86 macOS with Xcode 12.5
  2021-05-02  4:04 Error building OVMF on x86 macOS with Xcode 12.5 Rebecca Cran
@ 2021-05-02 18:04 ` Michael D Kinney
  2021-05-02 19:06   ` Rebecca Cran
  0 siblings, 1 reply; 7+ messages in thread
From: Michael D Kinney @ 2021-05-02 18:04 UTC (permalink / raw)
  To: devel@edk2.groups.io, rebecca@bsdio.com, Andrew Fish,
	Laszlo Ersek, Kinney, Michael D

Please try this patch:

	https://edk2.groups.io/g/devel/message/74684

If it works, can you please also do a review?  Many community members are offline this week and I want to get these fixes in.

Mike

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Rebecca Cran
> Sent: Saturday, May 1, 2021 9:05 PM
> To: devel@edk2.groups.io; Andrew Fish <afish@apple.com>; Laszlo Ersek <lersek@redhat.com>
> Subject: [edk2-devel] Error building OVMF on x86 macOS with Xcode 12.5
> 
> I'm trying to build OVMF on an x86 Mac running Big Sur and Xcode 12.5.
> 
> If I run "./OvmfPkg/build.sh -a X64 -t XCODE5 -b RELEASE" it seems to
> get quite far, but then tries to run ld with "-z common-page-size",
> causing the error:
> 
> 
> "ld" -arch x86_64 -u __ModuleEntryPoint -e __ModuleEntryPoint -preload
> -segalign 0x20 -pie -all_load -dead_strip -seg1addr 0x240 -map
> /Users/bcran/src/edk2/Build/OvmfX64/RELEASE_XCODE5/X64/MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/MonotonicCounterR
> untimeDxe/DEBUG/MonotonicCounterRuntimeDxe.map
> -z common-page-size=0x1000 -seg1addr 0x1000 -segalign 0x1000 -o
> /Users/bcran/src/edk2/Build/OvmfX64/RELEASE_XCODE5/X64/MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/MonotonicCounterR
> untimeDxe/DEBUG/MonotonicCounterRuntimeDxe.dll
> -filelist
> /Users/bcran/src/edk2/Build/OvmfX64/RELEASE_XCODE5/X64/MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/MonotonicCounterR
> untimeDxe/OUTPUT/static_library_files.lst
> Building ... /Users/bcran/src/edk2/UefiCpuPkg/CpuMpPei/CpuMpPei.inf [X64]
> make: Nothing to be done for `tbuild'.
> ld: unknown option: -z
> 
> 
> --
> 
> Rebecca Cran
> 
> 
> 
> 
> 
> 


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [edk2-devel] Error building OVMF on x86 macOS with Xcode 12.5
  2021-05-02 18:04 ` [edk2-devel] " Michael D Kinney
@ 2021-05-02 19:06   ` Rebecca Cran
  2021-05-02 20:20     ` Andrew Fish
  2021-05-02 22:20     ` Michael D Kinney
  0 siblings, 2 replies; 7+ messages in thread
From: Rebecca Cran @ 2021-05-02 19:06 UTC (permalink / raw)
  To: Kinney, Michael D, devel@edk2.groups.io, Andrew Fish,
	Laszlo Ersek

It doesn't seem to apply against
1e6b0394d6c001802dc454ecff19076aaa80f51c (master as of today):

patching file BaseTools/Source/Python/AutoGen/ModuleAutoGenHelper.py
Hunk #1 FAILED at 181.
Hunk #2 FAILED at 632.
2 out of 2 hunks FAILED -- saving rejects to file
BaseTools/Source/Python/AutoGen/ModuleAutoGenHelper.py.rej
patching file BaseTools/Source/Python/AutoGen/PlatformAutoGen.py
Hunk #1 FAILED at 1391.
Hunk #2 FAILED at 1534.
2 out of 2 hunks FAILED -- saving rejects to file
BaseTools/Source/Python/AutoGen/PlatformAutoGen.py.rej
patching file BaseTools/Source/Python/build/build.py
Hunk #1 FAILED at 897.
Hunk #2 FAILED at 930.
2 out of 2 hunks FAILED -- saving rejects to file
BaseTools/Source/Python/build/build.py.rej

-- 
Rebecca Cran

On 5/2/21 12:04 PM, Kinney, Michael D wrote:
> Please try this patch:
>
> 	https://edk2.groups.io/g/devel/message/74684
>
> If it works, can you please also do a review?  Many community members are offline this week and I want to get these fixes in.
>
> Mike
>
>> -----Original Message-----
>> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Rebecca Cran
>> Sent: Saturday, May 1, 2021 9:05 PM
>> To: devel@edk2.groups.io; Andrew Fish <afish@apple.com>; Laszlo Ersek <lersek@redhat.com>
>> Subject: [edk2-devel] Error building OVMF on x86 macOS with Xcode 12.5
>>
>> I'm trying to build OVMF on an x86 Mac running Big Sur and Xcode 12.5.
>>
>> If I run "./OvmfPkg/build.sh -a X64 -t XCODE5 -b RELEASE" it seems to
>> get quite far, but then tries to run ld with "-z common-page-size",
>> causing the error:
>>
>>
>> "ld" -arch x86_64 -u __ModuleEntryPoint -e __ModuleEntryPoint -preload
>> -segalign 0x20 -pie -all_load -dead_strip -seg1addr 0x240 -map
>> /Users/bcran/src/edk2/Build/OvmfX64/RELEASE_XCODE5/X64/MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/MonotonicCounterR
>> untimeDxe/DEBUG/MonotonicCounterRuntimeDxe.map
>> -z common-page-size=0x1000 -seg1addr 0x1000 -segalign 0x1000 -o
>> /Users/bcran/src/edk2/Build/OvmfX64/RELEASE_XCODE5/X64/MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/MonotonicCounterR
>> untimeDxe/DEBUG/MonotonicCounterRuntimeDxe.dll
>> -filelist
>> /Users/bcran/src/edk2/Build/OvmfX64/RELEASE_XCODE5/X64/MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/MonotonicCounterR
>> untimeDxe/OUTPUT/static_library_files.lst
>> Building ... /Users/bcran/src/edk2/UefiCpuPkg/CpuMpPei/CpuMpPei.inf [X64]
>> make: Nothing to be done for `tbuild'.
>> ld: unknown option: -z
>>
>>
>> --
>>
>> Rebecca Cran
>>
>>
>>
>>
>> 
>>



^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [edk2-devel] Error building OVMF on x86 macOS with Xcode 12.5
  2021-05-02 19:06   ` Rebecca Cran
@ 2021-05-02 20:20     ` Andrew Fish
  2021-05-02 22:23       ` Michael D Kinney
  2021-05-02 22:20     ` Michael D Kinney
  1 sibling, 1 reply; 7+ messages in thread
From: Andrew Fish @ 2021-05-02 20:20 UTC (permalink / raw)
  To: edk2-devel-groups-io, rebecca; +Cc: Mike Kinney, Laszlo Ersek

[-- Attachment #1: Type: text/plain, Size: 3971 bytes --]

Rebecca,

I don’t think `-z` is a valid argument to ld64 (macOS linker). My guess is XCODE is inheriting a GCC flag from a platform DSC file. 

$ git grep "z common-page-size" -- *.dsc
OvmfPkg/OvmfPkgIa32.dsc:89:  GCC:*_*_*_DLINK_FLAGS = -z common-page-size=0x1000
OvmfPkg/OvmfPkgIa32.dsc:97:  GCC:*_*_*_DLINK_FLAGS = -z common-page-size=0x1000
OvmfPkg/OvmfPkgIa32X64.dsc:93:  GCC:*_*_*_DLINK_FLAGS = -z common-page-size=0x1000
OvmfPkg/OvmfPkgIa32X64.dsc:101:  GCC:*_*_*_DLINK_FLAGS = -z common-page-size=0x1000
OvmfPkg/OvmfPkgX64.dsc:93:  GCC:*_*_*_DLINK_FLAGS = -z common-page-size=0x1000
OvmfPkg/OvmfPkgX64.dsc:101:  GCC:*_*_*_DLINK_FLAGS = -z common-page-size=0x1000
OvmfPkg/OvmfXen.dsc:84:  GCC:*_*_*_DLINK_FLAGS = -z common-page-size=0x1000
OvmfPkg/OvmfXen.dsc:92:  GCC:*_*_*_DLINK_FLAGS = -z common-page-size=0x1000
StandaloneMmPkg/StandaloneMmPkg.dsc:116:GCC:*_*_*_DLINK_FLAGS = -z common-page-size=0x1000 -march=armv8-a+nofp -mstrict-align

Thanks,

Andrew Fish

> On May 2, 2021, at 12:06 PM, Rebecca Cran <rebecca@bsdio.com> wrote:
> 
> It doesn't seem to apply against
> 1e6b0394d6c001802dc454ecff19076aaa80f51c (master as of today):
> 
> patching file BaseTools/Source/Python/AutoGen/ModuleAutoGenHelper.py
> Hunk #1 FAILED at 181.
> Hunk #2 FAILED at 632.
> 2 out of 2 hunks FAILED -- saving rejects to file
> BaseTools/Source/Python/AutoGen/ModuleAutoGenHelper.py.rej
> patching file BaseTools/Source/Python/AutoGen/PlatformAutoGen.py
> Hunk #1 FAILED at 1391.
> Hunk #2 FAILED at 1534.
> 2 out of 2 hunks FAILED -- saving rejects to file
> BaseTools/Source/Python/AutoGen/PlatformAutoGen.py.rej
> patching file BaseTools/Source/Python/build/build.py
> Hunk #1 FAILED at 897.
> Hunk #2 FAILED at 930.
> 2 out of 2 hunks FAILED -- saving rejects to file
> BaseTools/Source/Python/build/build.py.rej
> 
> -- 
> Rebecca Cran
> 
> On 5/2/21 12:04 PM, Kinney, Michael D wrote:
>> Please try this patch:
>> 
>> 	https://edk2.groups.io/g/devel/message/74684 <https://edk2.groups.io/g/devel/message/74684>
>> 
>> If it works, can you please also do a review?  Many community members are offline this week and I want to get these fixes in.
>> 
>> Mike
>> 
>>> -----Original Message-----
>>> From: devel@edk2.groups.io <mailto:devel@edk2.groups.io> <devel@edk2.groups.io <mailto:devel@edk2.groups.io>> On Behalf Of Rebecca Cran
>>> Sent: Saturday, May 1, 2021 9:05 PM
>>> To: devel@edk2.groups.io <mailto:devel@edk2.groups.io>; Andrew Fish <afish@apple.com <mailto:afish@apple.com>>; Laszlo Ersek <lersek@redhat.com <mailto:lersek@redhat.com>>
>>> Subject: [edk2-devel] Error building OVMF on x86 macOS with Xcode 12.5
>>> 
>>> I'm trying to build OVMF on an x86 Mac running Big Sur and Xcode 12.5.
>>> 
>>> If I run "./OvmfPkg/build.sh -a X64 -t XCODE5 -b RELEASE" it seems to
>>> get quite far, but then tries to run ld with "-z common-page-size",
>>> causing the error:
>>> 
>>> 
>>> "ld" -arch x86_64 -u __ModuleEntryPoint -e __ModuleEntryPoint -preload
>>> -segalign 0x20 -pie -all_load -dead_strip -seg1addr 0x240 -map
>>> /Users/bcran/src/edk2/Build/OvmfX64/RELEASE_XCODE5/X64/MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/MonotonicCounterR
>>> untimeDxe/DEBUG/MonotonicCounterRuntimeDxe.map
>>> -z common-page-size=0x1000 -seg1addr 0x1000 -segalign 0x1000 -o
>>> /Users/bcran/src/edk2/Build/OvmfX64/RELEASE_XCODE5/X64/MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/MonotonicCounterR
>>> untimeDxe/DEBUG/MonotonicCounterRuntimeDxe.dll
>>> -filelist
>>> /Users/bcran/src/edk2/Build/OvmfX64/RELEASE_XCODE5/X64/MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/MonotonicCounterR
>>> untimeDxe/OUTPUT/static_library_files.lst
>>> Building ... /Users/bcran/src/edk2/UefiCpuPkg/CpuMpPei/CpuMpPei.inf [X64]
>>> make: Nothing to be done for `tbuild'.
>>> ld: unknown option: -z
>>> 
>>> 
>>> --
>>> 
>>> Rebecca Cran
>>> 
>>> 
>>> 
>>> 
>>> 
>>> 
> 
> 
> 
> 
> 


[-- Attachment #2: Type: text/html, Size: 29358 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [edk2-devel] Error building OVMF on x86 macOS with Xcode 12.5
  2021-05-02 19:06   ` Rebecca Cran
  2021-05-02 20:20     ` Andrew Fish
@ 2021-05-02 22:20     ` Michael D Kinney
  2021-05-02 23:21       ` Rebecca Cran
  1 sibling, 1 reply; 7+ messages in thread
From: Michael D Kinney @ 2021-05-02 22:20 UTC (permalink / raw)
  To: Rebecca Cran, devel@edk2.groups.io, Andrew Fish, Laszlo Ersek,
	Kinney, Michael D

Hi Rebecca,

Not sure why it will not apply.  I sent that patch against master as of 5/1, and there at no commits to master since 4/30.

A branch with the change is also posted here:

	https://github.com/mdkinney/edk2/tree/Bug_3359_BaseTools_Expand_Tool_Star

Mike

> -----Original Message-----
> From: Rebecca Cran <rebecca@bsdio.com>
> Sent: Sunday, May 2, 2021 12:07 PM
> To: Kinney, Michael D <michael.d.kinney@intel.com>; devel@edk2.groups.io; Andrew Fish <afish@apple.com>; Laszlo Ersek
> <lersek@redhat.com>
> Subject: Re: [edk2-devel] Error building OVMF on x86 macOS with Xcode 12.5
> 
> It doesn't seem to apply against
> 1e6b0394d6c001802dc454ecff19076aaa80f51c (master as of today):
> 
> patching file BaseTools/Source/Python/AutoGen/ModuleAutoGenHelper.py
> Hunk #1 FAILED at 181.
> Hunk #2 FAILED at 632.
> 2 out of 2 hunks FAILED -- saving rejects to file
> BaseTools/Source/Python/AutoGen/ModuleAutoGenHelper.py.rej
> patching file BaseTools/Source/Python/AutoGen/PlatformAutoGen.py
> Hunk #1 FAILED at 1391.
> Hunk #2 FAILED at 1534.
> 2 out of 2 hunks FAILED -- saving rejects to file
> BaseTools/Source/Python/AutoGen/PlatformAutoGen.py.rej
> patching file BaseTools/Source/Python/build/build.py
> Hunk #1 FAILED at 897.
> Hunk #2 FAILED at 930.
> 2 out of 2 hunks FAILED -- saving rejects to file
> BaseTools/Source/Python/build/build.py.rej
> 
> --
> Rebecca Cran
> 
> On 5/2/21 12:04 PM, Kinney, Michael D wrote:
> > Please try this patch:
> >
> > 	https://edk2.groups.io/g/devel/message/74684
> >
> > If it works, can you please also do a review?  Many community members are offline this week and I want to get these
> fixes in.
> >
> > Mike
> >
> >> -----Original Message-----
> >> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Rebecca Cran
> >> Sent: Saturday, May 1, 2021 9:05 PM
> >> To: devel@edk2.groups.io; Andrew Fish <afish@apple.com>; Laszlo Ersek <lersek@redhat.com>
> >> Subject: [edk2-devel] Error building OVMF on x86 macOS with Xcode 12.5
> >>
> >> I'm trying to build OVMF on an x86 Mac running Big Sur and Xcode 12.5.
> >>
> >> If I run "./OvmfPkg/build.sh -a X64 -t XCODE5 -b RELEASE" it seems to
> >> get quite far, but then tries to run ld with "-z common-page-size",
> >> causing the error:
> >>
> >>
> >> "ld" -arch x86_64 -u __ModuleEntryPoint -e __ModuleEntryPoint -preload
> >> -segalign 0x20 -pie -all_load -dead_strip -seg1addr 0x240 -map
> >>
> /Users/bcran/src/edk2/Build/OvmfX64/RELEASE_XCODE5/X64/MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/MonotonicCounterR
> >> untimeDxe/DEBUG/MonotonicCounterRuntimeDxe.map
> >> -z common-page-size=0x1000 -seg1addr 0x1000 -segalign 0x1000 -o
> >>
> /Users/bcran/src/edk2/Build/OvmfX64/RELEASE_XCODE5/X64/MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/MonotonicCounterR
> >> untimeDxe/DEBUG/MonotonicCounterRuntimeDxe.dll
> >> -filelist
> >>
> /Users/bcran/src/edk2/Build/OvmfX64/RELEASE_XCODE5/X64/MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/MonotonicCounterR
> >> untimeDxe/OUTPUT/static_library_files.lst
> >> Building ... /Users/bcran/src/edk2/UefiCpuPkg/CpuMpPei/CpuMpPei.inf [X64]
> >> make: Nothing to be done for `tbuild'.
> >> ld: unknown option: -z
> >>
> >>
> >> --
> >>
> >> Rebecca Cran
> >>
> >>
> >>
> >>
> >> 
> >>
> 


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [edk2-devel] Error building OVMF on x86 macOS with Xcode 12.5
  2021-05-02 20:20     ` Andrew Fish
@ 2021-05-02 22:23       ` Michael D Kinney
  0 siblings, 0 replies; 7+ messages in thread
From: Michael D Kinney @ 2021-05-02 22:23 UTC (permalink / raw)
  To: Andrew Fish, edk2-devel-groups-io, rebecca@bsdio.com,
	Kinney, Michael D
  Cc: Laszlo Ersek

[-- Attachment #1: Type: text/plain, Size: 4323 bytes --]

Hi Andrew,

This is a regression against BaseTools.  Same observation was seen with CLANGPDB toolchain.

Steven Shi reopened 3359 to address this regression:

https://bugzilla.tianocore.org/show_bug.cgi?id=3359

The patch I provided fixed CLANGPDB and I expect it to also fix XCODE5.

Mike

From: Andrew Fish <afish@apple.com>
Sent: Sunday, May 2, 2021 1:20 PM
To: edk2-devel-groups-io <devel@edk2.groups.io>; rebecca@bsdio.com
Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Laszlo Ersek <lersek@redhat.com>
Subject: Re: [edk2-devel] Error building OVMF on x86 macOS with Xcode 12.5

Rebecca,

I don’t think `-z` is a valid argument to ld64 (macOS linker). My guess is XCODE is inheriting a GCC flag from a platform DSC file.

$ git grep "z common-page-size" -- *.dsc
OvmfPkg/OvmfPkgIa32.dsc:89:  GCC:*_*_*_DLINK_FLAGS = -z common-page-size=0x1000
OvmfPkg/OvmfPkgIa32.dsc:97:  GCC:*_*_*_DLINK_FLAGS = -z common-page-size=0x1000
OvmfPkg/OvmfPkgIa32X64.dsc:93:  GCC:*_*_*_DLINK_FLAGS = -z common-page-size=0x1000
OvmfPkg/OvmfPkgIa32X64.dsc:101:  GCC:*_*_*_DLINK_FLAGS = -z common-page-size=0x1000
OvmfPkg/OvmfPkgX64.dsc:93:  GCC:*_*_*_DLINK_FLAGS = -z common-page-size=0x1000
OvmfPkg/OvmfPkgX64.dsc:101:  GCC:*_*_*_DLINK_FLAGS = -z common-page-size=0x1000
OvmfPkg/OvmfXen.dsc:84:  GCC:*_*_*_DLINK_FLAGS = -z common-page-size=0x1000
OvmfPkg/OvmfXen.dsc:92:  GCC:*_*_*_DLINK_FLAGS = -z common-page-size=0x1000
StandaloneMmPkg/StandaloneMmPkg.dsc:116:GCC:*_*_*_DLINK_FLAGS = -z common-page-size=0x1000 -march=armv8-a+nofp -mstrict-align

Thanks,

Andrew Fish


On May 2, 2021, at 12:06 PM, Rebecca Cran <rebecca@bsdio.com<mailto:rebecca@bsdio.com>> wrote:

It doesn't seem to apply against
1e6b0394d6c001802dc454ecff19076aaa80f51c (master as of today):

patching file BaseTools/Source/Python/AutoGen/ModuleAutoGenHelper.py
Hunk #1 FAILED at 181.
Hunk #2 FAILED at 632.
2 out of 2 hunks FAILED -- saving rejects to file
BaseTools/Source/Python/AutoGen/ModuleAutoGenHelper.py.rej
patching file BaseTools/Source/Python/AutoGen/PlatformAutoGen.py
Hunk #1 FAILED at 1391.
Hunk #2 FAILED at 1534.
2 out of 2 hunks FAILED -- saving rejects to file
BaseTools/Source/Python/AutoGen/PlatformAutoGen.py.rej
patching file BaseTools/Source/Python/build/build.py
Hunk #1 FAILED at 897.
Hunk #2 FAILED at 930.
2 out of 2 hunks FAILED -- saving rejects to file
BaseTools/Source/Python/build/build.py.rej

--
Rebecca Cran

On 5/2/21 12:04 PM, Kinney, Michael D wrote:

Please try this patch:

  https://edk2.groups.io/g/devel/message/74684

If it works, can you please also do a review?  Many community members are offline this week and I want to get these fixes in.

Mike


-----Original Message-----
From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> On Behalf Of Rebecca Cran
Sent: Saturday, May 1, 2021 9:05 PM
To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Andrew Fish <afish@apple.com<mailto:afish@apple.com>>; Laszlo Ersek <lersek@redhat.com<mailto:lersek@redhat.com>>
Subject: [edk2-devel] Error building OVMF on x86 macOS with Xcode 12.5

I'm trying to build OVMF on an x86 Mac running Big Sur and Xcode 12.5.

If I run "./OvmfPkg/build.sh -a X64 -t XCODE5 -b RELEASE" it seems to
get quite far, but then tries to run ld with "-z common-page-size",
causing the error:


"ld" -arch x86_64 -u __ModuleEntryPoint -e __ModuleEntryPoint -preload
-segalign 0x20 -pie -all_load -dead_strip -seg1addr 0x240 -map
/Users/bcran/src/edk2/Build/OvmfX64/RELEASE_XCODE5/X64/MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/MonotonicCounterR
untimeDxe/DEBUG/MonotonicCounterRuntimeDxe.map
-z common-page-size=0x1000 -seg1addr 0x1000 -segalign 0x1000 -o
/Users/bcran/src/edk2/Build/OvmfX64/RELEASE_XCODE5/X64/MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/MonotonicCounterR
untimeDxe/DEBUG/MonotonicCounterRuntimeDxe.dll
-filelist
/Users/bcran/src/edk2/Build/OvmfX64/RELEASE_XCODE5/X64/MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/MonotonicCounterR
untimeDxe/OUTPUT/static_library_files.lst
Building ... /Users/bcran/src/edk2/UefiCpuPkg/CpuMpPei/CpuMpPei.inf [X64]
make: Nothing to be done for `tbuild'.
ld: unknown option: -z


--

Rebecca Cran












[-- Attachment #2: Type: text/html, Size: 51471 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [edk2-devel] Error building OVMF on x86 macOS with Xcode 12.5
  2021-05-02 22:20     ` Michael D Kinney
@ 2021-05-02 23:21       ` Rebecca Cran
  0 siblings, 0 replies; 7+ messages in thread
From: Rebecca Cran @ 2021-05-02 23:21 UTC (permalink / raw)
  To: Kinney, Michael D, devel@edk2.groups.io, Andrew Fish,
	Laszlo Ersek

Hi Mike,

It turned out that adding --ignore-space-change --ignore-whitespace
allowed the patch to be applied.

I've verified the build now works on macOS with XCODE5 - thanks!

-- 
Rebecca Cran

On 5/2/21 4:20 PM, Kinney, Michael D wrote:
> Hi Rebecca,
>
> Not sure why it will not apply.  I sent that patch against master as of 5/1, and there at no commits to master since 4/30.
>
> A branch with the change is also posted here:
>
> 	https://github.com/mdkinney/edk2/tree/Bug_3359_BaseTools_Expand_Tool_Star
>
> Mike
>
>> -----Original Message-----
>> From: Rebecca Cran <rebecca@bsdio.com>
>> Sent: Sunday, May 2, 2021 12:07 PM
>> To: Kinney, Michael D <michael.d.kinney@intel.com>; devel@edk2.groups.io; Andrew Fish <afish@apple.com>; Laszlo Ersek
>> <lersek@redhat.com>
>> Subject: Re: [edk2-devel] Error building OVMF on x86 macOS with Xcode 12.5
>>
>> It doesn't seem to apply against
>> 1e6b0394d6c001802dc454ecff19076aaa80f51c (master as of today):
>>
>> patching file BaseTools/Source/Python/AutoGen/ModuleAutoGenHelper.py
>> Hunk #1 FAILED at 181.
>> Hunk #2 FAILED at 632.
>> 2 out of 2 hunks FAILED -- saving rejects to file
>> BaseTools/Source/Python/AutoGen/ModuleAutoGenHelper.py.rej
>> patching file BaseTools/Source/Python/AutoGen/PlatformAutoGen.py
>> Hunk #1 FAILED at 1391.
>> Hunk #2 FAILED at 1534.
>> 2 out of 2 hunks FAILED -- saving rejects to file
>> BaseTools/Source/Python/AutoGen/PlatformAutoGen.py.rej
>> patching file BaseTools/Source/Python/build/build.py
>> Hunk #1 FAILED at 897.
>> Hunk #2 FAILED at 930.
>> 2 out of 2 hunks FAILED -- saving rejects to file
>> BaseTools/Source/Python/build/build.py.rej
>>
>> --
>> Rebecca Cran
>>
>> On 5/2/21 12:04 PM, Kinney, Michael D wrote:
>>> Please try this patch:
>>>
>>> 	https://edk2.groups.io/g/devel/message/74684
>>>
>>> If it works, can you please also do a review?  Many community members are offline this week and I want to get these
>> fixes in.
>>> Mike
>>>
>>>> -----Original Message-----
>>>> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Rebecca Cran
>>>> Sent: Saturday, May 1, 2021 9:05 PM
>>>> To: devel@edk2.groups.io; Andrew Fish <afish@apple.com>; Laszlo Ersek <lersek@redhat.com>
>>>> Subject: [edk2-devel] Error building OVMF on x86 macOS with Xcode 12.5
>>>>
>>>> I'm trying to build OVMF on an x86 Mac running Big Sur and Xcode 12.5.
>>>>
>>>> If I run "./OvmfPkg/build.sh -a X64 -t XCODE5 -b RELEASE" it seems to
>>>> get quite far, but then tries to run ld with "-z common-page-size",
>>>> causing the error:
>>>>
>>>>
>>>> "ld" -arch x86_64 -u __ModuleEntryPoint -e __ModuleEntryPoint -preload
>>>> -segalign 0x20 -pie -all_load -dead_strip -seg1addr 0x240 -map
>>>>
>> /Users/bcran/src/edk2/Build/OvmfX64/RELEASE_XCODE5/X64/MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/MonotonicCounterR
>>>> untimeDxe/DEBUG/MonotonicCounterRuntimeDxe.map
>>>> -z common-page-size=0x1000 -seg1addr 0x1000 -segalign 0x1000 -o
>>>>
>> /Users/bcran/src/edk2/Build/OvmfX64/RELEASE_XCODE5/X64/MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/MonotonicCounterR
>>>> untimeDxe/DEBUG/MonotonicCounterRuntimeDxe.dll
>>>> -filelist
>>>>
>> /Users/bcran/src/edk2/Build/OvmfX64/RELEASE_XCODE5/X64/MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/MonotonicCounterR
>>>> untimeDxe/OUTPUT/static_library_files.lst
>>>> Building ... /Users/bcran/src/edk2/UefiCpuPkg/CpuMpPei/CpuMpPei.inf [X64]
>>>> make: Nothing to be done for `tbuild'.
>>>> ld: unknown option: -z
>>>>
>>>>
>>>> --
>>>>
>>>> Rebecca Cran
>>>>
>>>>
>>>>
>>>>
>>>> 
>>>>



^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2021-05-02 23:21 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-05-02  4:04 Error building OVMF on x86 macOS with Xcode 12.5 Rebecca Cran
2021-05-02 18:04 ` [edk2-devel] " Michael D Kinney
2021-05-02 19:06   ` Rebecca Cran
2021-05-02 20:20     ` Andrew Fish
2021-05-02 22:23       ` Michael D Kinney
2021-05-02 22:20     ` Michael D Kinney
2021-05-02 23:21       ` Rebecca Cran

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox