From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id AB5F0AC1AAE for ; Thu, 18 Jan 2024 22:30:24 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=XllRkpApyJ8E02C0og4dSo1YZlb1MsdfUtdTvBTr++8=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1705617023; v=1; b=nmtP9kCapr+WByLonlEPk35q2Cfvd40bNIdTIDkg9HaqDkhUz5nLy/M902eVagBbMO/xy4QR bM5+vWANrcKuVEoCHPtv+QE8zmd6Ass3HGLFFoMQV8iTjpssooENsq/0XOgz1FwK9FiP5P7hE6B RyeEgeCrvh04nd1Hk1X6lDFc= X-Received: by 127.0.0.2 with SMTP id LDR1YY7687511xuud5RBK2Yy; Thu, 18 Jan 2024 14:30:23 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by mx.groups.io with SMTP id smtpd.web10.7410.1705617022099841457 for ; Thu, 18 Jan 2024 14:30:22 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10956"; a="19183138" X-IronPort-AV: E=Sophos;i="6.05,203,1701158400"; d="scan'208";a="19183138" X-Received: from orviesa004.jf.intel.com ([10.64.159.144]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jan 2024 14:30:21 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.05,203,1701158400"; d="scan'208";a="537335" X-Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orviesa004.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 18 Jan 2024 14:30:22 -0800 X-Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 18 Jan 2024 14:30:20 -0800 X-Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 18 Jan 2024 14:30:20 -0800 X-Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 18 Jan 2024 14:30:20 -0800 X-Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.169) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 18 Jan 2024 14:30:20 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MH5AHL9H+EY05SVQlPcIr0aatXYJXx0SMxIKQMMpS9dptQuqEb8wddRTBLilGk3/OI8QvnrsBXZ/z0qDmumD4IsPQERuLS0KN/z8+ykzR1aRTBb4Ue/AGRJEJZ1j3z5Vi74xZJpnjntWEG66L20VtyVaZDPnnanJaftfXMspNIOzYdVlzs1nhxRBBI+cr5rl0BvmvaIUAnioS1APoxWLck31m9Pm/bYDNnvoqKvRtXwplDXSPbvrEuB8ryfxjQWuPv85E5/vXho2scmyo9iGIaj1Kfe/8KMTCHt9TR0A94uY7K3imN9wxmtt7MYrGHaO33e712VrVhyhibCVtioEdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mr0BvMpT34gCmVMdhZZ35YiQzliX5fSucOrss6UVowA=; b=BYp7Q70QSy+9I+c5WEJ6s4pVOngxr8PaOp4R3s974hCHnkz8Ptkk5kSwi0eilw4toIuQxYXFTMNwzgD+uZAKDEmioaVHvsvQoo3KbI9AtYvV/0yQlpO/nZM/ITSg+S3socjuWQOL+Sfm102JTaSHLu+ma2NJxJ69xF8R7NmDUlMCFcblgBctqCX6roaOiV45NKVIxhyxZbZTv/ow0L/f8+/im1bXcWPPozoO04NQ0x0OLp6UFFrxjLWMyZLpj43li5OrkrxBqwzoakOwBjGNzpHgypDPR3vfZXltlRfjG+cBVkvwewhi+08LLGk0aAFQjtqLipKmA1xqcXaL8rO8Mw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com (2603:10b6:303:6d::19) by SA2PR11MB5179.namprd11.prod.outlook.com (2603:10b6:806:112::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7202.24; Thu, 18 Jan 2024 22:30:18 +0000 X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::4382:5b03:f13:88ff]) by CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::4382:5b03:f13:88ff%4]) with mapi id 15.20.7202.024; Thu, 18 Jan 2024 22:30:18 +0000 From: "Michael D Kinney" To: "Pethaiyan, Madhan" , "devel@edk2.groups.io" CC: "Gao, Liming" , "Xu, Wei6" , "Tan, Ming" , "S, Ashraf Ali" , "Kinney, Michael D" Subject: Re: [edk2-devel] [PATCH V2] FmpDevicePkg: GetImageInfo Add missing condition Thread-Topic: [PATCH V2] FmpDevicePkg: GetImageInfo Add missing condition Thread-Index: AQHaQf3ri8yJvnyzKkqDxn26CDrvubDfVK8AgAC5xiCAACbykA== Date: Thu, 18 Jan 2024 22:30:18 +0000 Message-ID: References: <2d53b710572890495a268f208027c8de1e9b7fea.1704696138.git.madhan.pethaiyan@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO1PR11MB4929:EE_|SA2PR11MB5179:EE_ x-ms-office365-filtering-correlation-id: c3d581b5-8d63-4d59-fe90-08dc18750ca7 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: gL3znMJwG6AE7XxZyumPhtCDkgx9ee7Vrg4fTe+Kmn1I+MsP0pQjt3eGRpIvfhNdNvt8+srOnNaxgg/g8atBgPtoNIlpP+S1EaJlMVXPDCoRwyESgrmOsQyqCmKllOIxNlGh1uZruZ3hXHrmcJcEvREWWVspa6dS+iYTXNmxqywTXQyTM9PuB6Pp3eprU3k567i9sLwpT1Kkk3vAsiO0I2XDciuae5W+8kun2DjeV8hGfSJurg9IR4mRgV7xHNgEzPy8EiycgDxEVuocZ1ASdSNGXEN8hpGIf77N37k9JC0HT+qc/3BWrBEr7oW2NOp8KocJ5zPU5uzkRTm5kuW3W5XOihjgnd6NVDj2yzwDW6ZVLRErDJzlkjv7/42iH0CIBhyWrGnGrKKg0XW0VXKogE1lcoAbXkws7DBco2aTsy/6cUBpXGCMuFhyt5WuJDqfik1q46BHWlib/iU2E2hAqCMfFWZNqV0Zt8SPTaLIyvkLmhHutjE/R1omwD+GsC59EB0Dy4TG+kT4GweQttbA80CxL7gI8KbwAxdnRAol4neen/R4mo2t8IYwQ4vmGAwyAld+NWoTvme5e/vcpS9hFRYeVsJg3Z8cxV4oR4Bk509yb4aSj0Z7QT6ZP0iXYIJ4 x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?TtApvOyxWE0LrYSo6H0+OdTiizHWnGFa/Nx54a0Y5m2BXU9LF5GT4tRdvQn3?= =?us-ascii?Q?tu/1PKUgpfSet795K8zs6Q00x8A/p6XCrGqerkGR+5eoLRO5SjkGfEoVkbop?= =?us-ascii?Q?/ilDDdKptAlcBsBHF+RAq+HZCOKwBJDncax6/BF9uWTzTiEdvRZwndDvDbSc?= =?us-ascii?Q?QX/gDbcPBgWeF1QpQ+g64/xgFOAtV4Qs9eqjME5EDnOBlVErWo1NYh2pH6H/?= =?us-ascii?Q?YHeengw2bqI85ZUisMElXO2ATRNA8AUYMCv8QNtHs2bjvjkLfNk4JwQlEGWj?= =?us-ascii?Q?5+p/Rfo+s6V6EDYl6VT8EwHPjZX3/dFoDrkAJqxExMMEh/WaW6Zm7sIZa8wr?= =?us-ascii?Q?XF+c0jPdFUGJXGtOKhtZ/+D3mBy8YF6FSHm4/l5tEuF59KfpkzHByoDm0r1Z?= =?us-ascii?Q?y9d+cHDMNkoA7vp2blLOP8PHQvfFiksaI+71Ub8R9TzeX0j6q5t9BArr2g/R?= =?us-ascii?Q?rFO7YFSvgUgq68CRUH0fuNbLQtpGJwLGmHfcp8uE+mujHk87g+KEcKddzUlF?= =?us-ascii?Q?vXDHCHZUy2g3561woUQbfGtYEDJsD25FprHdqs9Jwl0tBhVeN8rfWVvOoVz2?= =?us-ascii?Q?ZBUw0H3iqN2IbXQWwBwTkXLD8mBkF44wbd9LFuUD2qph1oEeDaA+YSXYz/Dr?= =?us-ascii?Q?QXZPOOIYPx5RWJXuEyEpxEzWuoUR48ImywlBp2OY1WLXwIfnuToFU/5FEFg1?= =?us-ascii?Q?lx9j3o7wMvH4akw98LzhjqXFIUqcRiG/5HiG+wnwFARytLJ5PjBSEdN0NRP+?= =?us-ascii?Q?lKart4v566OFVFuRZSBdU8L0pRyoTTzim6NiXFc5NR/PyQj3JT5iG4bhwMp+?= =?us-ascii?Q?+MIBehtQlOaceS+og5WQQilSQAzW0v1dVLrOutd/i13uXPzFTVtQwKrYD8lJ?= =?us-ascii?Q?/53NJq/w+UT+m3b1gUbD+8iWC1qRUz4bw0o40cJQi4nz1YG4SoFmv8Bu+puc?= =?us-ascii?Q?Q0rE9a8vZPSsIUl5EQrHfM0lctTtFGwkaPhmgZdTxJuajlmjrx+2oteW857c?= =?us-ascii?Q?+5A0Olni93n1NLQgXttVtEUIDSTp4XIJ4LprynQOm0aenV8RREPzXpWrRwye?= =?us-ascii?Q?+kzP/J8C/ie/V3eAoZOYG09BL7dWAzsbV0/BRrz+kTSjDE6lRBE8zA9Sobp0?= =?us-ascii?Q?2FMtlZd02zztppIdknMK83TbtNw4u83Yo//BYXZmzeBuYjVvPEInPHtr2Gqs?= =?us-ascii?Q?3/ZguPRx6ajDKWxh4e5rSN7iuk31YaoO+GQ+VvThxHH928HcxDsFOQBQbllY?= =?us-ascii?Q?chf33bsaX3cIastp7KRcnctTTdUJJnXsKkriX0N2PL7mdX5s1LTx1/kRaovt?= =?us-ascii?Q?qRmCuENttarVjN+oKuGf8R3Gx3hQhRkDc8VwknohLlZPBsqKj6f1QucfFcuu?= =?us-ascii?Q?q6QurUsvsNJUsrYH43QITxemn0KQaJaq6hd7tF3yFmiculWTKmz+M4sxXtez?= =?us-ascii?Q?3OBFFBqjD+K25FmokpvoIpRR2SvMiUp+BRraAhiKr8afnHTfQ2KQgEoFx8Kr?= =?us-ascii?Q?IAP5SOukByU6jrnzGjdYvGodDjyNF3hYln/biifCwlTsbOrJn00I/Mf1XekK?= =?us-ascii?Q?4Jti95rqnyvIREU4A5USOy/Fo9Hm2Xx5FL2GnzODTpOOOa7Q/ykIDRg3ng1F?= =?us-ascii?Q?yw=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4929.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c3d581b5-8d63-4d59-fe90-08dc18750ca7 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jan 2024 22:30:18.1706 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ghGidVoUuOWoutWTGwO3IDEbbjH6cmdP+31Yx/kH8LETULdxJ8O04A3ET9nFcctJfYR4xiRXRivgLJ5nfKGrEb/ENEnbNTFTplAEgc2oBgc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5179 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,michael.d.kinney@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: yRiqm49t2rUDXBcAbZH3BgTBx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=nmtP9kCa; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Madhan, The patch you provided does fix the logic in the .c file, but the update is incomplete. * FmpDevicePkg/FmpDxe/FmpDxe.c - Update GetTheImageInfo() function header= =20 to match the UEFI 2.10 specification that includes all the conditions to return EFI_INVALID_PARAMETER. * FmpDevicePkg/FmpDxe/FmpDxe.h - Update GetTheImageInfo() function header= =20 to match the UEFI 2.10 specification that includes all the conditions to return EFI_INVALID_PARAMETER. * MdePkg/Include/Protocol/FirmwareManagement.h - Update function header For EFI_FIRMWARE_MANAGEMENT_PROTOCOL_GET_IMAGE_INFO to match the UEFI 2.1= 0 specification that includes all the conditions to return EFI_INVALID_PARA= METER. Also, when trying to search for these, I found that the FmpDxe implementati= on uses the function name "GetTheImageInfo()" for the protocol service called "GetImageInfo()". I recommend the FmpDxe implementation be updated so the function name matches the name of the protocol service. I will wait for a V3 patch set to review as a whole before merging. Also, the UEFI SCTs would need to be updated for this additional return sta= tus. please enter a Bugzilla and work with the UEFI SCT team to get them updated= . Thanks, Mike > -----Original Message----- > From: Kinney, Michael D > Sent: Thursday, January 18, 2024 12:03 PM > To: Pethaiyan, Madhan ; devel@edk2.groups.io > Cc: Gao, Liming ; Xu, Wei6 > ; Tan, Ming ; S, Ashraf Ali > ; Kinney, Michael D > Subject: RE: [PATCH V2] FmpDevicePkg: GetImageInfo Add missing condition >=20 > Reviewed-by: Michael D Kinney >=20 >=20 >=20 > > -----Original Message----- > > From: Pethaiyan, Madhan > > Sent: Thursday, January 18, 2024 12:57 AM > > To: devel@edk2.groups.io > > Cc: Gao, Liming ; Kinney, Michael D > > ; Xu, Wei6 ; Tan, Ming > > ; S, Ashraf Ali > > Subject: RE: [PATCH V2] FmpDevicePkg: GetImageInfo Add missing > condition > > > > Hi All, > > > > I had corrected the description, added the UEFI spec version and > section > > details . Please check and approve it > > > > Thanks, > > P. Madhan > > > > -----Original Message----- > > From: Pethaiyan, Madhan > > Sent: Monday, January 8, 2024 12:13 PM > > To: devel@edk2.groups.io > > Cc: Pethaiyan, Madhan ; Gao, Liming > > ; Kinney, Michael D > > ; Xu, Wei6 > > Subject: [PATCH V2] FmpDevicePkg: GetImageInfo Add missing condition > > > > From: "Pethaiyan, Madhan" > > > > UEFI Spec 2.10 , 23.1 Firmware Management Protocol , Added missing > > condition check under GetImageInfo function, if the PackageVersionName > > is NULL return EFI_INVALID_PARAMETER > > > > Signed-off-by: Pethaiyan Madhan > > Cc: Liming Gao > > Cc: Michael D Kinney > > Cc: Wei6 Xu > > --- > > FmpDevicePkg/FmpDxe/FmpDxe.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/FmpDevicePkg/FmpDxe/FmpDxe.c > b/FmpDevicePkg/FmpDxe/FmpDxe.c > > index 1e7ec4a09e..e87094f84c 100644 > > --- a/FmpDevicePkg/FmpDxe/FmpDxe.c > > +++ b/FmpDevicePkg/FmpDxe/FmpDxe.c > > @@ -495,7 +495,7 @@ GetTheImageInfo ( > > // Confirm that buffer isn't null > > // > > if ( (ImageInfo =3D=3D NULL) || (DescriptorVersion =3D=3D NULL) || > > (DescriptorCount =3D=3D NULL) || (DescriptorSize =3D=3D NULL) > > - || (PackageVersion =3D=3D NULL)) > > + || (PackageVersion =3D=3D NULL) || (PackageVersionName =3D=3D NUL= L)) > > { > > DEBUG ((DEBUG_ERROR, "FmpDxe(%s): GetImageInfo() - Pointer > > Parameter is NULL.\n", mImageIdName)); > > Status =3D EFI_INVALID_PARAMETER; > > -- > > 2.38.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114012): https://edk2.groups.io/g/devel/message/114012 Mute This Topic: https://groups.io/mt/103620853/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-