From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 67951740032 for ; Wed, 1 May 2024 17:44:13 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=By/mCxLgzEGlkVF4+qmarpHPQsX+b47iObWrtm049mw=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1714585451; v=1; b=T0h0buetRLqdV2PggcbZDEFnWwysM0tpqaweqlUL6trm4l1CUA5HT3+mJNYZQx2xhNzZczZT Zv4HdK8BS59LnKAt8xDlma2FvtVCcC4mRgWDXsU+adXprfO6IWciXR97DcCcpc0MAGvi8qOEXPk FFJbcWZuSdgJJ3mRGWCR5lU85Chb9uFHAfuNEKB2V17HfqBe9L9kZBOgi5FrsJyw7lJK+iLiTdl WmG0XwzGgOx/q5FFdZYmOlqJMy5qvmhMzKeN1Z6PLvl6kUNpwXA+SLFnaYZxyLsfj9tfpDXsLed JDtv26Y+n1KkHs+lhTv+sId7G1Jdkmi5xEhyfAnzOsbjA== X-Received: by 127.0.0.2 with SMTP id zBbrYY7687511xMNQQ1hPF2W; Wed, 01 May 2024 10:44:11 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) by mx.groups.io with SMTP id smtpd.web11.2952.1714585443796948356 for ; Wed, 01 May 2024 10:44:06 -0700 X-CSE-ConnectionGUID: 02n3EpaDRByzIZ/Tp0dfrA== X-CSE-MsgGUID: FgALzqajS4CosYSzzQQYoQ== X-IronPort-AV: E=McAfee;i="6600,9927,11061"; a="27851110" X-IronPort-AV: E=Sophos;i="6.07,245,1708416000"; d="scan'208";a="27851110" X-Received: from orviesa006.jf.intel.com ([10.64.159.146]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 May 2024 10:44:03 -0700 X-CSE-ConnectionGUID: fm1AleVTQtm88fLjh0YP8w== X-CSE-MsgGUID: 2w/1AZwsQmGeKfezBhevtw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,245,1708416000"; d="scan'208";a="27266880" X-Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orviesa006.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 01 May 2024 10:44:04 -0700 X-Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 1 May 2024 10:44:02 -0700 X-Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Wed, 1 May 2024 10:44:02 -0700 X-Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.169) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 1 May 2024 10:43:59 -0700 X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com (2603:10b6:303:6d::19) by PH0PR11MB7634.namprd11.prod.outlook.com (2603:10b6:510:28d::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.35; Wed, 1 May 2024 17:43:51 +0000 X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::e34e:4d18:b93e:c368]) by CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::e34e:4d18:b93e:c368%5]) with mapi id 15.20.7519.035; Wed, 1 May 2024 17:43:51 +0000 From: "Michael D Kinney" To: "devel@edk2.groups.io" , "rfc@edk2.groups.io" CC: Leif Lindholm , "Andrew Fish (afish@apple.com)" , "Kinney, Michael D" Subject: [edk2-devel] Proposal to switch TianoCore Code Review from email to GitHub Pull Requests on 5-24-2024 Thread-Topic: Proposal to switch TianoCore Code Review from email to GitHub Pull Requests on 5-24-2024 Thread-Index: Adqb7x8IscZNQdbZROekmFEG+Zxa7A== Date: Wed, 1 May 2024 17:43:51 +0000 Message-ID: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO1PR11MB4929:EE_|PH0PR11MB7634:EE_ x-ms-office365-filtering-correlation-id: 62e06782-65cf-44e5-9be8-08dc6a0643aa x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: =?us-ascii?Q?8QfR9aJztXccTkYn6WY33TmKV9p8Q4CjOVW8RyfPzYHSf2Ft6wVpfffMmzqQ?= =?us-ascii?Q?IlroznJK08av46E3qEY/n+hDykEdBS7UXWcPqoz5GSRwrhrDOl8c9FUQr3eM?= =?us-ascii?Q?eQ81bM6J/otyknpPJvU1BJqoylWPEOgKnETVIhBa+XomGi9NQqr4Y7xpfI8A?= =?us-ascii?Q?qsNUwvUh+EMzQ9IFFIz8b4QCeCZFW9TJrZleprE9BFMb6TKruZXZdiU4MnCl?= =?us-ascii?Q?5m/frOJzvjD2z1sn43tFxeT6mScZBRf/x2R9KJwkFDgM7M8YObKWBz5nMGbs?= =?us-ascii?Q?+5+3+FItFRaAaTLonjHRhOPvy9biOGUNrXGK48y72Z/Enzl/h7Q8sJ4GlFF+?= =?us-ascii?Q?TpBHd0wyVA4Bahpx95Ar9cJ3gpZj7kn9SPZUB8JD/OA0XgZSm594psZNFUDZ?= =?us-ascii?Q?AJWFCPEvLA+pKyLi5qJo6kWZ6I+4Wq9jWgtGFqOwZ1lTcbF4AeIstPvR6IlK?= =?us-ascii?Q?62MVvPNR1GHx4lyX5qHya7VOUlWOTie0EMSj/ATy8cYvLebaNBaIqrHesEta?= =?us-ascii?Q?rRGEG15588CQXJ44JFXXb50iZVy8A8lkPnM13l3Xx+BbK5inWp5/ms/1h9P2?= =?us-ascii?Q?t0gfxXPlatSCkXPhNFMekllVo6+d4JYC0uJUY0Zl21c+IucHEdAW7CKxnvxW?= =?us-ascii?Q?UOgK2l1MoSLNcWCvbt/jhJKuRvmKC0idoUP2Z0Ra3cwk16pRmIQPTGNx9BM2?= =?us-ascii?Q?isiZV9pETC9RGveBTlemu8g010ZKg0tS0XGIrJYRz0bCk538bMKaquj+M50K?= =?us-ascii?Q?oe6NyKZAPrWhrnyb1lTZ/s8CfTR1ZZCffGi+pe/SB+5NkQB7diJyF3gaVzlk?= =?us-ascii?Q?gFOphIM1fJClyfUZTN0Hhh42lK61NIyJrtOz1V8HIRk2nsH4O9gKmeqb7kv/?= =?us-ascii?Q?y5ELHLaky4ie0ncU+4rGpaMdDmzcEjU5DIN3a47gsrK/j8drSkRdlbkeqTfs?= =?us-ascii?Q?NQX8vPMICLfuFE6Zt/PuMuv++mFre31USp5/bNEU7OF9K2lLF2gVm0ZcRcdI?= =?us-ascii?Q?kecgh83DbAVEghs7sizP8KNZSKl05ukMI4LqURVvhjRDSUAcwZL+GONCnuYm?= =?us-ascii?Q?nI+HuH1aCDAp7wDcFCJF2R/2JWAcijS5+gi8URbjFkWqQ4QhuDiWyFTOGgZZ?= =?us-ascii?Q?wjYZCQwlDVsGEiqgeMSd9olc2xmsNNp3VSyg0KRoDiTHyhGeSKP3eXDZaUHx?= =?us-ascii?Q?iWRuIUwykQgIN8pHVIwDlo7tY8fHjPfNbDqBL7F+fjTYopLfcrVedVe++s2/?= =?us-ascii?Q?ncHPUuGJIkl9S4hrg0uCThyDisdaiJN82MjBExZqEftQRVpQIymn8Bq4Euxf?= =?us-ascii?Q?gqY4vgDwy2156UPzKgmfXMEDTpJPpxXKhrUEdshIsyG1sd+5Qtcay4SHl3mD?= =?us-ascii?Q?lYVgLMk=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?DasGCciE1xyYCwntt1nRbGicfES6Fm9oDQnm00nLyyLg39WlP43Lx7j03g70?= =?us-ascii?Q?IoGJQRrMbCnKJ0iVMgo+xScMF7ZUvEsdxGqm6TW0U7mo9rUGTSClToIbqaNF?= =?us-ascii?Q?qz9Zx0tenB08Dxw25zT7n0bY57n27dKYmszaIeTrrN7z1dHabs1U6s+XoUMl?= =?us-ascii?Q?uKaRSR+EVNACRsX9h+cLuOajKkLXcRtOYGN0b2L8hfHbMfYf+FrgJCGHbWg/?= =?us-ascii?Q?d6zKpUWY5rLRaCpxyYS8Wql9AXYJWgC95UPBso9cPv+isDmuiW65GKitc/0J?= =?us-ascii?Q?5S1SnIDcpRGbj296KVqqM6/CBg3UWGT9IjopSiSY2m0kGeExDcm+92YQHxst?= =?us-ascii?Q?xeNrcOXzdxP9aKXmhxMl6ow1PjBh9ucvXAeJrJ9h7H+xhomiGNF/XY/XoxYK?= =?us-ascii?Q?sUSmO2KiJtMY56bnOSgu83w5SY7aMwx0uTCQO0fo6RU2mJQvBC8EREvqiX2k?= =?us-ascii?Q?ZZR1FTI+2GcRBGgIQwk2lTV0rFefv03l1pCdhxy71Lf4d2sEm+zTkoveu9F0?= =?us-ascii?Q?j66qmU2uMjFiXRZdZDdysLGsbQqnYbiVmDFEfyaQDirSE4eAGZYgfph4zVf5?= =?us-ascii?Q?V4vjwiLiUp/JibRbwnZr2Awav3SB36EnIA6+BJPbFEkRZSMQS5s+oo4/CXiY?= =?us-ascii?Q?057YDx8+NIZBVl1Yrz0NcifQGhOauiQf2jdhBMWO4bq1O3/vSd24dLzkItDR?= =?us-ascii?Q?0Bz3nVzUnGM312xTpFsc1IvT1mkzIf7BMmuUSPULmF/3hfystxKii2+E9TrQ?= =?us-ascii?Q?0HnttNx9DChS868Sq0h7AOBSJ9+KPNaJi2y84Yj1I8vRlC8qgjfP673xWouT?= =?us-ascii?Q?LmCRFPwyHUpzm3GtwG23x1A+VW7O4qzp1a4109KPNmCgRqrbvEK2eTJsl7s9?= =?us-ascii?Q?15RW11QH6qnenJscLlW5f5Es8f5u2oQuaypoV2slcsgr9zy+ui9sFooalmKk?= =?us-ascii?Q?SS/mfY0QsEjxu7ih/Pj8ZC+ZPJ6Jmy8iVRKCtTpYxFBQ7bs5z9MCAOOkaS2A?= =?us-ascii?Q?haKuiSKDDOiN3FCd4aZkosS6IUH8P9Dy4l/ruuAySzNdAg6BfYKUNhfAL8Bd?= =?us-ascii?Q?UISGqOEVIrZI09PbSiyfsoaVc5UHE/GzCQMlYKoYY8XVmRpidQfBAEaO0bWt?= =?us-ascii?Q?7uPGZhKLbYKmFFQvcknA969b6uiK1yE1ziKgGr2J9hHqbKM9ip/swvGqznpR?= =?us-ascii?Q?Y2K4r08eBGsWK8HyI1F5EIrI+vOvvZCfAbMR7qk1hhjDbL1F4kyw7rG8Ojes?= =?us-ascii?Q?qRFejHJZ5vXpU9Iehungf0w+5I9TxJZKkwJYJF9zG0WzGOulpIKTj19Y3CCV?= =?us-ascii?Q?iNTdVpFe62tVDqkHIY6pYTNNArY/qJ2RQezBFVqHSiQ/TqtxT5xtHxAZIwi5?= =?us-ascii?Q?u+vDyo41n9MqrVNacTeLNmB8bFtr/5k3E9vm8Xp+a6MjW2Q3GFElWNUt/0PL?= =?us-ascii?Q?PGd/JvktDsxW3zmnOhhpXAbYNOwSsJx7sjEYIWlG4t7qK6fkOmEYMA6HLyMI?= =?us-ascii?Q?Lb4oUlEQu1SR7KM3nyxy9RPshlR72dCoj0S2sGHyaSSRTxLg/ON22vZYlCzi?= =?us-ascii?Q?i74lDIBiZ69s0N2Gi4nI88XSodN6if+McThMrUnr?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4929.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 62e06782-65cf-44e5-9be8-08dc6a0643aa X-MS-Exchange-CrossTenant-originalarrivaltime: 01 May 2024 17:43:51.7175 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +ujUek1BGVJDkhkz6XmFz7X9y6hAZGf8oDXIFO3BE6/p+Ei5h9Xgx8DU2rHmxiBlXPP4S5Ed4w6vj9gd0Xo1VW/sQl1vTaGozM20XnVA2xM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB7634 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Wed, 01 May 2024 10:44:06 -0700 Resent-From: michael.d.kinney@intel.com Reply-To: devel@edk2.groups.io,michael.d.kinney@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: Ts3IMn92MEU9InbZIPV0p4BAx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=T0h0buet; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io Hello, I would like to propose that TianoCore move all code review from email based code reviews to GitHub Pull Requests based code reviews. The proposed date to switch would be immediately after the next stable tag which is currently scheduled for May 24, 2024. Updates to the following Wiki page would be required to describe the=20 required process when using GitHub Pull Requests for all code review related activity. https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Developmen= t-Process A couple examples of the changes that would need to be documented are: * All contributors, maintainers, and reviewers must have GitHub IDs. * The commit message would no longer require Cc:, Reviewed-by:, Acked-by: or Tested-by: tags. The only required tag would be Signed-off-by. * The Pull Request submitter is required to invite the required maintainers and reviewers to the pull request. This is the same=20 set of maintainers and reviewers that are required to be listed in Cc: tags in today's process. * Maintainers are responsible for verifying that all conversations in the code review are resolved and that all review approvals from the required set of maintainers are present before setting the 'push' label. Please provide feedback 1) If you are not in favor of this change. 2) If you are not in favor of the proposed date of this change. 3) On the process changes you would like to see documented in the Wiki pages related to using GitHub Pull Request based code reviews. There is some prototype work to automate/simplify some of the PR based code review process steps. Those could be added over time as resources are available to finish and support them.=20 Best regards, Mike -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118468): https://edk2.groups.io/g/devel/message/118468 Mute This Topic: https://groups.io/mt/105847510/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-