Re: [edk2-devel] [PATCH] MdeModulePkg/TerminalDxe: add modes

["Michael D Kinney" <michael.d.kinney@intel.com>]

This looks like a reasonable update to support platforms that have both 
graphical consoles and serial consoles.

Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>


> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Konstantin Aladyshev
> Sent: Monday, September 19, 2022 1:57 AM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J <jian.j.wang@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Ni, Ray <ray.ni@intel.com>; Konstantin
> Aladyshev <aladyshev22@gmail.com>
> Subject: [edk2-devel] [PATCH] MdeModulePkg/TerminalDxe: add modes
> 
> The commit b807174fecacf4c9f8400cab4d6fb3f580284021
> ("MdeModulePkg/GraphicsConsoleDxe: add modes") has added modes for the
> high display resolutions. Support these modes in the TerminalDxe as
> well, so it would be possible to select the text mode that would take
> all the available screen space.
> 
> Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
> ---
>  MdeModulePkg/Universal/Console/TerminalDxe/Terminal.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/MdeModulePkg/Universal/Console/TerminalDxe/Terminal.c b/MdeModulePkg/Universal/Console/TerminalDxe/Terminal.c
> index e2d779c783..6b7b970516 100644
> --- a/MdeModulePkg/Universal/Console/TerminalDxe/Terminal.c
> +++ b/MdeModulePkg/Universal/Console/TerminalDxe/Terminal.c
> @@ -115,6 +115,9 @@ TERMINAL_CONSOLE_MODE_DATA  mTerminalConsoleModeData[] = {
>    { 80,  25 },
> 
>    { 80,  50 },
> 
>    { 100, 31 },
> 
> +  { 128, 40 },
> 
> +  { 160, 42 },
> 
> +  { 240, 56 },
> 
>    //
> 
>    // New modes can be added here.
> 
>    //
> 
> --
> 2.25.1
> 
> 
> 
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#93935): https://edk2.groups.io/g/devel/message/93935
> Mute This Topic: https://groups.io/mt/93777396/1643496
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub [michael.d.kinney@intel.com]
> -=-=-=-=-=-=
>