From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id E04407803CD for ; Thu, 18 Jan 2024 23:27:43 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=Fi27qmL94mchO4vTd3F8afp3D7W2GC/ngQNQgxN59yU=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1705620462; v=1; b=TL6ZKWxUsNJZf9GHQfTJ43J40i3SG+TPaH8JH7XdEc4aUW+5TRbt2nfvLK6aD+8Me/05xmmF 2TwtwYaNNsKTDyodQGcWTwVxMyEiSu88Yw+gchwIWUizZKHaClP6HsLkY1iW0ON7M3yhXXNPv07 3wAQNAmyh1dSP8Ey+qKIBVvU= X-Received: by 127.0.0.2 with SMTP id IzH1YY7687511x8YGnt9I5cU; Thu, 18 Jan 2024 15:27:42 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) by mx.groups.io with SMTP id smtpd.web10.8798.1705620460977411745 for ; Thu, 18 Jan 2024 15:27:41 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10956"; a="497687" X-IronPort-AV: E=Sophos;i="6.05,203,1701158400"; d="scan'208";a="497687" X-Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jan 2024 15:27:40 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10956"; a="957966014" X-IronPort-AV: E=Sophos;i="6.05,203,1701158400"; d="scan'208";a="957966014" X-Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga005.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 18 Jan 2024 15:27:40 -0800 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 18 Jan 2024 15:27:39 -0800 X-Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 18 Jan 2024 15:27:39 -0800 X-Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.101) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 18 Jan 2024 15:27:38 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bNxd88HV8UIxU06Qe6urcUMNFlHawkMJQYKi0aR0iiQw2ITbJyk48w5yMJ6QYPuqiGPfPZ0/dl11hTlBeRaywCEwyfcFjQb34RF8PCTWFUK6kod5kQ6xKXrtBsLbgwRDgY9Wc5Ah7IJU5lHUSPl9MAFkOK0jv8zL+2SoGtx5p8ACHJf0cBG6Czgm02bBaEpImz52jbnx+YVk1ePfR/3/l9WzG7mox/KWSYqq+flMavMrk7gngEyfo0j0JG/gtlagW6mENH5TGBVlhpM98dFWmYo5MoYDHKfIV2UEGNdQwzRL0dDbI+AwlvayM5EdmeWG8UCs5OuXh0GJiOHsLrK4ZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=V7iXitBqYEnYCT2ueytsIpIZ8i71yuXztO6EbyQbK9A=; b=P716JJE6loa6RSKQfbNcaum/Vyw3TFHx/YxaqPadY+TAERbZaeTNfkNZmrYB6rlNZtu06xDB9HgjnioQ3uU2leT6IVYT3r/uhA5CQ0OgRYX3HKIXsfYLzGzySpTVhcwOBmLcniI/5sIILvWldSiK/D4NKqJsrmYrabTTJuhzlg5Ac6wifPHbJUs/dd2BE9ll3ZByXOzFTi9ok8hq6YykTHfJh4YqRxBtxTAohicrFC9cx0prSIDO0me6C6Mf3jh18PtyZS4Ei8SoENdEHfS+t9uZPv4mW7jWuEq/9Pz+zcVTgWIIqaaE6u2HE1p1ny1vjxTxTMDSczWB3oLYfB6TVA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com (2603:10b6:303:6d::19) by LV8PR11MB8488.namprd11.prod.outlook.com (2603:10b6:408:1e7::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7202.24; Thu, 18 Jan 2024 23:27:31 +0000 X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::4382:5b03:f13:88ff]) by CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::4382:5b03:f13:88ff%4]) with mapi id 15.20.7202.024; Thu, 18 Jan 2024 23:27:29 +0000 From: "Michael D Kinney" To: "Kasbekar, Saloni" , Ashish Singhal , "devel@edk2.groups.io" , "Clark-williams, Zachary" , Jeff Brasen , "Gao, Liming" CC: "Kinney, Michael D" Subject: Re: [edk2-devel] [PATCH] NetworkPkg/Ip4Dxe: Fix Reset To Default Thread-Topic: [PATCH] NetworkPkg/Ip4Dxe: Fix Reset To Default Thread-Index: AQHaSWptaECHoeKBlkeF+HCDu9zqEbDgONcQ Date: Thu, 18 Jan 2024 23:27:29 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO1PR11MB4929:EE_|LV8PR11MB8488:EE_ x-ms-office365-filtering-correlation-id: d83b3c32-3474-4068-e6c0-08dc187d0a07 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: Duyqu1LWRIzpCRJV0XtcBBcwkR0ckGphf8PJT66lgdRfQA7zExIj5QTlZzk3yyUHQpnuCb2OxfoHXoPjDTuYP8NH1GYF34RuacqUOOGO5NVXSjPaRRaX5Tb+ncK87vZyDlP8JFzUgZztE/gVEhBSUil7Vcred0YMyTGJpuHxfnGS/ENk5pTHlc069OG0l438922UGN/8HNAjyRVeZXYcDrrwWYOsDdzTKEoDe0rGWy9jEt2pP72ww49dIhjeH2vPUpMeqT9FznA0I4+CegJe9ancIr+RFDSxI8YI3GFOpluh/2eIN902wjN+7pb762i1q+LnqqkQfk0G8CF6JVQ1wujbVRYGtjH7NyOUrrFnGfdBZPlAmWpA7U/foYLxzKmzjYPt/FAk58ZZxpeXa1e4X+LX/grhYRD0l/ult5oLhoo/6Hg8i7PNwSuerrYHYrqo3yfmwW9eB+iLUmWgFSzFlVUOLsRx37gVTY2k1ksD78tzMAl+YtdOzS3YIvKThPyI2T6+ZhIryVWqLtizbZBbvmArTtKgUejuL2uYreetaTHGw3oQteA3fkLYj0V9fLO1TS6KrRIRGY3Ai5p5i0QynlW6jZPX/1ga9Fbe/5D99QORZu7B1XWN690w9qUYEez8smWd5nmFChqx+kRSfR+W1A== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?cYaBOpxt8hoA1TctyW0iNIDWFUNjBupA37BC1Pp/+BJw/iHVblG7wCuxiE?= =?iso-8859-1?Q?+QZ+HQx2+aCzmDsPTynsBQsMfsbp+1SKwIGTX6e4BkoIF4v3T9IZm9BF7V?= =?iso-8859-1?Q?XraNZKuoIj0Acj3rti+i+BXcEKN9Qr7kPI5ctWz69Ebd2eYXjPHgDOTS0y?= =?iso-8859-1?Q?HPEVx5afKMzt6hmJMlRmG9/cXzxlMyxW/BTnWibg5RFumJ57hV3/X78fUA?= =?iso-8859-1?Q?3cK1XkfJdYIBWErNhK66WqJ/TP4CwMYTv95iP9is68zRZUQHMulnDlYoLR?= =?iso-8859-1?Q?6Xljm6Dh/Ndnk+Fk6p59in/c9eP8XgpinINF7sNQUb4Rvh30aOjZiMv7+6?= =?iso-8859-1?Q?gVxo36IaRWulRzE1NHTJvFSFbmzlqzOh5YU/0CiWwCsJddbTYVMx4Fdug/?= =?iso-8859-1?Q?kj194GcP142F87vrftmTelWcvNdBcJoeRXdqYvF9QyNS0MWhNWWABcCWsN?= =?iso-8859-1?Q?JC7q7LsNHpHdjzvTcNS0rzvu2ulhRMqT3YmL7r+sDSg8tOPW1dEThUhqJi?= =?iso-8859-1?Q?whGMIeUQ6ptjLG5oHuby2zJVMQlfi4zJB7yAzPsqnnM+d0Xin9ErBlvmLa?= =?iso-8859-1?Q?Ex2T/gqGC/Qm5sbBQMhsxWuZ3SOoUaOLIyPRQOo7iTk9fnIR6QojXonAi8?= =?iso-8859-1?Q?bpSvtlTo1Xm1dAidvFzJ74sb6cHnp6eVy5dOmVALkqEGGyvji0ekEey95r?= =?iso-8859-1?Q?4UfXiEOvqOvILhR430Uti0Me+RWsYacLNHE8kt2txzgw0BJFiE/Vpuv97y?= =?iso-8859-1?Q?LfSgIMSUTMHHDhkVcA4P0ozAlsg2rAZzLbqxNt9grvkpgb8lyA4aaU6eDf?= =?iso-8859-1?Q?EFmnmUBOo6c1zwdsExlYXwK16ell8NnHz1M4NcWNBgw9acmYO2saegJ6+w?= =?iso-8859-1?Q?61biiC+hI8w7SiwZPRYBJ/6wcTYuLqGM9fEbK8W6CyD3pkxm9qvX41G1KL?= =?iso-8859-1?Q?wVpfWsU0pAAPrPbGUOinuDKPN3GQuNFsClO8Pz0uvHouEWU4hJWOFIZBoM?= =?iso-8859-1?Q?8qWg7QW+7YFrUdP2K4z66y7SF9xPgdjnaiBl3HAMEtGgKkm3lzJw1M9V2i?= =?iso-8859-1?Q?D+CGOqYK7QUipbH7KkGo5IAeQj7CNsXa5FRlcE45WMRG0txP2+mReUCHCf?= =?iso-8859-1?Q?dT1jnOPFhJSwceuHwsttfLJVLtbO1XCgg9KPRxphpbePIPWx59SW3eDZyJ?= =?iso-8859-1?Q?BndfJyfpapulRXtKN7fg4IOqPO1QAg5lXlwk5SmrxI5d2AlFyXM21af1IN?= =?iso-8859-1?Q?66qsOxxWuHxxF1536Fv6X3ltU9f4Atga2DsC1AWIgVP/uaTYnFYMsP46AQ?= =?iso-8859-1?Q?8jvK/Tid0VLTsIjgjbL6NEVFJ6m8bxeUcD7AtYyPVC6Bgh5XfLSsEFfD8K?= =?iso-8859-1?Q?gs1k1nk3lbyc6yJAroKqRO/4NbDwUEtTI1iew67Usyc2jWxwYIPyRLylR2?= =?iso-8859-1?Q?lkKnbYplTBhuhrPSgTgXyHlLnWfJ1hz1Na3tISF8xrVCtRy2FsYJ8s489D?= =?iso-8859-1?Q?XnLHyWppyxsnAsoElN8Fo041gK7WKoI5U483XQM1UbZq9y8BLimLZPX0aN?= =?iso-8859-1?Q?yGTyq4RgbYhmZ2nhrzEpznPCXxriTfZ1VLbgEWt71p49+SRE1iTpDkXWbY?= =?iso-8859-1?Q?ropOMnCGFC+KYlxMvsg2tKTeo3mKRtXZNofl7JosjW79HvQBiWMuvSdA?= =?iso-8859-1?Q?=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4929.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d83b3c32-3474-4068-e6c0-08dc187d0a07 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jan 2024 23:27:29.7799 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: wOZwrDCFq25F9/nBxnSiCOVkz0OgXSwV+RLA+zMhimFymKFLE9lDz3gkMU0CI2x6qDD5PGgIAJv35XF5jZXXuaZKY+LLczIDy5m2qAIT+j0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR11MB8488 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,michael.d.kinney@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: yV5ue5lezDOZ7NXLj3plxy3Bx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=TL6ZKWxU; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Acked-by: Michael D Kinney I will prepare PR for merge From: Kasbekar, Saloni =20 Sent: Wednesday, January 17, 2024 9:27 AM To: Ashish Singhal ; devel@edk2.groups.io; Clark-w= illiams, Zachary ; Jeff Brasen ; Kinney, Michael D ; Gao, Liming Subject: RE: [PATCH] NetworkPkg/Ip4Dxe: Fix Reset To Default Liming, Mike, Could you please help merge this PR? Thanks, Saloni From: Ashish Singhal =20 Sent: Wednesday, January 17, 2024 6:08 AM To: Kasbekar, Saloni ; mailto:devel@edk2.= groups.io; Clark-williams, Zachary ; Jeff Brasen Subject: Re: [PATCH] NetworkPkg/Ip4Dxe: Fix Reset To Default Hello, Checking back for an update on when this PR can be merged or if there are a= ny other changes you recommend. Thanks Ashish ________________________________________ From:=A0Ashish Singhal Sent:=A0Saturday, January 6, 2024 5:53 AM To:=A0Kasbekar, Saloni ; mailto:devel@edk= 2.groups.io ; Clark-williams, Zachary ; Jeff Brasen Subject:=A0Re: [PATCH] NetworkPkg/Ip4Dxe: Fix Reset To Default=20 =A0 Thanks Saloni. PR for getting this merged is available at https://github.co= m/tianocore/edk2/pull/5150 Thanks Ashish ________________________________________ From:=A0Kasbekar, Saloni Sent:=A0Saturday, January 6, 2024 1:31 AM To:=A0Ashish Singhal ; mailto:devel@edk2.gr= oups.io ; Clark-williams, Zachary ; Jeff Brasen Subject:=A0RE: [PATCH] NetworkPkg/Ip4Dxe: Fix Reset To Default=20 =A0 External email: Use caution opening links or attachments Yes, SetData does reset the previous configuration. =A0 Reviewed-by: Saloni Kasbekar =A0 Thanks, Saloni =A0 From:=A0Ashish Singhal Sent:=A0Friday, January 5, 2024 2:34 AM To:=A0Kasbekar, Saloni ; mailto:devel@edk= 2.groups.io; Clark-williams, Zachary ; Jeff Brasen Subject:=A0Re: [PATCH] NetworkPkg/Ip4Dxe: Fix Reset To Default =A0 I do not recommend doing that. Setting policy via SetData does enough to wi= pe out any previous manual configuration and that is the goal for reset to = default. ________________________________________ From:=A0Kasbekar, Saloni Sent:=A0Friday, January 5, 2024 2:30 AM To:=A0Ashish Singhal ; mailto:devel@edk2.gr= oups.io=A0; Clark-williams, Zachary ; Jeff Brasen Subject:=A0RE: [PATCH] NetworkPkg/Ip4Dxe: Fix Reset To Default =A0 External email: Use caution opening links or attachments =A0 Makes sense. Should we also set IfrNvData->DhcpEnable =3D TRUE when updatin= g the Policy then? =A0 From:=A0Ashish Singhal Sent:=A0Wednesday, January 3, 2024 8:52 AM To:=A0Kasbekar, Saloni ; mailto:devel@edk= 2.groups.io; Clark-williams, Zachary ; Jeff Brasen Subject:=A0Re: [PATCH] NetworkPkg/Ip4Dxe: Fix Reset To Default =A0 Hello Saloni, =A0 Thanks for the feedback. After the reset, or when we disable configure from= menu, GetData returns policy to static as the enum value is 0. However, se= tting value as static does not have any benefit as it forces to reuse the o= ld network settings. Using DHCP really mimics the reset behavior that we se= e without any configuration done manually. =A0 Thanks Ashish =A0 ________________________________________ From:=A0Kasbekar, Saloni Sent:=A0Tuesday, January 2, 2024 1:47 PM To:=A0Ashish Singhal ; mailto:devel@edk2.gr= oups.io=A0; Clark-williams, Zachary ; Jeff Brasen Subject:=A0RE: [PATCH] NetworkPkg/Ip4Dxe: Fix Reset To Default =A0 External email: Use caution opening links or attachments =A0 Hi Ashish, =A0 +=A0=A0=A0 Ip4NvData->Policy =3D Ip4Config2PolicyDhcp; +=A0=A0=A0 Status=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 =3D Ip4Cfg2->SetData ( +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 Ip4Cfg2, +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 Ip4Config2DataTypePolicy, +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 sizeof (EFI_IP4_CONFIG2_POLICY), +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 &Ip4NvData->Policy +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 ); =A0 Here we're assuming IfrFormNvData->DhcpEnable is TRUE. Should we check it b= efore setting the policy and calling SetData()? =A0 Thanks, Saloni =A0 =A0 From:=A0Ashish Singhal Sent:=A0Monday, January 1, 2024 8:48 AM To: mailto:devel@edk2.groups.io; Kasbekar, Saloni ; Clark-williams, Zachary ; Jeff Brasen Subject:=A0Re: [PATCH] NetworkPkg/Ip4Dxe: Fix Reset To Default =A0 Hello, =A0 Checking again for some feedback on this. =A0 Thanks Ashish =A0 ________________________________________ From:=A0Ashish Singhal Sent:=A0Thursday, December 14, 2023 4:42 PM To: mailto:devel@edk2.groups.io=A0; mailto:sal= oni.kasbekar@intel.com=A0; mailto:zachary= .clark-williams@intel.com=A0; Jeff= Brasen Cc:=A0Ashish Singhal Subject:=A0[PATCH] NetworkPkg/Ip4Dxe: Fix Reset To Default =A0 Exercising reset to default does not reset the settings. Add handler code for the case where configuration is disabled. Signed-off-by: Ashish Singhal --- =A0NetworkPkg/Ip4Dxe/Ip4Config2Nv.c | 25 +++++++++++++++++++++++++ =A01 file changed, 25 insertions(+) diff --git a/NetworkPkg/Ip4Dxe/Ip4Config2Nv.c b/NetworkPkg/Ip4Dxe/Ip4Config= 2Nv.c index e0b6a4d4a9..dac5817b7c 100644 --- a/NetworkPkg/Ip4Dxe/Ip4Config2Nv.c +++ b/NetworkPkg/Ip4Dxe/Ip4Config2Nv.c @@ -586,6 +586,31 @@ Ip4Config2ConvertIfrNvDataToConfigNvData ( =A0=A0 } =A0 =A0=A0 if (IfrFormNvData->Configure !=3D TRUE) { +=A0=A0=A0 if (Ip4NvData->DnsAddress !=3D NULL) { +=A0=A0=A0=A0=A0 FreePool (Ip4NvData->DnsAddress); +=A0=A0=A0=A0=A0 Ip4NvData->DnsAddress=A0=A0=A0=A0=A0 =3D NULL; +=A0=A0=A0=A0=A0 Ip4NvData->DnsAddressCount =3D 0; +=A0=A0=A0 } + +=A0=A0=A0 if (Ip4NvData->GatewayAddress !=3D NULL) { +=A0=A0=A0=A0=A0 FreePool (Ip4NvData->GatewayAddress); +=A0=A0=A0=A0=A0 Ip4NvData->GatewayAddress=A0=A0=A0=A0=A0 =3D NULL; +=A0=A0=A0=A0=A0 Ip4NvData->GatewayAddressCount =3D 0; +=A0=A0=A0 } + +=A0=A0=A0 if (Ip4NvData->ManualAddress !=3D NULL) { +=A0=A0=A0=A0=A0 FreePool (Ip4NvData->ManualAddress); +=A0=A0=A0=A0=A0 Ip4NvData->ManualAddress=A0=A0=A0=A0=A0 =3D NULL; +=A0=A0=A0=A0=A0 Ip4NvData->ManualAddressCount =3D 0; +=A0=A0=A0 } + +=A0=A0=A0 Ip4NvData->Policy =3D Ip4Config2PolicyDhcp; +=A0=A0=A0 Status=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 =3D Ip4Cfg2->SetData ( +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 Ip4Cfg2, +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 Ip4Config2DataTypePolicy, +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 sizeof (EFI_IP4_CONFIG2_POLICY), +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 &Ip4NvData->Policy +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 ); =A0=A0=A0=A0 return EFI_SUCCESS; =A0=A0 } =A0 -- 2.17.1 Hello, Hello Saloni, Thanks=A0 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114017): https://edk2.groups.io/g/devel/message/114017 Mute This Topic: https://groups.io/mt/103181314/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-