public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [edk2-devel] [PATCH v4 0/3] Update ReceiveData and SendData function description
@ 2024-02-26  3:05 Qingyu
  2024-02-26  3:05 ` [edk2-devel] [PATCH v4 1/3] MdePkg: " Qingyu
                   ` (3 more replies)
  0 siblings, 4 replies; 8+ messages in thread
From: Qingyu @ 2024-02-26  3:05 UTC (permalink / raw)
  To: devel

Refer to Uefi spec 2.10 section 13.14, update the parameter 'MediaId'
description for EFI_STORAGE_SECURITY_COMMAND_PROTOCOL function ReceiveData
and SendData.

V4:
Split patch so there is one patch per package

V3:
Add maintainer to CC list.

V2:
Update some functions description in C and H header files in MdeModulePkg and SecurityPkg.

V1:
update the parameter description in MdePkg/Include/Protocol/StorageSecurityCommand.h.

Qingyu (3):
  MdePkg: Update ReceiveData and SendData function description
  MdeModulePkg: Update ReceiveData and SendData function description
  SecurityPkg: Update ReceiveData and SendData function description

 MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBus.c              |  8 ++++++--
 MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBus.h              |  8 ++++++--
 .../Bus/Pci/NvmExpressDxe/NvmExpressBlockIo.c        |  8 ++++++--
 .../Bus/Pci/NvmExpressDxe/NvmExpressBlockIo.h        |  8 ++++++--
 MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c         |  8 ++++++--
 MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.h         |  8 ++++++--
 MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.c            | 12 +++++++++---
 MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.h            | 12 +++++++++---
 MdePkg/Include/Protocol/StorageSecurityCommand.h     |  8 ++++++--
 SecurityPkg/Tcg/Opal/OpalPassword/OpalPasswordPei.c  |  8 ++++++--
 10 files changed, 66 insertions(+), 22 deletions(-)

-- 
2.39.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115950): https://edk2.groups.io/g/devel/message/115950
Mute This Topic: https://groups.io/mt/104581208/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



^ permalink raw reply	[flat|nested] 8+ messages in thread

* [edk2-devel] [PATCH v4 1/3] MdePkg: Update ReceiveData and SendData function description
  2024-02-26  3:05 [edk2-devel] [PATCH v4 0/3] Update ReceiveData and SendData function description Qingyu
@ 2024-02-26  3:05 ` Qingyu
  2024-03-06 14:10   ` 回复: " gaoliming via groups.io
  2024-02-26  3:05 ` [edk2-devel] [PATCH v4 2/3] MdeModulePkg: " Qingyu
                   ` (2 subsequent siblings)
  3 siblings, 1 reply; 8+ messages in thread
From: Qingyu @ 2024-02-26  3:05 UTC (permalink / raw)
  To: devel; +Cc: Michael D Kinney, Liming Gao, Zhiguang Liu

Refer to Uefi spec 2.10 section 13.14, update the parameter 'MediaId'
description for EFI_STORAGE_SECURITY_COMMAND_PROTOCOL function ReceiveData
and SendData.

Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Zhiguang Liu <zhiguang.liu@intel.com>
Signed-off-by: Qingyu <qingyu.shang@intel.com>
---
 MdePkg/Include/Protocol/StorageSecurityCommand.h | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/MdePkg/Include/Protocol/StorageSecurityCommand.h b/MdePkg/Include/Protocol/StorageSecurityCommand.h
index 810af59b85c3..206ae79aff8d 100644
--- a/MdePkg/Include/Protocol/StorageSecurityCommand.h
+++ b/MdePkg/Include/Protocol/StorageSecurityCommand.h
@@ -59,7 +59,9 @@ typedef struct _EFI_STORAGE_SECURITY_COMMAND_PROTOCOL EFI_STORAGE_SECURITY_COMMA
   function shall return EFI_DEVICE_ERROR.
 
   @param  This                         Indicates a pointer to the calling context.
-  @param  MediaId                      ID of the medium to receive data from.
+  @param  MediaId                      ID of the medium to receive data from. If there is no
+                                       block IO protocol supported by the physical device, the
+                                       value of MediaId is undefined.
   @param  Timeout                      The timeout, in 100ns units, to use for the execution
                                        of the security protocol command. A Timeout value of 0
                                        means that this function will wait indefinitely for the
@@ -138,7 +140,9 @@ EFI_STATUS
   shall return EFI_DEVICE_ERROR.
 
   @param  This                         Indicates a pointer to the calling context.
-  @param  MediaId                      ID of the medium to receive data from.
+  @param  MediaId                      ID of the medium to receive data from. If there is no
+                                       block IO protocol supported by the physical device, the
+                                       value of MediaId is undefined.
   @param  Timeout                      The timeout, in 100ns units, to use for the execution
                                        of the security protocol command. A Timeout value of 0
                                        means that this function will wait indefinitely for the
-- 
2.39.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115951): https://edk2.groups.io/g/devel/message/115951
Mute This Topic: https://groups.io/mt/104581209/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [edk2-devel] [PATCH v4 2/3] MdeModulePkg: Update ReceiveData and SendData function description
  2024-02-26  3:05 [edk2-devel] [PATCH v4 0/3] Update ReceiveData and SendData function description Qingyu
  2024-02-26  3:05 ` [edk2-devel] [PATCH v4 1/3] MdePkg: " Qingyu
@ 2024-02-26  3:05 ` Qingyu
  2024-03-06 14:10   ` 回复: " gaoliming via groups.io
  2024-02-26  3:05 ` [edk2-devel] [PATCH v4 3/3] SecurityPkg: " Qingyu
  2024-03-13  4:24 ` [edk2-devel] [PATCH v4 0/3] " Michael D Kinney
  3 siblings, 1 reply; 8+ messages in thread
From: Qingyu @ 2024-02-26  3:05 UTC (permalink / raw)
  To: devel; +Cc: Liming Gao, Michael D Kinney

AtaBusDxe, NvmExpressDxe, ScsiDiskDxe and EmmcDxe is used to back the
EFI_STORAGE_SECURITY_COMMAND_PROTOCOL, update the parameter 'MediaId'
description for the protocal function ReceiveData and SendData as described
in Uefi spec 2.10 section 13.14.

Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Signed-off-by: Qingyu <qingyu.shang@intel.com>
---
 MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBus.c              |  8 ++++++--
 MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBus.h              |  8 ++++++--
 .../Bus/Pci/NvmExpressDxe/NvmExpressBlockIo.c        |  8 ++++++--
 .../Bus/Pci/NvmExpressDxe/NvmExpressBlockIo.h        |  8 ++++++--
 MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c         |  8 ++++++--
 MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.h         |  8 ++++++--
 MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.c            | 12 +++++++++---
 MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.h            | 12 +++++++++---
 8 files changed, 54 insertions(+), 18 deletions(-)

diff --git a/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBus.c b/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBus.c
index a729c087ff5a..67c6389bb8b3 100644
--- a/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBus.c
+++ b/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBus.c
@@ -1483,7 +1483,9 @@ AtaDiskInfoWhichIde (
   function shall return EFI_DEVICE_ERROR.
 
   @param  This                         Indicates a pointer to the calling context.
-  @param  MediaId                      ID of the medium to receive data from.
+  @param  MediaId                      ID of the medium to receive data from. If there is no
+                                       block IO protocol supported by the physical device, the
+                                       value of MediaId is undefined.
   @param  Timeout                      The timeout, in 100ns units, to use for the execution
                                        of the security protocol command. A Timeout value of 0
                                        means that this function will wait indefinitely for the
@@ -1600,7 +1602,9 @@ AtaStorageSecurityReceiveData (
   shall return EFI_DEVICE_ERROR.
 
   @param  This                         Indicates a pointer to the calling context.
-  @param  MediaId                      ID of the medium to receive data from.
+  @param  MediaId                      ID of the medium to receive data from. If there is no
+                                       block IO protocol supported by the physical device, the
+                                       value of MediaId is undefined.
   @param  Timeout                      The timeout, in 100ns units, to use for the execution
                                        of the security protocol command. A Timeout value of 0
                                        means that this function will wait indefinitely for the
diff --git a/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBus.h b/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBus.h
index 6bc345f7e777..8906947e28b3 100644
--- a/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBus.h
+++ b/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBus.h
@@ -927,7 +927,9 @@ AtaDiskInfoWhichIde (
   function shall return EFI_DEVICE_ERROR.
 
   @param  This                         Indicates a pointer to the calling context.
-  @param  MediaId                      ID of the medium to receive data from.
+  @param  MediaId                      ID of the medium to receive data from. If there is no
+                                       block IO protocol supported by the physical device, the
+                                       value of MediaId is undefined.
   @param  Timeout                      The timeout, in 100ns units, to use for the execution
                                        of the security protocol command. A Timeout value of 0
                                        means that this function will wait indefinitely for the
@@ -1007,7 +1009,9 @@ AtaStorageSecurityReceiveData (
   shall return EFI_DEVICE_ERROR.
 
   @param  This                         Indicates a pointer to the calling context.
-  @param  MediaId                      ID of the medium to receive data from.
+  @param  MediaId                      ID of the medium to receive data from. If there is no
+                                       block IO protocol supported by the physical device, the
+                                       value of MediaId is undefined.
   @param  Timeout                      The timeout, in 100ns units, to use for the execution
                                        of the security protocol command. A Timeout value of 0
                                        means that this function will wait indefinitely for the
diff --git a/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressBlockIo.c b/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressBlockIo.c
index b6ed7f7031b3..e0a85c1cb34e 100644
--- a/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressBlockIo.c
+++ b/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressBlockIo.c
@@ -1699,7 +1699,9 @@ TrustTransferNvmeDevice (
   function shall return EFI_DEVICE_ERROR.
 
   @param  This                         Indicates a pointer to the calling context.
-  @param  MediaId                      ID of the medium to receive data from.
+  @param  MediaId                      ID of the medium to receive data from. If there is no
+                                       block IO protocol supported by the physical device, the
+                                       value of MediaId is undefined.
   @param  Timeout                      The timeout, in 100ns units, to use for the execution
                                        of the security protocol command. A Timeout value of 0
                                        means that this function will wait indefinitely for the
@@ -1812,7 +1814,9 @@ NvmeStorageSecurityReceiveData (
   shall return EFI_DEVICE_ERROR.
 
   @param  This                         Indicates a pointer to the calling context.
-  @param  MediaId                      ID of the medium to receive data from.
+  @param  MediaId                      ID of the medium to receive data from. If there is no
+                                       block IO protocol supported by the physical device, the
+                                       value of MediaId is undefined.
   @param  Timeout                      The timeout, in 100ns units, to use for the execution
                                        of the security protocol command. A Timeout value of 0
                                        means that this function will wait indefinitely for the
diff --git a/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressBlockIo.h b/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressBlockIo.h
index 8cad15efd33a..5547e057e77a 100644
--- a/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressBlockIo.h
+++ b/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressBlockIo.h
@@ -289,7 +289,9 @@ NvmeBlockIoFlushBlocksEx (
   function shall return EFI_DEVICE_ERROR.
 
   @param  This                         Indicates a pointer to the calling context.
-  @param  MediaId                      ID of the medium to receive data from.
+  @param  MediaId                      ID of the medium to receive data from. If there is no
+                                       block IO protocol supported by the physical device, the
+                                       value of MediaId is undefined.
   @param  Timeout                      The timeout, in 100ns units, to use for the execution
                                        of the security protocol command. A Timeout value of 0
                                        means that this function will wait indefinitely for the
@@ -369,7 +371,9 @@ NvmeStorageSecurityReceiveData (
   shall return EFI_DEVICE_ERROR.
 
   @param  This                         Indicates a pointer to the calling context.
-  @param  MediaId                      ID of the medium to receive data from.
+  @param  MediaId                      ID of the medium to receive data from. If there is no
+                                       block IO protocol supported by the physical device, the
+                                       value of MediaId is undefined.
   @param  Timeout                      The timeout, in 100ns units, to use for the execution
                                        of the security protocol command. A Timeout value of 0
                                        means that this function will wait indefinitely for the
diff --git a/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c b/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c
index 670f70caf41f..e79110c14e11 100644
--- a/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c
+++ b/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c
@@ -1897,7 +1897,9 @@ Done:
   function shall return EFI_DEVICE_ERROR.
 
   @param  This                         Indicates a pointer to the calling context.
-  @param  MediaId                      ID of the medium to receive data from.
+  @param  MediaId                      ID of the medium to receive data from. If there is no
+                                       block IO protocol supported by the physical device, the
+                                       value of MediaId is undefined.
   @param  Timeout                      The timeout, in 100ns units, to use for the execution
                                        of the security protocol command. A Timeout value of 0
                                        means that this function will wait indefinitely for the
@@ -2119,7 +2121,9 @@ Done:
   shall return EFI_DEVICE_ERROR.
 
   @param  This                         Indicates a pointer to the calling context.
-  @param  MediaId                      ID of the medium to receive data from.
+  @param  MediaId                      ID of the medium to receive data from. If there is no
+                                       block IO protocol supported by the physical device, the
+                                       value of MediaId is undefined.
   @param  Timeout                      The timeout, in 100ns units, to use for the execution
                                        of the security protocol command. A Timeout value of 0
                                        means that this function will wait indefinitely for the
diff --git a/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.h b/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.h
index 5a25b55c4952..49a00403695f 100644
--- a/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.h
+++ b/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.h
@@ -677,7 +677,9 @@ ScsiDiskEraseBlocks (
   function shall return EFI_DEVICE_ERROR.
 
   @param  This                         Indicates a pointer to the calling context.
-  @param  MediaId                      ID of the medium to receive data from.
+  @param  MediaId                      ID of the medium to receive data from. If there is no
+                                       block IO protocol supported by the physical device, the
+                                       value of MediaId is undefined.
   @param  Timeout                      The timeout, in 100ns units, to use for the execution
                                        of the security protocol command. A Timeout value of 0
                                        means that this function will wait indefinitely for the
@@ -751,7 +753,9 @@ ScsiDiskReceiveData (
   shall return EFI_DEVICE_ERROR.
 
   @param  This                         Indicates a pointer to the calling context.
-  @param  MediaId                      ID of the medium to receive data from.
+  @param  MediaId                      ID of the medium to receive data from. If there is no
+                                       block IO protocol supported by the physical device, the
+                                       value of MediaId is undefined.
   @param  Timeout                      The timeout, in 100ns units, to use for the execution
                                        of the security protocol command. A Timeout value of 0
                                        means that this function will wait indefinitely for the
diff --git a/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.c b/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.c
index 39b7c7ce6ef1..61fa740be505 100644
--- a/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.c
+++ b/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.c
@@ -1267,7 +1267,9 @@ EmmcFlushBlocksEx (
   function shall return EFI_DEVICE_ERROR.
 
   @param[in]  This                         Indicates a pointer to the calling context.
-  @param[in]  MediaId                      ID of the medium to receive data from.
+  @param[in]  MediaId                      ID of the medium to receive data from. If there is no
+                                           block IO protocol supported by the physical device, the
+                                           value of MediaId is undefined.
   @param[in]  Timeout                      The timeout, in 100ns units, to use for the execution
                                            of the security protocol command. A Timeout value of 0
                                            means that this function will wait indefinitely for the
@@ -1454,7 +1456,9 @@ EmmcSecurityProtocolInOut (
   function shall return EFI_DEVICE_ERROR.
 
   @param  This                         Indicates a pointer to the calling context.
-  @param  MediaId                      ID of the medium to receive data from.
+  @param  MediaId                      ID of the medium to receive data from. If there is no
+                                       block IO protocol supported by the physical device, the
+                                       value of MediaId is undefined.
   @param  Timeout                      The timeout, in 100ns units, to use for the execution
                                        of the security protocol command. A Timeout value of 0
                                        means that this function will wait indefinitely for the
@@ -1555,7 +1559,9 @@ EmmcSecurityProtocolIn (
   shall return EFI_DEVICE_ERROR.
 
   @param  This                         Indicates a pointer to the calling context.
-  @param  MediaId                      ID of the medium to receive data from.
+  @param  MediaId                      ID of the medium to receive data from. If there is no
+                                       block IO protocol supported by the physical device, the
+                                       value of MediaId is undefined.
   @param  Timeout                      The timeout, in 100ns units, to use for the execution
                                        of the security protocol command. A Timeout value of 0
                                        means that this function will wait indefinitely for the
diff --git a/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.h b/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.h
index 2568f0359df3..8c7e5d2675ff 100644
--- a/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.h
+++ b/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.h
@@ -250,7 +250,9 @@ EmmcFlushBlocksEx (
   function shall return EFI_DEVICE_ERROR.
 
   @param[in]  This                         Indicates a pointer to the calling context.
-  @param[in]  MediaId                      ID of the medium to receive data from.
+  @param[in]  MediaId                      ID of the medium to receive data from. If there is no
+                                           block IO protocol supported by the physical device, the
+                                           value of MediaId is undefined.
   @param[in]  Timeout                      The timeout, in 100ns units, to use for the execution
                                            of the security protocol command. A Timeout value of 0
                                            means that this function will wait indefinitely for the
@@ -337,7 +339,9 @@ EmmcSecurityProtocolInOut (
   function shall return EFI_DEVICE_ERROR.
 
   @param  This                         Indicates a pointer to the calling context.
-  @param  MediaId                      ID of the medium to receive data from.
+  @param  MediaId                      ID of the medium to receive data from. If there is no
+                                       block IO protocol supported by the physical device, the
+                                       value of MediaId is undefined.
   @param  Timeout                      The timeout, in 100ns units, to use for the execution
                                        of the security protocol command. A Timeout value of 0
                                        means that this function will wait indefinitely for the
@@ -417,7 +421,9 @@ EmmcSecurityProtocolIn (
   shall return EFI_DEVICE_ERROR.
 
   @param  This                         Indicates a pointer to the calling context.
-  @param  MediaId                      ID of the medium to receive data from.
+  @param  MediaId                      ID of the medium to receive data from. If there is no
+                                       block IO protocol supported by the physical device, the
+                                       value of MediaId is undefined.
   @param  Timeout                      The timeout, in 100ns units, to use for the execution
                                        of the security protocol command. A Timeout value of 0
                                        means that this function will wait indefinitely for the
-- 
2.39.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115952): https://edk2.groups.io/g/devel/message/115952
Mute This Topic: https://groups.io/mt/104581210/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [edk2-devel] [PATCH v4 3/3] SecurityPkg: Update ReceiveData and SendData function description
  2024-02-26  3:05 [edk2-devel] [PATCH v4 0/3] Update ReceiveData and SendData function description Qingyu
  2024-02-26  3:05 ` [edk2-devel] [PATCH v4 1/3] MdePkg: " Qingyu
  2024-02-26  3:05 ` [edk2-devel] [PATCH v4 2/3] MdeModulePkg: " Qingyu
@ 2024-02-26  3:05 ` Qingyu
  2024-02-28  5:57   ` Yao, Jiewen
  2024-03-13  4:24 ` [edk2-devel] [PATCH v4 0/3] " Michael D Kinney
  3 siblings, 1 reply; 8+ messages in thread
From: Qingyu @ 2024-02-26  3:05 UTC (permalink / raw)
  To: devel; +Cc: Jiewen Yao

Refer to Uefi spec 2.10 section 13.14, update the parameter 'MediaId'
description for EFI_STORAGE_SECURITY_COMMAND_PROTOCOL function ReceiveData
and SendData.

Cc: Jiewen Yao <jiewen.yao@intel.com>
Signed-off-by: Qingyu <qingyu.shang@intel.com>
---
 SecurityPkg/Tcg/Opal/OpalPassword/OpalPasswordPei.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/SecurityPkg/Tcg/Opal/OpalPassword/OpalPasswordPei.c b/SecurityPkg/Tcg/Opal/OpalPassword/OpalPasswordPei.c
index 0fb6b1bf41d5..1ee55105e435 100644
--- a/SecurityPkg/Tcg/Opal/OpalPassword/OpalPasswordPei.c
+++ b/SecurityPkg/Tcg/Opal/OpalPassword/OpalPasswordPei.c
@@ -49,7 +49,9 @@ EFI_GUID  mOpalDeviceLockBoxGuid = OPAL_DEVICE_LOCKBOX_GUID;
   function shall return EFI_DEVICE_ERROR.
 
   @param  This                         Indicates a pointer to the calling context.
-  @param  MediaId                      ID of the medium to receive data from.
+  @param  MediaId                      ID of the medium to receive data from. If there is no
+                                       block IO protocol supported by the physical device, the
+                                       value of MediaId is undefined.
   @param  Timeout                      The timeout, in 100ns units, to use for the execution
                                        of the security protocol command. A Timeout value of 0
                                        means that this function will wait indefinitely for the
@@ -148,7 +150,9 @@ SecurityReceiveData (
   shall return EFI_DEVICE_ERROR.
 
   @param  This                         Indicates a pointer to the calling context.
-  @param  MediaId                      ID of the medium to receive data from.
+  @param  MediaId                      ID of the medium to receive data from. If there is no
+                                       block IO protocol supported by the physical device, the
+                                       value of MediaId is undefined.
   @param  Timeout                      The timeout, in 100ns units, to use for the execution
                                        of the security protocol command. A Timeout value of 0
                                        means that this function will wait indefinitely for the
-- 
2.39.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115953): https://edk2.groups.io/g/devel/message/115953
Mute This Topic: https://groups.io/mt/104581211/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [edk2-devel] [PATCH v4 3/3] SecurityPkg: Update ReceiveData and SendData function description
  2024-02-26  3:05 ` [edk2-devel] [PATCH v4 3/3] SecurityPkg: " Qingyu
@ 2024-02-28  5:57   ` Yao, Jiewen
  0 siblings, 0 replies; 8+ messages in thread
From: Yao, Jiewen @ 2024-02-28  5:57 UTC (permalink / raw)
  To: Shang, Qingyu, devel@edk2.groups.io

Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>

> -----Original Message-----
> From: Shang, Qingyu <qingyu.shang@intel.com>
> Sent: Monday, February 26, 2024 11:06 AM
> To: devel@edk2.groups.io
> Cc: Yao, Jiewen <jiewen.yao@intel.com>
> Subject: [PATCH v4 3/3] SecurityPkg: Update ReceiveData and SendData function
> description
> 
> Refer to Uefi spec 2.10 section 13.14, update the parameter 'MediaId'
> description for EFI_STORAGE_SECURITY_COMMAND_PROTOCOL function
> ReceiveData
> and SendData.
> 
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Signed-off-by: Qingyu <qingyu.shang@intel.com>
> ---
>  SecurityPkg/Tcg/Opal/OpalPassword/OpalPasswordPei.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/SecurityPkg/Tcg/Opal/OpalPassword/OpalPasswordPei.c
> b/SecurityPkg/Tcg/Opal/OpalPassword/OpalPasswordPei.c
> index 0fb6b1bf41d5..1ee55105e435 100644
> --- a/SecurityPkg/Tcg/Opal/OpalPassword/OpalPasswordPei.c
> +++ b/SecurityPkg/Tcg/Opal/OpalPassword/OpalPasswordPei.c
> @@ -49,7 +49,9 @@ EFI_GUID  mOpalDeviceLockBoxGuid =
> OPAL_DEVICE_LOCKBOX_GUID;
>    function shall return EFI_DEVICE_ERROR.
> 
>    @param  This                         Indicates a pointer to the calling context.
> -  @param  MediaId                      ID of the medium to receive data from.
> +  @param  MediaId                      ID of the medium to receive data from. If there is
> no
> +                                       block IO protocol supported by the physical device, the
> +                                       value of MediaId is undefined.
>    @param  Timeout                      The timeout, in 100ns units, to use for the
> execution
>                                         of the security protocol command. A Timeout value of 0
>                                         means that this function will wait indefinitely for the
> @@ -148,7 +150,9 @@ SecurityReceiveData (
>    shall return EFI_DEVICE_ERROR.
> 
>    @param  This                         Indicates a pointer to the calling context.
> -  @param  MediaId                      ID of the medium to receive data from.
> +  @param  MediaId                      ID of the medium to receive data from. If there is
> no
> +                                       block IO protocol supported by the physical device, the
> +                                       value of MediaId is undefined.
>    @param  Timeout                      The timeout, in 100ns units, to use for the
> execution
>                                         of the security protocol command. A Timeout value of 0
>                                         means that this function will wait indefinitely for the
> --
> 2.39.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116091): https://edk2.groups.io/g/devel/message/116091
Mute This Topic: https://groups.io/mt/104581211/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



^ permalink raw reply	[flat|nested] 8+ messages in thread

* 回复: [edk2-devel] [PATCH v4 1/3] MdePkg: Update ReceiveData and SendData function description
  2024-02-26  3:05 ` [edk2-devel] [PATCH v4 1/3] MdePkg: " Qingyu
@ 2024-03-06 14:10   ` gaoliming via groups.io
  0 siblings, 0 replies; 8+ messages in thread
From: gaoliming via groups.io @ 2024-03-06 14:10 UTC (permalink / raw)
  To: devel, qingyu.shang; +Cc: 'Michael D Kinney', 'Zhiguang Liu'

Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Qingyu
> 发送时间: 2024年2月26日 11:06
> 收件人: devel@edk2.groups.io
> 抄送: Michael D Kinney <michael.d.kinney@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>; Zhiguang Liu <zhiguang.liu@intel.com>
> 主题: [edk2-devel] [PATCH v4 1/3] MdePkg: Update ReceiveData and
> SendData function description
> 
> Refer to Uefi spec 2.10 section 13.14, update the parameter 'MediaId'
> description for EFI_STORAGE_SECURITY_COMMAND_PROTOCOL function
> ReceiveData
> and SendData.
> 
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Signed-off-by: Qingyu <qingyu.shang@intel.com>
> ---
>  MdePkg/Include/Protocol/StorageSecurityCommand.h | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/MdePkg/Include/Protocol/StorageSecurityCommand.h
> b/MdePkg/Include/Protocol/StorageSecurityCommand.h
> index 810af59b85c3..206ae79aff8d 100644
> --- a/MdePkg/Include/Protocol/StorageSecurityCommand.h
> +++ b/MdePkg/Include/Protocol/StorageSecurityCommand.h
> @@ -59,7 +59,9 @@ typedef struct
> _EFI_STORAGE_SECURITY_COMMAND_PROTOCOL
> EFI_STORAGE_SECURITY_COMMA
>    function shall return EFI_DEVICE_ERROR.
> 
>    @param  This                         Indicates a pointer to the
> calling context.
> -  @param  MediaId                      ID of the medium to
> receive data from.
> +  @param  MediaId                      ID of the medium to
> receive data from. If there is no
> +                                       block IO protocol supported
> by the physical device, the
> +                                       value of MediaId is
> undefined.
>    @param  Timeout                      The timeout, in 100ns units,
> to use for the execution
>                                         of the security protocol
> command. A Timeout value of 0
>                                         means that this function
> will wait indefinitely for the
> @@ -138,7 +140,9 @@ EFI_STATUS
>    shall return EFI_DEVICE_ERROR.
> 
>    @param  This                         Indicates a pointer to the
> calling context.
> -  @param  MediaId                      ID of the medium to
> receive data from.
> +  @param  MediaId                      ID of the medium to
> receive data from. If there is no
> +                                       block IO protocol supported
> by the physical device, the
> +                                       value of MediaId is
> undefined.
>    @param  Timeout                      The timeout, in 100ns units,
> to use for the execution
>                                         of the security protocol
> command. A Timeout value of 0
>                                         means that this function
> will wait indefinitely for the
> --
> 2.39.1.windows.1
> 
> 
> 
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116440): https://edk2.groups.io/g/devel/message/116440
Mute This Topic: https://groups.io/mt/104766054/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



^ permalink raw reply	[flat|nested] 8+ messages in thread

* 回复: [edk2-devel] [PATCH v4 2/3] MdeModulePkg: Update ReceiveData and SendData function description
  2024-02-26  3:05 ` [edk2-devel] [PATCH v4 2/3] MdeModulePkg: " Qingyu
@ 2024-03-06 14:10   ` gaoliming via groups.io
  0 siblings, 0 replies; 8+ messages in thread
From: gaoliming via groups.io @ 2024-03-06 14:10 UTC (permalink / raw)
  To: devel, qingyu.shang; +Cc: 'Michael D Kinney'

Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Qingyu
> 发送时间: 2024年2月26日 11:06
> 收件人: devel@edk2.groups.io
> 抄送: Liming Gao <gaoliming@byosoft.com.cn>; Michael D Kinney
> <michael.d.kinney@intel.com>
> 主题: [edk2-devel] [PATCH v4 2/3] MdeModulePkg: Update ReceiveData and
> SendData function description
> 
> AtaBusDxe, NvmExpressDxe, ScsiDiskDxe and EmmcDxe is used to back the
> EFI_STORAGE_SECURITY_COMMAND_PROTOCOL, update the parameter
> 'MediaId'
> description for the protocal function ReceiveData and SendData as
described
> in Uefi spec 2.10 section 13.14.
> 
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Signed-off-by: Qingyu <qingyu.shang@intel.com>
> ---
>  MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBus.c              |  8
> ++++++--
>  MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBus.h              |  8
> ++++++--
>  .../Bus/Pci/NvmExpressDxe/NvmExpressBlockIo.c        |  8 ++++++--
>  .../Bus/Pci/NvmExpressDxe/NvmExpressBlockIo.h        |  8 ++++++--
>  MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c         |  8 ++++++--
>  MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.h         |  8 ++++++--
>  MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.c            | 12
> +++++++++---
>  MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.h            | 12
> +++++++++---
>  8 files changed, 54 insertions(+), 18 deletions(-)
> 
> diff --git a/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBus.c
> b/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBus.c
> index a729c087ff5a..67c6389bb8b3 100644
> --- a/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBus.c
> +++ b/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBus.c
> @@ -1483,7 +1483,9 @@ AtaDiskInfoWhichIde (
>    function shall return EFI_DEVICE_ERROR.
> 
>    @param  This                         Indicates a pointer to the
> calling context.
> -  @param  MediaId                      ID of the medium to
> receive data from.
> +  @param  MediaId                      ID of the medium to
> receive data from. If there is no
> +                                       block IO protocol supported
> by the physical device, the
> +                                       value of MediaId is
> undefined.
>    @param  Timeout                      The timeout, in 100ns units,
> to use for the execution
>                                         of the security protocol
> command. A Timeout value of 0
>                                         means that this function
> will wait indefinitely for the
> @@ -1600,7 +1602,9 @@ AtaStorageSecurityReceiveData (
>    shall return EFI_DEVICE_ERROR.
> 
>    @param  This                         Indicates a pointer to the
> calling context.
> -  @param  MediaId                      ID of the medium to
> receive data from.
> +  @param  MediaId                      ID of the medium to
> receive data from. If there is no
> +                                       block IO protocol supported
> by the physical device, the
> +                                       value of MediaId is
> undefined.
>    @param  Timeout                      The timeout, in 100ns units,
> to use for the execution
>                                         of the security protocol
> command. A Timeout value of 0
>                                         means that this function
> will wait indefinitely for the
> diff --git a/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBus.h
> b/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBus.h
> index 6bc345f7e777..8906947e28b3 100644
> --- a/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBus.h
> +++ b/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBus.h
> @@ -927,7 +927,9 @@ AtaDiskInfoWhichIde (
>    function shall return EFI_DEVICE_ERROR.
> 
>    @param  This                         Indicates a pointer to the
> calling context.
> -  @param  MediaId                      ID of the medium to
> receive data from.
> +  @param  MediaId                      ID of the medium to
> receive data from. If there is no
> +                                       block IO protocol supported
> by the physical device, the
> +                                       value of MediaId is
> undefined.
>    @param  Timeout                      The timeout, in 100ns units,
> to use for the execution
>                                         of the security protocol
> command. A Timeout value of 0
>                                         means that this function
> will wait indefinitely for the
> @@ -1007,7 +1009,9 @@ AtaStorageSecurityReceiveData (
>    shall return EFI_DEVICE_ERROR.
> 
>    @param  This                         Indicates a pointer to the
> calling context.
> -  @param  MediaId                      ID of the medium to
> receive data from.
> +  @param  MediaId                      ID of the medium to
> receive data from. If there is no
> +                                       block IO protocol supported
> by the physical device, the
> +                                       value of MediaId is
> undefined.
>    @param  Timeout                      The timeout, in 100ns units,
> to use for the execution
>                                         of the security protocol
> command. A Timeout value of 0
>                                         means that this function
> will wait indefinitely for the
> diff --git a/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressBlockIo.c
> b/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressBlockIo.c
> index b6ed7f7031b3..e0a85c1cb34e 100644
> --- a/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressBlockIo.c
> +++ b/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressBlockIo.c
> @@ -1699,7 +1699,9 @@ TrustTransferNvmeDevice (
>    function shall return EFI_DEVICE_ERROR.
> 
>    @param  This                         Indicates a pointer to the
> calling context.
> -  @param  MediaId                      ID of the medium to
> receive data from.
> +  @param  MediaId                      ID of the medium to
> receive data from. If there is no
> +                                       block IO protocol supported
> by the physical device, the
> +                                       value of MediaId is
> undefined.
>    @param  Timeout                      The timeout, in 100ns units,
> to use for the execution
>                                         of the security protocol
> command. A Timeout value of 0
>                                         means that this function
> will wait indefinitely for the
> @@ -1812,7 +1814,9 @@ NvmeStorageSecurityReceiveData (
>    shall return EFI_DEVICE_ERROR.
> 
>    @param  This                         Indicates a pointer to the
> calling context.
> -  @param  MediaId                      ID of the medium to
> receive data from.
> +  @param  MediaId                      ID of the medium to
> receive data from. If there is no
> +                                       block IO protocol supported
> by the physical device, the
> +                                       value of MediaId is
> undefined.
>    @param  Timeout                      The timeout, in 100ns units,
> to use for the execution
>                                         of the security protocol
> command. A Timeout value of 0
>                                         means that this function
> will wait indefinitely for the
> diff --git a/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressBlockIo.h
> b/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressBlockIo.h
> index 8cad15efd33a..5547e057e77a 100644
> --- a/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressBlockIo.h
> +++ b/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressBlockIo.h
> @@ -289,7 +289,9 @@ NvmeBlockIoFlushBlocksEx (
>    function shall return EFI_DEVICE_ERROR.
> 
>    @param  This                         Indicates a pointer to the
> calling context.
> -  @param  MediaId                      ID of the medium to
> receive data from.
> +  @param  MediaId                      ID of the medium to
> receive data from. If there is no
> +                                       block IO protocol supported
> by the physical device, the
> +                                       value of MediaId is
> undefined.
>    @param  Timeout                      The timeout, in 100ns units,
> to use for the execution
>                                         of the security protocol
> command. A Timeout value of 0
>                                         means that this function
> will wait indefinitely for the
> @@ -369,7 +371,9 @@ NvmeStorageSecurityReceiveData (
>    shall return EFI_DEVICE_ERROR.
> 
>    @param  This                         Indicates a pointer to the
> calling context.
> -  @param  MediaId                      ID of the medium to
> receive data from.
> +  @param  MediaId                      ID of the medium to
> receive data from. If there is no
> +                                       block IO protocol supported
> by the physical device, the
> +                                       value of MediaId is
> undefined.
>    @param  Timeout                      The timeout, in 100ns units,
> to use for the execution
>                                         of the security protocol
> command. A Timeout value of 0
>                                         means that this function
> will wait indefinitely for the
> diff --git a/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c
> b/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c
> index 670f70caf41f..e79110c14e11 100644
> --- a/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c
> +++ b/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c
> @@ -1897,7 +1897,9 @@ Done:
>    function shall return EFI_DEVICE_ERROR.
> 
>    @param  This                         Indicates a pointer to the
> calling context.
> -  @param  MediaId                      ID of the medium to
> receive data from.
> +  @param  MediaId                      ID of the medium to
> receive data from. If there is no
> +                                       block IO protocol supported
> by the physical device, the
> +                                       value of MediaId is
> undefined.
>    @param  Timeout                      The timeout, in 100ns units,
> to use for the execution
>                                         of the security protocol
> command. A Timeout value of 0
>                                         means that this function
> will wait indefinitely for the
> @@ -2119,7 +2121,9 @@ Done:
>    shall return EFI_DEVICE_ERROR.
> 
>    @param  This                         Indicates a pointer to the
> calling context.
> -  @param  MediaId                      ID of the medium to
> receive data from.
> +  @param  MediaId                      ID of the medium to
> receive data from. If there is no
> +                                       block IO protocol supported
> by the physical device, the
> +                                       value of MediaId is
> undefined.
>    @param  Timeout                      The timeout, in 100ns units,
> to use for the execution
>                                         of the security protocol
> command. A Timeout value of 0
>                                         means that this function
> will wait indefinitely for the
> diff --git a/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.h
> b/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.h
> index 5a25b55c4952..49a00403695f 100644
> --- a/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.h
> +++ b/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.h
> @@ -677,7 +677,9 @@ ScsiDiskEraseBlocks (
>    function shall return EFI_DEVICE_ERROR.
> 
>    @param  This                         Indicates a pointer to the
> calling context.
> -  @param  MediaId                      ID of the medium to
> receive data from.
> +  @param  MediaId                      ID of the medium to
> receive data from. If there is no
> +                                       block IO protocol supported
> by the physical device, the
> +                                       value of MediaId is
> undefined.
>    @param  Timeout                      The timeout, in 100ns units,
> to use for the execution
>                                         of the security protocol
> command. A Timeout value of 0
>                                         means that this function
> will wait indefinitely for the
> @@ -751,7 +753,9 @@ ScsiDiskReceiveData (
>    shall return EFI_DEVICE_ERROR.
> 
>    @param  This                         Indicates a pointer to the
> calling context.
> -  @param  MediaId                      ID of the medium to
> receive data from.
> +  @param  MediaId                      ID of the medium to
> receive data from. If there is no
> +                                       block IO protocol supported
> by the physical device, the
> +                                       value of MediaId is
> undefined.
>    @param  Timeout                      The timeout, in 100ns units,
> to use for the execution
>                                         of the security protocol
> command. A Timeout value of 0
>                                         means that this function
> will wait indefinitely for the
> diff --git a/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.c
> b/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.c
> index 39b7c7ce6ef1..61fa740be505 100644
> --- a/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.c
> +++ b/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.c
> @@ -1267,7 +1267,9 @@ EmmcFlushBlocksEx (
>    function shall return EFI_DEVICE_ERROR.
> 
>    @param[in]  This                         Indicates a pointer to
> the calling context.
> -  @param[in]  MediaId                      ID of the medium to
> receive data from.
> +  @param[in]  MediaId                      ID of the medium to
> receive data from. If there is no
> +                                           block IO protocol
> supported by the physical device, the
> +                                           value of MediaId is
> undefined.
>    @param[in]  Timeout                      The timeout, in 100ns
> units, to use for the execution
>                                             of the security
> protocol command. A Timeout value of 0
>                                             means that this
> function will wait indefinitely for the
> @@ -1454,7 +1456,9 @@ EmmcSecurityProtocolInOut (
>    function shall return EFI_DEVICE_ERROR.
> 
>    @param  This                         Indicates a pointer to the
> calling context.
> -  @param  MediaId                      ID of the medium to
> receive data from.
> +  @param  MediaId                      ID of the medium to
> receive data from. If there is no
> +                                       block IO protocol supported
> by the physical device, the
> +                                       value of MediaId is
> undefined.
>    @param  Timeout                      The timeout, in 100ns units,
> to use for the execution
>                                         of the security protocol
> command. A Timeout value of 0
>                                         means that this function
> will wait indefinitely for the
> @@ -1555,7 +1559,9 @@ EmmcSecurityProtocolIn (
>    shall return EFI_DEVICE_ERROR.
> 
>    @param  This                         Indicates a pointer to the
> calling context.
> -  @param  MediaId                      ID of the medium to
> receive data from.
> +  @param  MediaId                      ID of the medium to
> receive data from. If there is no
> +                                       block IO protocol supported
> by the physical device, the
> +                                       value of MediaId is
> undefined.
>    @param  Timeout                      The timeout, in 100ns units,
> to use for the execution
>                                         of the security protocol
> command. A Timeout value of 0
>                                         means that this function
> will wait indefinitely for the
> diff --git a/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.h
> b/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.h
> index 2568f0359df3..8c7e5d2675ff 100644
> --- a/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.h
> +++ b/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.h
> @@ -250,7 +250,9 @@ EmmcFlushBlocksEx (
>    function shall return EFI_DEVICE_ERROR.
> 
>    @param[in]  This                         Indicates a pointer to
> the calling context.
> -  @param[in]  MediaId                      ID of the medium to
> receive data from.
> +  @param[in]  MediaId                      ID of the medium to
> receive data from. If there is no
> +                                           block IO protocol
> supported by the physical device, the
> +                                           value of MediaId is
> undefined.
>    @param[in]  Timeout                      The timeout, in 100ns
> units, to use for the execution
>                                             of the security
> protocol command. A Timeout value of 0
>                                             means that this
> function will wait indefinitely for the
> @@ -337,7 +339,9 @@ EmmcSecurityProtocolInOut (
>    function shall return EFI_DEVICE_ERROR.
> 
>    @param  This                         Indicates a pointer to the
> calling context.
> -  @param  MediaId                      ID of the medium to
> receive data from.
> +  @param  MediaId                      ID of the medium to
> receive data from. If there is no
> +                                       block IO protocol supported
> by the physical device, the
> +                                       value of MediaId is
> undefined.
>    @param  Timeout                      The timeout, in 100ns units,
> to use for the execution
>                                         of the security protocol
> command. A Timeout value of 0
>                                         means that this function
> will wait indefinitely for the
> @@ -417,7 +421,9 @@ EmmcSecurityProtocolIn (
>    shall return EFI_DEVICE_ERROR.
> 
>    @param  This                         Indicates a pointer to the
> calling context.
> -  @param  MediaId                      ID of the medium to
> receive data from.
> +  @param  MediaId                      ID of the medium to
> receive data from. If there is no
> +                                       block IO protocol supported
> by the physical device, the
> +                                       value of MediaId is
> undefined.
>    @param  Timeout                      The timeout, in 100ns units,
> to use for the execution
>                                         of the security protocol
> command. A Timeout value of 0
>                                         means that this function
> will wait indefinitely for the
> --
> 2.39.1.windows.1
> 
> 
> 
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116441): https://edk2.groups.io/g/devel/message/116441
Mute This Topic: https://groups.io/mt/104766056/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [edk2-devel] [PATCH v4 0/3] Update ReceiveData and SendData function description
  2024-02-26  3:05 [edk2-devel] [PATCH v4 0/3] Update ReceiveData and SendData function description Qingyu
                   ` (2 preceding siblings ...)
  2024-02-26  3:05 ` [edk2-devel] [PATCH v4 3/3] SecurityPkg: " Qingyu
@ 2024-03-13  4:24 ` Michael D Kinney
  3 siblings, 0 replies; 8+ messages in thread
From: Michael D Kinney @ 2024-03-13  4:24 UTC (permalink / raw)
  To: devel@edk2.groups.io, Shang, Qingyu; +Cc: Kinney, Michael D

Merged: https://github.com/tianocore/edk2/pull/5463

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Qingyu
> Sent: Sunday, February 25, 2024 7:06 PM
> To: devel@edk2.groups.io
> Subject: [edk2-devel] [PATCH v4 0/3] Update ReceiveData and SendData
> function description
> 
> Refer to Uefi spec 2.10 section 13.14, update the parameter 'MediaId'
> description for EFI_STORAGE_SECURITY_COMMAND_PROTOCOL function ReceiveData
> and SendData.
> 
> V4:
> Split patch so there is one patch per package
> 
> V3:
> Add maintainer to CC list.
> 
> V2:
> Update some functions description in C and H header files in MdeModulePkg
> and SecurityPkg.
> 
> V1:
> update the parameter description in
> MdePkg/Include/Protocol/StorageSecurityCommand.h.
> 
> Qingyu (3):
>   MdePkg: Update ReceiveData and SendData function description
>   MdeModulePkg: Update ReceiveData and SendData function description
>   SecurityPkg: Update ReceiveData and SendData function description
> 
>  MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBus.c              |  8 ++++++--
>  MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBus.h              |  8 ++++++--
>  .../Bus/Pci/NvmExpressDxe/NvmExpressBlockIo.c        |  8 ++++++--
>  .../Bus/Pci/NvmExpressDxe/NvmExpressBlockIo.h        |  8 ++++++--
>  MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c         |  8 ++++++--
>  MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.h         |  8 ++++++--
>  MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.c            | 12 +++++++++---
>  MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.h            | 12 +++++++++---
>  MdePkg/Include/Protocol/StorageSecurityCommand.h     |  8 ++++++--
>  SecurityPkg/Tcg/Opal/OpalPassword/OpalPasswordPei.c  |  8 ++++++--
>  10 files changed, 66 insertions(+), 22 deletions(-)
> 
> --
> 2.39.1.windows.1
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116704): https://edk2.groups.io/g/devel/message/116704
Mute This Topic: https://groups.io/mt/104581208/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2024-03-13  4:24 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-26  3:05 [edk2-devel] [PATCH v4 0/3] Update ReceiveData and SendData function description Qingyu
2024-02-26  3:05 ` [edk2-devel] [PATCH v4 1/3] MdePkg: " Qingyu
2024-03-06 14:10   ` 回复: " gaoliming via groups.io
2024-02-26  3:05 ` [edk2-devel] [PATCH v4 2/3] MdeModulePkg: " Qingyu
2024-03-06 14:10   ` 回复: " gaoliming via groups.io
2024-02-26  3:05 ` [edk2-devel] [PATCH v4 3/3] SecurityPkg: " Qingyu
2024-02-28  5:57   ` Yao, Jiewen
2024-03-13  4:24 ` [edk2-devel] [PATCH v4 0/3] " Michael D Kinney

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox