Re: [edk2-devel] [Patch 1/2] OvmfPkg: Change default to disable MptScsi and PvScsi

["Michael D Kinney" <michael.d.kinney@intel.com>]

Hi Dann,

The purpose of this first step was due to lack of support/maintainers/reviewers.

If there are issues, then we need to find maintainers/reviewers starting with
those that are using and depend on these features.

If there are no issues from disabling these by default, then the 2nd step
would be deleting the code and the flags.

Are these features actually being used?

Thanks,

Mike

> -----Original Message-----
> From: dann frazier <dann.frazier@canonical.com>
> Sent: Monday, December 5, 2022 3:36 PM
> To: devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>; Yao, Jiewen <jiewen.yao@intel.com>; Justen, Jordan L
> <jordan.l.justen@intel.com>; Gerd Hoffmann <kraxel@redhat.com>; Boeuf, Sebastien <sebastien.boeuf@intel.com>; Brijesh Singh
> <brijesh.singh@amd.com>; Aktas, Erdem <erdemaktas@google.com>; James Bottomley <jejb@linux.ibm.com>; Xu, Min M
> <min.m.xu@intel.com>; Tom Lendacky <thomas.lendacky@amd.com>
> Subject: Re: [edk2-devel] [Patch 1/2] OvmfPkg: Change default to disable MptScsi and PvScsi
> 
> On Tue, Jul 26, 2022 at 12:46:39PM -0700, Michael D Kinney wrote:
> > The email addresses for the reviewers of the MptScsi and
> > PvScsi are no longer valid.  Disable the MptScsi and PvScsi
> > drivers in all DSC files until new maintainers/reviewers can
> > be identified.
> 
> Hi Michael,
> 
>   This seems likely to be the reason for the following regression
> report in Debian:
> 
>   https://bugs.debian.org/1016359
> 
>   I'm trying to decide whether or not this is something we should
> force back on for our users to avoid the regression, and/or if we need
> to actively move users off of it (mark it deprecated, etc). Do you know
> if there are known issues with this code, other than the lack of
> reviewers? Is there a plan to remove this code at some point?
> 
>   -dann
> 
> > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> > Cc: Jiewen Yao <jiewen.yao@intel.com>
> > Cc: Jordan Justen <jordan.l.justen@intel.com>
> > Cc: Gerd Hoffmann <kraxel@redhat.com>
> > Cc: Sebastien Boeuf <sebastien.boeuf@intel.com>
> > Cc: Brijesh Singh <brijesh.singh@amd.com>
> > Cc: Erdem Aktas <erdemaktas@google.com>
> > Cc: James Bottomley <jejb@linux.ibm.com>
> > Cc: Jiewen Yao <jiewen.yao@intel.com>
> > Cc: Min Xu <min.m.xu@intel.com>
> > Cc: Tom Lendacky <thomas.lendacky@amd.com>
> > Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> > ---
> >  OvmfPkg/AmdSev/AmdSevX64.dsc     | 4 ++--
> >  OvmfPkg/CloudHv/CloudHvX64.dsc   | 4 ++--
> >  OvmfPkg/IntelTdx/IntelTdxX64.dsc | 4 ++--
> >  OvmfPkg/Microvm/MicrovmX64.dsc   | 4 ++--
> >  OvmfPkg/OvmfPkgIa32.dsc          | 4 ++--
> >  OvmfPkg/OvmfPkgIa32X64.dsc       | 4 ++--
> >  OvmfPkg/OvmfPkgX64.dsc           | 4 ++--
> >  7 files changed, 14 insertions(+), 14 deletions(-)
> >
> > diff --git a/OvmfPkg/AmdSev/AmdSevX64.dsc b/OvmfPkg/AmdSev/AmdSevX64.dsc
> > index 726521c94381..90e8a213ef77 100644
> > --- a/OvmfPkg/AmdSev/AmdSevX64.dsc
> > +++ b/OvmfPkg/AmdSev/AmdSevX64.dsc
> > @@ -43,8 +43,8 @@ [Defines]
> >    #
> >    # Device drivers
> >    #
> > -  DEFINE PVSCSI_ENABLE           = TRUE
> > -  DEFINE MPT_SCSI_ENABLE         = TRUE
> > +  DEFINE PVSCSI_ENABLE           = FALSE
> > +  DEFINE MPT_SCSI_ENABLE         = FALSE
> >    DEFINE LSI_SCSI_ENABLE         = FALSE
> >
> >    #
> > diff --git a/OvmfPkg/CloudHv/CloudHvX64.dsc b/OvmfPkg/CloudHv/CloudHvX64.dsc
> > index 0bfe542f8a88..f0d700f14477 100644
> > --- a/OvmfPkg/CloudHv/CloudHvX64.dsc
> > +++ b/OvmfPkg/CloudHv/CloudHvX64.dsc
> > @@ -49,8 +49,8 @@ [Defines]
> >    #
> >    # Device drivers
> >    #
> > -  DEFINE PVSCSI_ENABLE           = TRUE
> > -  DEFINE MPT_SCSI_ENABLE         = TRUE
> > +  DEFINE PVSCSI_ENABLE           = FALSE
> > +  DEFINE MPT_SCSI_ENABLE         = FALSE
> >    DEFINE LSI_SCSI_ENABLE         = FALSE
> >
> >    #
> > diff --git a/OvmfPkg/IntelTdx/IntelTdxX64.dsc b/OvmfPkg/IntelTdx/IntelTdxX64.dsc
> > index 144d50aa9dba..71b1cf8e7090 100644
> > --- a/OvmfPkg/IntelTdx/IntelTdxX64.dsc
> > +++ b/OvmfPkg/IntelTdx/IntelTdxX64.dsc
> > @@ -34,8 +34,8 @@ [Defines]
> >    #
> >    # Device drivers
> >    #
> > -  DEFINE PVSCSI_ENABLE           = TRUE
> > -  DEFINE MPT_SCSI_ENABLE         = TRUE
> > +  DEFINE PVSCSI_ENABLE           = FALSE
> > +  DEFINE MPT_SCSI_ENABLE         = FALSE
> >    DEFINE LSI_SCSI_ENABLE         = FALSE
> >
> >    #
> > diff --git a/OvmfPkg/Microvm/MicrovmX64.dsc b/OvmfPkg/Microvm/MicrovmX64.dsc
> > index 61db9b6e4c83..52498bbe90a8 100644
> > --- a/OvmfPkg/Microvm/MicrovmX64.dsc
> > +++ b/OvmfPkg/Microvm/MicrovmX64.dsc
> > @@ -47,8 +47,8 @@ [Defines]
> >    #
> >    # Device drivers
> >    #
> > -  DEFINE PVSCSI_ENABLE           = TRUE
> > -  DEFINE MPT_SCSI_ENABLE         = TRUE
> > +  DEFINE PVSCSI_ENABLE           = FALSE
> > +  DEFINE MPT_SCSI_ENABLE         = FALSE
> >    DEFINE LSI_SCSI_ENABLE         = FALSE
> >
> >    #
> > diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc
> > index e708411076ca..725a01ae9a20 100644
> > --- a/OvmfPkg/OvmfPkgIa32.dsc
> > +++ b/OvmfPkg/OvmfPkgIa32.dsc
> > @@ -50,8 +50,8 @@ [Defines]
> >    #
> >    # Device drivers
> >    #
> > -  DEFINE PVSCSI_ENABLE           = TRUE
> > -  DEFINE MPT_SCSI_ENABLE         = TRUE
> > +  DEFINE PVSCSI_ENABLE           = FALSE
> > +  DEFINE MPT_SCSI_ENABLE         = FALSE
> >    DEFINE LSI_SCSI_ENABLE         = FALSE
> >
> >    #
> > diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc
> > index 0b036d8bb53f..adc813ba2e1e 100644
> > --- a/OvmfPkg/OvmfPkgIa32X64.dsc
> > +++ b/OvmfPkg/OvmfPkgIa32X64.dsc
> > @@ -49,8 +49,8 @@ [Defines]
> >    #
> >    # Device drivers
> >    #
> > -  DEFINE PVSCSI_ENABLE           = TRUE
> > -  DEFINE MPT_SCSI_ENABLE         = TRUE
> > +  DEFINE PVSCSI_ENABLE           = FALSE
> > +  DEFINE MPT_SCSI_ENABLE         = FALSE
> >    DEFINE LSI_SCSI_ENABLE         = FALSE
> >
> >    #
> > diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc
> > index 8ad04b50f74f..6e68f60dc90f 100644
> > --- a/OvmfPkg/OvmfPkgX64.dsc
> > +++ b/OvmfPkg/OvmfPkgX64.dsc
> > @@ -49,8 +49,8 @@ [Defines]
> >    #
> >    # Device drivers
> >    #
> > -  DEFINE PVSCSI_ENABLE           = TRUE
> > -  DEFINE MPT_SCSI_ENABLE         = TRUE
> > +  DEFINE PVSCSI_ENABLE           = FALSE
> > +  DEFINE MPT_SCSI_ENABLE         = FALSE
> >    DEFINE LSI_SCSI_ENABLE         = FALSE
> >
> >    #