Re: [edk2-devel] [PATCH 1/2] MdeModulePkg/Core/Dxe: Fix memory leak issue in FwVol.c

["Michael D Kinney" <michael.d.kinney@intel.com>]

+Jian

Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Dandan Bi <dandan.bi@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>

> -----Original Message-----
> From: Mike Maslenkin <mike.maslenkin@gmail.com>
> Sent: Thursday, August 31, 2023 5:11 PM
> To: devel@edk2.groups.io
> Cc: Bi, Dandan <dandan.bi@intel.com>; Gao, Liming
> <gaoliming@byosoft.com.cn>; Kinney, Michael D <michael.d.kinney@intel.com>;
> Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Mike Maslenkin
> <mike.maslenkin@gmail.com>
> Subject: [PATCH 1/2] MdeModulePkg/Core/Dxe: Fix memory leak issue in
> FwVol.c
> 
> FwVolHeader must be deallocated on error path.
> 
> Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
> ---
>  MdeModulePkg/Core/Dxe/FwVol/FwVol.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/MdeModulePkg/Core/Dxe/FwVol/FwVol.c
> b/MdeModulePkg/Core/Dxe/FwVol/FwVol.c
> index 153bfecafa77..0c1554ba4d63 100644
> --- a/MdeModulePkg/Core/Dxe/FwVol/FwVol.c
> +++ b/MdeModulePkg/Core/Dxe/FwVol/FwVol.c
> @@ -659,6 +659,7 @@ NotifyFwVolBlock (
>        //
> 
>        FvDevice = AllocateCopyPool (sizeof (FV_DEVICE), &mFvDevice);
> 
>        if (FvDevice == NULL) {
> 
> +        CoreFreePool (FwVolHeader);
> 
>          return;
> 
>        }
> 
> 
> 
> --
> 2.32.0 (Apple Git-132)



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108464): https://edk2.groups.io/g/devel/message/108464
Mute This Topic: https://groups.io/mt/101085563/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-