From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 9B935D8018D for ; Fri, 8 Sep 2023 21:46:33 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=LbYN5j4WvhUjMElVddSXAmCM7zd9diuWCtKtKIqpHTY=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1694209592; v=1; b=JWnKNh+qREUv9mdJRQSvjsLXSRzSyckspVfhqGpi+EoFJzZqXPcXiRKTEIIfc7EEZzaPxqhr g8BY1Kt52QwHh4Ji0NMR3hqQos1HccEnQRoeKsIgZ5bDXR/Ozel6YYbVwGByDEVmF5hoGW1ZyrN b2GhlYVUK6u49L5p6ODl98Qk= X-Received: by 127.0.0.2 with SMTP id tg64YY7687511xPJ1qd5mLDG; Fri, 08 Sep 2023 14:46:32 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web11.5643.1694209591573280412 for ; Fri, 08 Sep 2023 14:46:31 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10827"; a="357219146" X-IronPort-AV: E=Sophos;i="6.02,237,1688454000"; d="scan'208";a="357219146" X-Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Sep 2023 14:46:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10827"; a="771891066" X-IronPort-AV: E=Sophos;i="6.02,237,1688454000"; d="scan'208";a="771891066" X-Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga008.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 08 Sep 2023 14:46:30 -0700 X-Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Fri, 8 Sep 2023 14:46:30 -0700 X-Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Fri, 8 Sep 2023 14:46:29 -0700 X-Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Fri, 8 Sep 2023 14:46:29 -0700 X-Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.173) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Fri, 8 Sep 2023 14:46:29 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JT9uf8ZnVjFEhPI9oef/anUY60q9zP0S3yCkcz4eEMjNeiGxsV8mSfceQQgIyv3P6qmYWvHM5xxdCYch81uMKtQvYMIoMtz3GsFqcT3FMah+EXdbwXh+P5GBaFJ3JVvbt23bpbMXfreoBxD/QPOTjEQSOs9kNrFkwFRkl+9n6c06Fi/5+cAedcQLX6KHGV8k3Ip/zp9XjwVxo21N1oUh367Ggb6P5Q1W00biAQscPH3baRIggwtIvsourJoO3wKtmSvWseRvwro4PJF785HzaNEO4bJzRJFSiC2A6/jO1p7RabERi5Yo9QxjwmEI/q6HcxDNyNSNj/8h9I+65dY6SQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0h7JHCeYidn6eGlDxWESg5ELE7A8jG9FmfhGmDWFRbo=; b=aJgy12U4U+NJuKH3QENT9R0ZKkYCTiu24gjhm7XFKmhoyECmghB35xEdfvGgVGsbg2/UQGaqFLSkHeoyuNGC3oDVxlMpDfcROj01DVOLMecSF0JyBQoYwX8fInhgiblQLI6WmaOuKcxWDQbrGxMnIw+XfPM3RkDoi+ZnTgadIUGALi4WEuLtnqQF9PNb0tqbsvGMd6m0eHxK7uEGAl3hJPyQ6oEFd6YmBTVyZ1lXj0SBdw9kalHa5mRoxLrLbC+Xo6C5QsAwSPfyCKEmwNDabtkYgqI8YpC/JelHjOBL897fyfB98za1f02RIOp16+NyjWPSwF6c/xE60L83Fyt6FQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com (2603:10b6:303:6d::19) by SJ0PR11MB5939.namprd11.prod.outlook.com (2603:10b6:a03:42e::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6768.30; Fri, 8 Sep 2023 21:46:27 +0000 X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::eaa6:1c0:c33f:2a11]) by CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::eaa6:1c0:c33f:2a11%2]) with mapi id 15.20.6768.029; Fri, 8 Sep 2023 21:46:27 +0000 From: "Michael D Kinney" To: Mike Maslenkin , "devel@edk2.groups.io" CC: "Bi, Dandan" , "Gao, Liming" , "Desimone, Nathaniel L" , "Wang, Jian J" , "Kinney, Michael D" Subject: Re: [edk2-devel] [PATCH 1/2] MdeModulePkg/Core/Dxe: Fix memory leak issue in FwVol.c Thread-Topic: [PATCH 1/2] MdeModulePkg/Core/Dxe: Fix memory leak issue in FwVol.c Thread-Index: AQHZ3GjsFImOovintkKI5ubfG7kxtbARgs/g Date: Fri, 8 Sep 2023 21:46:27 +0000 Message-ID: References: <20230901001032.52136-1-mike.maslenkin@gmail.com> <20230901001032.52136-2-mike.maslenkin@gmail.com> In-Reply-To: <20230901001032.52136-2-mike.maslenkin@gmail.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO1PR11MB4929:EE_|SJ0PR11MB5939:EE_ x-ms-office365-filtering-correlation-id: 804bc503-b4d9-49fc-efd8-08dbb0b50dd9 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: WYS7gYgNV7MiIBt4ZUr0GVuS2TzX8X93u81++IBu9xkj+QHjTEb3nnRYBdo4UQS/O2oHtdZNvbQv250iD31z+JcKeSqM/5URX+/qZCRZO+fKcWy/HUATimjXGL9SLIGpzEElRajydwbaO6dw2+3RWo+9skBCJOr3rNZkbAIYSGL49mwygVilcCpVDmrZaMjh/w2NOgYi+stJJYPBLRhqkyzhV5z4p5GfdtmGuOXYNz4WzKy/pLXKgsyguUT1zk1f4V3q6s3p2rFOiwIQElmCnAokUrcurMAlLLwP03Db1Skgznwuw0FDJiYx+4OgHAO3IvXLji6SfeHS04HWJZT06a5vXP/oqpEKSsTiSj3sQrAanLTytjdQl/RiXsy+i6tmglgQuIDw+/VPkIDSbqxZMaVHrwwJOsQkIbMZAtNlvp4Sy9eZli6L9q/FV3psvx3rO0uUR7+ykxrZSDQALU0CzJk5xOp4Mpwg3cxNKo3iHWz/wRgcCBD1cgOnmWpJXIZRwr5B+sjJHSbCN0CDLSsd8IugEi/+LdRtu19nMZLf03NoOIc8OECUq0pvghEfBsbcFzAWVFRsSgAwexjK4laIDiM5xlpadp01DdJD/LyOZJvGlOdpKfKy0H268ov6fIoZ x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?GgjeDEIcgBnaTp4xinSKkjkC0HgO9xhf3EUL1xL68+vGv6yVG2Trv2OKRtSV?= =?us-ascii?Q?yGUHvZ/puujDekOp6l3t7iO8nrWephLoBcAIx4BYppyO7CSOJOx5A4t9+Trv?= =?us-ascii?Q?O/TEP2yd1FfpwvAqLY2nRNXhqUdeUcQQc6qu6GiPhIGVIMlV1SZpr7jlXsjR?= =?us-ascii?Q?rbaqLgIjvn8F1zU61dJ3OfiL5L/UXna7fz+VsIfzhE0SAdgNZ74Nyw4N8D2K?= =?us-ascii?Q?7obAe8K3TZ8d5gBEhWGXf76OwZPeEPk5iXlqfwjPJR/Vc7IE3mslWgIdvyKS?= =?us-ascii?Q?XVvIWapu4UK/EvptH9j6C3+4aMmRxJ0ImtjWuB9U2W7JjZ/zOiEtgx9V2Byv?= =?us-ascii?Q?4SjQDtQauqBF4Pq4C3gAHttSJrpui1840RpWAyLhyFho5DVXHRccerlMkfZW?= =?us-ascii?Q?JdrU6R65q2P3Z7YXs0TCWCscHN9cJNdNMzVRLGjVve4ucyO4gWXlnYQv1zd+?= =?us-ascii?Q?kLI/As+NBZ6TsR0Bq6HQkSKALN1yFpjv9qHsHGemPniz8YlkCVkGizPwFeMC?= =?us-ascii?Q?CU99kLsLk8PEqZlBv5hK5OaCNG8iCMDjuULfeQ0GWDQk5BqunPkL0n25oVNd?= =?us-ascii?Q?vb35RnbgawrhlCm0pQF4PUI1EUgK4ZkVmKQ1tuLmIaIavIvchkqRd0mswXSw?= =?us-ascii?Q?iyR/IMgvUIW1iI1+e3K8VwQN4C977hUYLd75J7zBAjwGZ/RIC79kRwYxkUQB?= =?us-ascii?Q?1Qro38wk6NKi1+XKEpDUXhW86qT3DSc/NZ9R0asATUzpEb7kFLmlM5Yrv7Ar?= =?us-ascii?Q?KGNYlu1ITwhYpqWjLh6iWmemk4TNEgVUu5P5XNI24EnSg9F2D7TK7byHN6ad?= =?us-ascii?Q?9DAxL3lRiN4J+lU6z3zRXW0XAK/sKWtQGVZi5aTFk7xtldLeMTjcEo7vsO/L?= =?us-ascii?Q?monZRxKfOLIh/9ZBP4FGUL5u681zvgT6cxS+4mEN3QYa+hGieLpPAH1atEX9?= =?us-ascii?Q?x2TgLLAlnLuUuP8eISuxL0hMU071RezZACbVesTdZHY2PpFsRB7FO0omUCw/?= =?us-ascii?Q?UcGzN5e7TnkzLzu5NX6834pqzE+WAPsRXYEt/dXQaEix8jmqDXf/CGm/SzJM?= =?us-ascii?Q?+G7h9WHod7CTFMVeVrusLHqX+2ujcMseCcI4GEQePcbnZQdHSbfjqFqA5+S3?= =?us-ascii?Q?i2xpKu7HwyIO9HI9l6sa3KyE+AviIqiTh4D3HUK6DKzMRvvtyqbYTnc3mV6w?= =?us-ascii?Q?wvnNUjUFI8AfdmsyEZ6XcyeQCgCvDBR3SpYhZn/CpGMSXub+ze6l9eVGsWBj?= =?us-ascii?Q?jegHPBVrszfzC9On/aWgfWTLBF3tQk1u28wz4cjJ2fczz3miva8NrZzlBuRS?= =?us-ascii?Q?rfeW7AqBLv+3ubOZ8ujfMVkGJ3rWW7+wcIU1XHvc5P9uBuYwg/3JYWcWA4MN?= =?us-ascii?Q?RX8CdZ74wF61Our9sgHBVeDw1sfxX4loQzTxFH9oRQCZJqPPr8qycJGKx1YI?= =?us-ascii?Q?71A1ziPz2yfriWPKwHk3CUcJ9gEhwYQkVa7fbGljtJQBrzK5ZSVPmwhWdFfx?= =?us-ascii?Q?rr1xrN4tQmIa5zzQyoeYC2DZEqKDGQMJfX2PiYXM81fnKV9kfNXtrfwYnF9L?= =?us-ascii?Q?y4dLdjd9vTVXfrJoNT1NH3xYfzgdamFDjYzvEOdaTiDQjCvWzfd9rxe96r18?= =?us-ascii?Q?BQ=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4929.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 804bc503-b4d9-49fc-efd8-08dbb0b50dd9 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Sep 2023 21:46:27.0767 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: XjY46tMi/DenTafh664c5aM6reNQQEosIHRwqAxEY/4k8sijWrFyuLEn2AHUyj3cpW4lXK3O5xub0FBnB/Zm05+KMJYgZPHS6xCT4TKwktM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5939 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,michael.d.kinney@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: btvoR6yeKAztyzdq5ms2pKDpx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=JWnKNh+q; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") +Jian Cc: Jian J Wang Cc: Dandan Bi Cc: Liming Gao > -----Original Message----- > From: Mike Maslenkin > Sent: Thursday, August 31, 2023 5:11 PM > To: devel@edk2.groups.io > Cc: Bi, Dandan ; Gao, Liming > ; Kinney, Michael D ; > Desimone, Nathaniel L ; Mike Maslenkin > > Subject: [PATCH 1/2] MdeModulePkg/Core/Dxe: Fix memory leak issue in > FwVol.c >=20 > FwVolHeader must be deallocated on error path. >=20 > Signed-off-by: Mike Maslenkin > --- > MdeModulePkg/Core/Dxe/FwVol/FwVol.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/MdeModulePkg/Core/Dxe/FwVol/FwVol.c > b/MdeModulePkg/Core/Dxe/FwVol/FwVol.c > index 153bfecafa77..0c1554ba4d63 100644 > --- a/MdeModulePkg/Core/Dxe/FwVol/FwVol.c > +++ b/MdeModulePkg/Core/Dxe/FwVol/FwVol.c > @@ -659,6 +659,7 @@ NotifyFwVolBlock ( > // >=20 > FvDevice =3D AllocateCopyPool (sizeof (FV_DEVICE), &mFvDevice); >=20 > if (FvDevice =3D=3D NULL) { >=20 > + CoreFreePool (FwVolHeader); >=20 > return; >=20 > } >=20 >=20 >=20 > -- > 2.32.0 (Apple Git-132) -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108464): https://edk2.groups.io/g/devel/message/108464 Mute This Topic: https://groups.io/mt/101085563/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-