From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id C7388D804EA for ; Thu, 18 Jul 2024 15:44:11 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=6szkxRCgLDm31L7uHq8TP0iZp2tPFjuGNewkJ1DZ1T4=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1721317451; v=1; b=O8OXww2OlkeFBTMhRSY2+1kaVp05OxQ3Pw4FjNj8JGxTMHgGpURWlaztBwgxY2dj8ff2A0Do nzahyK2vcD0iURQhwkX+8cmUcOWVosSzlAmh5JJRN9yfYrR+j8bdDL0wXOr+X2PKWJ5vTGCPOxk XSsBCKCB/c9zf+u2hn+0Y76r0Arlz/EVsey1fxp9goxAxYNkabJ2DiOTlN5QgyaqgpOTAIXMoIg RlAnzbJT45VdvqWJhBIAYivowPAeVdzND5P5mJDAS7S91xqLQVzW9PJFD4UG05073PrJnu+5CXD h70iYHFPa1CUysLl9Gtha3oGHxMnfgEjwqd6hZPvkkbig== X-Received: by 127.0.0.2 with SMTP id Qe1fYY7687511xZHHcPpsG5G; Thu, 18 Jul 2024 08:44:10 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) by mx.groups.io with SMTP id smtpd.web11.18304.1721317444685368811 for ; Thu, 18 Jul 2024 08:44:04 -0700 X-CSE-ConnectionGUID: piSW+ODWQt2cjJJ/+uYD/w== X-CSE-MsgGUID: 4aEJD8NyRo2/OLhr590plg== X-IronPort-AV: E=McAfee;i="6700,10204,11137"; a="21790440" X-IronPort-AV: E=Sophos;i="6.09,218,1716274800"; d="scan'208";a="21790440" X-Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jul 2024 08:44:04 -0700 X-CSE-ConnectionGUID: FILgfBjDS4+cJgb+9Q6Z0A== X-CSE-MsgGUID: kZ+rPuRqQwm+RLKnOKy5EA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,218,1716274800"; d="scan'208";a="55337599" X-Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmviesa004.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 18 Jul 2024 08:44:05 -0700 X-Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 18 Jul 2024 08:44:03 -0700 X-Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Thu, 18 Jul 2024 08:44:03 -0700 X-Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.40) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Thu, 18 Jul 2024 08:44:03 -0700 X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com (2603:10b6:303:6d::19) by SN7PR11MB6750.namprd11.prod.outlook.com (2603:10b6:806:266::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7784.17; Thu, 18 Jul 2024 15:44:00 +0000 X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::a886:6510:729d:f9d0]) by CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::a886:6510:729d:f9d0%4]) with mapi id 15.20.7762.027; Thu, 18 Jul 2024 15:44:00 +0000 From: "Michael D Kinney" To: "Jayaprakash, N" , "devel@edk2.groups.io" CC: Rebecca Cran , "Kinney, Michael D" Subject: Re: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc: Support for compiling Python UEFI interpreter with VS2022 Thread-Topic: [edk2-libc Patch 1/1] edk2-libc: Support for compiling Python UEFI interpreter with VS2022 Thread-Index: AQHa2BdB4ZV4XTxc20+HSXXsOSIN/rH7Fz7ggADWywCAALQPEA== Date: Thu, 18 Jul 2024 15:44:00 +0000 Message-ID: References: <20240717070053.323-1-n.jayaprakash@intel.com> <20240717070053.323-2-n.jayaprakash@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO1PR11MB4929:EE_|SN7PR11MB6750:EE_ x-ms-office365-filtering-correlation-id: cc0a58da-63ee-4964-e547-08dca740717f x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: =?us-ascii?Q?+R9oIOvcHQcWhqrgS8eDtRP4iHICpiuUXK8MKglxI7+uxnZ3GHFWAfnirtoV?= =?us-ascii?Q?WI6sxzyj6ahKvWYJQqAX7MMyk3KP+pN/a1GEdz9LEFtLG5m3WJOnuWGDKehY?= =?us-ascii?Q?lu/geWdp1MW08yMc3grElLMcH9YTf6NB1807hptQBIdkupw1+N2RHU3f5Jts?= =?us-ascii?Q?69xPj447rRB6EIChcBAwDAArjhObGPfzeWGFbR+y+oxd7OT6R8BKVA/lEqwW?= =?us-ascii?Q?s4GfDId9OpOg97Quc2SHsEgLJVC7zx2k34sIiAPoEBGXco/PTBCsBE7LBxtI?= =?us-ascii?Q?6a+R8m0+QQ5i39E5AHbi0EgxhMv3sKHrZHkrh9jgIDdxUWad/vatpgi85MI0?= =?us-ascii?Q?Lnoki7DUS93NZiwqxJOjhKo/dVo+37wi5OdP+wPCK8u5DIzWHUxFIWNubOJv?= =?us-ascii?Q?nO+aXoim97/Q4IPOI2tLROdGJnBm2T8aUyLR8aJHge20SppQLU32M6ZnB68V?= =?us-ascii?Q?xZ46LC/PqdussbPqJSFampg/C0CBJJ36FlDuglndA5t+J4gxU6gNlHBIh4Cw?= =?us-ascii?Q?Qb532KjSD8Kb+Bt2Kn2D6l7dD0oqfwkvFaxepDM2NgRWEJZNnL098tqyxS7l?= =?us-ascii?Q?ND0jsuDln0e3MSDTTp/nThFb9St9SUsyXVaZicXuhQOmMCbAHJgz10rm5kiD?= =?us-ascii?Q?Z/4jV/muJk/ZUNdDESp8Eq+pyyFFzCJYp1go5da5SFx4yb57s9hg7QXSeVRO?= =?us-ascii?Q?HpTM4Onw2MYx58b0O/ByLTprfm06eTLQU8k3xn4++2836j1fjdpXCQT1T40H?= =?us-ascii?Q?g+HHFqEzmh5u/fcC1ZKnWGK8oFjrdG4OffrzDd3houhmDS2bZCS6f19oMPd4?= =?us-ascii?Q?9gpDcRP/T3Rjij3QuscDY/Gp2wtI4PaymrDXdfcaeqrrN6NRUdpwnimYfN4O?= =?us-ascii?Q?5XtQdN7lvgPD9B5PO8oiMrFwrx9cBpPXiOo0LG4uUNdWs2M6Rb6mOKG2NBqr?= =?us-ascii?Q?0fcm6WfNXvw8AIJ2R0FvDcIAX1PSs5vuMtcpUWiyTKVtfaKK7/2it6Kuhn9Y?= =?us-ascii?Q?EN9EOAV+c92A2I74DfT1FvSbg1wShfuVhghmp0XvsmPj6Df3VGlf3vzVQI0q?= =?us-ascii?Q?OCQWdZJJ0H50Yi7+wIZ/dJ36T9ibDnpXxEUFijEFQu4dj+32hDEZ5MklaWGl?= =?us-ascii?Q?ZmHlrNcIJXFDQQwaUBUpt1DCSHQaGhFKf7/6xVOIhN+5+d75WwpgrBhkcBaq?= =?us-ascii?Q?t4J1ruoLoKe+Fh+Wpvdn2PR54jFcGzYdAJTpNiQ4xu6mOev3TlW06lulmyzW?= =?us-ascii?Q?Ws9G3FQZV4TycznKmYFRIcMQcPbPDS39/5XUW3MoDDNMWQRkXshRaXFLfSd0?= =?us-ascii?Q?ALx0x0sgEidhWUdBAz3PToAWsQW8zBESX8JaS4BjyBA4uj8z1YGHIu9gbb/T?= =?us-ascii?Q?1zDtSPo=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?yZGZn4tsbgWJfaao8tlxM2bW7k8J+qZM+lIWTVNY+l0Av8LAVzY9XRFRtR1c?= =?us-ascii?Q?TwEv7GCGbU14by80EWoejILHHoiwApDRItb4ekCgSgyXOHyf8TOCxWGj8PHK?= =?us-ascii?Q?E3wDIlhKIykYAwdR1FoqMt81+f+GKgHAiVhJM2+yl87EZR4Ix6XYDGEeByfH?= =?us-ascii?Q?Tdgvi9sE9pZCcmfnJuyOBY2k7MeB90EdEfRdDeNWwqA2w3uoApRfben3DzMV?= =?us-ascii?Q?icg5mWMYa89QorLQJfKgoKzdC3keFiPB54avgxfWrZbwKfS/J4pMF5EAcK9B?= =?us-ascii?Q?kFNoH5UDIj7WsGoH9A1LLAk2CNE4HQTHQKzHWQBMNWGakFTxh5aMgEgv1j3w?= =?us-ascii?Q?xFP3Oe3oNaSNIdsDU87xho00GxOChmbnopIsu92UoYbAyzL2JofACjPYWf0R?= =?us-ascii?Q?Rlw3vSyupzhCjWSJI8LXE+sWhCIH0tkHfs5S8RXcsCndJrCWcKsFidGqOwu/?= =?us-ascii?Q?ZZVNLTSuPUV6wT3GTPChr/GfnHuvdDofSN71SdmXbK1lgRgLw5iv4gTn5RN2?= =?us-ascii?Q?n+vH9kRH5HF71k8dNIsB6HJLFwvbEpC3rf0ZycTqg4W7TCc/aI80mL4jH1Xr?= =?us-ascii?Q?DcMGp294ypHrRGfgarIHRtdeooXztoOwt3iuiM8NeQ6Ali9owqy5JFU7Rcmo?= =?us-ascii?Q?f7NJP5n7Yzt6cGpV1oSK0foKblq9YGU9Y6TC0B+T25VTz33O3DEPQZALZj92?= =?us-ascii?Q?zweTiMB1OQrdUZlbEsPhf03BA498WHAupPC8RATVZCB1LLaByaCj6e/+/Wgt?= =?us-ascii?Q?ix8vyuQjQTfF59osJTBPPPdPHOIeFkOT1nG/TbEf5TcxiMDV2vCtpeCYwTM3?= =?us-ascii?Q?hXRI6ncDEHhNO1hTKl1HQZLK8DYQPKAEEyuw7Hhh35GHm9owljjfLSCCC5uF?= =?us-ascii?Q?WjRLIzakHL038jVrBrsdy1ung5JPGZQNZUbzNJsCcxYcEkw1llOgDan5dRK7?= =?us-ascii?Q?Ls+EegTaoq4BkbmY8HsmX6yvSHIBNm0Wyf7fXrOVQcR4SDcKR3G0QQ3YadF6?= =?us-ascii?Q?GiLNAFNaDHMS4gcaOLQpwN0WoNbwYJjdathnW3kFsBIJ/xMgQjPqAq6s1+F6?= =?us-ascii?Q?Tf0t9Xt7LAmj0oAnhZMiwEsD6EL+f2QOYzAN1vFC01alMcuUyXeoHfWi8D44?= =?us-ascii?Q?1njymgbcgGCcliKsFWXpARmWMj2080yYerKJ8a12A/T4hk24aHUj7dV/Df/w?= =?us-ascii?Q?+OoABTaTDNAFK1kgc6K1JOjJFDNpNZpTehDHEyZgh48o6KCXNOw1gvgfRj0l?= =?us-ascii?Q?rdFuzpq1nwNWudiAW3El4+4PCPAlUdvgooaj+GVUkU0PQwg20OM1YA9buPcD?= =?us-ascii?Q?FxWzSTexG9cIVy3s87rEVQmc/RTR+EO3CAFVcYPcAQFLaguN6mKl4ENIC61P?= =?us-ascii?Q?zbKV4uPguGbgaHYxrHPlV7H4TGkCtx9+yn9nmHq0/RiTpR7kag2I4PknRzK7?= =?us-ascii?Q?TGND7AMcH3RJhmiP0tXSYL3+BVglEQVaBRhHKjbqy7DBOVm+KSw/YhuC36Y0?= =?us-ascii?Q?xAWQKXeyPlroVTu4fuoHtQZQpUlQCoqJA7lB+x2Qi6l3Uo+Kknsh6EwQ7Qat?= =?us-ascii?Q?XYChAbdMXSraB6IQtZJJTCEmxOa83dy5nxF0uEfF?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4929.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cc0a58da-63ee-4964-e547-08dca740717f X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jul 2024 15:44:00.3166 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: LqVnqxELNgY6uqxmMyviycjP9qkCseDbnplNHTR01wi1/T8dn351/Jn5Y68UeXz1qI2PUH1qfUpUZvjLC3v7ukjhvHMOy7OijxTzppxezFk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB6750 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Thu, 18 Jul 2024 08:44:04 -0700 Resent-From: michael.d.kinney@intel.com Reply-To: devel@edk2.groups.io,michael.d.kinney@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: OXzso3xBjw7bHNp5HZ4ZyCqDx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=O8OXww2O; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none) Hi JP, Thanks for adding details to the BZ. For the commit message and PR description please add the Summary of the types of compiler warnings being addressed. For example, I did not know why declaring a different named local variable resolved an issue. Mike > -----Original Message----- > From: Jayaprakash, N > Sent: Wednesday, July 17, 2024 9:58 PM > To: Kinney, Michael D ; devel@edk2.groups.io > Cc: Rebecca Cran > Subject: RE: [edk2-libc Patch 1/1] edk2-libc: Support for compiling Pytho= n > UEFI interpreter with VS2022 >=20 > Hi Mike, >=20 > It's a big list of warnings treated as errors in VS2022. > So, I have captured all these compilation issues in the BZ: > https://bugzilla.tianocore.org/show_bug.cgi?id=3D4811 >=20 > GitHub actions with VS2019 and GCC building successfully post these fixes= in > my fork of edk2-libc. > VS2019 Github action: https://github.com/jpshivakavi/edk2-libc- > jp/actions/runs/9969663166 > GCC github action: https://github.com/jpshivakavi/edk2-libc- > jp/actions/runs/9969663158 >=20 > I have also verified the builds with VS2022 in my local workspace. >=20 > Regards, > JP > -----Original Message----- > From: Kinney, Michael D > Sent: Wednesday, July 17, 2024 9:40 PM > To: Jayaprakash, N ; devel@edk2.groups.io > Cc: Rebecca Cran ; Kinney, Michael D > > Subject: RE: [edk2-libc Patch 1/1] edk2-libc: Support for compiling Pytho= n > UEFI interpreter with VS2022 >=20 > Can you list the compiler errors that are being fixed by this patch? >=20 > Mike >=20 > > -----Original Message----- > > From: Jayaprakash, N > > Sent: Tuesday, July 16, 2024 11:59 PM > > To: devel@edk2.groups.io > > Cc: Jayaprakash, N ; Rebecca Cran > > ; Kinney, Michael D > > Subject: [edk2-libc Patch 1/1] edk2-libc: Support for compiling Python > > UEFI interpreter with VS2022 > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4811 > > > > This commit fixes the compilation issues observed with several > > components in the edk2-libc repo while trying to compile Python > > interpreter for UEFI. > > > > Cc: Rebecca Cran > > Cc: Michael D Kinney > > Cc: Jayaprakash N > > Signed-off-by: Jayaprakash N > > --- > > AppPkg/Applications/Enquire/Enquire.c | 48 +++++------ > > .../OrderedCollectionTest.c | 10 +-- > > .../Sockets/DataSource/DataSource.c | 10 +-- > > AppPkg/Applications/Sockets/OobRx/OobRx.c | 4 +- > > .../Applications/Sockets/RawIp4Rx/RawIp4Rx.c | 4 +- > > StdLib/BsdSocketLib/getnetbyht.c | 9 ++- > > StdLib/BsdSocketLib/ns_print.c | 57 +++++++------ > > StdLib/EfiSocketLib/Socket.c | 80 +++++++++---------- > > 8 files changed, 116 insertions(+), 106 deletions(-) > > > > diff --git a/AppPkg/Applications/Enquire/Enquire.c > > b/AppPkg/Applications/Enquire/Enquire.c > > index 1e1db69..5e34f48 100644 > > --- a/AppPkg/Applications/Enquire/Enquire.c > > +++ b/AppPkg/Applications/Enquire/Enquire.c > > @@ -5,7 +5,7 @@ > > Steven Pemberton, CWI, Amsterdam; "Steven.Pemberton@cwi.nl" > > Used with permission. > > > > - Copyright (c) 2010 - 2011, Intel Corporation. All rights reserved.=
> > + Copyright (c) 2010 - 2024, Intel Corporation. All rights > > + reserved.
> > This program and the accompanying materials > > are licensed and made available under the terms and conditions of > > the BSD License > > which accompanies this distribution. The full text of the license > > may be found at @@ -918,15 +918,15 @@ memeq( } > > > > Void > > -farewell(int bugs) > > +farewell(int bugs_local) > > { > > - if (bugs =3D=3D 0) exit(0); > > + if (bugs_local =3D=3D 0) exit(0); > > printf("\n%sFor hints on dealing with the ", co); > > - if (bugs =3D=3D 1) printf("problem"); > > - else printf("%d problems", bugs); > > + if (bugs_local =3D=3D 1) printf("problem"); else printf("%d problem= s", > > + bugs_local); > > printf(" above\n see the section 'TROUBLESHOOTING' in the file "); > > printf("%s%s\n", FILENAME, oc); > > - exit(bugs); > > + exit(bugs_local); > > } > > > > /* The program has received a signal where it wasn't expecting one */ > > @@ -1927,51 +1927,51 @@ int cprop( void ) > > > > if (c_signed) { > > #ifndef NO_UC > > -/* Syntax error? Define NO_UC */ Volatile unsigned char c1, char_max; > > - c1=3D0; char_max=3D0; > > +/* Syntax error? Define NO_UC */ Volatile unsigned char c1, > char_max_local; > > + c1=3D0; char_max_local=3D0; > > c1++; > > - if (setjmp(lab)=3D=3D0) { /* Yields char_max */ > > - while (c1>char_max) { > > - char_max=3Dc1; > > + if (setjmp(lab)=3D=3D0) { /* Yields char_max_local */ > > + while (c1>char_max_local) { > > + char_max_local=3Dc1; > > c1++; > > } > > } > > Unexpected(4); > > if (sizeof(char) =3D=3D sizeof(int)) { > > u_define(D_UCHAR_MAX, "", "UCHAR", "_MAX", > > - (ulong) char_max, > > + (ulong) char_max_local, > > (ulong) UCHAR_MAX, ""); > > } else { > > i_define(D_UCHAR_MAX, "", "UCHAR", "_MAX", > > - (long) char_max, 0L, > > + (long) char_max_local, 0L, > > (long) UCHAR_MAX, ""); > > } > > #endif > > } else { > > #ifndef NO_SC > > -/* Syntax error? Define NO_SC */ Volatile signed char c1, char_max, > > char_min; > > - c1=3D0; char_max=3D0; > > +/* Syntax error? Define NO_SC */ Volatile signed char c1, > > +char_max_local, > > char_min_local; > > + c1=3D0; char_max_local=3D0; > > c1++; > > - if (setjmp(lab)=3D=3D0) { /* Yields char_max */ > > - while (c1>char_max) { > > - char_max=3Dc1; > > + if (setjmp(lab)=3D=3D0) { /* Yields char_max_local */ > > + while (c1>char_max_local) { > > + char_max_local=3Dc1; > > c1++; > > } > > } > > - c1=3D0; char_min=3D0; > > + c1=3D0; char_min_local=3D0; > > c1--; > > - if (setjmp(lab)=3D=3D0) { /* Yields char_min */ > > - while (c1 > - char_min=3Dc1; > > + if (setjmp(lab)=3D=3D0) { /* Yields char_min_local */ > > + while (c1 > + char_min_local=3Dc1; > > c1--; > > } > > } > > Unexpected(5); > > i_define(D_SCHAR_MIN, "", "SCHAR", "_MIN", > > - (long) char_min, (long) maxint, > > + (long) char_min_local, (long) maxint, > > (long) SCHAR_MIN, ""); > > i_define(D_SCHAR_MAX, "", "SCHAR", "_MAX", > > - (long) char_max, 0L, > > + (long) char_max_local, 0L, > > (long) SCHAR_MAX, ""); > > #endif /* NO_SC */ > > } > > diff --git > > a/AppPkg/Applications/OrderedCollectionTest/OrderedCollectionTest.c > > b/AppPkg/Applications/OrderedCollectionTest/OrderedCollectionTest.c > > index 712ee8f..ea44b31 100644 > > --- > > a/AppPkg/Applications/OrderedCollectionTest/OrderedCollectionTest.c > > +++ b/AppPkg/Applications/OrderedCollectionTest/OrderedCollectionTest. > > +++ c > > @@ -7,7 +7,7 @@ > > per default, eg. serial line). > > > > Copyright (C) 2014, Red Hat, Inc. > > - Copyright (c) 2010 - 2011, Intel Corporation. All rights > > reserved.
> > + Copyright (c) 2010 - 2024, Intel Corporation. All rights > > + reserved.
> > > > SPDX-License-Identifier: BSD-2-Clause-Patent **/ @@ -458,10 > > +458,10 @@ SetupInputOutput ( > > > > case 'h': > > fprintf (stderr, > > - "%1$s: simple OrderedCollectionLib tester\n" > > + "%s: simple OrderedCollectionLib tester\n" > > "\n" > > - "Usage: 1. %1$s [-i InputFile] [-o OutputFile]\n" > > - " 2. %1$s -h\n" > > + "Usage: 1. %s [-i InputFile] [-o OutputFile]\n" > > + " 2. %s -h\n" > > "\n" > > "Options:\n" > > " -i InputFile : read commands from InputFile\n" > > @@ -469,7 +469,7 @@ SetupInputOutput ( > > " -o OutputFile: write command responses to OutputFile\n" > > " (will write to stdout if absent)\n" > > " -h : print this help and exit\n" > > - "\n", ArgV[0]); > > + "\n", ArgV[0], ArgV[0], ArgV[0]); > > ListCommands (); > > exit (EXIT_SUCCESS); > > > > diff --git a/AppPkg/Applications/Sockets/DataSource/DataSource.c > > b/AppPkg/Applications/Sockets/DataSource/DataSource.c > > index 360689e..0ca6a9a 100644 > > --- a/AppPkg/Applications/Sockets/DataSource/DataSource.c > > +++ b/AppPkg/Applications/Sockets/DataSource/DataSource.c > > @@ -1,7 +1,7 @@ > > /** @file > > Data source for network testing. > > > > - Copyright (c) 2011-2012, Intel Corporation. All rights reserved. > > + Copyright (c) 2011-2024, Intel Corporation. All rights reserved. > > SPDX-License-Identifier: BSD-2-Clause-Patent > > > > **/ > > @@ -538,7 +538,7 @@ EFI_STATUS > > SocketSend ( > > ) > > { > > - size_t BytesSent; > > + size_t BytesSentLocal; > > EFI_STATUS Status; > > EFI_TPL TplPrevious; > > > > @@ -562,8 +562,8 @@ SocketSend ( > > // > > // Send some bytes > > // > > - BytesSent =3D write ( Socket, &Buffer[0], sizeof ( Buffer )); > > - if ( -1 =3D=3D BytesSent ) { > > + BytesSentLocal =3D write ( Socket, &Buffer[0], sizeof ( Buffer )); > > + if ( -1 =3D=3D BytesSentLocal ) { > > DEBUG (( DEBUG_INFO, > > "ERROR: send failed, errno: %d\r\n", > > errno )); > > @@ -589,7 +589,7 @@ Status =3D EFI_NOT_STARTED; > > // > > // Account for the data sent > > // > > - TotalBytesSent +=3D BytesSent; > > + TotalBytesSent +=3D BytesSentLocal; > > > > // > > // Release the TimerCallback routine synchronization diff --git > > a/AppPkg/Applications/Sockets/OobRx/OobRx.c > > b/AppPkg/Applications/Sockets/OobRx/OobRx.c > > index 28e10d8..af07127 100644 > > --- a/AppPkg/Applications/Sockets/OobRx/OobRx.c > > +++ b/AppPkg/Applications/Sockets/OobRx/OobRx.c > > @@ -150,7 +150,7 @@ OobRx ( > > // > > // Display the received OOB data > > // > > - printf ( "%5Ld OOB bytes received\r\n", (UINT64)BytesRecei= ved > ); > > + printf ( "%5llu OOB bytes received\r\n", > > + (UINT64)BytesReceived > > ); > > > > // > > // Account for the bytes received @@ -183,7 +183,7 @@ > > OobRx ( > > // > > // Display the received data > > // > > - printf ( "%4Ld bytes received\r\n", (UINT64)BytesReceive= d ); > > + printf ( "%4llu bytes received\r\n", > > + (UINT64)BytesReceived ); > > > > // > > // Account for the bytes received diff --git > > a/AppPkg/Applications/Sockets/RawIp4Rx/RawIp4Rx.c > > b/AppPkg/Applications/Sockets/RawIp4Rx/RawIp4Rx.c > > index b52cd38..b190b44 100644 > > --- a/AppPkg/Applications/Sockets/RawIp4Rx/RawIp4Rx.c > > +++ b/AppPkg/Applications/Sockets/RawIp4Rx/RawIp4Rx.c > > @@ -1,7 +1,7 @@ > > /** @file > > Raw IP4 receive application > > > > - Copyright (c) 2011-2012, Intel Corporation. All rights reserved. > > + Copyright (c) 2011-2024, Intel Corporation. All rights reserved. > > SPDX-License-Identifier: BSD-2-Clause-Patent > > > > **/ > > @@ -157,7 +157,7 @@ RawIp4Rx ( > > // Display the bytes received > > // > > if ( 0 =3D=3D RetVal ) { > > - printf ( "Total Bytes Received: %Ld\r\n", TotalBytesReceive= d ); > > + printf ( "Total Bytes Received: %llu\r\n", > > + TotalBytesReceived ); > > } > > > > // > > diff --git a/StdLib/BsdSocketLib/getnetbyht.c > > b/StdLib/BsdSocketLib/getnetbyht.c > > index 08b8042..5907d44 100644 > > --- a/StdLib/BsdSocketLib/getnetbyht.c > > +++ b/StdLib/BsdSocketLib/getnetbyht.c > > @@ -41,6 +41,11 @@ > > * from getnetent.c 1.1 (Coimbra) 93/06/02 > > */ > > > > +/* > > + * Copyright (c) 2024, Intel Corporation. All rights reserved. > > + * SPDX-License-Identifier: BSD-2-Clause-Patent */ > > + > > #if defined(LIBC_SCCS) && !defined(lint) > > static char sccsid[] =3D "@(#)getnetent.c 8.1 (Berkeley) 6/4/93"; > > static char orig_rcsid[] =3D "From: Id: getnetent.c,v 8.4 1997/06/01 > > 20:34:37 vixie Exp"; @@ -155,13 +160,13 @@ found: > > } > > > > struct netent * > > -_getnetbyhtaddr(register unsigned long net, register int type) > > +_getnetbyhtaddr(register unsigned long net_local, register int type) > > { > > register struct netent *p; > > > > setnetent(_net_stayopen); > > while ( NULL !=3D (p =3D getnetent()) ) > > - if (p->n_addrtype =3D=3D type && p->n_net =3D=3D net) > > + if (p->n_addrtype =3D=3D type && p->n_net =3D=3D net_local) > > break; > > if (!_net_stayopen) > > endnetent(); > > diff --git a/StdLib/BsdSocketLib/ns_print.c > > b/StdLib/BsdSocketLib/ns_print.c index ea29d01..fb19bf9 100644 > > --- a/StdLib/BsdSocketLib/ns_print.c > > +++ b/StdLib/BsdSocketLib/ns_print.c > > @@ -55,6 +55,11 @@ > > * > > */ > > > > +/* > > + * Copyright (c) 2024, Intel Corporation. All rights reserved. > > + * SPDX-License-Identifier: BSD-2-Clause-Patent */ > > + > > /* Import. */ > > > > #include > > @@ -211,7 +216,7 @@ ns_sprintrrf(const u_char *msg, size_t msglen, > > break; > > > > case ns_t_soa: { > > - u_long t; > > + u_long t_local; > > > > /* Server name. */ > > T(addname(msg, msglen, &rdata, origin, &buf, &buflen)); @@ > > -226,45 +231,45 @@ ns_sprintrrf(const u_char *msg, size_t msglen, > > goto formerr; > > > > /* Serial number. */ > > - t =3D ns_get32(rdata); rdata +=3D NS_INT32SZ; > > + t_local =3D ns_get32(rdata); rdata +=3D NS_INT32SZ; > > T(addstr("\t\t\t\t\t", 5, &buf, &buflen)); > > - len =3D SPRINTF((tmp, "%lu", (unsigned long)t)); > > + len =3D SPRINTF((tmp, "%lu", (unsigned long)t_local)); > > T(addstr(tmp, len, &buf, &buflen)); > > T(spaced =3D addtab(len, 16, spaced, &buf, &buflen)); > > T(addstr("; serial\n", 9, &buf, &buflen)); > > spaced =3D 0; > > > > /* Refresh interval. */ > > - t =3D ns_get32(rdata); rdata +=3D NS_INT32SZ; > > + t_local =3D ns_get32(rdata); rdata +=3D NS_INT32SZ; > > T(addstr("\t\t\t\t\t", 5, &buf, &buflen)); > > - T(len =3D ns_format_ttl(t, buf, buflen)); > > + T(len =3D ns_format_ttl(t_local, buf, buflen)); > > addlen(len, &buf, &buflen); > > T(spaced =3D addtab(len, 16, spaced, &buf, &buflen)); > > T(addstr("; refresh\n", 10, &buf, &buflen)); > > spaced =3D 0; > > > > /* Retry interval. */ > > - t =3D ns_get32(rdata); rdata +=3D NS_INT32SZ; > > + t_local =3D ns_get32(rdata); rdata +=3D NS_INT32SZ; > > T(addstr("\t\t\t\t\t", 5, &buf, &buflen)); > > - T(len =3D ns_format_ttl(t, buf, buflen)); > > + T(len =3D ns_format_ttl(t_local, buf, buflen)); > > addlen(len, &buf, &buflen); > > T(spaced =3D addtab(len, 16, spaced, &buf, &buflen)); > > T(addstr("; retry\n", 8, &buf, &buflen)); > > spaced =3D 0; > > > > /* Expiry. */ > > - t =3D ns_get32(rdata); rdata +=3D NS_INT32SZ; > > + t_local =3D ns_get32(rdata); rdata +=3D NS_INT32SZ; > > T(addstr("\t\t\t\t\t", 5, &buf, &buflen)); > > - T(len =3D ns_format_ttl(t, buf, buflen)); > > + T(len =3D ns_format_ttl(t_local, buf, buflen)); > > addlen(len, &buf, &buflen); > > T(spaced =3D addtab(len, 16, spaced, &buf, &buflen)); > > T(addstr("; expiry\n", 9, &buf, &buflen)); > > spaced =3D 0; > > > > /* Minimum TTL. */ > > - t =3D ns_get32(rdata); rdata +=3D NS_INT32SZ; > > + t_local =3D ns_get32(rdata); rdata +=3D NS_INT32SZ; > > T(addstr("\t\t\t\t\t", 5, &buf, &buflen)); > > - T(len =3D ns_format_ttl(t, buf, buflen)); > > + T(len =3D ns_format_ttl(t_local, buf, buflen)); > > addlen(len, &buf, &buflen); > > T(addstr(" )", 2, &buf, &buflen)); > > T(spaced =3D addtab(len, 16, spaced, &buf, &buflen)); @@ -276,15 > > +281,15 @@ ns_sprintrrf(const u_char *msg, size_t msglen, > > case ns_t_mx: > > case ns_t_afsdb: > > case ns_t_rt: { > > - u_int t; > > + u_int t_local; > > > > if (rdlen < NS_INT16SZ) > > goto formerr; > > > > /* Priority. */ > > - t =3D ns_get16(rdata); > > + t_local =3D ns_get16(rdata); > > rdata +=3D NS_INT16SZ; > > - len =3D SPRINTF((tmp, "%u ", (unsigned int)t)); > > + len =3D SPRINTF((tmp, "%u ", (unsigned int)t_local)); > > T(addstr(tmp, len, &buf, &buflen)); > > > > /* Target. */ > > @@ -294,15 +299,15 @@ ns_sprintrrf(const u_char *msg, size_t msglen, > > } > > > > case ns_t_px: { > > - u_int t; > > + u_int t_local; > > > > if (rdlen < NS_INT16SZ) > > goto formerr; > > > > /* Priority. */ > > - t =3D ns_get16(rdata); > > + t_local =3D ns_get16(rdata); > > rdata +=3D NS_INT16SZ; > > - len =3D SPRINTF((tmp, "%u ", (unsigned int)t)); > > + len =3D SPRINTF((tmp, "%u ", (unsigned int)t_local)); > > T(addstr(tmp, len, &buf, &buflen)); > > > > /* Name1. */ > > @@ -503,33 +508,33 @@ ns_sprintrrf(const u_char *msg, size_t msglen, > > } > > > > case ns_t_sig: { > > - u_int type, algorithm, labels, footprint; > > + u_int type_local, algorithm, labels, footprint; > > const char *leader; > > - u_long t; > > + u_long t_local; > > int n; > > > > if (rdlen < 22) > > goto formerr; > > > > /* Type covered, Algorithm, Label count, Original TTL. */ > > - type =3D ns_get16(rdata); rdata +=3D NS_INT16SZ; > > + type_local =3D ns_get16(rdata); rdata +=3D NS_INT16SZ; > > algorithm =3D *rdata++; > > labels =3D *rdata++; > > - t =3D ns_get32(rdata); rdata +=3D NS_INT32SZ; > > + t_local =3D ns_get32(rdata); rdata +=3D NS_INT32SZ; > > len =3D SPRINTF((tmp, " %s %d %lu ", > > - p_type((int)type), (int)algorithm, (unsigned long)t= )); > > + p_type((int)type_local), (int)algorithm, (unsigned > > long)t_local)); > > T(addstr(tmp, len, &buf, &buflen)); > > if (labels !=3D (u_int)dn_count_labels(name)) > > goto formerr; > > > > /* Signature expiry. */ > > - t =3D ns_get32(rdata); rdata +=3D NS_INT32SZ; > > - len =3D SPRINTF((tmp, "%s ", p_secstodate(t))); > > + t_local =3D ns_get32(rdata); rdata +=3D NS_INT32SZ; > > + len =3D SPRINTF((tmp, "%s ", p_secstodate(t_local))); > > T(addstr(tmp, len, &buf, &buflen)); > > > > /* Time signed. */ > > - t =3D ns_get32(rdata); rdata +=3D NS_INT32SZ; > > - len =3D SPRINTF((tmp, "%s ", p_secstodate(t))); > > + t_local =3D ns_get32(rdata); rdata +=3D NS_INT32SZ; > > + len =3D SPRINTF((tmp, "%s ", p_secstodate(t_local))); > > T(addstr(tmp, len, &buf, &buflen)); > > > > /* Signature Footprint. */ > > diff --git a/StdLib/EfiSocketLib/Socket.c > > b/StdLib/EfiSocketLib/Socket.c index ee15b62..5f91744 100644 > > --- a/StdLib/EfiSocketLib/Socket.c > > +++ b/StdLib/EfiSocketLib/Socket.c > > @@ -5,7 +5,7 @@ > > * Bound - pSocket->PortList is not NULL > > * Listen - AcceptWait event is not NULL > > > > - Copyright (c) 2010 - 2014, Intel Corporation. All rights > > reserved.
> > + Copyright (c) 2010 - 2024, Intel Corporation. All rights > > + reserved.
> > SPDX-License-Identifier: BSD-2-Clause-Patent > > > > > > @@ -570,7 +570,7 @@ EslSocket ( > > int ApiArraySize; > > ESL_SOCKET * pSocket; > > EFI_STATUS Status; > > - int errno; > > + int error_num; > > > > DBG_ENTER ( ); > > > > @@ -583,7 +583,7 @@ EslSocket ( > > } > > > > // Assume success > > - errno =3D 0; > > + error_num =3D 0; > > Status =3D EFI_SUCCESS; > > > > // Use break instead of goto > > @@ -595,7 +595,7 @@ EslSocket ( > > DEBUG (( DEBUG_ERROR | DEBUG_SOCKET, > > "ERROR - Invalid domain value\r\n" )); > > Status =3D EFI_INVALID_PARAMETER; > > - errno =3D EAFNOSUPPORT; > > + error_num =3D EAFNOSUPPORT; > > break; > > } > > > > @@ -625,7 +625,7 @@ EslSocket ( > > "ERROR - Invalid type value\r\n" )); > > // The socket type is not supported > > Status =3D EFI_INVALID_PARAMETER; > > - errno =3D EPROTOTYPE; > > + error_num =3D EPROTOTYPE; > > break; > > } > > > > @@ -665,15 +665,15 @@ EslSocket ( > > if ( ppApiArrayEnd <=3D ppApiArray ) { > > DEBUG (( DEBUG_ERROR | DEBUG_SOCKET, > > "ERROR - The protocol is not supported!\r\n" )); > > - errno =3D EPROTONOSUPPORT; > > + error_num =3D EPROTONOSUPPORT; > > break; > > } > > > > // The driver does not support this protocol > > DEBUG (( DEBUG_ERROR | DEBUG_SOCKET, > > "ERROR - The protocol does not support this socket > > type!\r\n" )); > > - errno =3D EPROTONOSUPPORT; > > - errno =3D EPROTOTYPE; > > + error_num =3D EPROTONOSUPPORT; > > + error_num =3D EPROTOTYPE; > > break; > > } > > // Save the socket attributes > > @@ -687,7 +687,7 @@ EslSocket ( > > } > > // Return the operation status > > if ( NULL !=3D pErrno ) { > > - *pErrno =3D errno; > > + *pErrno =3D error_num; > > } > > DBG_EXIT_STATUS ( Status ); > > return Status; > > @@ -1334,7 +1334,7 @@ EslSocketClosePoll ( > > IN int * pErrno > > ) > > { > > - int errno; > > + int error_num; > > ESL_LAYER * pLayer; > > ESL_SOCKET * pNextSocket; > > ESL_SOCKET * pSocket; > > @@ -1346,7 +1346,7 @@ EslSocketClosePoll ( > > // > > // Assume success > > // > > - errno =3D 0; > > + error_num =3D 0; > > Status =3D EFI_SUCCESS; > > > > // > > @@ -1401,7 +1401,7 @@ EslSocketClosePoll ( > > // At least one port is still open > > // > > Status =3D EFI_NOT_READY; > > - errno =3D EAGAIN; > > + error_num =3D EAGAIN; > > } > > } > > else { > > @@ -1409,7 +1409,7 @@ EslSocketClosePoll ( > > // SocketCloseStart was not called > > // > > Status =3D EFI_NOT_STARTED; > > - errno =3D EPERM; > > + error_num =3D EPERM; > > } > > break; > > } > > @@ -1428,7 +1428,7 @@ EslSocketClosePoll ( > > // Socket not found > > // > > Status =3D EFI_NOT_FOUND; > > - errno =3D ENOTSOCK; > > + error_num =3D ENOTSOCK; > > } > > > > // > > @@ -1440,7 +1440,7 @@ EslSocketClosePoll ( > > // Return the operation status > > // > > if ( NULL !=3D pErrno ) { > > - *pErrno =3D errno; > > + *pErrno =3D error_num; > > } > > DBG_EXIT_STATUS ( Status ); > > return Status; > > @@ -1477,7 +1477,7 @@ EslSocketCloseStart ( > > IN int * pErrno > > ) > > { > > - int errno; > > + int error_num; > > ESL_PORT * pNextPort; > > ESL_PORT * pPort; > > ESL_SOCKET * pSocket; > > @@ -1490,7 +1490,7 @@ EslSocketCloseStart ( > > // Assume success > > // > > Status =3D EFI_SUCCESS; > > - errno =3D 0; > > + error_num =3D 0; > > > > // > > // Synchronize with the socket layer @@ -1521,7 +1521,7 @@ > > EslSocketCloseStart ( > > DEBUG_CLOSE | DEBUG_LISTEN | > > DEBUG_CONNECTION ); > > if (( EFI_SUCCESS !=3D Status ) > > && ( EFI_NOT_READY !=3D Status )) { > > - errno =3D EIO; > > + error_num =3D EIO; > > break; > > } > > > > @@ -1535,12 +1535,12 @@ EslSocketCloseStart ( > > // Attempt to finish closing the socket > > // > > if ( NULL =3D=3D pPort ) { > > - Status =3D EslSocketClosePoll ( pSocketProtocol, &errno ); > > + Status =3D EslSocketClosePoll ( pSocketProtocol, &error_num ); > > } > > } > > else { > > Status =3D EFI_NOT_READY; > > - errno =3D EAGAIN; > > + error_num =3D EAGAIN; > > } > > > > // > > @@ -1552,7 +1552,7 @@ EslSocketCloseStart ( > > // Return the operation status > > // > > if ( NULL !=3D pErrno ) { > > - *pErrno =3D errno; > > + *pErrno =3D error_num; > > } > > DBG_EXIT_STATUS ( Status ); > > return Status; > > @@ -1889,7 +1889,7 @@ EslSocketFree ( > > ) > > { > > EFI_HANDLE ChildHandle; > > - int errno; > > + int error_num; > > ESL_LAYER * pLayer; > > ESL_SOCKET * pSocket; > > ESL_SOCKET * pSocketPrevious; > > @@ -1901,7 +1901,7 @@ EslSocketFree ( > > // > > // Assume failure > > // > > - errno =3D EIO; > > + error_num =3D EIO; > > pSocket =3D NULL; > > Status =3D EFI_INVALID_PARAMETER; > > > > @@ -1986,7 +1986,7 @@ EslSocketFree ( > > "0x%08x: Free pSocket, %d bytes\r\n", > > pSocket, > > sizeof ( *pSocket ))); > > - errno =3D 0; > > + error_num =3D 0; > > } > > else { > > DEBUG (( DEBUG_ERROR | DEBUG_POOL, @@ -2014,10 +2014,10 @@ > > EslSocketFree ( > > } > > > > // > > - // Return the errno value if possible > > + // Return the error_num value if possible > > // > > if ( NULL !=3D pErrno ) { > > - *pErrno =3D errno; > > + *pErrno =3D error_num; > > } > > > > // > > @@ -2751,7 +2751,7 @@ EslSocketOptionGet ( > > IN int * pErrno > > ) > > { > > - int errno; > > + int error_num; > > socklen_t LengthInBytes; > > socklen_t MaxBytes; > > CONST UINT8 * pOptionData; > > @@ -2763,7 +2763,7 @@ EslSocketOptionGet ( > > // > > // Assume failure > > // > > - errno =3D EINVAL; > > + error_num =3D EINVAL; > > Status =3D EFI_INVALID_PARAMETER; > > > > // > > @@ -2795,7 +2795,7 @@ EslSocketOptionGet ( > > OptionName, > > (CONST void ** > > __restrict)&pOptionData, > > &LengthInBytes ); > > - errno =3D pSocket->errno; > > + error_num =3D pSocket->errno; > > break; > > } > > else { > > @@ -2814,7 +2814,7 @@ EslSocketOptionGet ( > > "ERROR - %a does not support any options!\r\n", > > pSocket->pApi->pName )); > > } > > - errno =3D ENOPROTOOPT; > > + error_num =3D ENOPROTOOPT; > > Status =3D EFI_INVALID_PARAMETER; > > break; > > > > @@ -2825,7 +2825,7 @@ EslSocketOptionGet ( > > // Socket option not supported > > // > > DEBUG (( DEBUG_INFO | DEBUG_OPTION, "ERROR - Invalid socket > > option!\r\n" )); > > - errno =3D EINVAL; > > + error_num =3D EINVAL; > > Status =3D EFI_INVALID_PARAMETER; > > break; > > > > @@ -2927,7 +2927,7 @@ EslSocketOptionGet ( > > if ( LengthInBytes < MaxBytes ) { > > ZeroMem ( &((UINT8 *)pOptionValue)[LengthInBytes], MaxBytes - > > LengthInBytes ); > > } > > - errno =3D 0; > > + error_num =3D 0; > > Status =3D EFI_SUCCESS; > > } > > } > > @@ -2936,7 +2936,7 @@ EslSocketOptionGet ( > > // Return the operation status > > // > > if ( NULL !=3D pErrno ) { > > - *pErrno =3D errno; > > + *pErrno =3D error_num; > > } > > DBG_EXIT_STATUS ( Status ); > > return Status; > > @@ -2971,7 +2971,7 @@ EslSocketOptionSet ( > > ) > > { > > BOOLEAN bTrueFalse; > > - int errno; > > + int error_num; > > socklen_t LengthInBytes; > > UINT8 * pOptionData; > > ESL_SOCKET * pSocket; > > @@ -2982,7 +2982,7 @@ EslSocketOptionSet ( > > // > > // Assume failure > > // > > - errno =3D EINVAL; > > + error_num =3D EINVAL; > > Status =3D EFI_INVALID_PARAMETER; > > > > // > > @@ -3015,7 +3015,7 @@ EslSocketOptionSet ( > > OptionName, > > pOptionValue, > > OptionLength ); > > - errno =3D pSocket->errno; > > + error_num =3D pSocket->errno; > > break; > > } > > else { > > @@ -3034,7 +3034,7 @@ EslSocketOptionSet ( > > "ERROR - %a does not support any options!\r\n", > > pSocket->pApi->pName )); > > } > > - errno =3D ENOPROTOOPT; > > + error_num =3D ENOPROTOOPT; > > Status =3D EFI_INVALID_PARAMETER; > > break; > > > > @@ -3046,7 +3046,7 @@ EslSocketOptionSet ( > > // > > DEBUG (( DEBUG_OPTION, > > "ERROR - Sockets does not support this option!\r\n= " > )); > > - errno =3D EINVAL; > > + error_num =3D EINVAL; > > Status =3D EFI_INVALID_PARAMETER; > > break; > > > > @@ -3133,7 +3133,7 @@ EslSocketOptionSet ( > > // Set the option value > > // > > CopyMem ( pOptionData, pOptionValue, LengthInBytes ); > > - errno =3D 0; > > + error_num =3D 0; > > Status =3D EFI_SUCCESS; > > } > > else { > > @@ -3150,7 +3150,7 @@ EslSocketOptionSet ( > > // Return the operation status > > // > > if ( NULL !=3D pErrno ) { > > - *pErrno =3D errno; > > + *pErrno =3D error_num; > > } > > DBG_EXIT_STATUS ( Status ); > > return Status; > > -- > > 2.45.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119971): https://edk2.groups.io/g/devel/message/119971 Mute This Topic: https://groups.io/mt/107267145/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-