From: "Michael D Kinney" <michael.d.kinney@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"rebecca@nuviainc.com" <rebecca@nuviainc.com>,
"Kinney, Michael D" <michael.d.kinney@intel.com>
Cc: "Jayaprakash, N" <n.jayaprakash@intel.com>
Subject: Re: [edk2-devel] [edk2-libc Patch 1/1] AppPkg/Applications/Python/Python-3.6.8: Py 3.6.8 UEFI changes
Date: Thu, 2 Sep 2021 20:46:31 +0000 [thread overview]
Message-ID: <CO1PR11MB49296A8C779902626CFCE69FD2CE9@CO1PR11MB4929.namprd11.prod.outlook.com> (raw)
In-Reply-To: <e6a27dfe-ea91-c550-bf0b-af43bd89529d@nuviainc.com>
Hi Rebecca,
Responses below.
Some of the items you are observing are due to following the exact
same pattern as the Python 2.x ports. There are many things that can
get cleaned up in the Python 3.x ports. I would prefer to see this
initial functional version go in and add new BZs for additional cleanups.
Thanks,
Mike
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Rebecca Cran
> Sent: Thursday, September 2, 2021 11:41 AM
> To: devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com>
> Cc: Jayaprakash, N <n.jayaprakash@intel.com>
> Subject: Re: [edk2-devel] [edk2-libc Patch 1/1] AppPkg/Applications/Python/Python-3.6.8: Py 3.6.8 UEFI changes
>
> On 9/2/21 11:12 AM, Michael D Kinney wrote:
>
> > AppPkg/AppPkg.dsc | 3 +
> > .../Python/Python-3.6.8/Py368ReadMe.txt | 220 +
>
> This looks like it's formatted using Markdown, so should it be
> Py368ReadMe.md?
It looks like there are elements that do not follow MarkDown and the formatting
looks bad when using a MarkDown viewer. I would recommend leaving it as .txt for
now. We can enter a new issue to convert to MD.
>
> > create mode 100644 AppPkg/Applications/Python/Python-3.6.8/create_python368_pkg.bat
>
> The xcopy commands should probably have error checking after them.
There are several limitations to the BAT file. It is just being reused from the
Python 2.x ports. I think it would be better to port this to a Python script and
add all error checking in that version. We can enter a new issues for this Python
port.
>
>
> --
>
> Rebecca Cran
>
>
>
>
>
next prev parent reply other threads:[~2021-09-02 20:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-02 17:12 [edk2-libc Patch 0/1] Add Python 3.6.8 Michael D Kinney
2021-09-02 17:12 ` [edk2-libc Patch 1/1] AppPkg/Applications/Python/Python-3.6.8: Py 3.6.8 UEFI changes Michael D Kinney
2021-09-02 18:41 ` [edk2-devel] " Rebecca Cran
2021-09-02 20:46 ` Michael D Kinney [this message]
2021-09-02 20:48 ` Rebecca Cran
2021-09-02 20:48 ` Rebecca Cran
2021-09-02 18:22 ` [edk2-devel] [edk2-libc Patch 0/1] Add Python 3.6.8 Michael D Kinney
2021-09-03 1:35 ` Michael D Kinney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO1PR11MB49296A8C779902626CFCE69FD2CE9@CO1PR11MB4929.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox