From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id E9229D806DD for ; Thu, 18 Apr 2024 21:05:10 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=s0cazQ8UKE/ZLdgy8NzROUlp6sLIt31bE6OdL7MVZhc=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1713474309; v=1; b=YPEhfGIoJumXRRnBGOUIZv1GPgKBBTokKcVrWW2wUYzlG/g6IFLyAly52uzMuEgD+uoOQcX+ +aP8jeXmMiqn74VM3ZtdQwJsV4iALh0HvAxfdsI1fM0ZJyvOEz5xjn1pXXk7PyRx2El/IDsH8Ve 5Mf8Hb7AjXMUYSJPcM2CcipMyMlJ71awRaeU2W8caZYwkVkfajELBtFiOrovlwzckwn2E7+bFv8 T3P+AyAxiA+ZpqWQQtmJLJdMF8QiJFAf0IT2eA1zUkwjn47Pa/C2/ZE/EhCZKzphFFSIuUI/vXU YuX+Zzrovqc/0DkN5vf8MlKjrhq2IhKmCd7Zl28MaluqQ== X-Received: by 127.0.0.2 with SMTP id ftuCYY7687511x3V3IPeiNq9; Thu, 18 Apr 2024 14:05:09 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.16]) by mx.groups.io with SMTP id smtpd.web11.5195.1713474308296374433 for ; Thu, 18 Apr 2024 14:05:08 -0700 X-CSE-ConnectionGUID: inHybfvoR0SUMgGyDOC/Qw== X-CSE-MsgGUID: zfvRQmYfQ+K90ABh6T0q7Q== X-IronPort-AV: E=McAfee;i="6600,9927,11047"; a="9597184" X-IronPort-AV: E=Sophos;i="6.07,213,1708416000"; d="scan'208";a="9597184" X-Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Apr 2024 14:05:08 -0700 X-CSE-ConnectionGUID: Rr/CMBLmQyaVapeTPJbzPQ== X-CSE-MsgGUID: ezsdquSsSXShL1tbccakrA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,213,1708416000"; d="scan'208";a="54322357" X-Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmviesa001.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 18 Apr 2024 14:05:07 -0700 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 18 Apr 2024 14:05:06 -0700 X-Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 18 Apr 2024 14:05:06 -0700 X-Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.100) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 18 Apr 2024 14:05:06 -0700 X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com (2603:10b6:303:6d::19) by SA1PR11MB6992.namprd11.prod.outlook.com (2603:10b6:806:2b6::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.39; Thu, 18 Apr 2024 21:05:04 +0000 X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::e34e:4d18:b93e:c368]) by CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::e34e:4d18:b93e:c368%5]) with mapi id 15.20.7472.027; Thu, 18 Apr 2024 21:05:03 +0000 From: "Michael D Kinney" To: "Jayaprakash, N" , "devel@edk2.groups.io" CC: Rebecca Cran , "Kinney, Michael D" Subject: Re: [edk2-devel] [edk2-libc Patch 2 1/1] ek2-libc: wrmsr function available in edk2module is not working as expected Thread-Topic: [edk2-libc Patch 2 1/1] ek2-libc: wrmsr function available in edk2module is not working as expected Thread-Index: AQHakZDu9yAd5BG5nUCPOoG/GZqMM7FuhBzw Date: Thu, 18 Apr 2024 21:05:03 +0000 Message-ID: References: <20240418130317.1149-1-n.jayaprakash@intel.com> <20240418130317.1149-2-n.jayaprakash@intel.com> In-Reply-To: <20240418130317.1149-2-n.jayaprakash@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO1PR11MB4929:EE_|SA1PR11MB6992:EE_ x-ms-office365-filtering-correlation-id: dab7a2b9-a116-4096-0bcf-08dc5feb37cf x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: KIKc+OvL9poP//+lnrt8yiGuOW2aezb9m4q+VKEwL7fPScBDtjXa/ym2aSVdUWP2Lr597pfbt+6fYogHj2Z60XVRsq2XO8i5u+WlIxzhVhtEkuZjy2w9aAuXsHuIVaHSn8u4b1C0moXFKC66ayjFDWihk1tUKeagOkqyYZSDEnI/9celhyxYmLgo42kzU3emrupRKWro5VTBfFit4AeM1t12ppMCNTVXkevvD6iTVUIImr8rzTWyOFc4yXvWIlTYD/i10lHgvGLD/2UDgNmfZOJ+UKi/50V3Zifrp5qBbudAC/PAU8I/ZFrOUjRYbrEw3OlLNzO0sMIP6AZs/mHVcSsqDdGuDYZSMdquCwVNDvnN/7kSEFHb1EIhNazvng16P/2AaRH37jqa0I9rEDxB5U2mN2PNeAj15nxk+9uMD0NK4rOkmyDMrt68eKuDEkwkrTqd+600czt01pqD9EInrtYZnD3VKfSjfnBp34d1mSGjMDpChe8AZFdXluTAhna7YBNgFRwRhZsmA5UQA432NSVphhWjyWfS8eWVpCu3tOgfsItj3qIznnAPJk4OTELHomfAn77EZtC/pqS8FvSh3m4pDbO8aW0ApTPO4sSs4xK8Yj7QC+yxiGeC9A3CtsftqKLuj6RHqdaA+Zo2Ol8BHl+gnfxPJZwDfi9h2DkkqtQ= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?stuCBKc+AT9SA40Yj27OZLvu2eqJyWEJzAVG1VlX3p5rhQOJ1ZMUNLsBdM2L?= =?us-ascii?Q?/k+Llp6mqzzUdILlW6zo78ol8JP0pHuXGMNT5sO+rcXMoGrjIYDYrvDGEOSf?= =?us-ascii?Q?iOUJcIgop7HnjbeNygu5ZTV4ZY1QYKwm2gEWamyL/4OiVLIN9/F0PsfkAnsx?= =?us-ascii?Q?LUzQ059/y23SuKdijFAT3oq6ShgAcL/RdZPp6iHhCk2Gy2Apv7jw67JXcNyK?= =?us-ascii?Q?BrzNFQh/VAPlPdSTZ6B64kcM7F4FJXQmpdi0zFCglV9hPf4MxaLeS7bqTdaM?= =?us-ascii?Q?KZyiW25JDv8RFWamlS+B+GxTYd3dri6HWE2Bkk/uS75w70J68FgneT/9Fr30?= =?us-ascii?Q?piEKl7kYzkJTD7A9b3JLppNEV/nfoCDwyaiOQnWhoaljhWrTKpKFAg2K+OAJ?= =?us-ascii?Q?n5RD6QatRzXNHKmDMRZYcOAXF+IABFbygy97jk1cp6tPuH1FZOYoWkk9gYyF?= =?us-ascii?Q?uWbEPTb4l3XgvFSPTD16Am1oaQ5QxqyR7B8wk0dTZQ2HEwNiPZ5R3Al1WttZ?= =?us-ascii?Q?xfBpWpTwHiofd8JnHOly/bu9l35+qp6TQpf87UiEIozoLj1Fj3eGxKrIvbrv?= =?us-ascii?Q?whyFx2jLiG5S7aDHFeLlWca/UQOnZZYXZD0fmjcPUZQKeQCfKdwumOp6LG6B?= =?us-ascii?Q?eHc5+iQ2gUGjH9fWcFjGjHoLzsuuHl/cjYXSwbd75W1RiRyL/PDtT5lNsmW+?= =?us-ascii?Q?jXkhhlU2TuZ/3QwsKAPWumxSb1BHoYs0cnRBQIjPWlDNJI8OqI4TOyR1VMT1?= =?us-ascii?Q?gxBpuMolg3BNQZX7UzryXPe7IMPeLZ9CP62VMfFB7Nk1Dks2eX8PzIgEbpc0?= =?us-ascii?Q?iNvsEfXuyyPZO2ZDBmI9BihZ0mT/tUMyJjciMGaSrMcuUyRee+61d+GJAvWR?= =?us-ascii?Q?/ixIWM8vcp3POhVoRQR0dBoKC4sx9VquQjuGDhYzPeAzSC4l3F4d2M2CDGbc?= =?us-ascii?Q?udkladz+VseaA8FyXWbZCcctStGZnhmbg3Sh0XshwPwD6aUUh8/0p+4tl3e4?= =?us-ascii?Q?MiQqTKx2hHjyhK8Cf++JtquDr7u1cZFCJa4jOEib2jNENovZRN9s/e1qB/f/?= =?us-ascii?Q?lhEZzmI2mmsDqS3utsSTwBeMr/0BF2Tv0TfUHWLML9PVFWMMLZ7I8T9gkqIx?= =?us-ascii?Q?0jas3OKdjvv7xvmUpjFvrIuCb7xFVfmNNcfT09vQDPFpxuYhRL4eLcbIX/HA?= =?us-ascii?Q?Xgh8WkxoC6sLy7StPJR/SlzIAABKAkrAgjbwFPJ3TfQFFK607Tl/wb3heqLa?= =?us-ascii?Q?arLPvVtB95xfdOJLFR5teccmu9mQLdHD0CrY7G9d8QHhY8G2qg5W5q+216Ca?= =?us-ascii?Q?p/z2meQ+zhPSrI8cQ/7R2yJfDvOLWJzopLnjydfF89D9q6CQFN8mMGtNddjR?= =?us-ascii?Q?YVm4YqYrwi6vXYISzse8zzRxH+EQYjth5fhpuStuEoawarLoViIu80W/7Jvt?= =?us-ascii?Q?EL5F6zD6Zm6Ujsuaacy10fpZMw+kxNyd13+e1bAZNRQACJRMvSEuheNUpROQ?= =?us-ascii?Q?p6ubdXAOV5GdSYUUb1+RBf2/TiLiZXeVVEEEA3qYBRVM1UVjJS8AtT/XXcre?= =?us-ascii?Q?trVstugbmH5Xj8KVboXbEnoXb27AXB3gJ9FootYi?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4929.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: dab7a2b9-a116-4096-0bcf-08dc5feb37cf X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Apr 2024 21:05:03.7422 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: SRGuD9UOjZcWILmdRXH+69rmbDD3Nil8pRcBGyajQ3qUWnAzjKBi5hCmwrx8XfMyiszXILBeY7exVsRrBr3vgeb6kiCJn8rPSRaE2HJCCUU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB6992 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Thu, 18 Apr 2024 14:05:08 -0700 Resent-From: michael.d.kinney@intel.com Reply-To: devel@edk2.groups.io,michael.d.kinney@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: xyJeM6lAOdVsZBWO564UNXirx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=YPEhfGIo; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none) The use of BitFieldOr64() is really only required when updating a portion of a 32-bit or 64-bit value that are not aligned on a 32-bit boundary and do not have a 32-bit aligned width. Since this use case is setting the lower 32-bits, simpler logic should be used. data =3D LShiftU64(vedx, 32) | veax; Mike > -----Original Message----- > From: Jayaprakash, N > Sent: Thursday, April 18, 2024 5:55 AM > To: devel@edk2.groups.io > Cc: Jayaprakash, N ; Rebecca Cran > ; Kinney, Michael D > Subject: [edk2-libc Patch 2 1/1] ek2-libc: wrmsr function available in > edk2module is not working as expected >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4745 >=20 > This commit fixes the issue reported in the BZ4745. > The wrmsr was always writing 0 to the higher 32 bits of the msr > register. > This was due to a logical flaw in the code, where the input variable > of > type unsigned int was left shitted by 32 bits without explicitly > converting it to a 64 bit value. >=20 > The issue is with the below statement. > data =3D vedx << 32 | veax; > Where the vedx which is an unsigned int, after left shifting by 32 > bits > its value will be set to 0. Because of this the higher 32 bits of the > MSR > are always set to 0. This has been fixed by this commit. >=20 > Cc: Rebecca Cran > Cc: Michael D Kinney > Cc: Jayaprakash N > Signed-off-by: Jayaprakash N > --- > .../Python/Python-3.6.8/PyMod-3.6.8/Modules/edk2module.c | 3 > ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/AppPkg/Applications/Python/Python-3.6.8/PyMod- > 3.6.8/Modules/edk2module.c b/AppPkg/Applications/Python/Python- > 3.6.8/PyMod-3.6.8/Modules/edk2module.c > index 8786df8..06bcf82 100644 > --- a/AppPkg/Applications/Python/Python-3.6.8/PyMod- > 3.6.8/Modules/edk2module.c > +++ b/AppPkg/Applications/Python/Python-3.6.8/PyMod- > 3.6.8/Modules/edk2module.c > @@ -3886,7 +3886,8 @@ edk2_wrmsr(PyObject *self, PyObject *args) > UINT64 data =3D 0; > if (!PyArg_ParseTuple(args, "III", &vecx, &veax, &vedx)) > return NULL; > - data =3D vedx << 32 | veax; > + data =3D LShiftU64(vedx, 32); > + data =3D BitFieldOr64(data, 0, 31, veax); > Py_BEGIN_ALLOW_THREADS > AsmWriteMsr64(vecx, data); > Py_END_ALLOW_THREADS > -- > 2.44.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117999): https://edk2.groups.io/g/devel/message/117999 Mute This Topic: https://groups.io/mt/105597214/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-