[edk2-libc Patch 0/1] Py3 UEFI help built-in function issue fix

[edk2-libc Patch 0/1] Py3 UEFI help built-in function issue fix

[ajay.kadapathri]

This patch fixes help built-in function issue which reported by following
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4107

Ajay Kadapathri (1):
  Python/Python3.6.8: help built-in function issue fix

 .../Python/Python-3.6.8/PyMod-3.6.8/Include/pyconfig.h       | 5 +++++
 1 file changed, 5 insertions(+)

-- 
2.37.1.windows.1

[edk2-libc Patch 1/1] Python/Python3.6.8: help built-in function issue fix

[Ajay Kadapathri]

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4107

Observed that help built-in function in Python UEFI interpreter is
not giving the full help text information of python constructs such
as functions, objects , class and etc.

This patch request fixes this issue, once this patch is applied
We can get full text help information of python constructs

Cc: Rebecca Cran <rebecca@nuviainc.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Jayaprakash N <n.jayaprakash@intel.com>
Signed-off-by: Ajay Kadapathri <ajay.kadapathri@intel.com>
---
 .../Python/Python-3.6.8/PyMod-3.6.8/Include/pyconfig.h       | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/AppPkg/Applications/Python/Python-3.6.8/PyMod-3.6.8/Include/pyconfig.h b/AppPkg/Applications/Python/Python-3.6.8/PyMod-3.6.8/Include/pyconfig.h
index c447614..f1cb309 100644
--- a/AppPkg/Applications/Python/Python-3.6.8/PyMod-3.6.8/Include/pyconfig.h
+++ b/AppPkg/Applications/Python/Python-3.6.8/PyMod-3.6.8/Include/pyconfig.h
@@ -1155,8 +1155,13 @@
 /* Define if WINDOW in curses.h offers a field _flags. */
 #undef WINDOW_HAS_FLAGS
 
+#ifdef UEFI_C_SOURCE
+/* Define if you want documentation strings in extension modules */
+#define WITH_DOC_STRINGS 1
+#else
 /* Define if you want documentation strings in extension modules */
 #undef WITH_DOC_STRINGS
+#endif
 
 /* Define if you want to use the new-style (Openstep, Rhapsody, MacOS) dynamic
    linker (dyld) instead of the old-style (NextStep) dynamic linker (rld).
-- 
2.37.1.windows.1

Re: [edk2-libc Patch 1/1] Python/Python3.6.8: help built-in function issue fix

[Michael D Kinney]

Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>


> -----Original Message-----
> From: Kadapathri, Ajay <ajay.kadapathri@intel.com>
> Sent: Friday, October 21, 2022 3:57 AM
> To: devel@edk2.groups.io
> Cc: Rebecca Cran <rebecca@nuviainc.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Jayaprakash, N
> <n.jayaprakash@intel.com>
> Subject: [edk2-libc Patch 1/1] Python/Python3.6.8: help built-in function issue fix
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4107
> 
> Observed that help built-in function in Python UEFI interpreter is
> not giving the full help text information of python constructs such
> as functions, objects , class and etc.
> 
> This patch request fixes this issue, once this patch is applied
> We can get full text help information of python constructs
> 
> Cc: Rebecca Cran <rebecca@nuviainc.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Jayaprakash N <n.jayaprakash@intel.com>
> Signed-off-by: Ajay Kadapathri <ajay.kadapathri@intel.com>
> ---
>  .../Python/Python-3.6.8/PyMod-3.6.8/Include/pyconfig.h       | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/AppPkg/Applications/Python/Python-3.6.8/PyMod-3.6.8/Include/pyconfig.h b/AppPkg/Applications/Python/Python-
> 3.6.8/PyMod-3.6.8/Include/pyconfig.h
> index c447614..f1cb309 100644
> --- a/AppPkg/Applications/Python/Python-3.6.8/PyMod-3.6.8/Include/pyconfig.h
> +++ b/AppPkg/Applications/Python/Python-3.6.8/PyMod-3.6.8/Include/pyconfig.h
> @@ -1155,8 +1155,13 @@
>  /* Define if WINDOW in curses.h offers a field _flags. */
>  #undef WINDOW_HAS_FLAGS
> 
> +#ifdef UEFI_C_SOURCE
> +/* Define if you want documentation strings in extension modules */
> +#define WITH_DOC_STRINGS 1
> +#else
>  /* Define if you want documentation strings in extension modules */
>  #undef WITH_DOC_STRINGS
> +#endif
> 
>  /* Define if you want to use the new-style (Openstep, Rhapsody, MacOS) dynamic
>     linker (dyld) instead of the old-style (NextStep) dynamic linker (rld).
> --
> 2.37.1.windows.1

Re: [edk2-libc Patch 1/1] Python/Python3.6.8: help built-in function issue fix

[Michael D Kinney]

pushed 01c9d00fef1b086d64c6d0f383e0d299d8cf8fb7

Mike

> -----Original Message-----
> From: Kinney, Michael D <michael.d.kinney@intel.com>
> Sent: Monday, October 24, 2022 8:09 AM
> To: Kadapathri, Ajay <ajay.kadapathri@intel.com>; devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com>
> Cc: Rebecca Cran <rebecca@nuviainc.com>; Jayaprakash, N <n.jayaprakash@intel.com>
> Subject: RE: [edk2-libc Patch 1/1] Python/Python3.6.8: help built-in function issue fix
> 
> Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
> 
> 
> > -----Original Message-----
> > From: Kadapathri, Ajay <ajay.kadapathri@intel.com>
> > Sent: Friday, October 21, 2022 3:57 AM
> > To: devel@edk2.groups.io
> > Cc: Rebecca Cran <rebecca@nuviainc.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Jayaprakash, N
> > <n.jayaprakash@intel.com>
> > Subject: [edk2-libc Patch 1/1] Python/Python3.6.8: help built-in function issue fix
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4107
> >
> > Observed that help built-in function in Python UEFI interpreter is
> > not giving the full help text information of python constructs such
> > as functions, objects , class and etc.
> >
> > This patch request fixes this issue, once this patch is applied
> > We can get full text help information of python constructs
> >
> > Cc: Rebecca Cran <rebecca@nuviainc.com>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Jayaprakash N <n.jayaprakash@intel.com>
> > Signed-off-by: Ajay Kadapathri <ajay.kadapathri@intel.com>
> > ---
> >  .../Python/Python-3.6.8/PyMod-3.6.8/Include/pyconfig.h       | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/AppPkg/Applications/Python/Python-3.6.8/PyMod-3.6.8/Include/pyconfig.h b/AppPkg/Applications/Python/Python-
> > 3.6.8/PyMod-3.6.8/Include/pyconfig.h
> > index c447614..f1cb309 100644
> > --- a/AppPkg/Applications/Python/Python-3.6.8/PyMod-3.6.8/Include/pyconfig.h
> > +++ b/AppPkg/Applications/Python/Python-3.6.8/PyMod-3.6.8/Include/pyconfig.h
> > @@ -1155,8 +1155,13 @@
> >  /* Define if WINDOW in curses.h offers a field _flags. */
> >  #undef WINDOW_HAS_FLAGS
> >
> > +#ifdef UEFI_C_SOURCE
> > +/* Define if you want documentation strings in extension modules */
> > +#define WITH_DOC_STRINGS 1
> > +#else
> >  /* Define if you want documentation strings in extension modules */
> >  #undef WITH_DOC_STRINGS
> > +#endif
> >
> >  /* Define if you want to use the new-style (Openstep, Rhapsody, MacOS) dynamic
> >     linker (dyld) instead of the old-style (NextStep) dynamic linker (rld).
> > --
> > 2.37.1.windows.1