From: "Michael D Kinney" <michael.d.kinney@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"bret.barkelew@microsoft.com" <bret.barkelew@microsoft.com>,
Getnat Ejigu <getnatejigu@gmail.com>,
"Kinney, Michael D" <michael.d.kinney@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Subject: Re: [edk2-devel] [EXTERNAL] [PATCH v1 1/1] UnitTestFrameworkPkg: Sample unit test hangs when running in OVMF/QEMU
Date: Tue, 4 May 2021 02:28:58 +0000 [thread overview]
Message-ID: <CO1PR11MB49296EC7B709259A2F4AFD50D25A9@CO1PR11MB4929.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CO1PR11MB49294417CD13D9F4A02AD25CD25A9@CO1PR11MB4929.namprd11.prod.outlook.com>
Pushed commit to edk2/master:
https://github.com/tianocore/edk2/commit/f297b7f20010711e36e981fe45645302cc9d109d
GitHub PR:
https://github.com/tianocore/edk2/pull/1623
Mike
> -----Original Message-----
> From: Kinney, Michael D <michael.d.kinney@intel.com>
> Sent: Monday, May 3, 2021 5:38 PM
> To: devel@edk2.groups.io; bret.barkelew@microsoft.com; Getnat Ejigu <getnatejigu@gmail.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Subject: RE: [edk2-devel] [EXTERNAL] [PATCH v1 1/1] UnitTestFrameworkPkg: Sample unit test hangs when running in OVMF/QEMU
>
> I found one more place that is missing EFIAPI:
>
> STATIC
> VOID
> UnitTestLogFailure (
> IN FAILURE_TYPE FailureType,
> IN CONST CHAR8 *Format,
> ...
> )
> {
>
>
> I will fix this one too in the PR.
>
> Mike
>
>
>
> From: Kinney, Michael D <michael.d.kinney@intel.com>
> Sent: Monday, May 3, 2021 5:28 PM
> To: devel@edk2.groups.io; bret.barkelew@microsoft.com; Getnat Ejigu <getnatejigu@gmail.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Subject: RE: [edk2-devel] [EXTERNAL] [PATCH v1 1/1] UnitTestFrameworkPkg: Sample unit test hangs when running in OVMF/QEMU
>
> Reviewed-by: Michael D Kinney mailto:michael.d.kinney@intel.com
>
> Yes. I will submit PR.
>
> Mike
>
> From: mailto:devel@edk2.groups.io <mailto:devel@edk2.groups.io> On Behalf Of Bret Barkelew via groups.io
> Sent: Friday, April 30, 2021 2:16 PM
> To: mailto:devel@edk2.groups.io; Getnat Ejigu <mailto:getnatejigu@gmail.com>
> Cc: Kinney, Michael D <mailto:michael.d.kinney@intel.com>; Sean Brogan <mailto:sean.brogan@microsoft.com>
> Subject: Re: [edk2-devel] [EXTERNAL] [PATCH v1 1/1] UnitTestFrameworkPkg: Sample unit test hangs when running in OVMF/QEMU
>
> Mike,
>
> Can you stage the PR for this? Thanks!
>
> - Bret
>
> From: mailto:bret.barkelew=microsoft.com@groups.io
> Sent: Friday, April 30, 2021 2:16 PM
> To: mailto:getnatejigu@gmail.com; mailto:devel@edk2.groups.io
> Cc: mailto:michael.d.kinney@intel.com; mailto:sean.brogan@microsoft.com
> Subject: Re: [edk2-devel] [EXTERNAL] [PATCH v1 1/1] UnitTestFrameworkPkg: Sample unit test hangs when running in OVMF/QEMU
>
> Reviewed-by: Bret Barkelew <mailto:bret.barkelew@microsoft.com>
>
> - Bret
>
> From: mailto:getnatejigu@gmail.com
> Sent: Friday, April 30, 2021 2:07 PM
> To: mailto:devel@edk2.groups.io
> Cc: mailto:michael.d.kinney@intel.com; mailto:sean.brogan@microsoft.com; mailto:Bret.Barkelew@microsoft.com
> Subject: [EXTERNAL] [PATCH v1 1/1] UnitTestFrameworkPkg: Sample unit test hangs when running in OVMF/QEMU
>
> Sample unit tests in UnitTestFrameworkPkg hangs when running in OVMF/QEMU
> environment. Build target is X64/GCC5. Fixing this issue by adding EFIAPI
> to ReportPrint() function that use VA_ARGS.
>
> Signed-off-by: Getnat Ejigu <mailto:getnatejigu@gmail.com>
> Cc: Michael D Kinney <mailto:michael.d.kinney@intel.com>
> Cc: Sean Brogan <mailto:sean.brogan@microsoft.com>
> Cc: Bret Barkelew <mailto:Bret.Barkelew@microsoft.com>
> ---
> UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLib.c | 1 +
> UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c | 1 +
> UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibDebugLib.c | 1 +
> 3 files changed, 3 insertions(+)
>
> diff --git a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLib.c
> b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLib.c
> index 66c9db457d80..7f7443a23391 100644
> --- a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLib.c
> +++ b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLib.c
> @@ -11,6 +11,7 @@
> #include <Library/DebugLib.h>
>
>
>
> VOID
>
> +EFIAPI
>
> ReportPrint (
>
> IN CONST CHAR8 *Format,
>
> ...
>
> diff --git a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c
> b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c
> index cfb0c5972bd1..db5402d6a210 100644
> --- a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c
> +++ b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c
> @@ -12,6 +12,7 @@
> #include <Library/DebugLib.h>
>
>
>
> VOID
>
> +EFIAPI
>
> ReportPrint (
>
> IN CONST CHAR8 *Format,
>
> ...
>
> diff --git a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibDebugLib.c
> b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibDebugLib.c
> index 1402d0ef83e2..1d62c6a37117 100644
> --- a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibDebugLib.c
> +++ b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibDebugLib.c
> @@ -11,6 +11,7 @@
> #include <Library/DebugLib.h>
>
>
>
> VOID
>
> +EFIAPI
>
> ReportPrint (
>
> IN CONST CHAR8 *Format,
>
> ...
>
> --
> 2.25.1
>
>
>
prev parent reply other threads:[~2021-05-04 2:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-30 21:07 [PATCH v1 0/1] Fix sample unit test hang issue in OVMF/QEMU Getnat Ejigu
2021-04-30 21:07 ` [PATCH v1 1/1] UnitTestFrameworkPkg: Sample unit test hangs when running " Getnat Ejigu
2021-04-30 21:15 ` [EXTERNAL] " Bret Barkelew
2021-04-30 21:16 ` [edk2-devel] " Bret Barkelew
2021-05-04 0:28 ` Michael D Kinney
2021-05-04 0:38 ` Michael D Kinney
2021-05-04 2:28 ` Michael D Kinney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO1PR11MB49296EC7B709259A2F4AFD50D25A9@CO1PR11MB4929.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox