* [PATCH v1 0/1] Fix sample unit test hang issue in OVMF/QEMU
@ 2021-04-30 21:07 Getnat Ejigu
2021-04-30 21:07 ` [PATCH v1 1/1] UnitTestFrameworkPkg: Sample unit test hangs when running " Getnat Ejigu
0 siblings, 1 reply; 7+ messages in thread
From: Getnat Ejigu @ 2021-04-30 21:07 UTC (permalink / raw)
To: devel
*** BLURB HERE ***
Getnat Ejigu (1):
UnitTestFrameworkPkg: Sample unit test hangs when running in OVMF/QEMU
UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLib.c | 1 +
UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c | 1 +
UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibDebugLib.c | 1 +
3 files changed, 3 insertions(+)
--
2.25.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v1 1/1] UnitTestFrameworkPkg: Sample unit test hangs when running in OVMF/QEMU
2021-04-30 21:07 [PATCH v1 0/1] Fix sample unit test hang issue in OVMF/QEMU Getnat Ejigu
@ 2021-04-30 21:07 ` Getnat Ejigu
2021-04-30 21:15 ` [EXTERNAL] " Bret Barkelew
0 siblings, 1 reply; 7+ messages in thread
From: Getnat Ejigu @ 2021-04-30 21:07 UTC (permalink / raw)
To: devel; +Cc: Michael D Kinney, Sean Brogan, Bret Barkelew
Sample unit tests in UnitTestFrameworkPkg hangs when running in OVMF/QEMU
environment. Build target is X64/GCC5. Fixing this issue by adding EFIAPI
to ReportPrint() function that use VA_ARGS.
Signed-off-by: Getnat Ejigu <getnatejigu@gmail.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
---
UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLib.c | 1 +
UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c | 1 +
UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibDebugLib.c | 1 +
3 files changed, 3 insertions(+)
diff --git a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLib.c b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLib.c
index 66c9db457d80..7f7443a23391 100644
--- a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLib.c
+++ b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLib.c
@@ -11,6 +11,7 @@
#include <Library/DebugLib.h>
VOID
+EFIAPI
ReportPrint (
IN CONST CHAR8 *Format,
...
diff --git a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c
index cfb0c5972bd1..db5402d6a210 100644
--- a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c
+++ b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c
@@ -12,6 +12,7 @@
#include <Library/DebugLib.h>
VOID
+EFIAPI
ReportPrint (
IN CONST CHAR8 *Format,
...
diff --git a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibDebugLib.c b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibDebugLib.c
index 1402d0ef83e2..1d62c6a37117 100644
--- a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibDebugLib.c
+++ b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibDebugLib.c
@@ -11,6 +11,7 @@
#include <Library/DebugLib.h>
VOID
+EFIAPI
ReportPrint (
IN CONST CHAR8 *Format,
...
--
2.25.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [EXTERNAL] [PATCH v1 1/1] UnitTestFrameworkPkg: Sample unit test hangs when running in OVMF/QEMU
2021-04-30 21:07 ` [PATCH v1 1/1] UnitTestFrameworkPkg: Sample unit test hangs when running " Getnat Ejigu
@ 2021-04-30 21:15 ` Bret Barkelew
2021-04-30 21:16 ` [edk2-devel] " Bret Barkelew
0 siblings, 1 reply; 7+ messages in thread
From: Bret Barkelew @ 2021-04-30 21:15 UTC (permalink / raw)
To: Getnat Ejigu, devel@edk2.groups.io; +Cc: Kinney, Michael D, Sean Brogan
[-- Attachment #1: Type: text/plain, Size: 2839 bytes --]
Reviewed-by: Bret Barkelew <bret.barkelew@microsoft.com>
- Bret
From: Getnat Ejigu<mailto:getnatejigu@gmail.com>
Sent: Friday, April 30, 2021 2:07 PM
To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Cc: Kinney, Michael D<mailto:michael.d.kinney@intel.com>; Sean Brogan<mailto:sean.brogan@microsoft.com>; Bret Barkelew<mailto:Bret.Barkelew@microsoft.com>
Subject: [EXTERNAL] [PATCH v1 1/1] UnitTestFrameworkPkg: Sample unit test hangs when running in OVMF/QEMU
Sample unit tests in UnitTestFrameworkPkg hangs when running in OVMF/QEMU
environment. Build target is X64/GCC5. Fixing this issue by adding EFIAPI
to ReportPrint() function that use VA_ARGS.
Signed-off-by: Getnat Ejigu <getnatejigu@gmail.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
---
UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLib.c | 1 +
UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c | 1 +
UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibDebugLib.c | 1 +
3 files changed, 3 insertions(+)
diff --git a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLib.c b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLib.c
index 66c9db457d80..7f7443a23391 100644
--- a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLib.c
+++ b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLib.c
@@ -11,6 +11,7 @@
#include <Library/DebugLib.h>
VOID
+EFIAPI
ReportPrint (
IN CONST CHAR8 *Format,
...
diff --git a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c
index cfb0c5972bd1..db5402d6a210 100644
--- a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c
+++ b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c
@@ -12,6 +12,7 @@
#include <Library/DebugLib.h>
VOID
+EFIAPI
ReportPrint (
IN CONST CHAR8 *Format,
...
diff --git a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibDebugLib.c b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibDebugLib.c
index 1402d0ef83e2..1d62c6a37117 100644
--- a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibDebugLib.c
+++ b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibDebugLib.c
@@ -11,6 +11,7 @@
#include <Library/DebugLib.h>
VOID
+EFIAPI
ReportPrint (
IN CONST CHAR8 *Format,
...
--
2.25.1
[-- Attachment #2: Type: text/html, Size: 5213 bytes --]
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [EXTERNAL] [PATCH v1 1/1] UnitTestFrameworkPkg: Sample unit test hangs when running in OVMF/QEMU
2021-04-30 21:15 ` [EXTERNAL] " Bret Barkelew
@ 2021-04-30 21:16 ` Bret Barkelew
2021-05-04 0:28 ` Michael D Kinney
0 siblings, 1 reply; 7+ messages in thread
From: Bret Barkelew @ 2021-04-30 21:16 UTC (permalink / raw)
To: devel@edk2.groups.io, Getnat Ejigu; +Cc: Kinney, Michael D, Sean Brogan
[-- Attachment #1.1: Type: text/plain, Size: 3353 bytes --]
Mike,
Can you stage the PR for this? Thanks!
- Bret
From: Bret Barkelew via groups.io<mailto:bret.barkelew=microsoft.com@groups.io>
Sent: Friday, April 30, 2021 2:16 PM
To: Getnat Ejigu<mailto:getnatejigu@gmail.com>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Cc: Kinney, Michael D<mailto:michael.d.kinney@intel.com>; Sean Brogan<mailto:sean.brogan@microsoft.com>
Subject: Re: [edk2-devel] [EXTERNAL] [PATCH v1 1/1] UnitTestFrameworkPkg: Sample unit test hangs when running in OVMF/QEMU
Reviewed-by: Bret Barkelew <bret.barkelew@microsoft.com>
- Bret
From: Getnat Ejigu<mailto:getnatejigu@gmail.com>
Sent: Friday, April 30, 2021 2:07 PM
To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Cc: Kinney, Michael D<mailto:michael.d.kinney@intel.com>; Sean Brogan<mailto:sean.brogan@microsoft.com>; Bret Barkelew<mailto:Bret.Barkelew@microsoft.com>
Subject: [EXTERNAL] [PATCH v1 1/1] UnitTestFrameworkPkg: Sample unit test hangs when running in OVMF/QEMU
Sample unit tests in UnitTestFrameworkPkg hangs when running in OVMF/QEMU
environment. Build target is X64/GCC5. Fixing this issue by adding EFIAPI
to ReportPrint() function that use VA_ARGS.
Signed-off-by: Getnat Ejigu <getnatejigu@gmail.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
---
UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLib.c | 1 +
UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c | 1 +
UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibDebugLib.c | 1 +
3 files changed, 3 insertions(+)
diff --git a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLib.c b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLib.c
index 66c9db457d80..7f7443a23391 100644
--- a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLib.c
+++ b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLib.c
@@ -11,6 +11,7 @@
#include <Library/DebugLib.h>
VOID
+EFIAPI
ReportPrint (
IN CONST CHAR8 *Format,
...
diff --git a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c
index cfb0c5972bd1..db5402d6a210 100644
--- a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c
+++ b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c
@@ -12,6 +12,7 @@
#include <Library/DebugLib.h>
VOID
+EFIAPI
ReportPrint (
IN CONST CHAR8 *Format,
...
diff --git a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibDebugLib.c b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibDebugLib.c
index 1402d0ef83e2..1d62c6a37117 100644
--- a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibDebugLib.c
+++ b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibDebugLib.c
@@ -11,6 +11,7 @@
#include <Library/DebugLib.h>
VOID
+EFIAPI
ReportPrint (
IN CONST CHAR8 *Format,
...
--
2.25.1
[-- Attachment #1.2: Type: text/html, Size: 6555 bytes --]
[-- Attachment #2: BAA86E05D2984CAF898F06C6D6A0A521.png --]
[-- Type: image/png, Size: 140 bytes --]
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [EXTERNAL] [PATCH v1 1/1] UnitTestFrameworkPkg: Sample unit test hangs when running in OVMF/QEMU
2021-04-30 21:16 ` [edk2-devel] " Bret Barkelew
@ 2021-05-04 0:28 ` Michael D Kinney
2021-05-04 0:38 ` Michael D Kinney
0 siblings, 1 reply; 7+ messages in thread
From: Michael D Kinney @ 2021-05-04 0:28 UTC (permalink / raw)
To: devel@edk2.groups.io, bret.barkelew@microsoft.com, Getnat Ejigu,
Kinney, Michael D
Cc: Sean Brogan
[-- Attachment #1: Type: text/plain, Size: 4067 bytes --]
Reviewed-by: Michael D Kinney michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>
Yes. I will submit PR.
Mike
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Bret Barkelew via groups.io
Sent: Friday, April 30, 2021 2:16 PM
To: devel@edk2.groups.io; Getnat Ejigu <getnatejigu@gmail.com>
Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Sean Brogan <sean.brogan@microsoft.com>
Subject: Re: [edk2-devel] [EXTERNAL] [PATCH v1 1/1] UnitTestFrameworkPkg: Sample unit test hangs when running in OVMF/QEMU
Mike,
Can you stage the PR for this? Thanks!
- Bret
From: Bret Barkelew via groups.io<mailto:bret.barkelew=microsoft.com@groups.io>
Sent: Friday, April 30, 2021 2:16 PM
To: Getnat Ejigu<mailto:getnatejigu@gmail.com>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Cc: Kinney, Michael D<mailto:michael.d.kinney@intel.com>; Sean Brogan<mailto:sean.brogan@microsoft.com>
Subject: Re: [edk2-devel] [EXTERNAL] [PATCH v1 1/1] UnitTestFrameworkPkg: Sample unit test hangs when running in OVMF/QEMU
Reviewed-by: Bret Barkelew <bret.barkelew@microsoft.com<mailto:bret.barkelew@microsoft.com>>
- Bret
From: Getnat Ejigu<mailto:getnatejigu@gmail.com>
Sent: Friday, April 30, 2021 2:07 PM
To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Cc: Kinney, Michael D<mailto:michael.d.kinney@intel.com>; Sean Brogan<mailto:sean.brogan@microsoft.com>; Bret Barkelew<mailto:Bret.Barkelew@microsoft.com>
Subject: [EXTERNAL] [PATCH v1 1/1] UnitTestFrameworkPkg: Sample unit test hangs when running in OVMF/QEMU
Sample unit tests in UnitTestFrameworkPkg hangs when running in OVMF/QEMU
environment. Build target is X64/GCC5. Fixing this issue by adding EFIAPI
to ReportPrint() function that use VA_ARGS.
Signed-off-by: Getnat Ejigu <getnatejigu@gmail.com<mailto:getnatejigu@gmail.com>>
Cc: Michael D Kinney <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>
Cc: Sean Brogan <sean.brogan@microsoft.com<mailto:sean.brogan@microsoft.com>>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com<mailto:Bret.Barkelew@microsoft.com>>
---
UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLib.c | 1 +
UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c | 1 +
UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibDebugLib.c | 1 +
3 files changed, 3 insertions(+)
diff --git a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLib.c b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLib.c
index 66c9db457d80..7f7443a23391 100644
--- a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLib.c
+++ b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLib.c
@@ -11,6 +11,7 @@
#include <Library/DebugLib.h>
VOID
+EFIAPI
ReportPrint (
IN CONST CHAR8 *Format,
...
diff --git a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c
index cfb0c5972bd1..db5402d6a210 100644
--- a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c
+++ b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c
@@ -12,6 +12,7 @@
#include <Library/DebugLib.h>
VOID
+EFIAPI
ReportPrint (
IN CONST CHAR8 *Format,
...
diff --git a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibDebugLib.c b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibDebugLib.c
index 1402d0ef83e2..1d62c6a37117 100644
--- a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibDebugLib.c
+++ b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibDebugLib.c
@@ -11,6 +11,7 @@
#include <Library/DebugLib.h>
VOID
+EFIAPI
ReportPrint (
IN CONST CHAR8 *Format,
...
--
2.25.1
[-- Attachment #2: Type: text/html, Size: 44689 bytes --]
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [EXTERNAL] [PATCH v1 1/1] UnitTestFrameworkPkg: Sample unit test hangs when running in OVMF/QEMU
2021-05-04 0:28 ` Michael D Kinney
@ 2021-05-04 0:38 ` Michael D Kinney
2021-05-04 2:28 ` Michael D Kinney
0 siblings, 1 reply; 7+ messages in thread
From: Michael D Kinney @ 2021-05-04 0:38 UTC (permalink / raw)
To: devel@edk2.groups.io, bret.barkelew@microsoft.com, Getnat Ejigu,
Kinney, Michael D
Cc: Sean Brogan
I found one more place that is missing EFIAPI:
STATIC
VOID
UnitTestLogFailure (
IN FAILURE_TYPE FailureType,
IN CONST CHAR8 *Format,
...
)
{
I will fix this one too in the PR.
Mike
From: Kinney, Michael D <michael.d.kinney@intel.com>
Sent: Monday, May 3, 2021 5:28 PM
To: devel@edk2.groups.io; bret.barkelew@microsoft.com; Getnat Ejigu <getnatejigu@gmail.com>; Kinney, Michael D <michael.d.kinney@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Subject: RE: [edk2-devel] [EXTERNAL] [PATCH v1 1/1] UnitTestFrameworkPkg: Sample unit test hangs when running in OVMF/QEMU
Reviewed-by: Michael D Kinney mailto:michael.d.kinney@intel.com
Yes. I will submit PR.
Mike
From: mailto:devel@edk2.groups.io <mailto:devel@edk2.groups.io> On Behalf Of Bret Barkelew via groups.io
Sent: Friday, April 30, 2021 2:16 PM
To: mailto:devel@edk2.groups.io; Getnat Ejigu <mailto:getnatejigu@gmail.com>
Cc: Kinney, Michael D <mailto:michael.d.kinney@intel.com>; Sean Brogan <mailto:sean.brogan@microsoft.com>
Subject: Re: [edk2-devel] [EXTERNAL] [PATCH v1 1/1] UnitTestFrameworkPkg: Sample unit test hangs when running in OVMF/QEMU
Mike,
Can you stage the PR for this? Thanks!
- Bret
From: mailto:bret.barkelew=microsoft.com@groups.io
Sent: Friday, April 30, 2021 2:16 PM
To: mailto:getnatejigu@gmail.com; mailto:devel@edk2.groups.io
Cc: mailto:michael.d.kinney@intel.com; mailto:sean.brogan@microsoft.com
Subject: Re: [edk2-devel] [EXTERNAL] [PATCH v1 1/1] UnitTestFrameworkPkg: Sample unit test hangs when running in OVMF/QEMU
Reviewed-by: Bret Barkelew <mailto:bret.barkelew@microsoft.com>
- Bret
From: mailto:getnatejigu@gmail.com
Sent: Friday, April 30, 2021 2:07 PM
To: mailto:devel@edk2.groups.io
Cc: mailto:michael.d.kinney@intel.com; mailto:sean.brogan@microsoft.com; mailto:Bret.Barkelew@microsoft.com
Subject: [EXTERNAL] [PATCH v1 1/1] UnitTestFrameworkPkg: Sample unit test hangs when running in OVMF/QEMU
Sample unit tests in UnitTestFrameworkPkg hangs when running in OVMF/QEMU
environment. Build target is X64/GCC5. Fixing this issue by adding EFIAPI
to ReportPrint() function that use VA_ARGS.
Signed-off-by: Getnat Ejigu <mailto:getnatejigu@gmail.com>
Cc: Michael D Kinney <mailto:michael.d.kinney@intel.com>
Cc: Sean Brogan <mailto:sean.brogan@microsoft.com>
Cc: Bret Barkelew <mailto:Bret.Barkelew@microsoft.com>
---
UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLib.c | 1 +
UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c | 1 +
UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibDebugLib.c | 1 +
3 files changed, 3 insertions(+)
diff --git a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLib.c b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLib.c
index 66c9db457d80..7f7443a23391 100644
--- a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLib.c
+++ b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLib.c
@@ -11,6 +11,7 @@
#include <Library/DebugLib.h>
VOID
+EFIAPI
ReportPrint (
IN CONST CHAR8 *Format,
...
diff --git a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c
index cfb0c5972bd1..db5402d6a210 100644
--- a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c
+++ b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c
@@ -12,6 +12,7 @@
#include <Library/DebugLib.h>
VOID
+EFIAPI
ReportPrint (
IN CONST CHAR8 *Format,
...
diff --git a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibDebugLib.c b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibDebugLib.c
index 1402d0ef83e2..1d62c6a37117 100644
--- a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibDebugLib.c
+++ b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibDebugLib.c
@@ -11,6 +11,7 @@
#include <Library/DebugLib.h>
VOID
+EFIAPI
ReportPrint (
IN CONST CHAR8 *Format,
...
--
2.25.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [EXTERNAL] [PATCH v1 1/1] UnitTestFrameworkPkg: Sample unit test hangs when running in OVMF/QEMU
2021-05-04 0:38 ` Michael D Kinney
@ 2021-05-04 2:28 ` Michael D Kinney
0 siblings, 0 replies; 7+ messages in thread
From: Michael D Kinney @ 2021-05-04 2:28 UTC (permalink / raw)
To: devel@edk2.groups.io, bret.barkelew@microsoft.com, Getnat Ejigu,
Kinney, Michael D
Cc: Sean Brogan
Pushed commit to edk2/master:
https://github.com/tianocore/edk2/commit/f297b7f20010711e36e981fe45645302cc9d109d
GitHub PR:
https://github.com/tianocore/edk2/pull/1623
Mike
> -----Original Message-----
> From: Kinney, Michael D <michael.d.kinney@intel.com>
> Sent: Monday, May 3, 2021 5:38 PM
> To: devel@edk2.groups.io; bret.barkelew@microsoft.com; Getnat Ejigu <getnatejigu@gmail.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Subject: RE: [edk2-devel] [EXTERNAL] [PATCH v1 1/1] UnitTestFrameworkPkg: Sample unit test hangs when running in OVMF/QEMU
>
> I found one more place that is missing EFIAPI:
>
> STATIC
> VOID
> UnitTestLogFailure (
> IN FAILURE_TYPE FailureType,
> IN CONST CHAR8 *Format,
> ...
> )
> {
>
>
> I will fix this one too in the PR.
>
> Mike
>
>
>
> From: Kinney, Michael D <michael.d.kinney@intel.com>
> Sent: Monday, May 3, 2021 5:28 PM
> To: devel@edk2.groups.io; bret.barkelew@microsoft.com; Getnat Ejigu <getnatejigu@gmail.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Subject: RE: [edk2-devel] [EXTERNAL] [PATCH v1 1/1] UnitTestFrameworkPkg: Sample unit test hangs when running in OVMF/QEMU
>
> Reviewed-by: Michael D Kinney mailto:michael.d.kinney@intel.com
>
> Yes. I will submit PR.
>
> Mike
>
> From: mailto:devel@edk2.groups.io <mailto:devel@edk2.groups.io> On Behalf Of Bret Barkelew via groups.io
> Sent: Friday, April 30, 2021 2:16 PM
> To: mailto:devel@edk2.groups.io; Getnat Ejigu <mailto:getnatejigu@gmail.com>
> Cc: Kinney, Michael D <mailto:michael.d.kinney@intel.com>; Sean Brogan <mailto:sean.brogan@microsoft.com>
> Subject: Re: [edk2-devel] [EXTERNAL] [PATCH v1 1/1] UnitTestFrameworkPkg: Sample unit test hangs when running in OVMF/QEMU
>
> Mike,
>
> Can you stage the PR for this? Thanks!
>
> - Bret
>
> From: mailto:bret.barkelew=microsoft.com@groups.io
> Sent: Friday, April 30, 2021 2:16 PM
> To: mailto:getnatejigu@gmail.com; mailto:devel@edk2.groups.io
> Cc: mailto:michael.d.kinney@intel.com; mailto:sean.brogan@microsoft.com
> Subject: Re: [edk2-devel] [EXTERNAL] [PATCH v1 1/1] UnitTestFrameworkPkg: Sample unit test hangs when running in OVMF/QEMU
>
> Reviewed-by: Bret Barkelew <mailto:bret.barkelew@microsoft.com>
>
> - Bret
>
> From: mailto:getnatejigu@gmail.com
> Sent: Friday, April 30, 2021 2:07 PM
> To: mailto:devel@edk2.groups.io
> Cc: mailto:michael.d.kinney@intel.com; mailto:sean.brogan@microsoft.com; mailto:Bret.Barkelew@microsoft.com
> Subject: [EXTERNAL] [PATCH v1 1/1] UnitTestFrameworkPkg: Sample unit test hangs when running in OVMF/QEMU
>
> Sample unit tests in UnitTestFrameworkPkg hangs when running in OVMF/QEMU
> environment. Build target is X64/GCC5. Fixing this issue by adding EFIAPI
> to ReportPrint() function that use VA_ARGS.
>
> Signed-off-by: Getnat Ejigu <mailto:getnatejigu@gmail.com>
> Cc: Michael D Kinney <mailto:michael.d.kinney@intel.com>
> Cc: Sean Brogan <mailto:sean.brogan@microsoft.com>
> Cc: Bret Barkelew <mailto:Bret.Barkelew@microsoft.com>
> ---
> UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLib.c | 1 +
> UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c | 1 +
> UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibDebugLib.c | 1 +
> 3 files changed, 3 insertions(+)
>
> diff --git a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLib.c
> b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLib.c
> index 66c9db457d80..7f7443a23391 100644
> --- a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLib.c
> +++ b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLib.c
> @@ -11,6 +11,7 @@
> #include <Library/DebugLib.h>
>
>
>
> VOID
>
> +EFIAPI
>
> ReportPrint (
>
> IN CONST CHAR8 *Format,
>
> ...
>
> diff --git a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c
> b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c
> index cfb0c5972bd1..db5402d6a210 100644
> --- a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c
> +++ b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c
> @@ -12,6 +12,7 @@
> #include <Library/DebugLib.h>
>
>
>
> VOID
>
> +EFIAPI
>
> ReportPrint (
>
> IN CONST CHAR8 *Format,
>
> ...
>
> diff --git a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibDebugLib.c
> b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibDebugLib.c
> index 1402d0ef83e2..1d62c6a37117 100644
> --- a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibDebugLib.c
> +++ b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibDebugLib.c
> @@ -11,6 +11,7 @@
> #include <Library/DebugLib.h>
>
>
>
> VOID
>
> +EFIAPI
>
> ReportPrint (
>
> IN CONST CHAR8 *Format,
>
> ...
>
> --
> 2.25.1
>
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-05-04 2:29 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-04-30 21:07 [PATCH v1 0/1] Fix sample unit test hang issue in OVMF/QEMU Getnat Ejigu
2021-04-30 21:07 ` [PATCH v1 1/1] UnitTestFrameworkPkg: Sample unit test hangs when running " Getnat Ejigu
2021-04-30 21:15 ` [EXTERNAL] " Bret Barkelew
2021-04-30 21:16 ` [edk2-devel] " Bret Barkelew
2021-05-04 0:28 ` Michael D Kinney
2021-05-04 0:38 ` Michael D Kinney
2021-05-04 2:28 ` Michael D Kinney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox