From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id C5AF0940F27 for ; Wed, 24 Jan 2024 02:24:29 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=B+nLDi1IdX6mngGgf7bCt1GViLFDfoiSNP7QEEW7z8g=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1706063068; v=1; b=xEod0mh5xFJ7gXkDfzvZOMg+sqXvLZue3ipqX9UB+wgnR0Q5y4jQfgscISAiGn4c/1VwFkiO u5e3fk58NZUzEcbpgKDIOboVXEBOG8RqHMlyfSdLP1P+APz/yL/P4aV0fons7ts2xy/A/by1umd YBTAWxmhfnhU9+Lg6JyG0i+Q= X-Received: by 127.0.0.2 with SMTP id VVghYY7687511xf4gRuB4SIC; Tue, 23 Jan 2024 18:24:28 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) by mx.groups.io with SMTP id smtpd.web10.13496.1706063067832494343 for ; Tue, 23 Jan 2024 18:24:27 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10962"; a="1561558" X-IronPort-AV: E=Sophos;i="6.05,215,1701158400"; d="scan'208";a="1561558" X-Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jan 2024 18:24:26 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.05,215,1701158400"; d="scan'208";a="1755943" X-Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmviesa005.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 23 Jan 2024 18:24:25 -0800 X-Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 23 Jan 2024 18:24:05 -0800 X-Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Tue, 23 Jan 2024 18:24:05 -0800 X-Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.168) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Tue, 23 Jan 2024 18:24:05 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VtiyfBDT8+nyqlNlJKxIkrTwYnKF2PsoDioBV2FClrntg4RpPM6y50Chn8SGeGMOmNl4qBkaAnyPr0kIB/PKkM9fuiNg3hqvHvosWQKchTeT/fnp9DzhGrXcn2QvcgvII8TlfWn5q9QzQj8GjTzRCuRSiyIfVCR+N177lDZypMRO41+pR97HIB55wVDVGzr9j3CGQduFY39mzQLOoQmgWmPiL6CWvtEWKjE9HB2GDy8yxJUTiIA73WsewQESIihpIa/JsjgRJ7E3OYX+3rKUWOUQ3ZMx06a58zS/A1bwn1E/XIGbDnRFOs+AiaGxeKw4rOLLHKz4w6KvAfZbBNM1yg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YVxNZ35bpG7vz/W0XtaCX6YiO+hvDBb0uKiM2//6NXs=; b=i8KH7eODFh/jhnCB45v/ENatxF1bqA3jaW9N0BHrr6d07EFE9Fw+me1ocgzrNOB6LI56g7jPwh48N1bJ2ZKInYIntJkcHax8d2+rO8m57V4r1V88a3TmI5UKvWhyw7d/JMykmPIAqiNHyApe1/U+Rt0T/x48MnAMaaxxjHcDB3LL8tVWiwSyXLJYdENtDi1vu7Si2juYkz7cPdwQqWUL8FNdas/8SktCu7ltl22MQGt1eOi0NzMMIYgTstOzEtTbAMBZ+hCii262rZE8p2ksP/91yi8erGfnWnJZqr5ApydOTQc9T131NNUfuvXs5Un/JyyIAQEUwSAdvkIHNoaTHg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com (2603:10b6:303:6d::19) by MW3PR11MB4748.namprd11.prod.outlook.com (2603:10b6:303:2e::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7202.37; Wed, 24 Jan 2024 02:24:01 +0000 X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::7e42:1633:d0a6:9c00]) by CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::7e42:1633:d0a6:9c00%6]) with mapi id 15.20.7202.035; Wed, 24 Jan 2024 02:24:01 +0000 From: "Michael D Kinney" To: "devel@edk2.groups.io" , "dhaval@rivosinc.com" CC: "Gao, Liming" , "Liu, Zhiguang" , "Bi, Dandan" , Pedro Falcato , "Chiu, Chasel" , "Kinney, Michael D" Subject: Re: [edk2-devel] [PATCH v4 1/1] MdeModulePkg/AcpiTableDxe: Prefer xDSDT over DSDT when installing tables Thread-Topic: [edk2-devel] [PATCH v4 1/1] MdeModulePkg/AcpiTableDxe: Prefer xDSDT over DSDT when installing tables Thread-Index: AQHaQkOD5q7I+IbzhEWNaLk0HFJdjbDoU/pg Date: Wed, 24 Jan 2024 02:24:01 +0000 Message-ID: References: <20240108145938.16154-1-dhaval@rivosinc.com> <20240108145938.16154-2-dhaval@rivosinc.com> In-Reply-To: <20240108145938.16154-2-dhaval@rivosinc.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO1PR11MB4929:EE_|MW3PR11MB4748:EE_ x-ms-office365-filtering-correlation-id: a03ce433-3617-41cc-39e2-08dc1c838720 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: t7YdP1CxM1fDbvQV31j3xiuCmDD9FC9tF05BO5fEvJj1aPPQbLZztmxenvJ+fkVZkRWKN46C0ePFPWBVJy4YZqkAmdpBsbOotxc/gM+/qDGN9El+0KVm9gKRbsWrVDUP2eejjw85LmjNXf0lZ0JXxY//W9AKLbhscBW9ehPVTTNqowED/jZaSR55ktT9KBhZmZstUMMimicraSs8jLmVNPYjbqrN3tD1am51toLnl2ufCL5RpsSIjxcCf/5ehr7Fpxrf8nJKm23RaOSWlyJ6FWV5GqzG1DkPLOjUKfSEPaHP40rlUf0He3fGJAHoXzTT4QgrDV6qMIKqYSmtd7/C/kilAet2MO5rb+GSF42hUxYus66ql/YNwkd5DqEqqwr6hBSC6jg/KXFudJYBPBeXAQwm43SnbDtWewiaNtAM9AUWyZI9T9AKlhm+BdxLekqXznBOIRjNygx82pKF9AfiFLdU7nkAQnjfIa3KZReYjfCEiAKBAA5pLku6MMyY2locBrgURdrE/d9wuULlebxiKOlmZIf9k0m3cRAQV2whINeK1IyF6fwL2xg1j3aT0xsntNWRp040BNzN2W53Pkw+MRfxmKClQGID/m9PlsT8nggLbmZNPgWa2A6JCd84F8NAr2+8i893S2iD0ZPr4KaYeg== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?qQL6SM/+vbsZR1knZG9B9FUV74Tg9NkdTnHaufmowknY8Ncb6aktO2lB5mHE?= =?us-ascii?Q?jq+BSST4f9r86sMRhYiE6xHxFy5rBiQvto05EQJ4DlIllfIKEDWZzGfWEGAF?= =?us-ascii?Q?gHwJnl+aAKKPBWvsQvi2l3nbPZP1Q8vRPhHKh29VBTE6ccXJcgXiOKixBCfS?= =?us-ascii?Q?mnTnH+mpxw12C5OD2oSYjiQrm5mif/xRECuVl9nLsUN8JXtv6NqkUM6HSL29?= =?us-ascii?Q?UVIl+6/t2SVfbkafE+fJJIKp6KhCLRCJl6B6SIHzwK+VXS+RQZEZAPYw7bKq?= =?us-ascii?Q?O6IfLtvfmGgfPSj5NX+zcviDy+0otlXG7flOqhnPB07wh4EUvRjg/fLEc8sN?= =?us-ascii?Q?MI8lW7+Ww9EPQ15hevHDzf7tqf0Da9xLNPuXCKaHEYIdOBrdfzDNo340O9BK?= =?us-ascii?Q?AlxaRw8NcJLPaer/fpquR0xlhp2Qmrd3BAnhnqf4xwB7BHeoXSTuYGBYTvCR?= =?us-ascii?Q?rRqwLMjfchFg4PunP208Ck8qKazpHN88DvAd2NJns1344TRVe+u/JE6iHRS9?= =?us-ascii?Q?3iMMBJSwBm9aJDUQ9CN0DJc+ZMlL2sJ+vQEt+p39FhGnnJB5OkOVugJjL76P?= =?us-ascii?Q?n0UgwnoOrGMKdy3BwCfmmMN2ZDz7q47jUq/Ypx+q7CL0DNjs/VMO/rok3a8r?= =?us-ascii?Q?8cvUCm96ne1zVAzwrdKnVt0uQZ22D8ufsO6f5KD5/48pRsUGPf41HemhjRze?= =?us-ascii?Q?4X2S1kfS7UnOgAAfkS2kH1xdZrJQVT5k4uNTqm8IdUmqiArHtRpHrTbJQFoQ?= =?us-ascii?Q?XsBD44SGaZlJUtWugQvnBjH5FuwDwvx9wrG2VTkh9NQMAsMDzUvfbPM/4IC+?= =?us-ascii?Q?xeU2jl0N1BS0mOtQSmnnkN+y6+2854YZpwZ88a6Wr+YwUa2Cv1rQjEHS2aeW?= =?us-ascii?Q?pffSH1G5kidKY4ohFxY3OVyLOMnO+YPIG94bmRp8rnWHE5a8oPFiqzyB15mk?= =?us-ascii?Q?PlIOfig5u652WqyCaEV2XNNGsFC3isgLNCdnXBEYQdUjYwGB4c1nHtCnyAbT?= =?us-ascii?Q?EaxOCVzXFxo+obJYJJr36huPVdIn/b89S0FaWyi8zVx3D3w2XG31YqSgHMUO?= =?us-ascii?Q?ugbUzDciJyqa6HEMipxFBcq4CqaRBBWtYB/Z63woQgdHesG5ZSnNbwWqdmse?= =?us-ascii?Q?2xhfrUL//0f5Qz9aQhSPgqTfNDDg6pfgTETbX89ZJNOMBDJUgGzmW3daIsG7?= =?us-ascii?Q?nEfhhme1dS2wqfozBMffNp1T65RM3HQx3KnBRKxHwE9fgYin92AZOtm4LbX4?= =?us-ascii?Q?us6ZxLRSnkwPL5vIIy/hbQ4H/RPkMJ3jxkQib4ub8BXyxL5JRx0DhHKh1Uoe?= =?us-ascii?Q?k6PBLZTCquyduohUF4P0YU0+vjR8giet6BQjyWp9iO+9zuzj7af0VwmTlV58?= =?us-ascii?Q?MgImqh0KY3I3yqKRaNA+tkrU4UNX9dHqZeoUCdzYxDStOOVY6p5yZIKjqgOF?= =?us-ascii?Q?Pq1R+g2AKPzYMEKRN3LlnGlVth7orUki2JD+fHeJg9WhIlFIDKbkbAXjRsgO?= =?us-ascii?Q?WnD/TGVPZRR/Z1a5r0nLgCt2zBhA4CwnXPakrF9mAfGOLnfzMUkbbmU8ptAP?= =?us-ascii?Q?KZJZ5rKvVYmPCFt2byxVatm5AI/6bybnkUMTrYRZOFi3yOWq26UC1PnXdhRk?= =?us-ascii?Q?iA=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4929.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a03ce433-3617-41cc-39e2-08dc1c838720 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jan 2024 02:24:01.2570 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: FeMTSKcFWdZ8X3ezSsxPmwqYZHW2M9469YXW03KAuIlST2h1IesrCyTZ+cnIlQNe/+3V95IFBDpUKAqo0qZxpDXAJWEulXzYnqy9cTPby4U= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4748 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,michael.d.kinney@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: irzEcjG6ox3eNXQd2H9oeAAXx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=xEod0mh5; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Liming, I do not see any reviews of this patch. What is the status? Mike > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Dhaval > Sharma > Sent: Monday, January 8, 2024 7:00 AM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Liu, Zhiguang > ; Bi, Dandan ; Pedro > Falcato ; Chiu, Chasel > Subject: [edk2-devel] [PATCH v4 1/1] MdeModulePkg/AcpiTableDxe: Prefer > xDSDT over DSDT when installing tables >=20 > As per ACPI Spec 6.5+ Table 5-9 if xDSDT is available, > it should be used first. Handle required flow when xDSDT > is absent or present. >=20 > Test: Tested on RISCV64 Qemu platform with xDSDT and booted to > linux kernel. >=20 > Cc: Liming Gao > Cc: Zhiguang Liu > Cc: Dandan Bi > Cc: Pedro Falcato > Cc: devel@edk2.groups.io > Signed-off-by: Dhaval Sharma > Acked-by: Chasel Chiu > --- >=20 > Notes: > v4: > - Fix typos and commit message adding more clarity to patch subject > v3: > - Added description of ACPI spec clarification based on which this > patch is created > - Optimizing if-else flow > v2: > - Added proper indentation for else if >=20 > MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableProtocol.c | 23 > ++++++++++++++------ > 1 file changed, 16 insertions(+), 7 deletions(-) >=20 > diff --git > a/MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableProtocol.c > b/MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableProtocol.c > index e09bc9b704f5..61af6047a2a7 100644 > --- a/MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableProtocol.c > +++ b/MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableProtocol.c > @@ -1892,14 +1892,23 @@ InstallAcpiTableFromHob ( > } >=20 > } >=20 >=20 >=20 > - if (((EFI_ACPI_3_0_FIXED_ACPI_DESCRIPTION_TABLE *)ChildTable)- > >Dsdt !=3D 0) { >=20 > + // >=20 > + // First check if xDSDT is available, as that is preferred as > per >=20 > + // ACPI Spec 6.5+ Table 5-9 X_DSDT definition >=20 > + // >=20 > + if (((EFI_ACPI_3_0_FIXED_ACPI_DESCRIPTION_TABLE *)ChildTable)- > >XDsdt !=3D 0) { >=20 > + TableToInstall =3D (VOID > *)(UINTN)((EFI_ACPI_3_0_FIXED_ACPI_DESCRIPTION_TABLE *)ChildTable)- > >XDsdt; >=20 > + } else if (((EFI_ACPI_3_0_FIXED_ACPI_DESCRIPTION_TABLE > *)ChildTable)->Dsdt !=3D 0) { >=20 > TableToInstall =3D (VOID > *)(UINTN)((EFI_ACPI_3_0_FIXED_ACPI_DESCRIPTION_TABLE *)ChildTable)- > >Dsdt; >=20 > - Status =3D AddTableToList (AcpiTableInstance, > TableToInstall, TRUE, Version, TRUE, &TableKey); >=20 > - if (EFI_ERROR (Status)) { >=20 > - DEBUG ((DEBUG_ERROR, "InstallAcpiTableFromHob: Fail to add > ACPI table DSDT\n")); >=20 > - ASSERT_EFI_ERROR (Status); >=20 > - break; >=20 > - } >=20 > + } else { >=20 > + break; >=20 > + } >=20 > + >=20 > + Status =3D AddTableToList (AcpiTableInstance, TableToInstall, > TRUE, Version, TRUE, &TableKey); >=20 > + if (EFI_ERROR (Status)) { >=20 > + DEBUG ((DEBUG_ERROR, "InstallAcpiTableFromHob: Fail to add > ACPI table DSDT\n")); >=20 > + ASSERT_EFI_ERROR (Status); >=20 > + break; >=20 > } >=20 > } >=20 > } >=20 > -- > 2.39.2 >=20 >=20 >=20 > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#113401): > https://edk2.groups.io/g/devel/message/113401 > Mute This Topic: https://groups.io/mt/103598583/1643496 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub > [michael.d.kinney@intel.com] > -=3D-=3D-=3D-=3D-=3D-=3D >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114247): https://edk2.groups.io/g/devel/message/114247 Mute This Topic: https://groups.io/mt/103598583/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-