From: "Michael D Kinney" <michael.d.kinney@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"kraxel@redhat.com" <kraxel@redhat.com>,
Leif Lindholm <leif@nuviainc.com>,
"Kinney, Michael D" <michael.d.kinney@intel.com>
Cc: "Andrew Fish" <afish@apple.com>,
"Marvin Häuser" <mhaeuser@posteo.de>,
"Michael Kubacki" <Michael.Kubacki@microsoft.com>,
"mikuback@linux.microsoft.com" <mikuback@linux.microsoft.com>,
"rebecca@nuviainc.com" <rebecca@nuviainc.com>,
"Bret Barkelew" <Bret.Barkelew@microsoft.com>
Subject: Re: [edk2-devel] Progress on getting Uncrustify working for EDK2?
Date: Tue, 9 Nov 2021 15:44:52 +0000 [thread overview]
Message-ID: <CO1PR11MB492972114921659D79C29239D2929@CO1PR11MB4929.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20211109141007.z5iqvrspuqfleqzj@sirius.home.kraxel.org>
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Gerd Hoffmann
> Sent: Tuesday, November 9, 2021 6:10 AM
> To: Leif Lindholm <leif@nuviainc.com>
> Cc: devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com>; Andrew Fish <afish@apple.com>; Marvin Häuser
> <mhaeuser@posteo.de>; Michael Kubacki <Michael.Kubacki@microsoft.com>; mikuback@linux.microsoft.com; rebecca@nuviainc.com;
> Bret Barkelew <Bret.Barkelew@microsoft.com>
> Subject: Re: [edk2-devel] Progress on getting Uncrustify working for EDK2?
>
> On Tue, Nov 09, 2021 at 12:36:30PM +0000, Leif Lindholm wrote:
> > On Tue, Nov 09, 2021 at 09:40:02 +0100, Gerd Hoffmann wrote:
> > > Hi,
> > >
> > > > 3. Require use of uncrustify tool before submitting patch review emails or PRs.
> > > > * The required version would be a formally released version from the fork maintained by Michael Kubacki
> until the changes can be upstreamed.
> > > > * https://dev.azure.com/projectmu/Uncrustify
> > >
> > > Can we please *first* get the changes merged to upstream uncrustify?
> > >
> > > That'll make the whole process much less painful because the usual
> > > software repositories (linux distro packages, macos homebrew, ...)
> > > can be used to install uncrustify then, and it's also less confusing if
> > > developers don't have to juggle with different uncrustify variants
> > > (upstream vs. edk2).
> >
> > Whilst I agree in principle...
> >
> > This means postponing automated coding style changes until 2023
> > (Debian stable), 2025 (Ubuntu LTS), ??? (RHEL10), or even later
> > ... and I'd rather not.
> >
> > I like Marvin's suggestion of a submodule. Which we could drop once
> > no longer needed.
>
> I'm fine with a submodule (temporary & optional) so we don't have to
> wait until all distros (especially the LTS ones which are slower) have
> picked up the latest uncrustify release.
>
> But I still think upstreaming the uncrustify changes should be the first
> step.
The first step is to review and accept the style of code generated by
the current fork.
>
> take care,
> Gerd
>
>
>
>
>
next prev parent reply other threads:[~2021-11-09 15:44 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <e15cf895-03a4-96cd-2754-d1cfeead6b98@nuviainc.com>
2021-08-16 19:34 ` Progress on getting Uncrustify working for EDK2? Rebecca Cran
2021-08-16 19:39 ` [edk2-devel] " Marvin Häuser
2021-08-16 20:00 ` Michael Kubacki
2021-10-07 10:48 ` Leif Lindholm
2021-10-07 15:30 ` Andrew Fish
[not found] ` <16ABC94F0E9D1AC5.21629@groups.io>
2021-10-07 16:03 ` Andrew Fish
2021-10-07 16:34 ` Michael D Kinney
2021-10-07 17:01 ` Michael Kubacki
2021-10-07 17:05 ` Michael D Kinney
2021-10-07 18:30 ` Marvin Häuser
2021-10-07 17:19 ` Michael D Kinney
2021-10-07 17:36 ` Andrew Fish
2021-10-07 17:43 ` Marvin Häuser
2021-10-07 21:09 ` Andrew Fish
2021-11-09 0:23 ` Michael D Kinney
2021-11-09 1:09 ` Andrew Fish
2021-11-09 1:13 ` Michael D Kinney
2021-11-09 2:46 ` Andrew Fish
2021-11-09 3:02 ` Michael D Kinney
2021-11-09 7:32 ` Marvin Häuser
2021-11-09 15:43 ` Michael D Kinney
2021-11-09 16:12 ` Marvin Häuser
2021-11-09 16:33 ` Michael D Kinney
2021-11-09 20:55 ` Leif Lindholm
2021-11-09 21:20 ` Michael D Kinney
2021-11-09 23:23 ` Leif Lindholm
2021-11-10 10:12 ` Gerd Hoffmann
2021-11-09 1:12 ` 回复: " gaoliming
2021-11-09 15:22 ` Michael D Kinney
2021-11-09 8:40 ` Gerd Hoffmann
2021-11-09 11:56 ` Michael Brown
2021-11-09 12:36 ` Leif Lindholm
2021-11-09 14:10 ` Gerd Hoffmann
2021-11-09 15:44 ` Michael D Kinney [this message]
2021-11-10 15:38 ` Michael Kubacki
2021-11-09 15:08 ` Michael D Kinney
2021-11-09 18:13 ` Andrew Fish
2021-11-09 18:26 ` Michael D Kinney
2021-11-09 18:52 ` Andrew Fish
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO1PR11MB492972114921659D79C29239D2929@CO1PR11MB4929.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox