From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id B527ED8046F for ; Tue, 3 Oct 2023 16:00:45 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=ZtLAVQpqH2uBixY5cA8cWIqk8sGuV5GIT9ThK4SgwY4=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1696348844; v=1; b=GcfB9tZPiGIedzErJ/ou7b5So7ZrjDyTE9sPyqZKrj/Bu6zCKoqNfV+ppFd3gmcCkPuVenJF HFLSbnXeIAYnfWJoR01cpslMJHA+ovGPxOxV3aN0zbylQfIOlubtJNvfF72tVnckEtn7PFMuX9a nlE91BTZmIA/tMOY9nIOx9OQ= X-Received: by 127.0.0.2 with SMTP id IduIYY7687511xG6Y1NLV1zx; Tue, 03 Oct 2023 09:00:44 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web10.112409.1696348843275545142 for ; Tue, 03 Oct 2023 09:00:43 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10852"; a="385736023" X-IronPort-AV: E=Sophos;i="6.03,197,1694761200"; d="scan'208";a="385736023" X-Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Oct 2023 09:00:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10852"; a="821316851" X-IronPort-AV: E=Sophos;i="6.03,197,1694761200"; d="scan'208";a="821316851" X-Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga004.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 03 Oct 2023 09:00:35 -0700 X-Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Tue, 3 Oct 2023 09:00:35 -0700 X-Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Tue, 3 Oct 2023 09:00:35 -0700 X-Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.41) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Tue, 3 Oct 2023 09:00:35 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ivbhv3uYLdNpMBjxR4TVA07E/sd1SxXoiYZGi4maVgAQyeV2lRXG4qsdCv39CGtenaVzWTbc/9pdnTiF3TRbIlqw6/VU+mxwPW2JSwzs3oCyX7kfJ9riMjLeJT7kHQC9O6y+ZE4CHpz8poXOcZ6gCKQv7gfPHpgMJ2pL37m6TqxF9pRcCihOwwQsD7onA5wZp5R2Bv+blaOJCZTmvIeAtJPjfeGZkLh6p/hKDWGenRz7YksoullT064yOZ7Su3FODV352H9FUvMdUdcs1XOADLj7YqlhcsjEWrJnkZFdUQ2APTo+MFj16U5+OJQc6pCRKFSWCgHwsMZ2iam9r4cYiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PkAdiUGAgGCElkLOqcnZ0KlYYnirK5RmUrr4uy/bphk=; b=MbH2UBHNPGaX9Ay1LUiAELXeB1I2KJ3Xw+GFK6uL55f4BdAmy2ytxNC5ZkCYLc20POXGtKvtNFS+jSk+Mj4jws6DJBJuxxPVuhjNkL8OgYvWg7AEsm6oCqITLE4bhznJbhRXyTBe3N69jXzq0R2smbekSRbL6zkk8B8rstS3Pu2402YcFBZyPVjH6da2gMg2f+UyEz0CVXDHrJ01ob4cHHvNLmR3PV1mUbAtVQeAlQvUlG4Q2OhxoaVEUBMtX57Yxc+ZUzaJfe0OfmBT0K1myAcXxDqKK9mVjmlpiL4oGgXVAngLJBPa1BoJzAHPItOzmSO4ednnFyRbxs/Z69pmVQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com (2603:10b6:303:6d::19) by CY8PR11MB7729.namprd11.prod.outlook.com (2603:10b6:930:70::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.32; Tue, 3 Oct 2023 16:00:27 +0000 X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::2ebf:3b09:b169:ee2c]) by CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::2ebf:3b09:b169:ee2c%4]) with mapi id 15.20.6838.033; Tue, 3 Oct 2023 16:00:26 +0000 From: "Michael D Kinney" To: "Name jake@nvidia.com" , "devel@edk2.groups.io" CC: "Gao, Liming" , "Liu, Zhiguang" , Jake Garver , "Kinney, Michael D" Subject: Re: [edk2-devel] [PATCH] BaseStackCheckLib: Fix STACK FAULT message Thread-Topic: [PATCH] BaseStackCheckLib: Fix STACK FAULT message Thread-Index: AQHZ9fxjGOfT9BZ8Bk+8fgOQgV81crA4OR4Q Date: Tue, 3 Oct 2023 16:00:26 +0000 Message-ID: References: <20d06e654e1acf8f910f3c02d2f38ce121f769bf.1696339000.git.jake@nvidia.com> In-Reply-To: <20d06e654e1acf8f910f3c02d2f38ce121f769bf.1696339000.git.jake@nvidia.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO1PR11MB4929:EE_|CY8PR11MB7729:EE_ x-ms-office365-filtering-correlation-id: c4ac7ef1-d8eb-4824-db6a-08dbc429dbab x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: YjDPIwkTQ7y04bWR1fzSEu5IoNXWcHYVMvMh0wRuDKvRwBkh0zwgtIQhKr8bVduVxmrOR3Zuy+2LTvnysxS3Q8Qq1xXaJeJhegLuK0Y98VZcCJdfhqPSpqNOoXqi8W4rE/ypF3GXR8J4L2/rLBOdqWsAvawBScETyXXxBaaiQF17wCFWXfUnEK/bisDOvrHZ2MqI3SKIM6iFtGL1fTWiyDScLbbxYvVKC6+9IjBcS4XVOJR1Ip4JqSb0J8RAbfh8trZ+3hjprh4WFrf8TLIiMAhn7abRUZaUmCrucrkLquZnLexNYYfYi7NoPjDiJIpI2Y6kMmCRUJUXmxiIclD3ug6CDSzlrlA8fPspwN6lNuChy6RJAFuBSWVxHrAg4Vwmc0ffD0AtZlb96BSMboLmASbDQ6GR2PhfiUminbU+0t+gPhSQ/+oaQm/31eAtOMoVHViwgs/U801mDZRY0pS45PsIo3txhcT/L/Kcxttf0cY/CKcJ/psSVDnWefj56DrUGAkIpFCL7uePWVKrY9Vj93td8Q5lnHfVGQ2eCGJMSVQakfhrakMT1047dsWFF8BZ7jYAhLl0aVkozBtSh9cu2PGpCp9kOW7w1TAfbaYHjCMU++pgYrUgwdVJe3i9CRET x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?go9WUOCmTsxytfRSnnq+kL8MBqLH1SVnsRHTRYr/a8aS0rjbAS5hkqHyfC1D?= =?us-ascii?Q?cXw7r0d9dSiQZbCAWiFlyvuQJifZffvePVyQJmc084LdRLHnaSxj/ap3oYwK?= =?us-ascii?Q?PT9+MfZZXJYFdYv+9pNpzu+ht1VDV7k7BX9oyJSV68yrug1T6lmTEXDdHKzV?= =?us-ascii?Q?2puXOjiZiSlLLt5U5pGflQEVh0FjFnMBCgM8pEO5mZKiytQu4fQ2SRXA+rsb?= =?us-ascii?Q?uBAVi3AwJ2x0nj8cLpbV83LG7zK9p2hqrkABMZf5IIktmZMg10fspnDPdLCE?= =?us-ascii?Q?CASmQzrTYJO2zLn/3wvo8htndsKEl4zIELfa8gswWsc2e3+U+X8TFOngQ7ZB?= =?us-ascii?Q?SQI7gMW8Y7THlXZYFjMdggMhyou32B4cDiLEdMvl16N2MGkQTDeCHSdy01DG?= =?us-ascii?Q?Bzwxi6TJgZjXdMvRhSRJrHdv1Um4J6yxsjJ/dEVUp+IcvgvTcsqLUzb0hkHM?= =?us-ascii?Q?cqIC4Erm7GUZGykHgC1tuJtlP9mrjQ5sdXLiB4F7d/E0Asl7SQEXHXhqVKuE?= =?us-ascii?Q?9KCSn0r4CD33Ns+z1xvAo7lhK0DKE4fVYijBgiM6iUYDZPBNm0V6qDoOb53D?= =?us-ascii?Q?ewC6G9zoGEMOHwMzwDrfxafV667luq4n4CSDrpZFDWAeS3fVpu8pYdbHVULi?= =?us-ascii?Q?vfdunRK0RZOgOuaYAvXE7n1OLjGYrdJ9d6Q+uc0QiQJvqp8FkLV6hXdafOW4?= =?us-ascii?Q?9eQ7yRxjH/y1Y5L9G4Cc+g8kfEg23UCJwG4QLDFhhSwnauYvoPkWnSC0Hwf4?= =?us-ascii?Q?Or/9T3IyrzVt+gR1mFTUpW334/rcCijt7iWOzPWHFR4WzGGKyFqhIQWofxUC?= =?us-ascii?Q?3Ki8ylUzoTx+SQy9Ocn2kMYa3JT+3rt2hidQXIMwEGyigpqbMnQr4B71lCGN?= =?us-ascii?Q?yFR8kTY9K9RntZqrQI24vOtWrlLzKR7DUtuI8zBsdY2MaxjMLjJttr9A55B5?= =?us-ascii?Q?L+2LEyq6pyoxebPLvlggu8L8pRmo6m7voK9trxSHbKAlUYCAC7mH+0E2nN0J?= =?us-ascii?Q?XEpvqCZDf7lRFVUXnzdSM91GKYsB2LxJalqqKmixV3COmXLj0If4CHVaKhqA?= =?us-ascii?Q?MxcgPzb22UOOcWNI31XA4tz9fsoliKzMg1eSNNh6Aev2PBMCDu56OPh6t2C4?= =?us-ascii?Q?paBxGedgvbed8ycfpAVDOF7+XhcvmdKazL0ptOBEKt4I4ymSAembZUKO53cD?= =?us-ascii?Q?uZlSMfuYx4EOzDPTxbosCkabxMsVMDP7eqhziuIn6fQ7EeFh0sazX0SEEd5Q?= =?us-ascii?Q?3M83HsTGnsMh9+zVKbYfuqVG2OHCb9WEHu4Wj0aKlte/ltjv+4jILJEShk5Z?= =?us-ascii?Q?4MgQyi4paW976TdBnzFwKdnScBVjUGdPQn1WZ2Ehqd8Nae8pHc/EubucR8qn?= =?us-ascii?Q?GLm0V+J+6x94YZlq1hVUTmu5G3ajQVma0y77ZOWrNG5dn8YJ3P6CBYMG33th?= =?us-ascii?Q?s1drzr9C0b7IeRCHynMBtEwsOUi27Fhx8cKK3KtFRUVRX+9AG9mk102QiQHb?= =?us-ascii?Q?uVp5CJ3ccZo7uUtJQuOEybASWSJZm+GySs8RdUbGPlrXq+jqG5qqVUcgL3h9?= =?us-ascii?Q?kzFrRQhU5ng9RRX+yjwMKNLT9xGE+YLABTUGLbA/3mivobKKd28Vsvq/lT18?= =?us-ascii?Q?bw=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4929.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c4ac7ef1-d8eb-4824-db6a-08dbc429dbab X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Oct 2023 16:00:26.1070 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: v85NE5yf2Hcrb8x3Je/qkiBZXmtnWyIKFeFHpT94OJtvZ5lI2lMgeMf7aVML+RtKPylJty+BoUXfGUqHo1TjMvM86ws7VetdRNy7jcCKQfo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7729 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,michael.d.kinney@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: uBjlKoRaC8Hh80y4t29P1oQwx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=GcfB9tZP; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") I think the macro RETURN_ADDRESS from Base.h should be used instead of direct use of the builtin. Mike > -----Original Message----- > From: Name jake@nvidia.com > Sent: Tuesday, October 3, 2023 6:20 AM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Gao, Liming > ; Liu, Zhiguang ; Jake > Garver > Subject: [PATCH] BaseStackCheckLib: Fix STACK FAULT message >=20 > From: Jake Garver >=20 > __builtin_return_address returns a pointer, not a string. Fix the STACK > FAULT message in BaseStackCheckLib appropriately. >=20 > Signed-off-by: Jake Garver > --- > MdePkg/Library/BaseStackCheckLib/BaseStackCheckGcc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/MdePkg/Library/BaseStackCheckLib/BaseStackCheckGcc.c > b/MdePkg/Library/BaseStackCheckLib/BaseStackCheckGcc.c > index 0d2918668e..3b970391b7 100644 > --- a/MdePkg/Library/BaseStackCheckLib/BaseStackCheckGcc.c > +++ b/MdePkg/Library/BaseStackCheckLib/BaseStackCheckGcc.c > @@ -34,7 +34,7 @@ __stack_chk_fail ( > { > UINT8 DebugPropertyMask; >=20 > - DEBUG ((DEBUG_ERROR, "STACK FAULT: Buffer Overflow in function %a.\n", > __builtin_return_address (0))); > + DEBUG ((DEBUG_ERROR, "STACK FAULT: Buffer Overflow at 0x%p.\n", > __builtin_return_address (0))); >=20 > // > // Generate a Breakpoint, DeadLoop, or NOP based on PCD settings even = if > -- > 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109294): https://edk2.groups.io/g/devel/message/109294 Mute This Topic: https://groups.io/mt/101736789/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-