public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Michael D Kinney" <michael.d.kinney@intel.com>
To: Andrew Fish <afish@apple.com>,
	edk2-devel-groups-io <devel@edk2.groups.io>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>,
	Sean Brogan <sean.brogan@microsoft.com>
Cc: "rfc@edk2.groups.io" <rfc@edk2.groups.io>
Subject: Re: [edk2-devel] Update NASM to stable release 2.15.05
Date: Tue, 9 Nov 2021 18:39:59 +0000	[thread overview]
Message-ID: <CO1PR11MB4929756223F7C1E0FC827E60D2929@CO1PR11MB4929.namprd11.prod.outlook.com> (raw)
In-Reply-To: <1BD86940-6B6C-4390-8902-59E86057AEF6@apple.com>

Hi Andrew,

It looks like the EDK II CI agents were updated to use NASM 2.15.05 back in March of this year.

	https://github.com/tianocore/edk2/blob/0ecdcb6142037dd1cdd08660a2349960bcf0270a/BaseTools/Bin/nasm_ext_dep.yaml

So I think the only remaining task is to update the developer documentation to require NASM 2.15.05 as the new minimum required version.

Do you agree?

Mike

> -----Original Message-----
> From: Andrew Fish <afish@apple.com>
> Sent: Wednesday, October 20, 2021 11:05 AM
> To: edk2-devel-groups-io <devel@edk2.groups.io>; Kinney, Michael D <michael.d.kinney@intel.com>
> Cc: rfc@edk2.groups.io
> Subject: Re: [edk2-devel] Update NASM to stable release 2.15.05
> 
> Mike,
> 
> Sounds like a good plan.
> 
> Thanks,
> 
> Andrew Fish
> 
> > On Oct 20, 2021, at 9:51 AM, Michael D Kinney <michael.d.kinney@intel.com> wrote:
> >
> > Hello,
> >
> > I would like to propose that we update to a newer version of NASM.
> >
> > 	https://www.nasm.us/
> >
> > The most recent stable version is 2.15.05.
> >
> > 	https://www.nasm.us/pub/nasm/releasebuilds/2.15.05/
> >
> > NASM 2.15.05 Documentation:
> >
> > 	https://nasm.us/xdoc/2.15.05/html/
> > 	https://nasm.us/xdoc/2.15.05/nasmdoc.pdf
> >
> >
> > The reason to update is to use a version of NASM that supports
> > newer instructions that will allow the .nasm files with
> > DB statements for instructions to be updated to use
> > instruction names.  This improves the readability/maintenance
> > of the .nasm source files:
> >
> > 	https://nasm.us/xdoc/2.15.05/html/nasmdocb.html#section-B.1.41
> >
> > Also, the work on tools such as uncrustify to format source files
> > require tests to make sure the source format changes do not cause
> > any functional changes.  Compilers support flags for reproducible
> > builds.  NASM 2.15.05 added the --reproducible flag that provides
> > the same feature for OBJ files produces by NASM.
> >
> > 	https://nasm.us/xdoc/2.15.05/html/nasmdoc2.html#section-2.1.34
> >
> >
> > 	2.1.34 The --reproducible Option
> >
> > 	If this option is given, NASM will not emit information that is
> >       inherently dependent on the NASM version or different from run to
> >       run (such as timestamps) into the output file.
> >
> > Please let me know if there are any concerns with doing this tool update.
> > If there are no concerns, I will work on patches required to update
> > EDK II CI to use NASM 2.15.05 and to update the developer documentation
> > to require NASM 2.15.05 as the new minimum version.
> >
> > Thanks,
> >
> > Mike
> >
> >
> >
> > 
> >
> >


  reply	other threads:[~2021-11-09 18:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-20 16:51 Update NASM to stable release 2.15.05 Michael D Kinney
2021-10-20 18:05 ` [edk2-devel] " Andrew Fish
2021-11-09 18:39   ` Michael D Kinney [this message]
2021-11-09 18:51     ` Andrew Fish
2021-10-21  3:02 ` Ni, Ray

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CO1PR11MB4929756223F7C1E0FC827E60D2929@CO1PR11MB4929.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox