From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id C1C51D811C5 for ; Wed, 24 Jan 2024 06:27:08 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=KsCYRh2lfT4a84fR83TmxTjlQYNTBh4xL4kfr4o52Uo=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1706077627; v=1; b=n5UBYtfKwFCxBZ1CKExBBcFO9kDeDSL7K9AX5YQ+oaNfl/inm8HQjxXsxoywhj2owl7sriI9 ngOnbxS4HZVUhEWNFirJTYylPfPR/bV+3l6aPDX70lm25A+sjdkfrXPhdgFS1YP1OvUughDp9jY nGHBm+CbOcYyd/q0b9Kawmyo= X-Received: by 127.0.0.2 with SMTP id 4d5PYY7687511x8tFbprM07C; Tue, 23 Jan 2024 22:27:07 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) by mx.groups.io with SMTP id smtpd.web10.16884.1706077626563114939 for ; Tue, 23 Jan 2024 22:27:06 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10962"; a="9143000" X-IronPort-AV: E=Sophos;i="6.05,216,1701158400"; d="scan'208";a="9143000" X-Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jan 2024 22:27:06 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.05,216,1701158400"; d="scan'208";a="28277721" X-Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmviesa001.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 23 Jan 2024 22:27:06 -0800 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 23 Jan 2024 22:27:05 -0800 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 23 Jan 2024 22:27:04 -0800 X-Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Tue, 23 Jan 2024 22:27:04 -0800 X-Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.40) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Tue, 23 Jan 2024 22:27:04 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jiHnKl0/6gmY4nbCO85UMQkPU9Gyvu6it2b1tGIQG1ug8XyWOXJxKLd6MaQ1r4fU+ejL44C4bwqnrymTsylgau7OXvEJYPagiuiuwTUoLIm2Uq7gH38G60aPVD4WVRqvHxWx4UnrcXWC17jpmdboXI5qDRKRrQUjQ5wKQ/9bgKowgMy2esds/iiwNEkfXr1JfyT8m1lyNw76MN/m/O7v88FL6v9bZTJGx4hrqGJRONqZz6rS+Au/RLYHRui4+Fo4JW7bNknFInjrJwyEw2oJ4d+9xTdtDww+VRtSgHebXvG0UceS/bl5U6DM8BfMoVxYhLYIn8CUw4cJUbxYv1xFYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=p0fA+GXND7oO/w1nbo3NOtJn85ldZD8cOI6mYyKMo6w=; b=HgEalX4nkCyy0qneIwnp3A70TLKPiTTrxDm1ZHEjjyEEqAjFEW8KLr4w+6U25RkBLuVkbapuXVv2gY9fvqgMFDs0BDAAzeZxC3V/c2eJECoZ9c/9D6zUcWDpuzC3IaQTh4M1IhRFGmoTEuL3I3JYyI/RYu+RGwyra2FFNtE5BQdh1MmtNRJ4ZyQdPs1q3TSiviSYEkR5ITBP4HNXHEEMfaw5i5L99g5remgc0ikT5bxAe2cR4IHKgwqPkI2kI7uuXgeuPgP1ZKHHECQtTzegLw+RptUE/8MP5D0Jj3MxTvL2mjQ+VQSnal1X/Kkbgv1UOZOg0MUmRTk8zEscmWy/LA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com (2603:10b6:303:6d::19) by SJ0PR11MB4893.namprd11.prod.outlook.com (2603:10b6:a03:2ac::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7202.37; Wed, 24 Jan 2024 06:27:03 +0000 X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::7e42:1633:d0a6:9c00]) by CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::7e42:1633:d0a6:9c00%6]) with mapi id 15.20.7202.035; Wed, 24 Jan 2024 06:27:03 +0000 From: "Michael D Kinney" To: "devel@edk2.groups.io" , "jbrasen@nvidia.com" CC: "gaoliming@byosoft.com.cn" , "Liu, Zhiguang" , "Kinney, Michael D" Subject: Re: [edk2-devel] [PATCH v2 1/1] MdePkg/BaseFdtLib: Rename standard functions Thread-Topic: [edk2-devel] [PATCH v2 1/1] MdePkg/BaseFdtLib: Rename standard functions Thread-Index: AQHaTlIpM6O2xn8WrkGO+XPOhqoBQbDoCpeAgAB1ZhA= Date: Wed, 24 Jan 2024 06:27:03 +0000 Message-ID: References: <117b18420619e5b7065d678401063a6c24b2f52e.1706051719.git.jbrasen@nvidia.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO1PR11MB4929:EE_|SJ0PR11MB4893:EE_ x-ms-office365-filtering-correlation-id: 2f53d3c4-c2ef-42c6-c4bf-08dc1ca57a84 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: 1OtMCrpeC84Zeep577GDpPy1aj9Sr9XKjYADJeNMW5YZh8KkMxa0ZhvQYmugtfFvqQ0OkNGlDRCvR+4qQrb7TFCkHxxzYxZWJHpWyGyMOCLV4Fi4wRUlnhs1QFOvoL4hLhrgeIXfJhJXsDXYROxr54ovWowZ+g2GnxskybePUrZ0GSUMqEMTc/aO00BfyQFDdtRoxR4OxDmQNDFV7nQi7DXxLbosev9iJZGCp16mzzIOKfThgE9wQGOXkq1S0YhVzwEVfwmiWesTu/EoM8UmYf1F5aEcH3NEn9KmjZmz+plx0voZgabhE1VaOI92WlblnpU6OExY6PkL4c53/FLEYC8bp7LED9KruQNKN9TvtsT9qts0XTAEsI11O5jcO1Wap+8l62aPZpZaeXJ/i1ZXKDyRttusNF9CtKfjmfzh7L9Fm3dRpLtqCy//go8gmttl3TG3dbE1mEMbcGTBiJ5ZQUmASp3HQ248PJ7ti6816FvnSeQsd0sZChYATA+/jsyFi+A4waPAyx0pvPNYCzNGuvo1K4Sm6HQG4vYr0ULx+QKvnDhoQcbE2hfRM2wKnAW76Yxz+szjMu1FPWFyIrsj6safXNTZc8L/Gby5lIS8CuYLEKC+L5SIXdqErgu46KxRuwpMUbi0r21DaziDpAECcw== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?DtVp98B69UoAdLuod2lV/5piiE2MLLt7HQTu0jUQ0CvXDrO7DFaioc3QXuS/?= =?us-ascii?Q?XYjX0LLHSzxPgZ8LqBWuD8pfmGf+TknsB0/SUz09R3n2kbPTUSPVkScc+slf?= =?us-ascii?Q?aSVaaF9mZLA8aloWw6wiBYWUVa29nTESlL6XdD8bM8UL/8Nej1iaq8GdOuEV?= =?us-ascii?Q?kkJvTIOd3TJEi1MkrkvcRgbrIt5GKqX+K1EOY7yJM9VxplW5Xpjo6AcsTdy7?= =?us-ascii?Q?+EjNaCbB25krUYFWIYjk90sYjTHXEwf5CG5QCNY/0UAj4r9NNsibif4LdOeY?= =?us-ascii?Q?JKUz61VGYBUf7PzsONQrro4ytkvzhC1csi+sHG7joFfH80sxLE/4M/wPjsab?= =?us-ascii?Q?jrFW/3vkSpX0CQu0F2xiJs+7DdVdpKsuPMSn+8q0shQQT2x8xq0rEnkcjgLx?= =?us-ascii?Q?MfOOr1uHfJbwwvrgnhvER3uFSWsJH2E6ScN6Evp6OmMltdWrCqybMatcN1CR?= =?us-ascii?Q?ChcdoHO/3wQ+EgBm5dxowm0WrKNZXbDD9SrgRoIX04Omsln3Gw+BR7aOFslI?= =?us-ascii?Q?G/Ff42xsDaLO+yOzh3UqUQ2J9O1dbEoMhCUXz+AD5XH5beMy2fBlKaG3S7Uh?= =?us-ascii?Q?hzKXloMGz8FX9Hy952LBPWXa0kVu/Lggv72IsCsZvLY80OOSnp61HOLDoDsf?= =?us-ascii?Q?uctGhU3wWysLTP0r3dXLtvwGtBtFUi9OfpNWaSyvUK7xpPm6FOCsc2EHJhIn?= =?us-ascii?Q?acZKU5qYPWZoDHkUblqjzGItoz+wJSvW6CY9ImMQhs0I7jumkLuJnvtMQeHX?= =?us-ascii?Q?i/Kim9reTPoSq4/3Pwkl/BtK6rHWPCGTWSoBIl7JOJqhKT/LXU1txys1lCrE?= =?us-ascii?Q?7J1AFf3hstWYpPLpIgqeE0FKn83iynNVbZlkH1tNr4ijxnpSzIJ7zsFitf2P?= =?us-ascii?Q?CcTCAIyyBKMq/ADmcBl7udiboLPDH8sqzDxZL7lgcC30xvK/SxJINg+mRlOf?= =?us-ascii?Q?MCMYWDFI+2zIj0EsaQInDY1C5SelJ9Q2VFKyBP3svRDgRr+KEKIAtgkr2WnR?= =?us-ascii?Q?LeGmMo9ftoCRfNrqQ+CwhlY3O+irnsevGarcBFpINKSvJQEG0spGPvr8OAI/?= =?us-ascii?Q?ZfTX9yn2JDD/Bcwu3J9uYTQm0BEn4C2rxfE1cPbRvx6uburPO7eijkwlO9cr?= =?us-ascii?Q?94ZBqzAwoes4YmOyP9OhqKWmkD6r2CIKoa+bwyYNklxOtgObuQNeqELe9H0s?= =?us-ascii?Q?iRvsfW6o5L3ylpwR1XfT3MRuscLClBxhAMCCPqcowwGo6QeN6dD2GjGeqJWb?= =?us-ascii?Q?y1OkPYVo0FxAiQ4FLzEVKdqKmE/xVbKSi02pVY9VVUyrQLKPqiHEzIa62suf?= =?us-ascii?Q?Ch3CrDMPczXawevKWY0VD2mQNRcYIWiwJxA3WT+7j/9tjn/1tVEKcvD8wluP?= =?us-ascii?Q?YuE8q/wi+ZJciX8UuyX/KDQ82fQd0KkNGmZsTmqxP79GchRpg2TbcKnllFmv?= =?us-ascii?Q?BoB8U/DdKReByrLym/QogerSaIDU+nTuZXsCnzxzd4qX/fg3vHVnidhSa2fd?= =?us-ascii?Q?XBlc/DuiVkOw5qWgR2wmsCbRsH8GgJ8EUb1Mz9tFGKkYyfueCdWBtFrbDx+V?= =?us-ascii?Q?yqDFiSRY5hEBCRd0aUqg0yyUExr4w2mDYy4vOrd6MDpweX/HlcclNnWge5m2?= =?us-ascii?Q?eA=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4929.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2f53d3c4-c2ef-42c6-c4bf-08dc1ca57a84 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jan 2024 06:27:03.0285 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: mbgSS/N06Givp1LnDSJ2lRjtcsOa0yk1MXu+eecOh77LiyaPM5TIREZHBWR/wP0zbgs2JA3YHVwwbbPVSWHOyTzyVweOpBgrc5f0drUBFnE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4893 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,michael.d.kinney@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: QYdU0jtfFiaiqVuTZMdrlGB4x7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=n5UBYtfK; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Merged: https://github.com/tianocore/edk2/pull/5294 > -----Original Message----- > From: Kinney, Michael D > Sent: Tuesday, January 23, 2024 3:27 PM > To: devel@edk2.groups.io; jbrasen@nvidia.com > Cc: gaoliming@byosoft.com.cn; Liu, Zhiguang ; > Kinney, Michael D > Subject: RE: [edk2-devel] [PATCH v2 1/1] MdePkg/BaseFdtLib: Rename > standard functions >=20 > Reviewed-by: Michael D Kinney >=20 >=20 > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of Jeff > > Brasen via groups.io > > Sent: Tuesday, January 23, 2024 3:16 PM > > To: devel@edk2.groups.io > > Cc: gaoliming@byosoft.com.cn; Kinney, Michael D > > ; Liu, Zhiguang ; > > Jeff Brasen > > Subject: [edk2-devel] [PATCH v2 1/1] MdePkg/BaseFdtLib: Rename > standard > > functions > > > > Rename the standard functions in the LibFdtSupport to remove conflicts > > with other libraries that define them. > > > > Signed-off-by: Jeff Brasen > > --- > > MdePkg/Library/BaseFdtLib/LibFdtSupport.h | 7 +++++-- > > MdePkg/Library/BaseFdtLib/LibFdtWrapper.c | 25 ++-------------------- > - > > 2 files changed, 7 insertions(+), 25 deletions(-) > > > > diff --git a/MdePkg/Library/BaseFdtLib/LibFdtSupport.h > > b/MdePkg/Library/BaseFdtLib/LibFdtSupport.h > > index 393019324b73..8a26fbfc3251 100644 > > --- a/MdePkg/Library/BaseFdtLib/LibFdtSupport.h > > +++ b/MdePkg/Library/BaseFdtLib/LibFdtSupport.h > > @@ -63,13 +63,13 @@ strchr ( > > ); > > > > char * > > -strrchr ( > > +fdt_strrchr ( > > const char *, > > int > > ); > > > > unsigned long > > -strtoul ( > > +fdt_strtoul ( > > const char *, > > char **, > > int > > @@ -93,7 +93,10 @@ strcpy ( > > #define strnlen(str, count) > (size_t)(AsciiStrnLenS(str, > > count)) > > #define strncpy(strDest, strSource, count) AsciiStrnCpyS(strDest, > > MAX_STRING_SIZE, strSource, (UINTN)count) > > #define strcat(strDest, strSource) AsciiStrCatS(strDest, > > MAX_STRING_SIZE, strSource) > > +#define strchr(str, ch) ScanMem8(str, > AsciiStrSize > > (str), (UINT8)ch) > > #define strcmp(string1, string2, count) > (int)(AsciiStrCmp(string1, > > string2)) > > #define strncmp(string1, string2, count) > (int)(AsciiStrnCmp(string1, > > string2, (UINTN)(count))) > > +#define strrchr(str, ch) fdt_strrchr(str, ch) > > +#define strtoul(ptr, end_ptr, base) fdt_strtoul(ptr, end_ptr, > > base) > > > > #endif /* FDT_LIB_SUPPORT_H_ */ > > diff --git a/MdePkg/Library/BaseFdtLib/LibFdtWrapper.c > > b/MdePkg/Library/BaseFdtLib/LibFdtWrapper.c > > index ef6452914f5b..1a4cd573fdaf 100644 > > --- a/MdePkg/Library/BaseFdtLib/LibFdtWrapper.c > > +++ b/MdePkg/Library/BaseFdtLib/LibFdtWrapper.c > > @@ -18,28 +18,7 @@ > > // so the code gets a bit clunky to handle that case specifically. > > > > char * > > -strchr ( > > - const char *Str, > > - int Char > > - ) > > -{ > > - char *S; > > - > > - S =3D (char *)Str; > > - > > - for ( ; ; S++) { > > - if (*S =3D=3D Char) { > > - return S; > > - } > > - > > - if (*S =3D=3D '\0') { > > - return NULL; > > - } > > - } > > -} > > - > > -char * > > -strrchr ( > > +fdt_strrchr ( > > const char *Str, > > int Char > > ) > > @@ -71,7 +50,7 @@ __isspace ( > > } > > > > unsigned long > > -strtoul ( > > +fdt_strtoul ( > > const char *Nptr, > > char **EndPtr, > > int Base > > -- > > 2.34.1 > > > > > > > >=20 > > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114268): https://edk2.groups.io/g/devel/message/114268 Mute This Topic: https://groups.io/mt/103921658/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-