Re: [edk2-devel] GitHub PR Code Review process now active

["Michael D Kinney" <michael.d.kinney@intel.com>]

GitHub has notification settings.  Maintainers should configure
GitHub so they are notified of all PR submissions to edk2 repo.

The Wiki for the Maintainer Process provides a link to this page with the details:

https://docs.github.com/en/account-and-profile/managing-subscriptions-and-notifications-on-github/setting-up-notifications/configuring-notifications

https://docs.github.com/en/account-and-profile/managing-subscriptions-and-notifications-on-github/setting-up-notifications/configuring-notifications#about-custom-notifications

This allows Maintainers to receive notifications without being an
assigned reviewer.

Mike

> -----Original Message-----
> From: Rebecca Cran <rebecca@bsdio.com>
> Sent: Wednesday, May 29, 2024 11:19 AM
> To: devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com>;
> kraxel@redhat.com; Kubacki, Michael <michael.kubacki@microsoft.com>
> Subject: Re: [edk2-devel] GitHub PR Code Review process now active
> 
> On 5/29/2024 12:09 PM, Michael D Kinney via groups.io wrote:
> > Hi Gerd,
> >
> > We can clarify the Wiki.  A Maintainer has to be involved in every
> > code review.  The first action a Maintainer does is verify that the
> > code change should be considered at all or rejected.  Then add
> > maintainers for the ones that look like good submissions.
> >
> > I agree that this may add a bit of delay.  You are welcome to add
> > a comment with @<githubid> tags to the maintainers and reviewers so
> > they know to look at it and do the assignments.  If you like that
> > idea we can add that to the Wiki as well.
> >
> > Since PRs can be also opened by outside contributors that have
> > limited access, maintainers have to be involved in reviewing newly
> > submitted PRs.
> 
> "Then add maintainers for the ones that look like good submissions."
> 
> Surely in order for the maintainers to know the PR should be looked at
> in the first place they need to already be added?
> 
> --
> 
> Rebecca Cran



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119360): https://edk2.groups.io/g/devel/message/119360
Mute This Topic: https://groups.io/mt/106355103/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-