public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Michael D Kinney" <michael.d.kinney@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"abner.chang@amd.com" <abner.chang@amd.com>,
	"Ni, Ray" <ray.ni@intel.com>
Cc: "Wu, Hao A" <hao.a.wu@intel.com>,
	"Kirkendall, Garrett" <Garrett.Kirkendall@amd.com>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] [PATCH V4] MdeModulePkg/Pci: Display more information of PCIe devices
Date: Wed, 15 Feb 2023 00:40:40 +0000	[thread overview]
Message-ID: <CO1PR11MB49297DFEA332CE04CBD38E0ED2A39@CO1PR11MB4929.namprd11.prod.outlook.com> (raw)
In-Reply-To: <MN2PR12MB3966B40149364D9CB3C7804CEAA39@MN2PR12MB3966.namprd12.prod.outlook.com>

It is already in process of being merged

https://github.com/tianocore/edk2/pull/4042

Mike

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Chang, Abner via groups.io
> Sent: Tuesday, February 14, 2023 4:29 PM
> To: Kinney, Michael D <michael.d.kinney@intel.com>; devel@edk2.groups.io; Ni, Ray <ray.ni@intel.com>
> Cc: Wu, Hao A <hao.a.wu@intel.com>; Kirkendall, Garrett <Garrett.Kirkendall@amd.com>
> Subject: Re: [edk2-devel] [PATCH V4] MdeModulePkg/Pci: Display more information of PCIe devices
> 
> [AMD Official Use Only - General]
> 
> Thanks Ray and Mike, I will create PR and merge it.
> 
> Abner
> 
> > -----Original Message-----
> > From: Kinney, Michael D <michael.d.kinney@intel.com>
> > Sent: Wednesday, February 15, 2023 7:27 AM
> > To: devel@edk2.groups.io; Ni, Ray <ray.ni@intel.com>; Chang, Abner
> > <Abner.Chang@amd.com>
> > Cc: Wu, Hao A <hao.a.wu@intel.com>; Kirkendall, Garrett
> > <Garrett.Kirkendall@amd.com>; Kinney, Michael D
> > <michael.d.kinney@intel.com>
> > Subject: RE: [edk2-devel] [PATCH V4] MdeModulePkg/Pci: Display more
> > information of PCIe devices
> >
> > Caution: This message originated from an External Source. Use proper
> > caution when opening attachments, clicking links, or responding.
> >
> >
> > Acked-by: Michael D Kinney <michael.d.kinney@intel.com>
> >
> > > -----Original Message-----
> > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ni,
> > Ray
> > > Sent: Monday, February 13, 2023 6:18 PM
> > > To: devel@edk2.groups.io; abner.chang@amd.com
> > > Cc: Wu, Hao A <hao.a.wu@intel.com>; Garrett Kirkendall
> > > <garrett.kirkendall@amd.com>
> > > Subject: Re: [edk2-devel] [PATCH V4] MdeModulePkg/Pci: Display more
> > > information of PCIe devices
> > >
> > > Reviewed-by: Ray Ni <ray.ni@intel.com>
> > >
> > > > -----Original Message-----
> > > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> > > > Chang, Abner via groups.io
> > > > Sent: Thursday, January 12, 2023 1:14 PM
> > > > To: devel@edk2.groups.io
> > > > Cc: Wu, Hao A <hao.a.wu@intel.com>; Ni, Ray <ray.ni@intel.com>;
> > > > Garrett Kirkendall <garrett.kirkendall@amd.com>; Abner Chang
> > > > <abner.chang@amd.com>
> > > > Subject: [edk2-devel] [PATCH V4] MdeModulePkg/Pci: Display more
> > > > information of PCIe devices
> > > >
> > > > From: Abner Chang <abner.chang@amd.com>
> > > >
> > > > In V4: Update the copyright to 2023.
> > > > In V3: Add AMD copyright.
> > > > In V2: Remove the signed-off-by: Abner Chang
> > > >
> > > > Display PCIe Vendor ID and Device ID in DEBUG message.
> > > >
> > > > Signed-off-by: Jiangang He <jiangang.he@amd.com>
> > > > Cc: Hao A Wu <hao.a.wu@intel.com>
> > > > Cc: Ray Ni <ray.ni@intel.com>
> > > > Cc: Garrett Kirkendall <garrett.kirkendall@amd.com>
> > > > Cc: Abner Chang <abner.chang@amd.com>
> > > > ---
> > > >  MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c | 7 +++++-
> > -
> > > >  1 file changed, 5 insertions(+), 2 deletions(-)
> > > >
> > > > diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> > > > b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> > > > index 8eca8596958..6594b8eae83 100644
> > > > --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> > > > +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> > > > @@ -3,6 +3,7 @@
> > > >
> > > >  Copyright (c) 2006 - 2021, Intel Corporation. All rights
> > > > reserved.<BR>
> > > >  (C) Copyright 2015 Hewlett Packard Enterprise Development LP<BR>
> > > > +Copyright (C) 2023 Advanced Micro Devices, Inc. All rights
> > > > +reserved.<BR>
> > > >  SPDX-License-Identifier: BSD-2-Clause-Patent
> > > >
> > > >  **/
> > > > @@ -227,13 +228,15 @@ PciSearchDevice (
> > > >
> > > >    DEBUG ((
> > > >      DEBUG_INFO,
> > > > -    "PciBus: Discovered %s @ [%02x|%02x|%02x]\n",
> > > > +    "PciBus: Discovered %s @ [%02x|%02x|%02x]  [VID = 0x%x, DID =
> > > > 0x%0x]\n",
> > > >      IS_PCI_BRIDGE (Pci) ?     L"PPB" :
> > > >      IS_CARDBUS_BRIDGE (Pci) ? L"P2C" :
> > > >      L"PCI",
> > > >      Bus,
> > > >      Device,
> > > > -    Func
> > > > +    Func,
> > > > +    Pci->Hdr.VendorId,
> > > > +    Pci->Hdr.DeviceId
> > > >      ));
> > > >
> > > >    if (!IS_PCI_BRIDGE (Pci)) {
> > > > --
> > > > 2.37.1.windows.1
> > > >
> > > >
> > > >
> > > >
> > > >
> > >
> > >
> > >
> > >
> > >
> 
> 
> 
> 


  reply	other threads:[~2023-02-15  0:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-12  5:14 [PATCH V4] MdeModulePkg/Pci: Display more information of PCIe devices Chang, Abner
2023-02-14  2:18 ` [edk2-devel] " Ni, Ray
2023-02-14 23:27   ` Michael D Kinney
2023-02-15  0:28     ` Chang, Abner
2023-02-15  0:40       ` Michael D Kinney [this message]
2023-02-15  0:41         ` Chang, Abner
2023-02-15  1:23     ` Michael D Kinney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CO1PR11MB49297DFEA332CE04CBD38E0ED2A39@CO1PR11MB4929.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox