From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 828157803D0 for ; Thu, 20 Jul 2023 01:41:23 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=Pyohk1czo76MY95JU2OkWZ6UAU8VK9w5rJIzeMDRvlc=; c=relaxed/simple; d=groups.io; h=X-Received:X-Received:X-IronPort-AV:X-IronPort-AV:X-Received:X-ExtLoop1:X-IronPort-AV:X-IronPort-AV:X-Received:X-Received:X-Received:X-Received:ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:X-Received:X-Received:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:X-MS-Has-Attach:X-MS-TNEF-Correlator:x-ms-publictraffictype:x-ms-traffictypediagnostic:x-ms-office365-filtering-correlation-id:x-ms-exchange-senderadcheck:x-ms-exchange-antispam-relay:x-microsoft-antispam-message-info:x-ms-exchange-antispam-messagedata-chunkcount:x-ms-exchange-antispam-messagedata-0:MIME-Version:X-MS-Exchange-CrossTenant-AuthAs:X-MS-Exchange-CrossTenant-AuthSource:X-MS-Exchange-CrossTenant-Network-Message-Id:X-MS-Exchange-CrossTenant-originalarrivaltime:X-MS-Exchange-CrossTenant-fromentityheader:X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype:X-MS-Exchange-CrossTenant-userprincipalname:X-MS-Exchange-Transport-CrossTenantHeaders Stamped:X-OriginatorOrg:Precedence:List-Unsubscribe:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:X-Gm-Message-State:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1689817282; v=1; b=qksq95Kq5AgI+1ipJrTOg474bZIYCRlgM0TsAUdl8QOlSHBQP1Va04sWfu2N6c0oJv0O8Z/C h56OTqZRXUnnn2SLzYFO4rYK+Q/DU6AVRR6918VKLx/ImfBUtun1C4cNb5FWG52aOOsgskam5QL OblIktpyvHYrwx1huVoVQw8Q= X-Received: by 127.0.0.2 with SMTP id GCjsYY7687511x4FmeOEhuQp; Wed, 19 Jul 2023 18:41:22 -0700 X-Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web10.3814.1689817280829826108 for ; Wed, 19 Jul 2023 18:41:21 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10776"; a="366646159" X-IronPort-AV: E=Sophos;i="6.01,216,1684825200"; d="scan'208";a="366646159" X-Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jul 2023 18:41:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10776"; a="727515765" X-IronPort-AV: E=Sophos;i="6.01,216,1684825200"; d="scan'208";a="727515765" X-Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga007.fm.intel.com with ESMTP; 19 Jul 2023 18:41:20 -0700 X-Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Wed, 19 Jul 2023 18:41:19 -0700 X-Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Wed, 19 Jul 2023 18:41:19 -0700 X-Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.42) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Wed, 19 Jul 2023 18:41:19 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BgzVVfSHBN33u5DCTiK72Ab0xC1L0H3dlsKNhHU4i11aN3sbqQD9y2Gsr37Y84n3heHIJ+nlRfsTgG3/ag2E7f4RgBvGun3fskSbxMzTkkKy2S8DH61cFlXs7EKN8yO+xIIOeJ/bthCDg/7DryWlqOifEpljawMlU/M7DxzEIYbRJQH7gCQGbGVqdn/5FLJPWVpf/tuSP7tH//zaPww6dxWXp5kiWchVSgXC760mUyviTkBJJWEjL2t6YfCG6bLRX+toce5d59zPpy4l1g+k4+xVI3woJDZNH7k5h+JaRFygDrUxF/QghLJ7mBuUgcmHiqCSmOeVsOlry0wpwLHlvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tfmG/szADs0qxayg5/CsHG2YCSHWY2qb5KFSxVitF5Y=; b=QkRn69O796b5bIiKzH2BIb8Z1i2O2BwgnZRb/Im+C0cfh1/3Hbzp2nGOBAN8kKp2v9PuS2cF6Y5jQbbnMulvK0XkMDD4I6DHZdoZSe0EH8n1JxEYivSS1+0hLJrEdhXsUxwPG1f1JIyLEkq385uz5Gi5Sw2vAHa/g9nFe0WSCVolmKgjEPPkibrIjD//H9NLcGzcHSjI9zaGB5wIdkJJ2BED33MEqpixFEK71B2pq46seWAqAPvhNpw7BFCCnOjxrQ0JkC0Hi2r5N1AF2YQwlI+LewdEA7sCOVDVa/va8XKVQwm/D4i+cHeVCmEg6nLHURRCPBVZEzPIxBokN1tYJQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com (2603:10b6:303:6d::19) by CH0PR11MB8190.namprd11.prod.outlook.com (2603:10b6:610:188::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.25; Thu, 20 Jul 2023 01:41:17 +0000 X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::9c86:9394:6bb1:2e83]) by CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::9c86:9394:6bb1:2e83%5]) with mapi id 15.20.6609.024; Thu, 20 Jul 2023 01:41:17 +0000 From: "Michael D Kinney" To: "Kasbekar, Saloni" , Nickle Wang , "devel@edk2.groups.io" , "Clark-williams, Zachary" CC: Abner Chang , Igor Kulchytskyy , "Nick Ramirez" , "Kinney, Michael D" Subject: Re: [edk2-devel] [PATCH 2/2] NetworkPkg/HttpDxe: fix driver binding start issue. Thread-Topic: [edk2-devel] [PATCH 2/2] NetworkPkg/HttpDxe: fix driver binding start issue. Thread-Index: AQHZPUwAuV9WkswkYkek1DFyHKnaxa+gO4QQgAEvnACAADfV0IABlBQQgBT7atCAAJx/sIAJ9/VggAAU53A= Date: Thu, 20 Jul 2023 01:41:17 +0000 Message-ID: References: <174276A45CE2816B.5513@groups.io> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO1PR11MB4929:EE_|CH0PR11MB8190:EE_ x-ms-office365-filtering-correlation-id: beaec203-213d-4ac6-09e5-08db88c26983 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: pKlTrBxLfZVC0/1QMcIWnePgjQu6zWP5DEr4MQUJPy1HqIYxvLtcQDZbkNOYiZkanjoEJXlRkoXLvOOSil8wj/KUjBW6szEJMhisJFEieYrpT97UUxduROfCYgXoj+T71yi9sY11WmhhQYyPHdZeayPopsLGceJZWIKwPbe62HRSpwiwO2aUMPxy2eA2cPWRbqxpH1Ae3QDUxFSupmOTCwClrfR2iXvqDCkEl0CIrWS3DwHpYyw9oQ0AxV10KvheaLLxXy+B/SiVYMymVeinCrgevufL0dksfbztg9kVX9q5zjl5WhNZSIM76vXgJkDbW3KW/is4ZGNVtfWtbjdPc8f0YBeDro4eFHZFLJ5KpjyojD/Uch7MAw5byVpNgc4FltXSmfg5tYYWkec+NHzahNA6kTQzsWKvKekjLIRBk3WIldsfmJ0lPrbrb/pxAjY94oPubhgCKH/bliHyzaKEuOXyG2kRufLdeGuDB2Z9HX23iXBLfPru1xMbLuqYCbx3i4ndgrnkYlkgBjn8FDVQyZXTwVP8H6y52CtMr4d+R6B3PAIzNSlSTAFSj7dWJ0riex8H/lKBESv+CrslMRGzPs8NubHZi+CRAeqaTCa/2t5YGbuPmnNcwE2KQyuSf3zygEqNnp5VmP2rHYN2p4m5jxA0cTJe2dNyr61XO6L1/1M= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?6MButU1m+S/IjH5m2Ue/x2cSg2lov+GZYUHTW3X+ET4hrJY3hqifd9x09+qg?= =?us-ascii?Q?eRSfM2RXxYCWEzbhb29zLC0aOa4ZCFrA3TPa0UUAGiqYBA8NKmDLs2pUBN/Z?= =?us-ascii?Q?jd5Lh2idRngnXrRhkEDq8jNsTWTHWt2lpx9PBvCNpdbaOTEs0TCJ3gRWUTzz?= =?us-ascii?Q?BvSAX4aDf9gWS2AQlG4cCtQ9e4A2kowpF30NeCkli7ud1u753OQ8EIl70GyA?= =?us-ascii?Q?kckM9h+gpJSovcfOZZ2YOhvG9a+o9eMIm//PVbsHK4KmLdQe2vlwYU4TWX6h?= =?us-ascii?Q?kJzwC5rlSZULsWYr4Tmh48RZyFaPS4eBGq9NHGEKsrzP9ZS4w8t5TTEwXoVa?= =?us-ascii?Q?I54gCdHkQwO8Arn66LQw6X31ME6pfhbIz3Pdrd2jQrOKGowEXAQXqEDpeh8w?= =?us-ascii?Q?CDFoLShN81vG/eYlDMQoMc92JWMkeBv/ECbANYF6sG4e7avt0fZqxmKYyAQ8?= =?us-ascii?Q?QLFWSuXWvHvbvt3lQhNewc0g8b3f5RNZsvkqvnfiYbQHxo3mi4Tz6QhosJTs?= =?us-ascii?Q?qiuc4Wh6rUm98bLR+v3RL9qPaW0niecgSwaO7c9FrOmHjiugFJVvoN69LlRm?= =?us-ascii?Q?ZCCGSkW4EemqyWcthSjiUkkQ1z1mYcFyjODeW9H89NO8wqMW4du3t+iXTCs6?= =?us-ascii?Q?1VPv/aiCzMeIIEH4YWsV7r9lfLhNip0QTCGO3I80IyLVk/81hsj3V/DAcO5A?= =?us-ascii?Q?e3/WLz/9PLw3uSmt6Aq4LW5hPLL9LUmynfk51A0Sg6bDqyecRMaKZIec8wcn?= =?us-ascii?Q?/1rJhjX2RW8OtkqsJlCTSJYaYMBgA5+cZ07U3vzbpsgYgWe2lZh/SbXQBQPy?= =?us-ascii?Q?h6x7hHM86qgC3TmNJyOcgzSWHH5FN3lGodVUIHc+HrO4T8md9qQiQmeGF5Rd?= =?us-ascii?Q?8Wurp1oRtFLJavNb/ang81POPoctLt6rhIeYp2ViRF6HEJ6ZlvVy4RJRVJhD?= =?us-ascii?Q?32x30MMJ0LmKEX53VBdZ8cfTInJNhbw0OpXl5LzOsDm5/D8VWKuqcSqK75nS?= =?us-ascii?Q?MGIjrkLXZ9EnRLSV0mnpH3dGolpU2RXZSRlwvoH1fOaphqfourew36+TEc2h?= =?us-ascii?Q?PwyX4puGs02wjwHWb4+/3Vldacn7wFs8EDJ2Xv5AJ/K5JW19gPJq7Q7jrgB3?= =?us-ascii?Q?Ycw+xU1AJUPkZW4QqKtffJMZcTh2L/IbIlA+FnOdt3rQnE24DpFZdW0Lqvxi?= =?us-ascii?Q?Ok/XnQ+FWbbNaNey6dHA/1ojiuOqDZo725Tk6Gh1xYd/HBUsN5eWenn1hkrW?= =?us-ascii?Q?UfHv1Jmh6yrtZ1JvBgOqnK1BV+zp+xQMTOy97RQm+DjKrs7iv4boF86H/eq8?= =?us-ascii?Q?YAl2AjLW66EIS7pJkr/yniu0rj3Q3gPDoAq4rsD/+cGFlponS+FFqh/IZSNc?= =?us-ascii?Q?wk/28wWPRFOBHANeZFsg7x2yciOXhhjve2WWMF02/hh3Cnpg6Xc5LwKpX3pC?= =?us-ascii?Q?FOuTyzwg+KlZXIUkUDTqNeMAdpKEjDBmZy4h2Irz23+1ZmKmB5bnzXWWviIO?= =?us-ascii?Q?4r3s9B26Ccr+CBz27iC734jXC2sbLs4CmkEi9/3GDLISNEU2Yc1vT+qO2Yhh?= =?us-ascii?Q?UoD/nLpG4prXIAX7MvCcfmf+kFZc+w8RszBoF0F6rEW1nJuBnCICsxlMnOli?= =?us-ascii?Q?XA=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4929.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: beaec203-213d-4ac6-09e5-08db88c26983 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jul 2023 01:41:17.8232 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: UjTcYzZNmn0fcLW9nXVaJSaarmDoh1sGwHcKPgrnzmQzlgpAHgxs6awx21141znaYppcCIUKoant4Jx90GGSCWVqYBG3tH1OYryv4hJbhro= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB8190 X-OriginatorOrg: intel.com Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,michael.d.kinney@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click X-Gm-Message-State: VTCDKCGhhy7DqeAD0PutGKRFx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=qksq95Kq; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Merged: https://github.com/tianocore/edk2/pull/4666 Mike > -----Original Message----- > From: Kinney, Michael D > Sent: Wednesday, July 19, 2023 5:27 PM > To: Kasbekar, Saloni ; Nickle Wang > ; devel@edk2.groups.io; Clark-williams, Zachary > > Cc: Abner Chang ; Igor Kulchytskyy ; > Nick Ramirez ; Kinney, Michael D > > Subject: RE: [edk2-devel] [PATCH 2/2] NetworkPkg/HttpDxe: fix driver > binding start issue. >=20 > Acked-by: Michael D Kinney >=20 > > -----Original Message----- > > From: Kasbekar, Saloni > > Sent: Thursday, July 13, 2023 9:13 AM > > To: Nickle Wang ; devel@edk2.groups.io; Clark- > > williams, Zachary ; Kinney, Michael > D > > > > Cc: Abner Chang ; Igor Kulchytskyy > ; > > Nick Ramirez > > Subject: RE: [edk2-devel] [PATCH 2/2] NetworkPkg/HttpDxe: fix driver > > binding start issue. > > > > Mike, > > > > Would you be able to help us merge the patch? > > > > Thanks, > > Saloni > > > > -----Original Message----- > > From: Nickle Wang > > Sent: Wednesday, July 12, 2023 11:54 PM > > To: devel@edk2.groups.io; Kasbekar, Saloni > ; > > Clark-williams, Zachary > > Cc: Abner Chang ; Igor Kulchytskyy > ; > > Nick Ramirez > > Subject: RE: [edk2-devel] [PATCH 2/2] NetworkPkg/HttpDxe: fix driver > > binding start issue. > > > > Hi Saloni, > > > > Could you please help to merge this fix since there is no objection > > during past weeks? > > > > Thanks, > > Nickle > > > > > -----Original Message----- > > > From: devel@edk2.groups.io On Behalf Of > Saloni > > > Kasbekar via groups.io > > > Sent: Friday, June 30, 2023 6:28 AM > > > To: Nickle Wang ; devel@edk2.groups.io > > > Cc: Maciej Rabeda ; Siyuan Fu > > > ; Abner Chang ; Igor > > > Kulchytskyy ; Nick Ramirez > > > Subject: Re: [edk2-devel] [PATCH 2/2] NetworkPkg/HttpDxe: fix driver > > > binding start issue. > > > > > > External email: Use caution opening links or attachments > > > > > > > > > Hi Nickle, > > > > > > That makes sense. Thanks for the clarification. > > > > > > Reviewed-by: Saloni Kasbekar > > > > > > Thanks, > > > Saloni > > > > > > -----Original Message----- > > > From: Nickle Wang > > > Sent: Wednesday, June 28, 2023 3:30 PM > > > To: Kasbekar, Saloni ; > devel@edk2.groups.io > > > Cc: Maciej Rabeda ; Siyuan Fu > > > ; Abner Chang ; Igor > > > Kulchytskyy ; Nick Ramirez > > > Subject: RE: [edk2-devel] [PATCH 2/2] NetworkPkg/HttpDxe: fix driver > > > binding start issue. > > > > > > Hi Saloni, > > > > > > Thanks for your review. > > > > > > When uninstall fails, per UEFI specification, the protocol will be > > > installed again and will be visible to UEFI drivers. > > > > > > Page 190, UEFI spec. 2.10: > > > "If any errors are generated while the protocol interfaces are being > > > uninstalled, then the protocols uninstalled prior to the error will > be > > > reinstalled with the boot service > > > EFI_BOOT_SERVICES.InstallProtocolInterface() and the status code > > > EFI_INVALID_PARAMETER is returned." > > > > > > In this case, if we do FreePool while driver still can locate > > > gEfiHttpServiceBindingProtocolGuid. Driver will access to the memory > > > that is released to system. Memory issue may happen. > > > > > > Regards, > > > Nickle > > > > > > > -----Original Message----- > > > > From: Kasbekar, Saloni > > > > Sent: Thursday, June 29, 2023 3:07 AM > > > > To: devel@edk2.groups.io; Nickle Wang > > > > Cc: Maciej Rabeda ; Siyuan Fu > > > > ; Abner Chang ; Igor > > > > Kulchytskyy ; Nick Ramirez > > > > Subject: RE: [edk2-devel] [PATCH 2/2] NetworkPkg/HttpDxe: fix > driver > > > > binding start issue. > > > > > > > > External email: Use caution opening links or attachments > > > > > > > > > > > > Hi Nickle, > > > > > > > > We would want to do the FreePool even if the Uninstall fails (like > > > > in the case where we failed to install the multiple protocol > > > > interfaces and then went to ON_ERROR). Do you think it's better if > > > > we change it to - > > > > > > > > if (HttpService !=3D NULL) { > > > > HttpCleanService (HttpService, UsingIpv6); > > > > Status =3D gBS->UninstallMultipleProtocolInterfaces ( > > > > &ControllerHandle, > > > > &gEfiHttpServiceBindingProtocolGuid, > > > > &HttpService->ServiceBinding, > > > > NULL > > > > ); > > > > if ((HttpService->Tcp4ChildHandle =3D=3D NULL) && > > > > (HttpService->Tcp6ChildHandle =3D=3D NULL)) { > > > > FreePool (HttpService); > > > > } > > > > } > > > > > > > > Thanks, > > > > Saloni > > > > > > > > -----Original Message----- > > > > From: devel@edk2.groups.io On Behalf Of > > > > Nickle Wang via groups.io > > > > Sent: Tuesday, June 27, 2023 5:56 PM > > > > To: devel@edk2.groups.io; Nickle Wang > > > > Cc: Maciej Rabeda ; Siyuan Fu > > > > ; Abner Chang ; Igor > > > > Kulchytskyy ; Nick Ramirez > > > > Subject: Re: [edk2-devel] [PATCH 2/2] NetworkPkg/HttpDxe: fix > driver > > > > binding start issue. > > > > > > > > May I know if someone can help to review this patch? > > > > > > > > Thanks, > > > > Nickle > > > > > > > > > -----Original Message----- > > > > > From: devel@edk2.groups.io On Behalf Of > > > > > Nickle Wang via groups.io > > > > > Sent: Friday, February 10, 2023 8:34 PM > > > > > To: devel@edk2.groups.io > > > > > Cc: Maciej Rabeda ; Siyuan Fu > > > > > ; Abner Chang ; Igor > > > > > Kulchytskyy ; Nick Ramirez > > > > > Subject: [edk2-devel] [PATCH 2/2] NetworkPkg/HttpDxe: fix driver > > > > > binding start issue. > > > > > > > > > > External email: Use caution opening links or attachments > > > > > > > > > > > > > > > When failure happens in HttpDxeStart, the error handling code > > > > > release the memory buffer but it does not uninstall HTTP service > > > > > bindnig protocol. As the result, application can still locate > this > > > > > protocol and invoke service binding fucntions in released memory > > pool. > > > > > > > > > > Signed-off-by: Nickle Wang > > > > > Cc: Maciej Rabeda > > > > > Cc: Siyuan Fu > > > > > Cc: Abner Chang > > > > > Cc: Igor Kulchytskyy > > > > > Cc: Nick Ramirez > > > > > --- > > > > > NetworkPkg/HttpDxe/HttpDriver.c | 13 +++++++++++-- > > > > > 1 file changed, 11 insertions(+), 2 deletions(-) > > > > > > > > > > diff --git a/NetworkPkg/HttpDxe/HttpDriver.c > > > > > b/NetworkPkg/HttpDxe/HttpDriver.c index 5d918d3c4d..f6d1263cad > > > > > 100644 > > > > > --- a/NetworkPkg/HttpDxe/HttpDriver.c > > > > > +++ b/NetworkPkg/HttpDxe/HttpDriver.c > > > > > @@ -3,6 +3,7 @@ > > > > > > > > > > Copyright (c) 2015 - 2018, Intel Corporation. All rights > > reserved.
> > > > > (C) Copyright 2016 Hewlett Packard Enterprise Development > > > > > LP
> > > > > + Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All > rights > > > reserved. > > > > > > > > > > SPDX-License-Identifier: BSD-2-Clause-Patent > > > > > > > > > > @@ -464,8 +465,16 @@ ON_ERROR: > > > > > > > > > > if (HttpService !=3D NULL) { > > > > > HttpCleanService (HttpService, UsingIpv6); > > > > > - if ((HttpService->Tcp4ChildHandle =3D=3D NULL) && (HttpServi= ce- > > > > > >Tcp6ChildHandle =3D=3D NULL)) { > > > > > - FreePool (HttpService); > > > > > + Status =3D gBS->UninstallMultipleProtocolInterfaces ( > > > > > + &ControllerHandle, > > > > > + &gEfiHttpServiceBindingProtocolGuid, > > > > > + &HttpService->ServiceBinding, > > > > > + NULL > > > > > + ); > > > > > + if (!EFI_ERROR (Status)) { > > > > > + if ((HttpService->Tcp4ChildHandle =3D=3D NULL) && > (HttpService- > > > > > >Tcp6ChildHandle =3D=3D NULL)) { > > > > > + FreePool (HttpService); > > > > > + } > > > > > } > > > > > } > > > > > > > > > > -- > > > > > 2.39.1.windows.1 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >=20 > > > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107080): https://edk2.groups.io/g/devel/message/107080 Mute This Topic: https://groups.io/mt/99821789/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-