From: "Michael D Kinney" <michael.d.kinney@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"vnowkakeane@linux.microsoft.com"
<vnowkakeane@linux.microsoft.com>
Cc: "Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] [PATCH v2 0/7] Uncrustify GoogleTest update
Date: Tue, 12 Sep 2023 14:42:06 +0000 [thread overview]
Message-ID: <CO1PR11MB492984EA1EF73D777033ED0ED2F1A@CO1PR11MB4929.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20230816211523.12-1-vnowkakeane@linux.microsoft.com>
Series Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of VivianNK
> Sent: Wednesday, August 16, 2023 2:15 PM
> To: devel@edk2.groups.io
> Subject: [edk2-devel] [PATCH v2 0/7] Uncrustify GoogleTest update
>
> v1 -> v2:
> - Update commit message to explain the audit only mode change is
> temporary to prevent intermediate CI failures.
> - Format patch Cc's correctly
>
> v1 archive:https://edk2.groups.io/g/devel/message/107665
>
> VivianNK (7):
> .pytool: Set uncrustify check to audit only (temporary)
> .pytool: Add cpp support to uncrustify plugin
> MdeModulePkg: Apply uncrustify formatting to relevant files.
> MdePkg: Apply uncrustify formatting to relevant files
> SecurityPkg: Apply uncrustify formatting to relevant files
> UnitTestFrameworkPkg: Apply uncrustify formatting to relevant files
> .pytool: Undo uncrustify check change
>
> .pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py
> | 2 +-
> .pytool/Plugin/UncrustifyCheck/uncrustify.cfg
> | 4 +-
> MdeModulePkg/Library/UefiSortLib/GoogleTest/UefiSortLibGoogleTest.cpp
> | 37 +-
> MdeModulePkg/Test/Mock/Include/GoogleTest/Library/MockPciHostBridgeLib.h
> | 4 +-
>
> MdeModulePkg/Test/Mock/Library/GoogleTest/MockPciHostBridgeLib/MockPciHostBri
> dgeLib.cpp | 8 +-
>
> MdePkg/Test/GoogleTest/Library/BaseSafeIntLib/SafeIntLibUintnIntnUnitTests32.
> cpp | 114 ++--
>
> MdePkg/Test/GoogleTest/Library/BaseSafeIntLib/SafeIntLibUintnIntnUnitTests64.
> cpp | 114 ++--
> MdePkg/Test/GoogleTest/Library/BaseSafeIntLib/TestBaseSafeIntLib.cpp
> | 563 ++++++++++----------
> MdePkg/Test/Mock/Include/GoogleTest/Library/MockHobLib.h
> | 6 +-
> MdePkg/Test/Mock/Include/GoogleTest/Library/MockPeiServicesLib.h
> | 6 +-
> MdePkg/Test/Mock/Include/GoogleTest/Library/MockUefiLib.h
> | 4 +-
>
> MdePkg/Test/Mock/Include/GoogleTest/Library/MockUefiRuntimeServicesTableLib.h
> | 4 +-
> MdePkg/Test/Mock/Library/GoogleTest/MockHobLib/MockHobLib.cpp
> | 40 +-
>
> MdePkg/Test/Mock/Library/GoogleTest/MockPeiServicesLib/MockPeiServicesLib.cpp
> | 52 +-
> MdePkg/Test/Mock/Library/GoogleTest/MockUefiLib/MockUefiLib.cpp
> | 6 +-
>
> MdePkg/Test/Mock/Library/GoogleTest/MockUefiRuntimeServicesTableLib/MockUefiR
> untimeServicesTableLib.cpp | 12 +-
>
> SecurityPkg/Library/SecureBootVariableLib/GoogleTest/SecureBootVariableLibGoo
> gleTest.cpp | 205 ++++---
>
> SecurityPkg/Test/Mock/Include/GoogleTest/Library/MockPlatformPKProtectionLib.
> h | 4 +-
>
> SecurityPkg/Test/Mock/Library/GoogleTest/MockPlatformPKProtectionLib/MockPlat
> formPKProtectionLib.cpp | 4 +-
> UnitTestFrameworkPkg/Include/Library/GoogleTestLib.h
> | 2 +-
>
> UnitTestFrameworkPkg/Test/GoogleTest/Sample/SampleGoogleTest/SampleGoogleTest
> .cpp | 76 +--
> 21 files changed, 664 insertions(+), 603 deletions(-)
>
> --
> 2.41.0.windows.3
>
>
>
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#107809): https://edk2.groups.io/g/devel/message/107809
> Mute This Topic: https://groups.io/mt/100788665/1643496
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub
> [michael.d.kinney@intel.com]
> -=-=-=-=-=-=
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108536): https://edk2.groups.io/g/devel/message/108536
Mute This Topic: https://groups.io/mt/100788665/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2023-09-12 14:42 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-16 21:15 [edk2-devel] [PATCH v2 0/7] Uncrustify GoogleTest update VivianNK
2023-08-16 21:15 ` [edk2-devel] [PATCH v2 1/7] .pytool: Set uncrustify check to audit only (temporary) VivianNK
2023-08-16 22:09 ` Michael Kubacki
2023-08-16 21:15 ` [edk2-devel] [PATCH v2 2/7] .pytool: Add cpp support to uncrustify plugin VivianNK
2023-08-16 21:15 ` [edk2-devel] [PATCH v2 3/7] MdeModulePkg: Apply uncrustify formatting to relevant files VivianNK
2023-08-16 21:15 ` [edk2-devel] [PATCH v2 4/7] MdePkg: " VivianNK
2023-08-16 21:15 ` [edk2-devel] [PATCH v2 5/7] SecurityPkg: " VivianNK
2023-08-17 2:41 ` Yao, Jiewen
2023-08-16 21:15 ` [edk2-devel] [PATCH v2 6/7] UnitTestFrameworkPkg: " VivianNK
2023-08-16 21:15 ` [edk2-devel] [PATCH v2 7/7] .pytool: Undo uncrustify check change VivianNK
2023-08-16 22:09 ` Michael Kubacki
2023-09-12 1:08 ` 回复: [edk2-devel] [PATCH v2 0/7] Uncrustify GoogleTest update gaoliming via groups.io
2023-09-12 14:42 ` Michael D Kinney [this message]
2023-09-27 19:43 ` VivianNK
2023-10-24 20:34 ` VivianNK
2023-10-25 17:11 ` Michael D Kinney
2023-10-25 18:08 ` Michael D Kinney
2023-10-26 21:08 ` VivianNK
2023-10-27 2:41 ` Michael D Kinney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO1PR11MB492984EA1EF73D777033ED0ED2F1A@CO1PR11MB4929.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox