* [PATCH v1 1/1] MdePkg: Remove the restriction of SmmCpuRendezvousLibNull.
@ 2022-08-28 16:18 Li, Zhihao
2022-08-30 3:22 ` Michael D Kinney
0 siblings, 1 reply; 2+ messages in thread
From: Li, Zhihao @ 2022-08-28 16:18 UTC (permalink / raw)
To: devel; +Cc: Michael D Kinney, Liming Gao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4034
In the implementation of SmmCpuRendezvousLib null version,
there is a restriction in [LIBRARY_CLASS] section.
So removing the restriction that other type driver
can use SmmCpuRendezvousLib null version implemented.
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Signed-off-by: Zhihao Li <zhihao.li@intel.com>
---
MdePkg/Library/SmmCpuRendezvousLibNull/SmmCpuRendezvousLibNull.c | 2 +-
MdePkg/Library/SmmCpuRendezvousLibNull/SmmCpuRendezvousLibNull.inf | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/MdePkg/Library/SmmCpuRendezvousLibNull/SmmCpuRendezvousLibNull.c b/MdePkg/Library/SmmCpuRendezvousLibNull/SmmCpuRendezvousLibNull.c
index 769f4c673802..23284caee0f2 100644
--- a/MdePkg/Library/SmmCpuRendezvousLibNull/SmmCpuRendezvousLibNull.c
+++ b/MdePkg/Library/SmmCpuRendezvousLibNull/SmmCpuRendezvousLibNull.c
@@ -6,7 +6,7 @@
**/
-#include <Library/DebugLib.h>
+#include <Uefi.h>
#include <Library/SmmCpuRendezvousLib.h>
/**
diff --git a/MdePkg/Library/SmmCpuRendezvousLibNull/SmmCpuRendezvousLibNull.inf b/MdePkg/Library/SmmCpuRendezvousLibNull/SmmCpuRendezvousLibNull.inf
index 7c9bac9af2ff..bc513d432a21 100644
--- a/MdePkg/Library/SmmCpuRendezvousLibNull/SmmCpuRendezvousLibNull.inf
+++ b/MdePkg/Library/SmmCpuRendezvousLibNull/SmmCpuRendezvousLibNull.inf
@@ -13,8 +13,8 @@ [Defines]
INF_VERSION = 0x00010005
BASE_NAME = SmmCpuRendezvousLibNull
FILE_GUID = 1e5790ea-d013-4d7b-9047-b4342a762027
- MODULE_TYPE = DXE_SMM_DRIVER
- LIBRARY_CLASS = SmmCpuRendezvousLib|MM_STANDALONE DXE_SMM_DRIVER
+ MODULE_TYPE = BASE
+ LIBRARY_CLASS = SmmCpuRendezvousLib
[Sources]
SmmCpuRendezvousLibNull.c
--
2.26.2.windows.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v1 1/1] MdePkg: Remove the restriction of SmmCpuRendezvousLibNull.
2022-08-28 16:18 [PATCH v1 1/1] MdePkg: Remove the restriction of SmmCpuRendezvousLibNull Li, Zhihao
@ 2022-08-30 3:22 ` Michael D Kinney
0 siblings, 0 replies; 2+ messages in thread
From: Michael D Kinney @ 2022-08-30 3:22 UTC (permalink / raw)
To: Li, Zhihao, devel@edk2.groups.io; +Cc: Gao, Liming
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
> -----Original Message-----
> From: Li, Zhihao <zhihao.li@intel.com>
> Sent: Sunday, August 28, 2022 9:18 AM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>
> Subject: [PATCH v1 1/1] MdePkg: Remove the restriction of SmmCpuRendezvousLibNull.
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4034
>
> In the implementation of SmmCpuRendezvousLib null version,
> there is a restriction in [LIBRARY_CLASS] section.
> So removing the restriction that other type driver
> can use SmmCpuRendezvousLib null version implemented.
>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
>
> Signed-off-by: Zhihao Li <zhihao.li@intel.com>
> ---
> MdePkg/Library/SmmCpuRendezvousLibNull/SmmCpuRendezvousLibNull.c | 2 +-
> MdePkg/Library/SmmCpuRendezvousLibNull/SmmCpuRendezvousLibNull.inf | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/MdePkg/Library/SmmCpuRendezvousLibNull/SmmCpuRendezvousLibNull.c
> b/MdePkg/Library/SmmCpuRendezvousLibNull/SmmCpuRendezvousLibNull.c
> index 769f4c673802..23284caee0f2 100644
> --- a/MdePkg/Library/SmmCpuRendezvousLibNull/SmmCpuRendezvousLibNull.c
> +++ b/MdePkg/Library/SmmCpuRendezvousLibNull/SmmCpuRendezvousLibNull.c
> @@ -6,7 +6,7 @@
>
>
> **/
>
>
>
> -#include <Library/DebugLib.h>
>
> +#include <Uefi.h>
>
> #include <Library/SmmCpuRendezvousLib.h>
>
>
>
> /**
>
> diff --git a/MdePkg/Library/SmmCpuRendezvousLibNull/SmmCpuRendezvousLibNull.inf
> b/MdePkg/Library/SmmCpuRendezvousLibNull/SmmCpuRendezvousLibNull.inf
> index 7c9bac9af2ff..bc513d432a21 100644
> --- a/MdePkg/Library/SmmCpuRendezvousLibNull/SmmCpuRendezvousLibNull.inf
> +++ b/MdePkg/Library/SmmCpuRendezvousLibNull/SmmCpuRendezvousLibNull.inf
> @@ -13,8 +13,8 @@ [Defines]
> INF_VERSION = 0x00010005
>
> BASE_NAME = SmmCpuRendezvousLibNull
>
> FILE_GUID = 1e5790ea-d013-4d7b-9047-b4342a762027
>
> - MODULE_TYPE = DXE_SMM_DRIVER
>
> - LIBRARY_CLASS = SmmCpuRendezvousLib|MM_STANDALONE DXE_SMM_DRIVER
>
> + MODULE_TYPE = BASE
>
> + LIBRARY_CLASS = SmmCpuRendezvousLib
>
>
>
> [Sources]
>
> SmmCpuRendezvousLibNull.c
>
> --
> 2.26.2.windows.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-08-30 3:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-28 16:18 [PATCH v1 1/1] MdePkg: Remove the restriction of SmmCpuRendezvousLibNull Li, Zhihao
2022-08-30 3:22 ` Michael D Kinney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox