From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 61189740045 for ; Wed, 29 May 2024 14:44:54 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=u0bZ5DMwa57xa5Q+EFPKtnZSuDHdvT+PEK+gE92GvQk=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1716993894; v=1; b=EfZH75b+QlIocYeWVo0xWnBFaeO/zjq7Vc7zrJsfgAaFH+uxptvK0R+7lU1WjR5e40S3otMC TAF4FUEshd+MN08kEPOHRYlHz3gCWKNxhcZ82pyHX4uDa38PLBvM2280R8Aaajs2CfHM1RQ+SQ+ XbAo3xPfmmKLQeCTzunxdiQjbQwyO6+gMYjeIb2W95vEYqId2h0TrZUvtt0t6gLXxixDbHQb6yY bofjV3l5YmKHcHwSCPSJ+jeAeWN9ysJXWB7in9yh9JHAn1gQlo9dNOVHZdKFfi4eTdspnO/+bdL CNjdqAaqjoPFFQyLdIdXBtIK+3gODibuoul0+azIff6tQ== X-Received: by 127.0.0.2 with SMTP id wwf1YY7687511xEW6y9BJUkz; Wed, 29 May 2024 07:44:52 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by mx.groups.io with SMTP id smtpd.web10.16106.1716993887196075202 for ; Wed, 29 May 2024 07:44:47 -0700 X-CSE-ConnectionGUID: tgBvRNy1RbSCD/vQ7zX+QA== X-CSE-MsgGUID: ++k7pM2wS9qz/dYLveshOg== X-IronPort-AV: E=McAfee;i="6600,9927,11087"; a="35920694" X-IronPort-AV: E=Sophos;i="6.08,198,1712646000"; d="scan'208";a="35920694" X-Received: from orviesa009.jf.intel.com ([10.64.159.149]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 May 2024 07:44:46 -0700 X-CSE-ConnectionGUID: akx2E0TmRfu0KSJ2udCJWQ== X-CSE-MsgGUID: yVr36WCMQb6tOO5ECbhC1Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,198,1712646000"; d="scan'208";a="35521249" X-Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orviesa009.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 29 May 2024 07:44:47 -0700 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 29 May 2024 07:44:46 -0700 X-Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Wed, 29 May 2024 07:44:46 -0700 X-Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.41) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 29 May 2024 07:44:46 -0700 X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com (2603:10b6:303:6d::19) by IA1PR11MB6395.namprd11.prod.outlook.com (2603:10b6:208:3ac::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.21; Wed, 29 May 2024 14:44:41 +0000 X-Received: from CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::a886:6510:729d:f9d0]) by CO1PR11MB4929.namprd11.prod.outlook.com ([fe80::a886:6510:729d:f9d0%5]) with mapi id 15.20.7611.030; Wed, 29 May 2024 14:44:41 +0000 From: "Michael D Kinney" To: "Chang, Abner" , "devel@edk2.groups.io" CC: "Kinney, Michael D" Subject: Re: [edk2-devel] GitHub PR Code Review process now active Thread-Topic: GitHub PR Code Review process now active Thread-Index: AdqxKDms81p5Mq2lRy6LTkfbwilSAQAiifSgAAkO3cA= Date: Wed, 29 May 2024 14:44:41 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_ActionId=da3749d2-fccc-4f65-b971-ef4c17b39889;MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_ContentBits=0;MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_Enabled=true;MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_Method=Standard;MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_Name=AMD Internal Distribution Only;MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_SetDate=2024-05-29T10:24:25Z;MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO1PR11MB4929:EE_|IA1PR11MB6395:EE_ x-ms-office365-filtering-correlation-id: 923723f1-f1fa-433c-fbde-08dc7feddf59 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: =?us-ascii?Q?gn9+98pU+XalDO2uFPurlKbI5wpPWnJjJ9x76wEoaHAigLzrauOfss27P8u7?= =?us-ascii?Q?IJIfgA+zMdETOOIX91o9u4/5UhUJEH2ImaP3pgdIyXtaKVEYdfzMoqek9CBg?= =?us-ascii?Q?P+QFiJPIdJ7OLyS/uKRoav6wdWuhFL0IfCvfWDrdHbH4trTmR8Y0fFcv/b/k?= =?us-ascii?Q?HtpZALtl1WIHwWlur54icE5Oh2y8OuJFd2gpHFLnCqFl6t7/qwZwHoRGcaLX?= =?us-ascii?Q?bAySFnQoiBR3r/n0+3hP02cSL6BFQbb3LKPDotGfc2SPtmNQ619g956jyKS9?= =?us-ascii?Q?sBanRApn9KVylWRirSBRv4jrGIRNW2pQbJjpxs5zKpchXfYPlqjZuf8cQGh4?= =?us-ascii?Q?C+5q5ylhD3kmdiIggR6dB8nUvoBBiU40snjSj/hWWncC3vz6pQk9JLAioJtl?= =?us-ascii?Q?ChGdJcEtl2C8YIPSYClwstmcf4/oZWBdTA2Lp5v/l8/vPa88Ldw7WLdpQlsm?= =?us-ascii?Q?ThNfyjHll0niNRnlXRR/mSwMxB4yPM8FUYy+X4j83jDPRcsajrEEGDCeEYbs?= =?us-ascii?Q?iBHdH45IndP6TYJMAGfsd55B1NsHPBALK0YI1LmT73pJUWS6/VvA529Vbh1q?= =?us-ascii?Q?hWzhNZTd6iDyPQ9ixdA8V48vM4SSu/SVAi+sDU3dLsZlAMF2h5Wx14UC1l2b?= =?us-ascii?Q?VLdXGM3p+gzgV6MJspZSweJih3Hirf5mqnrtZQcqzThWfTxhUhzYfmchD/PJ?= =?us-ascii?Q?422EOQ6FoegecJbNJdPYpPd0eQGPoZZvmM5w/re41vS0NrlonOUBm1JIJfjl?= =?us-ascii?Q?0blegqWsrbQO/7qWWpMk9Bw6SMAC5/o2FkklCKql9oYGSsXlbXJcRrQQv/mv?= =?us-ascii?Q?jkUp4mfWyc76VlEhJqX2VNHtUryaqNIQtPhikz+QbfiTItXIgHYJ3H7H4yVl?= =?us-ascii?Q?WpXwvQmj81o8E2exBBa1H6S/aN0JcX2buTTDqtcg6DGq9r4oGJWDZJ/+ev6D?= =?us-ascii?Q?wQj8+Tox/dfLQvVl355Ojydgi5OlzC1/84sQpNSjwBDMzWL4CFUAmtRv5k+A?= =?us-ascii?Q?oV3yDDIGDia58oZAKD4W/6yu7A9Y9T6zIS5aR8sAODSQB0lUgyAuyfDMhG54?= =?us-ascii?Q?+IiDTtjFkkp27htSiV7urASyXMsCE9KovnKb+3AoMqZa//eeeZJ+lDlZGx7d?= =?us-ascii?Q?RuuWzKVXyvQStmbzougXEdtyphnSCACcri5K7DWyCXnwqCi4/f1Yvab98zdg?= =?us-ascii?Q?uNGbShBbVnJK7Eu94NL/JmNQEUX2XOwtpm8ouOcijn/rAhxvxwTqPe6rssAx?= =?us-ascii?Q?9DPn7jL8TuO5XVzXnQZmTTLe7094lB7lpLIih6uoRm8qfwLSi1EODxxqkjfV?= =?us-ascii?Q?zZw=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?b4WoomfrHCvNDCa2B1KtMpajHNbcudLTzygbn+Y0cseDhZtYdrD70XvoQqWf?= =?us-ascii?Q?0IlpUim6mE6/2mtrM8HO7U7GfBP93BbLuJc1y9z4IZ1hgQjTkuCd/P4wlQ7Y?= =?us-ascii?Q?JW1h/ypNmRSD9+L6lErrBaX8xPugUVz8Dm3QNxN0DNjW9ygLsFrvvvQLflCO?= =?us-ascii?Q?5Qf48JEcKztMIi2gj2i6P/Aq/SNyLY+TUHGt+D5To+XwHfbkWWpOU8ZYca9w?= =?us-ascii?Q?v8JVZrikr1kyUEop+2sKxSd39YYd+p98+s1dr9gYj+Pl16/5w9EmUPzef/Y3?= =?us-ascii?Q?28XthwK8lhwgdXsTOoAegEaGz6iA9WMRpV292G0DbIUbDSl3x/MeDmbDgyeO?= =?us-ascii?Q?Z9jg8xBRLgSCRD1b0JwseW+bR+/sW5YjM/+SphK/ljTvQHu928rnaZopuv0L?= =?us-ascii?Q?WWvYr4nLVt0zOQj7/K8HizoQxz3quiY75rKWKvKlpZorckY4AaCc5A6A83AP?= =?us-ascii?Q?oqHnwxXILCB9bio8QCVGSZf8PNEovpoAK5HGxoC7cjbmr4SN6BhXSgHvscWz?= =?us-ascii?Q?S/V594Fl67q22JGet178obwsT7uqXRbiP/3p9zNjr0SaR9jUjjp2AIXRpfc0?= =?us-ascii?Q?BTTHh0McVyC/Hj6d83XZGq5cokCOyEsGPtKvyZH0gBsPlcqZJ/6CYK8D13Lm?= =?us-ascii?Q?dHdxbdywjOcx8CRdT20FPucSKEEG4ZtDyAJqbRQIoi9FeiadPjwhwdkODXH8?= =?us-ascii?Q?abWCBVNi6LmPJr23gXqEsMPqoazqGKNuw5n3Ce29YjuHykA5XWIu02el8dO0?= =?us-ascii?Q?czN4o7yMIaseIzi++iMeBj0sF/UAPE0vwaUeJtl6/8yHHE2V8L9XhqAp7s1i?= =?us-ascii?Q?q6Y4mHNnBH0NGto83hPbsQmJLzpNm3GWFfaI7C/iu4OVLuzCxQmX+jBdcm3L?= =?us-ascii?Q?LkYOZHbvJ+3ozDsxTa9WH9VkZN+Nuhi8LCclvdBZh7EG//JClKYcirxLlcGX?= =?us-ascii?Q?vrVbZb9HB3rMBo0kffQNBT0n5wf5hDgT5IFKPbUNDT/vGaTnFQefKwGGQwfr?= =?us-ascii?Q?0mKjx33T981vXr6HJFdgWCKix1sakxmvB8CPQheEt8hfnHgzdkje8HH7or2N?= =?us-ascii?Q?UHyJupA4lSs1DP/4psmyor7PmHgJxznxpuFjyineJnRNVFC+/4VIb49WTnur?= =?us-ascii?Q?JihHGfcEMznYzoCIsHdMVkOdpDOSQ4Lpfn1pTpnTH1kYACEFmele9FbTrZca?= =?us-ascii?Q?ORg0bgiSEarscsOXEqXCvs62XPPvqgv9vGB0PS7xg1jNhYyJrxBNtcQPGgRV?= =?us-ascii?Q?MUVmstqwCEL/D+LvSvLWhPCKLVlm6rVSJG7rLr3lmFhh7qsbnGtHjWtEne5A?= =?us-ascii?Q?zJnWHmdoIwWVCgdacIIugPN2KfUWR6stYyiJ0G3WcJyiwKq2eo42gJmqNOeU?= =?us-ascii?Q?R/oQ3pmgA5Yrz4twhyRjhpgNA2dv2rjJMgddnK7voMoOu4Ok9iB2j0cV0/mv?= =?us-ascii?Q?Aw/RikhtgFHXoNXSwKW5EjSEYz3y3dfOIdAuoE4c1TdFSd1SxyBmy2Z3okNe?= =?us-ascii?Q?I5brK4qyoq30j4aQIo2K/7vGM/51C5AH+SA9cDvbwkFxKIUt75foFbJYz7b2?= =?us-ascii?Q?7wNiBGvoE9uRc+oc3/vDSjKapcc0emI7fhJjegEbivD3/JyELoCgxecDF3m4?= =?us-ascii?Q?bQ=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4929.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 923723f1-f1fa-433c-fbde-08dc7feddf59 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 May 2024 14:44:41.0730 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: HGfue4fiBtjYMfbuGmiLY6PgqgnydtkbjiM3+5J21LA8IxBa4AYj8KRPeUChVZ2nyjchG0MlR797Z7Y6K2WFErEiZmCGXFHINlMSjhmBARY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB6395 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Wed, 29 May 2024 07:44:47 -0700 Resent-From: michael.d.kinney@intel.com Reply-To: devel@edk2.groups.io,michael.d.kinney@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: rfx5ycADP2mwetRMjCc4tXr1x7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=EfZH75b+; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Abner, Yes. The plan is to apply to all repos. We want to use it on edk2 for a while to make sure we get the settings and process correct, then we will expand. Mike > -----Original Message----- > From: Chang, Abner > Sent: Wednesday, May 29, 2024 3:41 AM > To: devel@edk2.groups.io; Kinney, Michael D > Subject: RE: GitHub PR Code Review process now active >=20 > [AMD Official Use Only - AMD Internal Distribution Only] >=20 > Hi Mike, > Wondering if we also plan to apply GitHub PR process on edk2-platforms re= po? > Or other repos under tianocore? I found there is another email thread "En= able > GitHub PR, protected branches, and 'push' label" on edk2-platforms, but n= o > further discussions then. >=20 > Thanks > Abner >=20 > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of Michael = D > > Kinney via groups.io > > Sent: Wednesday, May 29, 2024 2:54 AM > > To: devel@edk2.groups.io > > Cc: Kinney, Michael D > > Subject: [edk2-devel] GitHub PR Code Review process now active > > > > Caution: This message originated from an External Source. Use proper > caution > > when opening attachments, clicking links, or responding. > > > > > > Hello, > > > > The GitHub PR code review process is now active. Please > > use the new PR based code review process for all new > > submissions starting today. > > > > * The Wiki has been updated with the process changes. > > > > https://github.com/tianocore/tianocore.github.io/wiki/EDK-II- > > Development-Process > > > > Big thanks to Michael Kubacki for writing up all the > > changes based on the RFC proposal and community discussions. > > > > We will learn by using, so if you see anything missing or > > incorrect or clarifications needed, please send feedback > > here so the Wiki pages can be updated quickly for everyone. > > > > * The edk2 repo settings have been updated to require > > a GitHub PR code review approval before merging and > > all conversations must be resolved before merging. > > > > * A PR has been opened that removes the requirement for > > Cc: tags in the commit messages and is the first PR > > that will use the new process. This PR needs to be > > reviewed and merged to support the revised commit > > message format. > > > > https://github.com/tianocore/edk2/pull/5688 > > > > https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message- > > Format > > > > * Please use "Draft" PRs to run CI without any reviews. > > Once ready for reviews, convert from "Draft" to > > "Ready for Review". > > > > * For active code reviews that are almost complete and will > > be ready for merge in the next few days, the submitter may > > choose to either complete using the email review process, > > or switch to the PR based code review process. > > > > * For active code reviews that are expected to take more than > > a few days to complete, please convert to a PR based code review. > > > > Thanks, > > > > Mike > > > > > > > >=20 > > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119351): https://edk2.groups.io/g/devel/message/119351 Mute This Topic: https://groups.io/mt/106355103/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-