From: "Michael D Kinney" <michael.d.kinney@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"abner.chang@amd.com" <abner.chang@amd.com>,
"Kinney, Michael D" <michael.d.kinney@intel.com>
Cc: "Gao, Liming" <gaoliming@byosoft.com.cn>,
"Liu, Zhiguang" <zhiguang.liu@intel.com>,
Nickle Wang <nicklew@nvidia.com>,
Igor Kulchytskyy <igork@ami.com>,
"Oram, Isaac W" <isaac.w.oram@intel.com>,
"Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>,
"Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] [PATCH V2 0/3] IPMI changes for Redfish
Date: Thu, 29 Dec 2022 17:37:23 +0000 [thread overview]
Message-ID: <CO1PR11MB4929883C85E8EAE3297F362DD2F39@CO1PR11MB4929.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20221228051336.1769-1-abner.chang@amd.com>
Hi Abner,
Can you provide an overview of the RedFish features that are required to interact with
HW interfaces such as USB and IPMI and network services?
I am wondering if these can be abstracted through dynamic interfaces such as PPI/Protocol
instead of static interfaces such as library classes. It may help provide more options
on where the Device/Platform specific sources are hosted.
Thanks,
Mike
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Chang, Abner via groups.io
> Sent: Tuesday, December 27, 2022 9:14 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Liu, Zhiguang
> <zhiguang.liu@intel.com>; Nickle Wang <nicklew@nvidia.com>; Igor Kulchytskyy <igork@ami.com>; Oram, Isaac W
> <isaac.w.oram@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>
> Subject: [edk2-devel] [PATCH V2 0/3] IPMI changes for Redfish
>
> From: Abner Chang <abner.chang@amd.com>
>
> This patch updates IPMI related definitions for supporting
> Redfish Host interface Credential bootstrapping spec and
> building up SMBIOS 42 record for the USB NIC host
> interface exposed by BMC.
> The corresponding updates on IpmiFeaturePkg is in the
> separate pacth for edk2-platforms.
>
> This is the part I of upstream, the follow up patche sets are:
> - RedfishPlatformCredentialLib contributed by NVidia.
> - Relocate IpmiCommandLib.h from edk2-platforms
> to edk2/MdePkg. A NULL instance of IpmiCommandLib is created
> and located under MdePkg. With above, RedfishPkg doesn't have the
> dependence with edk2-platforms. The implementation of IpmiCommandLib
> stays in edk2-platforms without relocation, which can be pulled in
> to platform DSC as needed.
> - PlatformHostInterfaceBmcUsbNic would be upstream to edk2-staging
> temporarily because some requirements are necessray to be spec out
> in the Redfish section in UEFI spec.
>
> Signed-off-by: Abner Chang <abner.chang@amd.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Cc: Nickle Wang <nicklew@nvidia.com>
> Cc: Igor Kulchytskyy <igork@ami.com>
> Cc: Isaac Oram <isaac.w.oram@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
>
> Abner Chang (3):
> MdePkg/IndustryStandard: Update IPMI definitions
> RedfishPkg/Include: Add Redfish IPMI definitions
> RedfishPkg/Include: Redfish USB Interface V2 update
>
> MdePkg/Include/IndustryStandard/Ipmi.h | 17 +++++++
> .../Include/IndustryStandard/IpmiNetFnApp.h | 37 ++++++++++++--
> .../IndustryStandard/IpmiNetFnTransport.h | 32 ++++++++++++
> .../IndustryStandard/RedfishHostInterface.h | 25 +++++++++-
> .../RedfishHostInterfaceIpmi.h | 50 +++++++++++++++++++
> 5 files changed, 156 insertions(+), 5 deletions(-)
> create mode 100644 RedfishPkg/Include/IndustryStandard/RedfishHostInterfaceIpmi.h
>
> --
> 2.37.1.windows.1
>
>
>
>
>
next prev parent reply other threads:[~2022-12-29 17:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-28 5:13 [PATCH V2 0/3] IPMI changes for Redfish Chang, Abner
2022-12-28 5:13 ` [PATCH V2 1/3] MdePkg/IndustryStandard: Update IPMI definitions Chang, Abner
2023-01-12 15:01 ` [edk2-devel] " manickavasakam karpagavinayagam
2023-01-12 15:12 ` Chang, Abner
2023-01-14 5:21 ` Chang, Abner
2022-12-28 5:13 ` [PATCH V2 2/3] RedfishPkg/Include: Add Redfish " Chang, Abner
2022-12-28 5:13 ` [PATCH V2 3/3] RedfishPkg/Include: Redfish USB Interface V2 update Chang, Abner
2022-12-28 6:28 ` Nickle Wang
2022-12-28 15:32 ` Igor Kulchytskyy
2022-12-29 17:37 ` Michael D Kinney [this message]
2022-12-30 4:10 ` [edk2-devel] [PATCH V2 0/3] IPMI changes for Redfish Chang, Abner
2023-01-08 15:18 ` Chang, Abner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO1PR11MB4929883C85E8EAE3297F362DD2F39@CO1PR11MB4929.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox